Nir Soffer has uploaded a new change for review.
Change subject: storage_exception: Show data in MetadataOverflowError
......................................................................
storage_exception: Show data in MetadataOverflowError
This should help to debug such issues. Previously we raised an error
without any details, making it hard to debug such issue.
Change-Id: I305584438c391cbe7d5da7e358482f255e292187
Backport-To: 3.6
Relates-To: https://bugzilla.redhat.com/1258097
Signed-off-by: Nir Soffer <nsoffer(a)redhat.com>
---
M vdsm/storage/blockSD.py
M vdsm/storage/storage_exception.py
2 files changed, 4 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/71/45471/1
diff --git a/vdsm/storage/blockSD.py b/vdsm/storage/blockSD.py
index 51814ab..978b85b 100644
--- a/vdsm/storage/blockSD.py
+++ b/vdsm/storage/blockSD.py
@@ -353,7 +353,7 @@
metaStr.write("\n")
if metaStr.pos > self._size:
- raise se.MetadataOverflowError()
+ raise se.MetadataOverflowError(metaStr.getvalue())
# Clear out previous data - it is a volume, not a file
metaStr.write('\0' * (self._size - metaStr.pos))
diff --git a/vdsm/storage/storage_exception.py b/vdsm/storage/storage_exception.py
index 3a4d33f..1e9c3f8 100644
--- a/vdsm/storage/storage_exception.py
+++ b/vdsm/storage/storage_exception.py
@@ -1665,6 +1665,9 @@
code = 756
message = "Metadata is too big. Cannot change Metadata"
+ def __init__(self, data):
+ self.value = "data=%r" % data
+
#################################################
# Import/Export Exceptions
--
To view, visit https://gerrit.ovirt.org/45471
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I305584438c391cbe7d5da7e358482f255e292187
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Shahar Havivi has uploaded a new change for review.
Change subject: schema: add v2vJobs to HostStats
......................................................................
schema: add v2vJobs to HostStats
v2vJobs reports via HostStats and needs to be declared in schema
Change-Id: I20b5b44b2b74c0e1326251d6a3b84ef66dac46c7
Signed-off-by: Shahar Havivi <shaharh(a)redhat.com>
---
M vdsm/rpc/vdsmapi-schema.json
1 file changed, 23 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/19/44919/1
diff --git a/vdsm/rpc/vdsmapi-schema.json b/vdsm/rpc/vdsmapi-schema.json
index 4cac5ae..f21d174 100644
--- a/vdsm/rpc/vdsmapi-schema.json
+++ b/vdsm/rpc/vdsmapi-schema.json
@@ -1970,6 +1970,24 @@
'score': 'uint'}}
##
+# @V2VJobs:
+#
+# Structure for current v2v jobs status
+#
+# @status: Indicates jobs status (done, error, aborted, copying_disk,
+# starting)
+#
+# @description: Description for the current status such as error or copying
+# disk description.
+#
+# @progress: Job progress between 0-100
+#
+# Since: 4.17.0
+##
+{'type': 'V2VJobs',
+ 'data': {'status': 'str', 'description': 'str', 'progress': 'uint'}}
+
+##
# @HostStats:
#
# Statistics about this host.
@@ -2065,6 +2083,9 @@
# @outgoingVmMigrations: The number of VMs migrating away from this host
# (new in version 4.17.0)
#
+# @v2vJobs: #optional Current v2v jobs that running/ended on
+# current host (new in version 4.17.0)
+#
# Since: 4.10.0
##
{'type': 'HostStats',
@@ -2086,7 +2107,8 @@
'haStatus': 'HostedEngineStatus', '*bootTime': 'uint',
'numaNodeMemFree': 'NumaNodeMemoryStatsMap',
'cpuStatistics': 'CpuCoreStatsMap',
- 'incomingVmMigrations': 'uint', 'outgoingVmMigrations': 'uint'}}
+ 'incomingVmMigrations': 'uint', 'outgoingVmMigrations': 'uint',
+ '*v2vJobs': 'V2VJobs'}}
##
# @Host.getStats:
--
To view, visit https://gerrit.ovirt.org/44919
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I20b5b44b2b74c0e1326251d6a3b84ef66dac46c7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com>
automation(a)ovirt.org has posted comments on this change.
Change subject: periodic: explicitely track domain availability
......................................................................
Patch Set 15:
* Update tracker::#1250839::OK
* Check Bug-Url::OK
* Check Public Bug::#1250839::OK, public bug
* Check Product::#1250839::OK, Correct product oVirt
* Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
--
To view, visit https://gerrit.ovirt.org/44544
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1b1d5173bac8e288474581092b8132dc0df03ad4
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No