Change in vdsm[master]: net: tests: renamed tests signatures to undercores
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: tests: renamed tests signatures to undercores
......................................................................
net: tests: renamed tests signatures to undercores
Change-Id: If0cf62b3eda8a63ca69f6150b35ef41ce97e7946
Signed-off-by: Leon Goldberg <lgoldber(a)redhat.com>
Reviewed-on: https://gerrit.ovirt.org/66388
Continuous-Integration: Jenkins CI
Reviewed-by: Edward Haas <edwardh(a)redhat.com>
Reviewed-by: Dan Kenigsberg <danken(a)redhat.com>
---
M tests/network/netinfo_test.py
1 file changed, 12 insertions(+), 12 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
Leon Goldberg: Verified
Edward Haas: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/66388
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If0cf62b3eda8a63ca69f6150b35ef41ce97e7946
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 6 months
Change in vdsm[master]: net: tests: renamed tests signatures to undercores
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: tests: renamed tests signatures to undercores
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/66388
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If0cf62b3eda8a63ca69f6150b35ef41ce97e7946
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 6 months
Change in vdsm[master]: net: tests: mock resolv.conf
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: tests: mock resolv.conf
......................................................................
net: tests: mock resolv.conf
testGetHostNameservers to use a mocked resolv.conf over
a temp file; function renamed to underscores
Change-Id: Icd75bfe1284baf3922428c2415ff52691d686286
Signed-off-by: Leon Goldberg <lgoldber(a)redhat.com>
Reviewed-on: https://gerrit.ovirt.org/66387
Continuous-Integration: Jenkins CI
Reviewed-by: Edward Haas <edwardh(a)redhat.com>
Reviewed-by: Dan Kenigsberg <danken(a)redhat.com>
Tested-by: Dan Kenigsberg <danken(a)redhat.com>
---
M tests/network/netinfo_test.py
1 file changed, 9 insertions(+), 9 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Dan Kenigsberg: Verified; Looks good to me, approved
Edward Haas: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/66387
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icd75bfe1284baf3922428c2415ff52691d686286
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 6 months
Change in vdsm[master]: net: tests: mock resolv.conf
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: tests: mock resolv.conf
......................................................................
Patch Set 5: Code-Review+2 Verified+1
(1 comment)
Still passes the test
https://gerrit.ovirt.org/#/c/66387/5/tests/network/netinfo_test.py
File tests/network/netinfo_test.py:
Line 57: 'nameserver 8.8.8.8\n'
Line 58: 'nameserver 8.8.4.4\n'
Line 59: )
Line 60: expected_nameservers = ['192.168.0.100', '8.8.8.8', '8.8.4.4']
Line 61: resolv_conf_stream = six.StringIO(RESOLV_CONF)
Thanks for teaching me about six.StringIO.
I think that we'd better also fix the tested code, so that it uses io.open so that we know if we're handling bytes or strings.
Line 62: mock_open.return_value.__enter__.return_value = resolv_conf_stream
Line 63:
Line 64: resulted_nameservers = dns.get_host_nameservers()
Line 65:
--
To view, visit https://gerrit.ovirt.org/66387
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icd75bfe1284baf3922428c2415ff52691d686286
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
7 years, 6 months
Change in vdsm[master]: net: handle unavailability of resolv.conf
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: handle unavailability of resolv.conf
......................................................................
net: handle unavailability of resolv.conf
get_host_nameservers to return an empty list on failure
to read from /etc/resolv.conf
Bug-Url: https://bugzilla.redhat.com/1392989
Change-Id: Ia6e87724b836b1ed1d49e6f6fff723e3b627412a
Signed-off-by: Leon Goldberg <lgoldber(a)redhat.com>
Reviewed-on: https://gerrit.ovirt.org/66311
Reviewed-by: Edward Haas <edwardh(a)redhat.com>
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg <danken(a)redhat.com>
---
M lib/vdsm/network/netinfo/dns.py
M tests/network/netinfo_test.py
2 files changed, 17 insertions(+), 2 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
Leon Goldberg: Verified
Edward Haas: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/66311
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia6e87724b836b1ed1d49e6f6fff723e3b627412a
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 6 months
Change in vdsm[master]: net: handle unavailability of resolv.conf
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: handle unavailability of resolv.conf
......................................................................
Patch Set 11: Code-Review+2
Thanks, Leon.
Please backport this to the ovirt-4.0 branch.
--
To view, visit https://gerrit.ovirt.org/66311
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6e87724b836b1ed1d49e6f6fff723e3b627412a
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 6 months
Change in vdsm[master]: exception: Fix bad error code
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: exception: Fix bad error code
......................................................................
Patch Set 1: Code-Review+2
Python is nasty
--
To view, visit https://gerrit.ovirt.org/66443
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2ffd86997c6bf7ef55f58eed8bf37315501f3b87
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 6 months
Change in vdsm[master]: net: Validate that default route is set for a single network.
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: Validate that default route is set for a single network.
......................................................................
net: Validate that default route is set for a single network.
https://gerrit.ovirt.org/#/c/66127 adds the ability for users to control
on which network the default route is set.
This patch adds VDSM validation, checking that the default route is not
marked on more than one network.
Change-Id: I4163d416aa6c68ac6413ee743986a883c15906b2
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
Reviewed-on: https://gerrit.ovirt.org/66310
Continuous-Integration: Jenkins CI
Reviewed-by: Germano Veit Michel <germano(a)redhat.com>
Reviewed-by: Dan Kenigsberg <danken(a)redhat.com>
Tested-by: Dan Kenigsberg <danken(a)redhat.com>
---
M lib/vdsm/network/ip/validator.py
M tests/network/ip_test.py
2 files changed, 89 insertions(+), 2 deletions(-)
Approvals:
Germano Veit Michel: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Dan Kenigsberg: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/66310
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4163d416aa6c68ac6413ee743986a883c15906b2
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Germano Veit Michel <germano(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 6 months
Change in vdsm[master]: net: Validate that default route is set for a single network.
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: Validate that default route is set for a single network.
......................................................................
Patch Set 2: Code-Review+2 Verified+1
Germano actually verified this, not just code-reviewed
--
To view, visit https://gerrit.ovirt.org/66310
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4163d416aa6c68ac6413ee743986a883c15906b2
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Germano Veit Michel <germano(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 6 months
Change in vdsm[master]: net: let users override Engine's default route
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has uploaded a new change for review.
Change subject: net: let users override Engine's default route
......................................................................
net: let users override Engine's default route
oVirt Engine sets default=True on the management network an on it alone.
Users may want to use another network for their host's default routing.
With this patch, they can modify this behavior by setting the custom
propery default_route to False on the management network attachement,
and to True on the would-be default route network.
Note that prior to using a custom property, one has to define it on
Engine by:
sudo engine-config -g CustomDeviceProperties
sudo engine-config -s CustomDeviceProperties='{type=interface;prop={default_reoute=^(true|false)$}}'
and restart of ovirt-engine.
(Cf. https://bugzilla.redhat.com/show_bug.cgi?id=1200963#c42 )
Change-Id: Iaf392ea05e1e39acbf1b74a7a31acda9e750b36e
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com>
---
M lib/vdsm/network/canonicalize.py
1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/27/66127/1
diff --git a/lib/vdsm/network/canonicalize.py b/lib/vdsm/network/canonicalize.py
index 3468796..d7df415 100644
--- a/lib/vdsm/network/canonicalize.py
+++ b/lib/vdsm/network/canonicalize.py
@@ -132,6 +132,10 @@
if 'defaultRoute' not in data:
data['defaultRoute'] = False
+ custom_default_route = utils.rget(data, ('custom', 'default_route'))
+ if custom_default_route is not None:
+ data['defaultRoute'] = utils.tobool(custom_default_route)
+
def _canonicalize_nameservers(data):
if 'nameservers' not in data:
--
To view, visit https://gerrit.ovirt.org/66127
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iaf392ea05e1e39acbf1b74a7a31acda9e750b36e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
7 years, 6 months