Change in vdsm[master]: tests: Avoid global state modification using forked
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: tests: Avoid global state modification using forked
......................................................................
Patch Set 1: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/67338/1/tests/moduleloader_test.py
File tests/moduleloader_test.py:
Line 39: for f in files:
Line 40: utils.touchFile(os.path.join(path, f))
Line 41: utils.touchFile(os.path.join(path, '__init__.py'))
Line 42: sys.path.append(os.path.dirname(path))
Line 43: yield importlib.import_module(os.path.basename(path))
it's true that we leave garbage in sys.path. We must clean it back to its original state after yield.
Line 44:
Line 45: @permutations(
Line 46: [(('a.py', 'b.py'), ('a', 'b')),
Line 47: (('a.py', 'b.py', 'a.pyc', 'a.pyioas'), ('a', 'b')),
Line 47: (('a.py', 'b.py', 'a.pyc', 'a.pyioas'), ('a', 'b')),
Line 48: (('a.py', 'b.py', 'a.pyc', 'a.py'), ('a', 'b')),
Line 49: (('a.py', 'b.py', 'a.pyc', '_my.py'), ('a', 'b', '_my'))]
Line 50: )
Line 51: @forked
I do not see how running this in another process is differnt from @broken_on_ci - both hide the problem without really understanding it. I prefer the explicit @broken_on_ci.
Line 52: def test_import_modules(self, files, expected_modules):
Line 53: with self._setup_test_modules(files) as module_name:
Line 54: result = moduleloader.load_modules(module_name)
Line 55:
--
To view, visit https://gerrit.ovirt.org/67338
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2130bcf39918c3c70ed9f8eb9c436c5c8f9c6c09
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
7 years, 4 months
Change in vdsm[master]: stats: Report running status of HE components
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: stats: Report running status of HE components
......................................................................
Patch Set 9:
Martin, Philip: I understand that you'd like to report some hosted-engine information via getVdsCaps. I'm suggesting to "hide" the logici in hosted-engine module, and only call it from Vdsm - much like you do in _getHaInfo.
(frankly, I wish that this hole code function had been in HE, and vdsm would simply call it and report its return value)
--
To view, visit https://gerrit.ovirt.org/66606
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5b8cc75fd31c63fa7021e90c77b66a80b091749
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 4 months
Change in vdsm[master]: vm_migrate_hook: skip interface handling for customized VMs
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: vm_migrate_hook: skip interface handling for customized VMs
......................................................................
Patch Set 2: Code-Review+1
horrible, but that's the best we can do right now.
--
To view, visit https://gerrit.ovirt.org/67455
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icd52d076ceb563ce965bdd90d850868bb6580e3d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 4 months
Change in vdsm[master]: client: construct namespaces from schema
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: client: construct namespaces from schema
......................................................................
client: construct namespaces from schema
namepaces are now constructed from vdsm schema and
each namespace holds a list of available methods.
This will allow method name verification in the future.
Change-Id: Ib550a86e7f66d3fd7e58fbe2d8b2f381cf155e79
Signed-off-by: Irit Goihman <igoihman(a)redhat.com>
---
M lib/vdsm/client.py
1 file changed, 13 insertions(+), 9 deletions(-)
Approvals:
Piotr Kliczewski: Looks good to me, approved
Nir Soffer: Looks good to me, but someone else must approve
Yaniv Bronhaim: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Irit Goihman: Verified
--
To view, visit https://gerrit.ovirt.org/67373
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib550a86e7f66d3fd7e58fbe2d8b2f381cf155e79
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 4 months
Change in vdsm[master]: spec: bump up to RHEL 7.3 GA version of qemu and libvirt
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: spec: bump up to RHEL 7.3 GA version of qemu and libvirt
......................................................................
spec: bump up to RHEL 7.3 GA version of qemu and libvirt
keep CentOS 7.2 support until 7.3 is out.
Dropping Fedora 23. Now requires virt-preview repo in Fedora 24
Change-Id: Idb960498288595ea26a937093342be60f340126e
Signed-off-by: Michal Skrivanek <michal.skrivanek(a)redhat.com>
---
M vdsm.spec.in
1 file changed, 19 insertions(+), 10 deletions(-)
Approvals:
Nir Soffer: Looks good to me, approved
Jenkins CI: Passed CI tests
Francesco Romani: Looks good to me, but someone else must approve
Michal Skrivanek: Verified
Milan Zamazal: Verified; Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/67439
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idb960498288595ea26a937093342be60f340126e
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 4 months
Change in vdsm[master]: virt network: correctly check if element is present
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: virt network: correctly check if element is present
......................................................................
Patch Set 1:
This should have been caught by a unit test. Can you add one?
--
To view, visit https://gerrit.ovirt.org/67434
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0c3e7c2cd5a41114dbd874d00afa0a5277da0a04
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 4 months
Change in vdsm[master]: net test: increase monitor timeout
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net test: increase monitor timeout
......................................................................
net test: increase monitor timeout
Monitor tests sometimes fail with E_TIMEOUT on CI. With this patch
we increase timeout limit to see if response is just slow or if there
is a more serious problem.
Change-Id: Iadcc94987582179864a19404e49df5c894ca47c9
Signed-off-by: Petr Horáček <phoracek(a)redhat.com>
---
M tests/network/netlink_test.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jenkins CI: Passed CI tests
Petr Horáček: Verified
Dan Kenigsberg: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/67433
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iadcc94987582179864a19404e49df5c894ca47c9
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 4 months
Change in vdsm[master]: net test: increase monitor timeout
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net test: increase monitor timeout
......................................................................
Patch Set 1: Code-Review+2
I hate it, but let's try it out.
--
To view, visit https://gerrit.ovirt.org/67433
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iadcc94987582179864a19404e49df5c894ca47c9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 4 months
Change in vdsm[master]: tests: rename api_test.py -> api_response_test.py
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: tests: rename api_test.py -> api_response_test.py
......................................................................
tests: rename api_test.py -> api_response_test.py
Cosmetic only change. We now have two test modules
which test related but different things, whose name
differs only by case.
This could be confusing for humans, and surely
confuses the Apple FS -with default settings.
Since we are very near to name shortage again[1],
we just rename api_test.py to api_response_test.py
to avoid the confusion.
+++
[1] $ git grep -i api Makefile.am
Makefile.am:47: API_test.py \
Makefile.am:49: api_response_test.py \
Makefile.am:153: vdsmapi_test.py \
Makefile.am:156: vmApiTests.py \
Makefile.am:173: API_test.py \
Makefile.am:243: vmApiTests.py \
Makefile.am:329: apiData.py \
Change-Id: If8ad99b576a373d28dfa8086901b22f69d5f50b5
Signed-off-by: Francesco Romani <fromani(a)redhat.com>
---
M tests/Makefile.am
R tests/api_response_test.py
2 files changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
Francesco Romani: Verified
Martin Polednik: Verified; Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/67396
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If8ad99b576a373d28dfa8086901b22f69d5f50b5
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 4 months
Change in vdsm[master]: tests: rename api_test.py -> api_response_test.py
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: tests: rename api_test.py -> api_response_test.py
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/67396
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If8ad99b576a373d28dfa8086901b22f69d5f50b5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 4 months