Change in vdsm[master]: resourceManager: Add NamespaceRegistered exception
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: resourceManager: Add NamespaceRegistered exception
......................................................................
resourceManager: Add NamespaceRegistered exception
We used to raise KeyError when trying to register existing namespace.
This is a horrible idea, possibly hiding bugs in the underlying code.
Replace it with new exception.
Change-Id: Ib1f7d5c2a3a0ea28e22551543f6cf00d8a48bea8
Signed-off-by: Nir Soffer <nsoffer(a)redhat.com>
---
M tests/storage_resourcemanager_test.py
M vdsm/storage/blockSD.py
M vdsm/storage/resourceManager.py
M vdsm/storage/sd.py
4 files changed, 13 insertions(+), 7 deletions(-)
Approvals:
Nir Soffer: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
Freddy Rolland: Looks good to me, but someone else must approve
Ala Hino: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/66947
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib1f7d5c2a3a0ea28e22551543f6cf00d8a48bea8
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 8 months
Change in vdsm[master]: resourceManager: Use log.debug for unimportant messages
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: resourceManager: Use log.debug for unimportant messages
......................................................................
resourceManager: Use log.debug for unimportant messages
Registering an existing namespace is neither an interesting event nor
a state change that should be logged in info log level. This is
unfortunate debug message that we see each time a domain is refreshed,
because of the horrible way domain objects are managed.
This change removes these useless logs from the default log level:
Resource namespace 01_img_93404146-0d02-4d98-8310-f356733d7176 already registered (sd:658)
Resource namespace 02_vol_93404146-0d02-4d98-8310-f356733d7176 already registered (sd:667)
Resource namespace 03_lvm_93404146-0d02-4d98-8310-f356733d7176 already registered (blockSD:874)
We need to check later if it is possible to avoid the registration in this
case, or maybe fix domain life cycle handling so we can register the namespace
after the previous instance unregistered it.
Change-Id: I785b411320735a2c24352da470f63a8b2dab554e
Signed-off-by: Nir Soffer <nsoffer(a)redhat.com>
---
M vdsm/storage/blockSD.py
M vdsm/storage/sd.py
2 files changed, 6 insertions(+), 6 deletions(-)
Approvals:
Nir Soffer: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
Freddy Rolland: Looks good to me, but someone else must approve
Maor Lipchuk: Looks good to me, but someone else must approve
Ala Hino: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/66948
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I785b411320735a2c24352da470f63a8b2dab554e
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 8 months
Change in vdsm[master]: net test: Cover and fix ip.address module with integration t...
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net test: Cover and fix ip.address module with integration tests
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/69317
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I95a508ccfb1a2d9773d64289683f6841ed03933c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
6 years, 8 months
Change in vdsm[master]: net: Raise IPRoute2Error from ipwrapper with the return code
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: Raise IPRoute2Error from ipwrapper with the return code
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/69316
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I56f2aaa4720ac22a0c39d42bd5b154c745a48f5e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
6 years, 8 months
Change in vdsm[master]: net: fix set_default_route call to routeDel
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: fix set_default_route call to routeDel
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/69315
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1d9da19e6831cd95d57a58e0bb86567740a1fac
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
6 years, 8 months
Change in vdsm[master]: net: For route deletion, specify the relevant family
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: For route deletion, specify the relevant family
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/69314
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id241c7938ad7fa9266f8d4761eae267e30f07ef4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
6 years, 8 months
Change in vdsm[master]: net test: Provide the ability to preserve the default route
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net test: Provide the ability to preserve the default route
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/69313
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0b8b27080b8aa0053cca8e9fc0642199c20760f6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
6 years, 8 months
Change in vdsm[master]: net: Aggregate network initializations under one roof
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: Aggregate network initializations under one roof
......................................................................
Patch Set 2: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/69198/2/lib/vdsm/supervdsm_server.py
File lib/vdsm/supervdsm_server.py:
Line 66: from vdsm.storage.iscsi import getDevIscsiInfo as _getdeviSCSIinfo
Line 67: from vdsm.storage.iscsi import readSessionInfo as _readSessionInfo
Line 68: from vdsm.supervdsm import _SuperVdsmManager
Line 69:
Line 70: from vdsm.network import initializer as network_initializer
but we know that we intend to kick dhclient_monitor out of supervdsm, so we are about to need to initilize these two network things independently. why merge them temporarily?
Line 71:
Line 72: from vdsm.storage.multipath import getScsiSerial as _getScsiSerial
Line 73: from vdsm.storage import multipath
Line 74: from vdsm.constants import METADATA_GROUP, \
--
To view, visit https://gerrit.ovirt.org/69198
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I90e002bdb029f796efeab2ff5e89234b8ce2200f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
6 years, 8 months
Change in vdsm[master]: net: reformat dhcp response data and always report it
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: reformat dhcp response data and always report it
......................................................................
net: reformat dhcp response data and always report it
DHCP response has been collected through the dhclient options handler.
The VDSM handler, located at /etc/dhcp/dhclient.d/sourceRoute.sh is
creating an unique file under /var/run/vdsm/sourceRoutes that contains
the IP information from the DHCP response.
This patch reformats the data representation and always reports it even
with partial data (e.g. even when the route is missing), leaving it up
to the event handler at the sourceroutethread.
This patch aims to allow (in future patches) to add actions beyond the
existing sourceroute one.
Change-Id: Ifa531e4697b0154849ef02c06100dde26c46b7eb
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
---
M lib/vdsm/network/sourceroutethread.py
M vdsm/sourceRoute.sh
2 files changed, 73 insertions(+), 28 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
Edward Haas: Verified
--
To view, visit https://gerrit.ovirt.org/69159
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifa531e4697b0154849ef02c06100dde26c46b7eb
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 8 months
Change in vdsm[master]: testValidation: tidy import order
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has uploaded a new change for review.
Change subject: testValidation: tidy import order
......................................................................
testValidation: tidy import order
Change-Id: Ie23b1c25ba364f20ecf663e990cebeac54e4070a
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com>
---
M tests/testValidation.py
1 file changed, 4 insertions(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/25/69325/1
diff --git a/tests/testValidation.py b/tests/testValidation.py
index c9b147d..67ceb02 100644
--- a/tests/testValidation.py
+++ b/tests/testValidation.py
@@ -18,12 +18,13 @@
# Refer to the README and COPYING files for full details of the license
#
import errno
-import os
-from nose.plugins.skip import SkipTest
from functools import wraps
-from nose.plugins import Plugin
+import os
import subprocess
+from nose.plugins.skip import SkipTest
+from nose.plugins import Plugin
+
class SlowTestsPlugin(Plugin):
"""
--
To view, visit https://gerrit.ovirt.org/69325
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie23b1c25ba364f20ecf663e990cebeac54e4070a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
6 years, 8 months