Change in vdsm[master]: dockerfile: add magic and blivet
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has uploaded a new change for review.
Change subject: dockerfile: add magic and blivet
......................................................................
dockerfile: add magic and blivet
Recent commit 4b8ce058 added new requirements to the import test, which
broke travis tests. We need to rebuild our images.
Change-Id: Iedb34d172b1de03975f89f042910386639c61fbb
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com>
---
M contrib/Dockerfile.centos
M contrib/Dockerfile.fedora
2 files changed, 4 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/27/67727/1
diff --git a/contrib/Dockerfile.centos b/contrib/Dockerfile.centos
index bd89b0d..78a3bcc 100644
--- a/contrib/Dockerfile.centos
+++ b/contrib/Dockerfile.centos
@@ -16,11 +16,13 @@
mom \
openvswitch \
psmisc \
+ python-blivet \
python-cpopen \
python-decorator \
python-devel \
python-inotify \
python-ioprocess \
+ python-magic \
python-netaddr \
python-pthreading \
python-requests \
diff --git a/contrib/Dockerfile.fedora b/contrib/Dockerfile.fedora
index 1c61d97..3fc1d0f 100644
--- a/contrib/Dockerfile.fedora
+++ b/contrib/Dockerfile.fedora
@@ -18,11 +18,13 @@
mom \
openvswitch \
psmisc \
+ python-blivet \
python-cpopen \
python-decorator \
python-devel \
python-inotify \
python-ioprocess \
+ python-magic \
python-netaddr \
python-pthreading \
python-requests \
--
To view, visit https://gerrit.ovirt.org/67727
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iedb34d172b1de03975f89f042910386639c61fbb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
7 years, 5 months
Change in vdsm[master]: vmstats: user proper way to detect host devices
by fromani＠redhat.com
Francesco Romani has uploaded a new change for review.
Change subject: vmstats: user proper way to detect host devices
......................................................................
vmstats: user proper way to detect host devices
Lacking better ways, back in time we detected host devices
checking their name (!). Now we the code is evolved and we
have proper and safer way to do the same task, so this patch
updates the vmstats code accordingly.
Change-Id: Ic71db639b980dbdf29284c432f4acda95b402c4f
Signed-off-by: Francesco Romani <fromani(a)redhat.com>
---
M lib/vdsm/virt/vmstats.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/71/65771/1
diff --git a/lib/vdsm/virt/vmstats.py b/lib/vdsm/virt/vmstats.py
index 8e271cb..9b65fbd 100644
--- a/lib/vdsm/virt/vmstats.py
+++ b/lib/vdsm/virt/vmstats.py
@@ -330,7 +330,7 @@
last_indexes = _find_bulk_stats_reverse_map(last_sample, 'net')
for nic in vm.getNicDevices():
- if nic.name.startswith('hostdev'):
+ if nic.is_hostdevice:
continue
# may happen if nic is a new hot-plugged one
--
To view, visit https://gerrit.ovirt.org/65771
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic71db639b980dbdf29284c432f4acda95b402c4f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
7 years, 5 months
Change in vdsm[master]: virt: Prevent hook races after a successful migration
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: virt: Prevent hook races after a successful migration
......................................................................
virt: Prevent hook races after a successful migration
When a migration is successfully finished, it's handled in two places:
1. In the source thread, where setDownStatus is called.
2. In the life cycle event handling thread where post-migration hooks are
called.
libvirt documentation doesn't specify when the life cycle event is emitted,
whether before or after migrateToURI3 finishes. This creates a possible source
of races, when a VM may be destroyed before the hooks are run or finished. The
risk may be higher when we introduce (in a followup patch) automatic destroying
of a VM on the source after a successful post-copy migration.
We could solve the problem by moving the hooks to
SourceThread._finishSuccessfully. But then we could still miss other life
cycle events, such as a notification about switching to post-copy migration,
that must be processed in order to handle and finish the migration correctly.
So a safer and simpler solution for now is introducing a synchronizing object
ensuring that we don't finish the migration in the source thread until the
final life cycle event is received and processed.
Change-Id: I92207376c18184dc002ee246953a4ed3a87bce78
Bug-Url: https://bugzilla.redhat.com/1354343
Signed-off-by: Milan Zamazal <mzamazal(a)redhat.com>
---
M lib/vdsm/virt/migration.py
M vdsm/virt/vm.py
2 files changed, 12 insertions(+), 4 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Francesco Romani: Looks good to me, approved
Milan Zamazal: Verified
--
To view, visit https://gerrit.ovirt.org/67499
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I92207376c18184dc002ee246953a4ed3a87bce78
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 5 months
Change in vdsm[master]: tests: Avoid global state modification using forked
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: tests: Avoid global state modification using forked
......................................................................
tests: Avoid global state modification using forked
moduleloader tests modify global state such as sys.path and sys.modules,
and there is no way to restore the state using monkey-patching due to
the complexity of import mechanism. Run the import modules tests in a
sub process so they cannot modify the main process global state.
Change-Id: I2130bcf39918c3c70ed9f8eb9c436c5c8f9c6c09
Signed-off-by: Nir Soffer <nsoffer(a)redhat.com>
---
M tests/moduleloader_test.py
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Piotr Kliczewski: Looks good to me, but someone else must approve
Nir Soffer: Verified
Jenkins CI: Passed CI tests
Irit Goihman: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/67338
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2130bcf39918c3c70ed9f8eb9c436c5c8f9c6c09
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 5 months
Change in vdsm[master]: tests: Avoid global state modification using forked
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: tests: Avoid global state modification using forked
......................................................................
Patch Set 2: Code-Review+2
ok, let's unbreak travis
--
To view, visit https://gerrit.ovirt.org/67338
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2130bcf39918c3c70ed9f8eb9c436c5c8f9c6c09
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 5 months
Change in vdsm[master]: Move caps module to vdsm.host.caps
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: Move caps module to vdsm.host.caps
......................................................................
Patch Set 6: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/57533
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1dfc6d4a873c3ab9ae811b84fca0f7b0a75ff69a
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 5 months
Change in vdsm[master]: Move caps module to vdsm.host.caps
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: Move caps module to vdsm.host.caps
......................................................................
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/57533/5/vdsm/virt/vm.py
File vdsm/virt/vm.py:
PS5, Line 69: from storage import sd
: from storage import sdc
I'm afraid that we cannot drop that comment yet - please keep it above the local storage imports
--
To view, visit https://gerrit.ovirt.org/57533
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1dfc6d4a873c3ab9ae811b84fca0f7b0a75ff69a
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
7 years, 5 months
Change in vdsm[master]: rwtab.d: Remove vdsm entry
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: rwtab.d: Remove vdsm entry
......................................................................
rwtab.d: Remove vdsm entry
oVirt Node Legacy is read-only file system, which required services
to speficy writable dirs into /etc/rwtab.d schema.
Currently, oVirt Node Next do not required such approach and can be
removed.
Change-Id: Ife3193bcb48fa28d5e648c1b28d0a0b01de9206e
Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com>
---
M static/Makefile.am
D static/etc/rwtab.d/vdsm.in
M vdsm.spec.in
3 files changed, 0 insertions(+), 12 deletions(-)
Approvals:
Fabian Deutsch: Looks good to me, but someone else must approve
Piotr Kliczewski: Looks good to me, but someone else must approve
Douglas Schilling Landgraf: Verified
Nir Soffer: Looks good to me, approved
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/67620
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ife3193bcb48fa28d5e648c1b28d0a0b01de9206e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <leon.otium(a)gmail.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 5 months
Change in vdsm[master]: Add ovirt-hosted-engine-ha package to key packages
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: Add ovirt-hosted-engine-ha package to key packages
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/67704
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7d033e1f063150066a8239cb9b87a453a8c379d5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 5 months
Change in vdsm[master]: testValidation: Add @skipif decorator
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: testValidation: Add @skipif decorator
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/67334
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I71a2ae262482edc8acf303f18eac6f9035e710bc
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 5 months