Change in vdsm[master]: supervdsm net: Fix supervdsm_server, restoring NM init call
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: supervdsm net: Fix supervdsm_server, restoring NM init call
......................................................................
Patch Set 1: Code-Review+2
git show 27023f32197f22445a23710e689455df164e687e~:vdsm/supervdsmServer > /tmp/old
git show 27023f32197f22445a23710e689455df164e687e:lib/vdsm/supervdsm_server.py > /tmp/new
diff /tmp/old /tmp/new
1d0
< #!/usr/bin/python2
19a19,20
> from __future__ import absolute_import
>
67,68d67
< from vdsm.storage.multipath import getScsiSerial as _getScsiSerial
< from vdsm.storage import multipath
72d70
< from vdsm.network.nm import networkmanager
73a72,73
> from vdsm.storage.multipath import getScsiSerial as _getScsiSerial
> from vdsm.storage import multipath
310d309
< networkmanager.init()
332,335d330
<
<
< if __name__ == '__main__':
< main(sys.argv[1:])
==> there's an awkward change of import order, but this should not block this patch.
--
To view, visit https://gerrit.ovirt.org/69260
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If8f490f6648e6c7a4ec440ee9efb99948f9db419
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 4 months
Change in vdsm[master]: ovirt_functions.sh: Remove script
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: ovirt_functions.sh: Remove script
......................................................................
Patch Set 4:
> After reboot ovirtmgmt was not there.
did you remember to setSafeNetConfig before reboot?
--
To view, visit https://gerrit.ovirt.org/68023
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I922b27595b3c1b7a0efd7134ba4a0f7ba8ea4983
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 4 months
Change in vdsm[master]: storage_mailbox: SPM_MailMonitor.join
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has uploaded a new change for review.
Change subject: storage_mailbox: SPM_MailMonitor.join
......................................................................
storage_mailbox: SPM_MailMonitor.join
Keep track of the mailbox-spm thread that is created by SPM_MailMonitor
during its initialization, and let SPM_MailMonitor users join on it.
This allows testThreadLeak to politely wait on the the thread that it
implictly created.
Change-Id: I013b60d4036720b1c4d05ca3516f57f782ddd95f
---
M tests/storage_mailbox_test.py
M vdsm/storage/storage_mailbox.py
2 files changed, 15 insertions(+), 9 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/32/69032/1
diff --git a/tests/storage_mailbox_test.py b/tests/storage_mailbox_test.py
index ce935ba..8e0e730 100644
--- a/tests/storage_mailbox_test.py
+++ b/tests/storage_mailbox_test.py
@@ -63,10 +63,13 @@
def testThreadLeak(self):
with StoragePoolStub() as pool:
mailer = sm.SPM_MailMonitor(pool, 100)
- threadCount = len(threading.enumerate())
- mailer.stop()
- mailer.run()
+ try:
+ threadCount = len(threading.enumerate())
+ mailer.stop()
+ mailer.run()
- t = lambda: self.assertEquals(
- threadCount, len(threading.enumerate()))
- retry(AssertionError, t, timeout=4, sleep=0.1)
+ t = lambda: self.assertEquals(
+ threadCount, len(threading.enumerate()))
+ retry(AssertionError, t, timeout=4, sleep=0.1)
+ finally:
+ mailer.join()
diff --git a/vdsm/storage/storage_mailbox.py b/vdsm/storage/storage_mailbox.py
index 79e6c3d..328eea7 100644
--- a/vdsm/storage/storage_mailbox.py
+++ b/vdsm/storage/storage_mailbox.py
@@ -579,11 +579,14 @@
self.log.warning("SPM_MailMonitor couldn't clear outgoing mail, "
"dd failed")
- t = concurrent.thread(self.run, name="mailbox-spm",
- logger=self.log.name)
- t.start()
+ self._thread = concurrent.thread(
+ self.run, name="mailbox-spm", logger=self.log.name)
+ self._thread.start()
self.log.debug('SPM_MailMonitor created for pool %s' % self._poolID)
+ def join(self):
+ self._thread.join()
+
def stop(self):
self._stop = True
--
To view, visit https://gerrit.ovirt.org/69032
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I013b60d4036720b1c4d05ca3516f57f782ddd95f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
7 years, 4 months
Change in vdsm[master]: docker: Move docker files to new docker directory
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: docker: Move docker files to new docker directory
......................................................................
docker: Move docker files to new docker directory
Change-Id: I6a0311838130ea4379cb6f155706e41c4602dd60
Signed-off-by: Nir Soffer <nsoffer(a)redhat.com>
---
R docker/Dockerfile.centos
R docker/Dockerfile.fedora
2 files changed, 0 insertions(+), 0 deletions(-)
Approvals:
Nir Soffer: Verified
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
Edward Haas: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/69204
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6a0311838130ea4379cb6f155706e41c4602dd60
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 4 months
Change in vdsm[master]: dockerfile: Install pip using the official package
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: dockerfile: Install pip using the official package
......................................................................
dockerfile: Install pip using the official package
The Fedora dockerfile was copied from the CentOS dockerfile, installing
python-setuptools and then installing pip using easy_install. However on
Fedora pip is available and we don't need the easy_install dance.
Change-Id: I3bf9cc2771c347959365f52163a8ebbe9d7a0bdb
Signed-off-by: Nir Soffer <nsoffer(a)redhat.com>
---
M docker/Dockerfile.fedora
1 file changed, 1 insertion(+), 2 deletions(-)
Approvals:
Nir Soffer: Verified
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
Edward Haas: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/69211
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3bf9cc2771c347959365f52163a8ebbe9d7a0bdb
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 4 months
Change in vdsm[master]: supervdsm net: Fix supervdsm_server, restoring NM init call
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: supervdsm net: Fix supervdsm_server, restoring NM init call
......................................................................
Patch Set 1: Code-Review+1
Have you verified that this is the only lost code, or should Irit?
--
To view, visit https://gerrit.ovirt.org/69260
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If8f490f6648e6c7a4ec440ee9efb99948f9db419
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 4 months
Change in vdsm[master]: check-merged: experimenting functional tests without NM
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: check-merged: experimenting functional tests without NM
......................................................................
check-merged: experimenting functional tests without NM
it is a suspicion NM causes functional tests to be slow.
this patch will be used as check-merged job to test this
suspicion.
Change-Id: I42608420b42f389fdf3981a22ec4d2077904474d
Signed-off-by: Leon Goldberg <lgoldber(a)redhat.com>
---
M automation/check-merged.sh
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Dan Kenigsberg: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/69241
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I42608420b42f389fdf3981a22ec4d2077904474d
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 4 months
Change in vdsm[master]: check-merged: experimenting functional tests without NM
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: check-merged: experimenting functional tests without NM
......................................................................
Patch Set 2: Code-Review+2 Verified+1
15:13:06 Ran 45 tests in 916.717s
15:13:06
15:13:06 OK (SKIP=1)
--
To view, visit https://gerrit.ovirt.org/69241
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I42608420b42f389fdf3981a22ec4d2077904474d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 4 months
Change in vdsm[master]: docker: Add gcc and redhat-rpm-config
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: docker: Add gcc and redhat-rpm-config
......................................................................
docker: Add gcc and redhat-rpm-config
These packages are required to build yappi. They are included in the
current images in docker hub but not in vdsm source, probably because I
forgot to submit the patch adding them.
Change-Id: I7075074894ddc69cdd6f595d463d6b036a68bdf1
Signed-off-by: Nir Soffer <nsoffer(a)redhat.com>
---
M contrib/Dockerfile.centos
M contrib/Dockerfile.fedora
2 files changed, 4 insertions(+), 0 deletions(-)
Approvals:
Nir Soffer: Verified
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/69212
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7075074894ddc69cdd6f595d463d6b036a68bdf1
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 4 months
Change in vdsm[master]: travis: Add Fedora 25 build
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: travis: Add Fedora 25 build
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/69206
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6961cc3cdf531d9e9347a2c462a364bba465516a
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 4 months