Change in vdsm[master]: storage: Support new dd output
by automation＠ovirt.org
gerrit-hooks has posted comments on this change.
Change subject: storage: Support new dd output
......................................................................
Patch Set 12:
* #1342397::Update tracker: OK
* Set MODIFIED::bug 1342397::::#1342397::::OK
--
To view, visit https://gerrit.ovirt.org/56091
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I632d99cdc2b41e96a75bdce12e86710241fa0939
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 10 months
Change in vdsm[master]: storage: Support new dd output
by Nir Soffer
Nir Soffer has submitted this change and it was merged.
Change subject: storage: Support new dd output
......................................................................
storage: Support new dd output
In Fedora 24 we can find the new dd from coreutils 8.25.5
which has a new fancier output format:
Example #1:
1+0 records in
1+0 records out
4096 bytes (4.1 kB, 4.0 KiB) copied, 0.00887814 s, 461 kB/s
^^^^^^^^^^^^^^^^^
Example #2:
0+1 records in
0+1 records out
30 bytes copied, 0.00156704 s, 19.1 kB/s
^^^^
Compare with the old dd output found in Fedora 23:
Example #1:
1+0 records in
1+0 records out
4096 bytes (4.1 kB) copied, 0.00135703 s, 3.0 MB/s
^^^^^^^^
Example #2:
0+1 records in
0+1 records out
30 bytes (30 B) copied, 0.0033204 s, 9.0 kB/s
^^^^^^
After a quick glance at the dd manpage, I couldn't find a way to
disable the new output, which breaks the storage regex to
parse the read speed results.
To add compatibility with the new format, without breaking
support for older versions, this patch replaces the implementation
of storage.check.CheckResult, switching from a regex to a simpler
pattern matching using the methods of string objects.
Change-Id: I632d99cdc2b41e96a75bdce12e86710241fa0939
Bug-Url: https://bugzilla.redhat.com/1342397
Signed-off-by: Francesco Romani <fromani(a)redhat.com>
Reviewed-on: https://gerrit.ovirt.org/56091
Continuous-Integration: Jenkins CI
Reviewed-by: Nir Soffer <nsoffer(a)redhat.com>
---
M lib/vdsm/storage/check.py
M tests/storage_check_test.py
2 files changed, 7 insertions(+), 7 deletions(-)
Approvals:
Nir Soffer: Looks good to me, approved
Jenkins CI: Passed CI tests
Francesco Romani: Verified
--
To view, visit https://gerrit.ovirt.org/56091
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I632d99cdc2b41e96a75bdce12e86710241fa0939
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 10 months
Change in vdsm[master]: storage: Support new dd output
by automation＠ovirt.org
gerrit-hooks has posted comments on this change.
Change subject: storage: Support new dd output
......................................................................
Patch Set 11:
* #1342397::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1342397::OK, public bug
* Check Product::#1342397::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
--
To view, visit https://gerrit.ovirt.org/56091
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I632d99cdc2b41e96a75bdce12e86710241fa0939
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 10 months
Change in vdsm[master]: storage: support new dd output
by Nir Soffer
Nir Soffer has posted comments on this change.
Change subject: storage: support new dd output
......................................................................
Patch Set 10: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/56091
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I632d99cdc2b41e96a75bdce12e86710241fa0939
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 10 months
Change in vdsm[master]: storage: support new dd output
by fromani＠redhat.com
Francesco Romani has posted comments on this change.
Change subject: storage: support new dd output
......................................................................
Patch Set 10: Verified+1
verified using the tests and letting a patched Vdsm run for a while on RHEL7.2, to at least do a basic check for regressions. Looks good.
--
To view, visit https://gerrit.ovirt.org/56091
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I632d99cdc2b41e96a75bdce12e86710241fa0939
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 10 months
Change in vdsm[master]: build: Make sure run_tests*.sh scripts are executable
by mzamazal＠redhat.com
Milan Zamazal has posted comments on this change.
Change subject: build: Make sure run_tests*.sh scripts are executable
......................................................................
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/55949/4/build-aux/Makefile.subs
File build-aux/Makefile.subs:
Line 39:
Line 40: CONFIGSUBST = $(top_builddir)/config.status --file=-
Line 41:
Line 42: %: %.in
Line 43: @echo " SED $@"; $(PATHSUBST) $< |$(CONFIGSUBST) >$@
> I have found out why it worked for Milan. Automake generated Makefiles have
Thank you, Tomáš, for explaining those tricky issues!
Yaniv, your make_executables rule works, but it must be invoked some way, which may be a problem and is not going to simplify things I guess.
Since Tomáš has confirmed single colon works, we can leave it here and we can consider his suggestion of switching to double colon in a separate patch.
Line 44: @if expr "$@" : ".*\\.sh" >/dev/null ; then \
Line 45: chmod a+x "$@" ; \
--
To view, visit https://gerrit.ovirt.org/55949
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc1e3dc8ace7f69801b765262352903020cc8aef
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Tomas Golembiovsky <tgolembi(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
7 years, 10 months
Change in vdsm[master]: net test: Cleanup setupNetwork by removing kwargs
by automation＠ovirt.org
gerrit-hooks has posted comments on this change.
Change subject: net test: Cleanup setupNetwork by removing kwargs
......................................................................
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit https://gerrit.ovirt.org/59210
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I67ead35aa60ba14fabeb3002169c25758817e63d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 10 months
Change in vdsm[master]: net test: Cleanup setupNetwork by removing kwargs
by Dan Kenigsberg
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net test: Cleanup setupNetwork by removing kwargs
......................................................................
net test: Cleanup setupNetwork by removing kwargs
Use test_kernel_config flag instead with a default value of True.
Change-Id: I67ead35aa60ba14fabeb3002169c25758817e63d
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
Reviewed-on: https://gerrit.ovirt.org/59210
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg <danken(a)redhat.com>
---
M tests/functional/networkTests.py
1 file changed, 1 insertion(+), 2 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
Edward Haas: Verified
--
To view, visit https://gerrit.ovirt.org/59210
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I67ead35aa60ba14fabeb3002169c25758817e63d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 10 months
Change in vdsm[master]: net test: Cleanup setupNetwork by removing kwargs
by Dan Kenigsberg
Dan Kenigsberg has posted comments on this change.
Change subject: net test: Cleanup setupNetwork by removing kwargs
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/59210
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I67ead35aa60ba14fabeb3002169c25758817e63d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 10 months
Change in vdsm[master]: build: Make sure run_tests*.sh scripts are executable
by automation＠ovirt.org
gerrit-hooks has posted comments on this change.
Change subject: build: Make sure run_tests*.sh scripts are executable
......................................................................
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0'])
--
To view, visit https://gerrit.ovirt.org/55949
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc1e3dc8ace7f69801b765262352903020cc8aef
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Tomas Golembiovsky <tgolembi(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 10 months
