Change in vdsm[master]: jsonrpcvdscli: pop timeout before preparing args
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: jsonrpcvdscli: pop timeout before preparing args
......................................................................
jsonrpcvdscli: pop timeout before preparing args
We get this error every time we add custom timeout:
Following parameters [u'_transport_timeout'] were not recognized.
_transport_timeout is no a command parameter but an indicator to
change default timeout to a new value.
So, it shouldn't be added to params and should be removed from kwargs
before that.
Change-Id: If89d2d96b183aaea13446c4bc6b940f4ea40cd62
Signed-off-by: Irit Goihman <igoihman(a)redhat.com>
---
M lib/vdsm/jsonrpcvdscli.py
1 file changed, 2 insertions(+), 3 deletions(-)
Approvals:
Piotr Kliczewski: Looks good to me, approved
Nir Soffer: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Irit Goihman: Verified
--
To view, visit https://gerrit.ovirt.org/71404
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If89d2d96b183aaea13446c4bc6b940f4ea40cd62
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 2 months
Change in vdsm[master]: fileSD: escape values passed to glob.glob
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: fileSD: escape values passed to glob.glob
......................................................................
Patch Set 10: Code-Review-1
needs to be rebased manually above bd3004eeea9b0a06fbb7ecee20086bddbd01ee96
--
To view, visit https://gerrit.ovirt.org/69835
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id13b5adadc8e2a2be0d32105cb22b35544db1fad
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 2 months
Change in vdsm[master]: hooks: Add localdisk hook
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: hooks: Add localdisk hook
......................................................................
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/71272/5/vdsm_hooks/localdisk/Makefile.am
File vdsm_hooks/localdisk/Makefile.am:
Line 43: $(RM) /usr/lib/udev/rules.d/12-vdsm-localdisk.rules
Line 44:
Line 45: install-data-sudoers:
Line 46: $(MKDIR_P) $(DESTDIR)$(sysconfdir)/sudoers.d
Line 47: $(INSTALL_DATA) $(srcdir)/50_vdsm_localdisk \
From CI:
07:54:37 /usr/bin/install -c -m 644 ./50_vdsm_localdisk \
07:54:37 /home/jenkins/workspace/vdsm_master_check-patch-el7-x86_64/vdsm/rpmbuild/BUILDROOT/vdsm-4.20.0-279.git7e4a773.el7.centos.x86_64/etc/sudoers.d/50_vdsm_localdisk
07:54:37 /usr/bin/install: cannot stat './50_vdsm_localdisk': No such file or directory
Line 48: $(DESTDIR)$(sysconfdir)/sudoers.d/50_vdsm_localdisk
Line 49:
Line 50: uninstall-data-sudoers:
Line 51: $(RM) $(DESTDIR)$(sysconfdir)/sudoers.d/50_vdsm_localdisk
--
To view, visit https://gerrit.ovirt.org/71272
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5b6ad8e8ebb4cd71bff02157f28cd2be5c31ac35
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Fred Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yaniv Kaul <ykaul(a)redhat.com>
Gerrit-HasComments: Yes
7 years, 2 months
Change in vdsm[master]: m2c: signature change in getsockopt
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: m2c: signature change in getsockopt
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/71246
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I851445fc6b7c463e062e5eb4964a40dd1d8a6fd5
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 2 months
Change in vdsm[master]: fileSD: escape values passed to glob.glob
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: fileSD: escape values passed to glob.glob
......................................................................
Patch Set 7: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/69835
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id13b5adadc8e2a2be0d32105cb22b35544db1fad
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 2 months
Change in vdsm[master]: compat: add glob.escape from Python 3.6
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: compat: add glob.escape from Python 3.6
......................................................................
compat: add glob.escape from Python 3.6
glob.escape was added in Python 3.6.
Since we need it for escaping values that are passed to glob.glob,
this patch adds it to glob.py.
Change-Id: Id2989a9edcc87ec671d8c29ec7900e01b537b3f1
Related-To: https://bugzilla.redhat.com/1302358
Signed-off-by: Idan Shaby <ishaby(a)redhat.com>
---
A lib/vdsm/common/glob.py
M lib/vdsm/compat.py
M tests/Makefile.am
A tests/glob_test.py
4 files changed, 176 insertions(+), 2 deletions(-)
Approvals:
Nir Soffer: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
Idan Shaby: Verified
Edward Haas: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/70473
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id2989a9edcc87ec671d8c29ec7900e01b537b3f1
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 2 months
Change in vdsm[master]: compat: add glob.escape from Python 3.6
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: compat: add glob.escape from Python 3.6
......................................................................
Patch Set 4: Code-Review+2
I don't like spamming vdsm.common with minor modules like this, but let it be.
--
To view, visit https://gerrit.ovirt.org/70473
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id2989a9edcc87ec671d8c29ec7900e01b537b3f1
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 2 months
Change in vdsm[master]: net: Set and report device mac address through link.iface
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: Set and report device mac address through link.iface
......................................................................
net: Set and report device mac address through link.iface
Change-Id: I21a63a4a36252634744e7af177706403353aaab4
Signed-off-by: Leon Goldberg <lgoldber(a)redhat.com>
---
M lib/vdsm/network/link/iface.py
M tests/network/link_iface_test.py
2 files changed, 20 insertions(+), 2 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
Leon Goldberg: Verified
Edward Haas: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/71368
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I21a63a4a36252634744e7af177706403353aaab4
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 2 months
Change in vdsm[master]: net: Set and report device mac address through link.iface
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: Set and report device mac address through link.iface
......................................................................
Patch Set 8: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/71368
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I21a63a4a36252634744e7af177706403353aaab4
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 2 months
Change in vdsm[master]: check-merged: unbreak network functional tests
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: check-merged: unbreak network functional tests
......................................................................
check-merged: unbreak network functional tests
network functional tests are running setupNetworks using
jsonrpcvdscli.
This results in JsonRpcNoResponseError, which means the operation
takes too long and we receive a timeout before we get a response back.
jsonrpc timeout was changed for all setupNetworks calls in tests,
ensuring the commands will finish before the short timeout.
Change-Id: I3d6cdea3f0f0b895ffaa7b5e829acad422b804e3
Signed-off-by: Irit Goihman <igoihman(a)redhat.com>
---
M tests/functional/utils.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Piotr Kliczewski: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Irit Goihman: Verified
Dan Kenigsberg: Looks good to me, approved
Edward Haas: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/71335
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3d6cdea3f0f0b895ffaa7b5e829acad422b804e3
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 2 months