Change in vdsm[master]: tests: Insert search path at start of sys.path
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: tests: Insert search path at start of sys.path
......................................................................
Patch Set 3: Code-Review+1
I don't mind, but you don't backup your statement with any time values
--
To view, visit https://gerrit.ovirt.org/67342
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I41db88ce35294667a12e83277e5163b14a55346d
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 4 months
Change in vdsm[master]: tests: Remove useless permutation
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: tests: Remove useless permutation
......................................................................
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/67341
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I107b29317e2f612faf7255e58ae4ac37c07c32c1
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 4 months
Change in vdsm[master]: net test: Cover and fix ip.address module with integration t...
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net test: Cover and fix ip.address module with integration tests
......................................................................
net test: Cover and fix ip.address module with integration tests
Change-Id: I95a508ccfb1a2d9773d64289683f6841ed03933c
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
---
M lib/vdsm/network/ip/address.py
M tests/Makefile.am
M tests/network/ip_address_test.py
3 files changed, 91 insertions(+), 4 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
Edward Haas: Verified
--
To view, visit https://gerrit.ovirt.org/69317
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I95a508ccfb1a2d9773d64289683f6841ed03933c
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 4 months
Change in vdsm[master]: automation: avoid yappi skips
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has uploaded a new change for review.
Change subject: automation: avoid yappi skips
......................................................................
automation: avoid yappi skips
I am not sure that testing yappi is worth the time consumed by it, but
I'd like to consider removing of
SKIP: yappi is not installed
messages from the test stdout.
Change-Id: I7ade1636b38e7b8361279e230ca9c238c41e0b6e
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com>
---
M automation/check-patch.sh
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/89/68089/1
diff --git a/automation/check-patch.sh b/automation/check-patch.sh
index ee9052f..d01161d 100755
--- a/automation/check-patch.sh
+++ b/automation/check-patch.sh
@@ -8,7 +8,7 @@
export OVIRT_CI=1
easy_install pip
-pip install -U tox==2.1.1
+pip install -U tox==2.1.1 yappi
./autogen.sh --system --enable-hooks --enable-vhostmd
--
To view, visit https://gerrit.ovirt.org/68089
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7ade1636b38e7b8361279e230ca9c238c41e0b6e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
7 years, 4 months
Change in vdsm[master]: net test: Cover and fix ip.address module with integration t...
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net test: Cover and fix ip.address module with integration tests
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/69317
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I95a508ccfb1a2d9773d64289683f6841ed03933c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 4 months
Change in vdsm[master]: net: fix set_default_route call to routeDel
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: fix set_default_route call to routeDel
......................................................................
net: fix set_default_route call to routeDel
Change-Id: Ia1d9da19e6831cd95d57a58e0bb86567740a1fac
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
---
M lib/vdsm/network/ip/address.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
Edward Haas: Verified
--
To view, visit https://gerrit.ovirt.org/69315
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia1d9da19e6831cd95d57a58e0bb86567740a1fac
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 4 months
Change in vdsm[master]: net: Raise IPRoute2Error from ipwrapper with the return code
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: Raise IPRoute2Error from ipwrapper with the return code
......................................................................
net: Raise IPRoute2Error from ipwrapper with the return code
It has been found useful in the debugging process and it may help upper
layers to catch/handle a more specific error.
Change-Id: I56f2aaa4720ac22a0c39d42bd5b154c745a48f5e
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
---
M lib/vdsm/network/ipwrapper.py
1 file changed, 1 insertion(+), 2 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
Edward Haas: Verified
--
To view, visit https://gerrit.ovirt.org/69316
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I56f2aaa4720ac22a0c39d42bd5b154c745a48f5e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 4 months
Change in vdsm[master]: net: For route deletion, specify the relevant family
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: For route deletion, specify the relevant family
......................................................................
net: For route deletion, specify the relevant family
Deleting a route without specifing the family may result in a deletion
of both IPv4 and IPv6 routes.
Such a scenario explicitly occurs when deleting the 'default' route.
This patch allows the caller to specify an explicit family for the route
deletion.
iproute2 module is the only caller at the moment.
Change-Id: Id241c7938ad7fa9266f8d4761eae267e30f07ef4
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
---
M lib/vdsm/network/configurators/iproute2.py
M lib/vdsm/network/ipwrapper.py
2 files changed, 3 insertions(+), 3 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
Edward Haas: Verified
--
To view, visit https://gerrit.ovirt.org/69314
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id241c7938ad7fa9266f8d4761eae267e30f07ef4
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 4 months
Change in vdsm[master]: net test: Provide the ability to preserve the default route
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net test: Provide the ability to preserve the default route
......................................................................
net test: Provide the ability to preserve the default route
Introducing preserve_default_route under nettestlib module, to assist
tests to preserve the system original default route and properly cleanup
the test.
With this patch, it is now possible to add a default route and query the
existing one for both IPv4 and IPv6.
Change-Id: I0b8b27080b8aa0053cca8e9fc0642199c20760f6
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
---
M lib/vdsm/network/ip/address.py
M lib/vdsm/network/ipwrapper.py
M lib/vdsm/network/netinfo/routes.py
M tests/network/nettestlib.py
4 files changed, 41 insertions(+), 3 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
Edward Haas: Verified
--
To view, visit https://gerrit.ovirt.org/69313
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0b8b27080b8aa0053cca8e9fc0642199c20760f6
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 4 months
Change in vdsm[master]: net test: Provide the ability to preserve the default route
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net test: Provide the ability to preserve the default route
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/69313
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0b8b27080b8aa0053cca8e9fc0642199c20760f6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 4 months