From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: gluster: avoid over allocation in lvs
......................................................................
Patch Set 2: Code-Review+2
raising Sahina's score
--
To view, visit https://gerrit.ovirt.org/72691
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I421401246b77c33e3ad02d08b3c0c06335c71446
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: tests: migration: add test to exercise retry
......................................................................
tests: migration: add test to exercise retry
Due the shape of the code, it is hard to test the migration
retry logic, we require a good chunk of boilerplate and faking.
This patch tries to be minimal and add those tests.
Change-Id: I2fe7c95a50af5d227bcd6eaf4099e8dd0f08e108
Related-To: https://bugzilla.redhat.com/1414626
Signed-off-by: Francesco Romani <fromani(a)redhat.com>
---
M tests/vmmigration_test.py
1 file changed, 110 insertions(+), 1 deletion(-)
Approvals:
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
Francesco Romani: Verified
Milan Zamazal: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/71300
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2fe7c95a50af5d227bcd6eaf4099e8dd0f08e108
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: tests: migration: add test to exercise retry
......................................................................
Patch Set 9: Code-Review+2
raising milan's opinion.
--
To view, visit https://gerrit.ovirt.org/71300
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2fe7c95a50af5d227bcd6eaf4099e8dd0f08e108
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: clientIF: drop xmlrpc support
......................................................................
Patch Set 3: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/72476/3/vdsm/clientIF.py
File vdsm/clientIF.py:
Line 247
Line 248
Line 249
Line 250
Line 251
this is the only functional import of bindingxmlrpc. We should eliminate it as a module. we should start the bindingxmlrpc http server unconditionally, but keep only OVS_STORE-related code there.
xmlrpc_enable should be deleted too.
--
To view, visit https://gerrit.ovirt.org/72476
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I15df578860f3276ffcc005800d6b03996900b2bb
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vdsm: update man page
......................................................................
vdsm: update man page
updated reference to vdsm wiki and the updated license
file.
Change-Id: Ic71ad17922c780e99d8275e02d8a2915d5c32681
Signed-off-by: Irit Goihman <igoihman(a)redhat.com>
---
M static/usr/share/man/man8/vdsmd.8.in
1 file changed, 7 insertions(+), 3 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Irit Goihman: Verified
Dan Kenigsberg: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/71067
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic71ad17922c780e99d8275e02d8a2915d5c32681
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: api: move vdsmapi to lib
......................................................................
Patch Set 1:
Sorry Francesco I missed your request to run ovirt-system-tests..
--
To view, visit https://gerrit.ovirt.org/72496
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I95a7caf4fa354c7bea7e8f15533d5748182ed5fc
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: m2c: reduce log level for ssl errors
......................................................................
m2c: reduce log level for ssl errors
m2crypto tends to be verbose when a client closes connection. I tested
this behavior using ssl debug and noticed that those error messages are
harmless. They only appear when using m2crypto. We want to reduce
confusion so it is better to log those in debug.
Bug-Url: https://bugzilla.redhat.com/1412583
Change-Id: I5624643b659ba5e97436b2c0f42a5f43420d50db
Signed-off-by: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
---
M lib/yajsonrpc/betterAsyncore.py
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Piotr Kliczewski: Verified
Yaniv Bronhaim: Looks good to me, approved
Jenkins CI: Passed CI tests
Irit Goihman: Looks good to me, but someone else must approve
Francesco Romani: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/72506
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5624643b659ba5e97436b2c0f42a5f43420d50db
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: api: move vdsmapi to lib
......................................................................
api: move vdsmapi to lib
We are going to move all the files from lib/api to lib/vdsm/api.
Bug-Url: https://bugzilla.redhat.com/1376116
Change-Id: I95a7caf4fa354c7bea7e8f15533d5748182ed5fc
Signed-off-by: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
---
M automation/build-artifacts.sh
M configure.ac
M lib/Makefile.am
M lib/vdsm/Makefile.am
R lib/vdsm/api/Makefile.am
R lib/vdsm/api/__init__.py
R lib/vdsm/api/schema_to_html.py
R lib/vdsm/api/vdsm-api-gluster.yml
R lib/vdsm/api/vdsm-api.yml
R lib/vdsm/api/vdsm-events.yml
R lib/vdsm/api/vdsmapi.py
M lib/vdsm/client.py
M lib/vdsm/jsonrpcvdscli.py
M lib/vdsm/rpc/Bridge.py
M tests/schemaValidationTest.py
M tests/vdsmapi_test.py
M tests/vmApiTests.py
M vdsm.spec.in
18 files changed, 32 insertions(+), 32 deletions(-)
Approvals:
Piotr Kliczewski: Verified
Yaniv Bronhaim: Looks good to me, approved
Jenkins CI: Passed CI tests
Irit Goihman: Looks good to me, but someone else must approve
Francesco Romani: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/72496
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I95a7caf4fa354c7bea7e8f15533d5748182ed5fc
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>