vdsm-patches February 2017

vdsm-patches@lists.fedorahosted.org

1 participants
297 discussions

Change in vdsm[ovirt-4.1]: he_upgrade: add commands for 3.5 -> 3.6 upgrade with jsonrpc
by Code Review 27 Feb '17

27 Feb '17

From Yaniv Bronhaim <ybronhei(a)redhat.com>: Yaniv Bronhaim has posted comments on this change. Change subject: he_upgrade: add commands for 3.5 -> 3.6 upgrade with jsonrpc ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/72731 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie8c2575e5c5874fc4152fb1ea6f9eb3ff400fa9e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.1 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-HasComments: No

1 0

Change in vdsm[master]: sampling: rename VMBulkSampler
by Code Review 27 Feb '17

27 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has submitted this change and it was merged. Change subject: sampling: rename VMBulkSampler ...................................................................... sampling: rename VMBulkSampler Rename to `VMBulkstatsMonitor` because is a bit nicer and more consistent with the rest of the periodic operations. No changes in behaviour. Change-Id: I029727100d7418e237bcedfad942ed28b44f933a Signed-off-by: Francesco Romani <fromani(a)redhat.com> --- M lib/vdsm/virt/periodic.py M lib/vdsm/virt/sampling.py M tests/virttests/bulk_sampling_test.py 3 files changed, 9 insertions(+), 9 deletions(-) Approvals: Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved Francesco Romani: Verified -- To view, visit https://gerrit.ovirt.org/67426 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I029727100d7418e237bcedfad942ed28b44f933a Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com> Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in vdsm[master]: sampling: rename VMBulkSampler
by Code Review 27 Feb '17

27 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has posted comments on this change. Change subject: sampling: rename VMBulkSampler ...................................................................... Patch Set 10: Code-Review+2 benign name change. -- To view, visit https://gerrit.ovirt.org/67426 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I029727100d7418e237bcedfad942ed28b44f933a Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com> Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-HasComments: No

1 0

Change in vdsm[master]: virt: Run job completed callback only for migrations
by Code Review 27 Feb '17

27 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has submitted this change and it was merged. Change subject: virt: Run job completed callback only for migrations ...................................................................... virt: Run job completed callback only for migrations We introduced onJobCompleted callback to handle finished migration statistics and other stuff. However we can't be sure that the callback is run only for remote host migration jobs. We add a check for that. We use SourceThread.started flag for that purpose. Once a migration starts, the flag is set. If the migration finishes successfully, we keep the flag set and we know that the callback must be from a migration (assuming it's not a delayed callback from another domain job and that we don't run other domain jobs in parallel with migrations). If the migration fails and the VM continues to operate then the flag is unset (this is change in handling of the flag but it doesn't influence its original use), in which case we disable the callback processing. We've got a similar problem in _recover_status, but we'll handle that separately, since we need more information from libvirt developers there and we needn't backport _recover_status changes to 4.1. Change-Id: I066906f4898d188ceac50101df6bf20adfa0ff89 Backport-To: 4.1 Signed-off-by: Milan Zamazal <mzamazal(a)redhat.com> --- M lib/vdsm/virt/migration.py M vdsm/virt/vm.py 2 files changed, 8 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Francesco Romani: Looks good to me, approved Milan Zamazal: Verified -- To view, visit https://gerrit.ovirt.org/72329 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I066906f4898d188ceac50101df6bf20adfa0ff89 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal <mzamazal(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in vdsm[master]: mailbox: Decrease the chance of checksum failures
by Code Review 26 Feb '17

26 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has posted comments on this change. Change subject: mailbox: Decrease the chance of checksum failures ...................................................................... Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/73078/2//COMMIT_MSG Commit Message: Line 17: There is no way to write 4096 bytes atomically, so we cannot fix this Line 18: issue. But we can decrease the chance of the failure by doing one write Line 19: of 4096 bytes, instead of 8 writes of 512 bytes. There is still chance Line 20: of failure since writing on the remote storage is probably done using Line 21: 512 blocks, but the chance of reading incomplete write is much lower. I suspect that this may also improve performance on modern storage, where the sector size is 4096 ? Line 22: Line 23: Since both reading and writing was done using 512 bytes blocks, both Line 24: were modified to use 4096 block size. The SPM mailbox is already writing Line 25: replies using 4096 block size. -- To view, visit https://gerrit.ovirt.org/73078 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3e170d69437a9fb86bac7b65d6fcd48971375e99 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-HasComments: Yes

1 0

Change in vdsm[master]: storage_persistentdict: simplify code by using sorted()
by Code Review 26 Feb '17

26 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has uploaded a new change for review. Change subject: storage_persistentdict: simplify code by using sorted() ...................................................................... storage_persistentdict: simplify code by using sorted() The intention was to make this code compliant with Python 3, but the outcome is cleaner, regardless. On its own, sorted() adds a redundant copy of a list, but this copy replaces an existing copy that was happening inside the keys() call. Change-Id: I9732157a410735c14d4f5f8d87249b2c77ecb04c Signed-off-by: Dan Kenigsberg <danken(a)redhat.com> --- M lib/vdsm/storage/persistent.py 1 file changed, 3 insertions(+), 6 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/00/73100/1 diff --git a/lib/vdsm/storage/persistent.py b/lib/vdsm/storage/persistent.py index 09682a3..be853de 100644 --- a/lib/vdsm/storage/persistent.py +++ b/lib/vdsm/storage/persistent.py @@ -32,6 +32,7 @@ import threading from copy import deepcopy +import six from six.moves import filter as ifilter SHA_CKSUM_TAG = "_SHA_CKSUM" @@ -268,9 +269,7 @@ return checksumCalculator = hashlib.sha1() - keys = newMD.keys() - keys.sort() - for key in keys: + for key in sorted(six.iterkeys(newMD)): value = newMD[key] line = "%s=%s" % (key, value) checksumCalculator.update(_preprocessLine(line)) @@ -292,9 +291,7 @@ checksumCalculator = hashlib.sha1() lines = [] - keys = md.keys() - keys.sort() - for key in keys: + for key in sorted(six.iterkeys(md)): value = md[key] line = "=".join([key, value.strip()]) checksumCalculator.update(_preprocessLine(line)) -- To view, visit https://gerrit.ovirt.org/73100 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I9732157a410735c14d4f5f8d87249b2c77ecb04c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>

1 0

Change in vdsm[master]: net tests: Don't compare running to kernel config with ifcfg...
by Code Review 26 Feb '17

26 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has submitted this change and it was merged. Change subject: net tests: Don't compare running to kernel config with ifcfg persistence ...................................................................... net tests: Don't compare running to kernel config with ifcfg persistence setupModules compares the running config to the kernel config in order to verify the integrity of the host, however if persistence is set to ifcfg the configs aren't available and shouldn't be compared. Change-Id: I5c957f89a1a90aac092b207666443e79257ad1e3 Signed-off-by: Leon Goldberg <lgoldber(a)redhat.com> --- M tests/functional/networkTests.py 1 file changed, 14 insertions(+), 10 deletions(-) Approvals: Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved Leon Goldberg: Verified Edward Haas: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/72977 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5c957f89a1a90aac092b207666443e79257ad1e3 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in vdsm[ovirt-4.0]: virt-net: attempt to unset port mirroring only if the VM was...
by Code Review 26 Feb '17

26 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has uploaded a new change for review. Change subject: virt-net: attempt to unset port mirroring only if the VM was properly initialized ...................................................................... virt-net: attempt to unset port mirroring only if the VM was properly initialized If qemu crashed before we read the libvirt-allocated device names, the VM moves to Down state. However, when we are asked to destroy() the VM object, we attempt to unset port mirroring on a vNIC that was never properly initialized. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1419931 Change-Id: I3bb916612285bea0d281c3c2e4c9dbb2eb08645a Signed-off-by: Dan Kenigsberg <danken(a)redhat.com> --- M vdsm/virt/vm.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/42/72742/1 diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py index d69d364..078c6eb 100644 --- a/vdsm/virt/vm.py +++ b/vdsm/virt/vm.py @@ -4119,7 +4119,7 @@ # unsetting mirror network will clear both mirroring # (on the same network). for nic in self._devices[hwclass.NIC]: - if hasattr(nic, 'portMirroring'): + if hasattr(nic, 'portMirroring') and hasattr(nic, 'name'): for network in nic.portMirroring[:]: supervdsm.getProxy().unsetPortMirroring(network, nic.name) -- To view, visit https://gerrit.ovirt.org/72742 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I3bb916612285bea0d281c3c2e4c9dbb2eb08645a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>

1 1

Change in vdsm[master]: net tests: Don't compare running to kernel config with ifcfg...
by Code Review 26 Feb '17

26 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has posted comments on this change. Change subject: net tests: Don't compare running to kernel config with ifcfg persistence ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/72977 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5c957f89a1a90aac092b207666443e79257ad1e3 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-HasComments: No

1 0

Change in vdsm[master]: pylint: storage: silence errors regarding six.moves.queue
by Code Review 26 Feb '17

26 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has uploaded a new change for review. Change subject: pylint: storage: silence errors regarding six.moves.queue ...................................................................... pylint: storage: silence errors regarding six.moves.queue six.moves is too smart for pylint. Change-Id: Iee9ac33fb94ce4fc0c6aaeb73d5e0b6434cfeffc Signed-off-by: Dan Kenigsberg <danken(a)redhat.com> --- M lib/vdsm/storage/resourceManager.py M lib/vdsm/storage/threadPool.py 2 files changed, 5 insertions(+), 5 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/92/73092/1 diff --git a/lib/vdsm/storage/resourceManager.py b/lib/vdsm/storage/resourceManager.py index eb04ac8..e0a22b6 100644 --- a/lib/vdsm/storage/resourceManager.py +++ b/lib/vdsm/storage/resourceManager.py @@ -27,7 +27,7 @@ from contextlib import nested from uuid import uuid4 -from six.moves.queue import Queue +from six.moves import queue from vdsm.logUtils import SimpleLogAdapter from vdsm import concurrent @@ -456,7 +456,7 @@ except ValueError: raise TypeError("'timeout' must be number") - resource = Queue() + resource = queue.Queue() def callback(req, res): resource.put(res) diff --git a/lib/vdsm/storage/threadPool.py b/lib/vdsm/storage/threadPool.py index 17fac3a..366122f 100644 --- a/lib/vdsm/storage/threadPool.py +++ b/lib/vdsm/storage/threadPool.py @@ -13,7 +13,7 @@ import logging import threading -from six.moves.queue import Queue, Empty +from six.moves import queue from time import sleep from vdsm import concurrent @@ -40,7 +40,7 @@ self._taskThread = {} self.__resizeLock = threading.Condition(threading.Lock()) self.__runningTasksLock = threading.Condition(threading.Lock()) - self.__tasks = Queue(maxTasks) + self.__tasks = queue.Queue(maxTasks) self.__isJoining = False self.__runningTasks = 0 self.__waitTimeout = waitTimeout @@ -134,7 +134,7 @@ try: id, cmd, args, callback = self.__tasks.get(True, self.__waitTimeout) - except Empty: + except queue.Empty: pass return id, cmd, args, callback -- To view, visit https://gerrit.ovirt.org/73092 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iee9ac33fb94ce4fc0c6aaeb73d5e0b6434cfeffc Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>

1 2

← Newer
1
2
3
4
5
6
7
8
9
...
30
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

vdsm-patches February 2017