vdsm-patches February 2017

vdsm-patches@lists.fedorahosted.org

1 participants
297 discussions

Change in vdsm[master]: hostdev: use reattach_detachable in PCI devices
by Code Review 28 Feb '17

28 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has submitted this change and it was merged. Change subject: hostdev: use reattach_detachable in PCI devices ...................................................................... hostdev: use reattach_detachable in PCI devices We can now do that with pci_reattach param. Moves part of the logic to hostdev module rather than (soon to be extinct) device class. Change-Id: Ic5669aa5e8486805f60fc636085071b58e9db7fa Signed-off-by: Martin Polednik <mpolednik(a)redhat.com> --- M lib/vdsm/virt/vmdevices/hostdevice.py 1 file changed, 1 insertion(+), 3 deletions(-) Approvals: Jenkins CI: Passed CI tests Francesco Romani: Looks good to me, approved Martin Polednik: Verified -- To view, visit https://gerrit.ovirt.org/73145 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic5669aa5e8486805f60fc636085071b58e9db7fa Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <mpolednik(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in vdsm[master]: hostdev: rmAppropriateIommuGroup in hostdev_reattach
by Code Review 28 Feb '17

28 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has submitted this change and it was merged. Change subject: hostdev: rmAppropriateIommuGroup in hostdev_reattach ...................................................................... hostdev: rmAppropriateIommuGroup in hostdev_reattach We try to always free the device -- even when it's not reattached. We should not hold ownership of *any* device that just happens to be bound to vfio-pci. Change-Id: Ifb2441ecab0b6a0b6f6703d92a49b5a2b8b5326a Signed-off-by: Martin Polednik <mpolednik(a)redhat.com> --- M lib/vdsm/hostdev.py 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Francesco Romani: Looks good to me, approved Martin Polednik: Verified -- To view, visit https://gerrit.ovirt.org/73144 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifb2441ecab0b6a0b6f6703d92a49b5a2b8b5326a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <mpolednik(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in vdsm[master]: hostdev: allow hostdev_reattach to actually reattach devices
by Code Review 28 Feb '17

28 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has submitted this change and it was merged. Change subject: hostdev: allow hostdev_reattach to actually reattach devices ...................................................................... hostdev: allow hostdev_reattach to actually reattach devices We've high-level implementation into low level function. Let's parametrize the function to allow the same functionality while default is what it should've been in the first place. Change-Id: Ifbaf74d1e407fe9b1c77cfe0cd21539d9b3db5b2 Signed-off-by: Martin Polednik <mpolednik(a)redhat.com> --- M lib/vdsm/hostdev.py 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests Francesco Romani: Looks good to me, approved Martin Polednik: Verified Edward Haas: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/73143 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifbaf74d1e407fe9b1c77cfe0cd21539d9b3db5b2 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <mpolednik(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in vdsm[master]: gluster: correct exception name in gluster/cli.py
by Code Review 28 Feb '17

28 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has posted comments on this change. Change subject: gluster: correct exception name in gluster/cli.py ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/73170 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iddc63f1fd100d33c7db541c8d2150f9e366e2491 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-HasComments: No

1 0

Change in vdsm[master]: gluster: fix pylint issues in gluster/tasks.py.
by Code Review 28 Feb '17

28 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has submitted this change and it was merged. Change subject: gluster: fix pylint issues in gluster/tasks.py. ...................................................................... gluster: fix pylint issues in gluster/tasks.py. volumeReplaceBrickStatus API is removed from gluster/cli.py. So removing its references from gluster/tasks.py Change-Id: I15b981ee759c6c516d4d32ff38d151d8a329f764 Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com> --- M lib/vdsm/gluster/tasks.py 1 file changed, 0 insertions(+), 4 deletions(-) Approvals: Jenkins CI: Passed CI tests Irit Goihman: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved Ramesh N: Verified -- To view, visit https://gerrit.ovirt.org/73169 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I15b981ee759c6c516d4d32ff38d151d8a329f764 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in vdsm[master]: gluster: fix pylint issues in gluster/tasks.py.
by Code Review 28 Feb '17

28 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has posted comments on this change. Change subject: gluster: fix pylint issues in gluster/tasks.py. ...................................................................... Patch Set 1: Code-Review+2 This should have been dropped in commit bce18a1c76f937443a90e6eb22c33d69b2abed2c -- To view, visit https://gerrit.ovirt.org/73169 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I15b981ee759c6c516d4d32ff38d151d8a329f764 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-HasComments: No

1 0

Change in vdsm[master]: vm: fix vcpu limit detection on create
by Code Review 28 Feb '17

28 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has submitted this change and it was merged. Change subject: vm: fix vcpu limit detection on create ...................................................................... vm: fix vcpu limit detection on create The code was not update and still called the old name of the XML helper, leading to a creation failure. We just use the new name. Proper test, to ensure it will not happen again, in a followup patch. Change-Id: I181544354cfd4a84c76a5f4ceea2f0d189358279 Bug-Url: https://bugzilla.redhat.com/1426727 Backport-To: 4.1 Signed-off-by: Francesco Romani <fromani(a)redhat.com> --- M vdsm/virt/vm.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Martin Sivák: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved Francesco Romani: Verified Michal Skrivanek: Verified; Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/73195 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I181544354cfd4a84c76a5f4ceea2f0d189358279 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in vdsm[master]: vm: tests: add test for initial vcpu limit setup
by Code Review 28 Feb '17

28 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has submitted this change and it was merged. Change subject: vm: tests: add test for initial vcpu limit setup ...................................................................... vm: tests: add test for initial vcpu limit setup We update the vm vcpu limit both on startup - if SLA QOS policy is given and after policy updates received from clients (e.g. Engine). We had tests for the latter, not for the former cases. This patch adds the missing test. For the sake of the practicality, we take one shortcut and we test a private Vm method. This is bad, but not having tests it is even worse, as the related BZ demonstrates. Change-Id: I7ae776e4f2abee2d4716ec260d00954fdd0b4eac Related-To: https://bugzilla.redhat.com/1426727 Backport-To: 4.1 Signed-off-by: Francesco Romani <fromani(a)redhat.com> --- M tests/vm_test.py 1 file changed, 20 insertions(+), 0 deletions(-) Approvals: Martin Sivák: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved Francesco Romani: Verified -- To view, visit https://gerrit.ovirt.org/73198 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7ae776e4f2abee2d4716ec260d00954fdd0b4eac Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in vdsm[master]: vm: tests: add test for initial vcpu limit setup
by Code Review 28 Feb '17

28 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has posted comments on this change. Change subject: vm: tests: add test for initial vcpu limit setup ...................................................................... Patch Set 1: Code-Review+2 raising score -- To view, visit https://gerrit.ovirt.org/73198 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7ae776e4f2abee2d4716ec260d00954fdd0b4eac Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-HasComments: No

1 0

Change in vdsm[master]: vm: fix vcpu limit detection on create
by Code Review 28 Feb '17

28 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has posted comments on this change. Change subject: vm: fix vcpu limit detection on create ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/73195 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I181544354cfd4a84c76a5f4ceea2f0d189358279 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-HasComments: No

1 0

← Newer
1
2
3
4
5
6
7
...
30
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

vdsm-patches February 2017