From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: restore-net now remove nets/bonds that are not safe persisted
......................................................................
net: restore-net now remove nets/bonds that are not safe persisted
On network restoration, there may be exist nets and/or bonds on the host
but not in the safe persisted config. For such cases, these extra
nets/bonds sould be removed, syncing with the safe persisted config.
Change-Id: I24a940f688a6bbf41ac610f20781b03b698accbf
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
---
M vdsm/vdsm-restore-net-config
1 file changed, 25 insertions(+), 11 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Petr Horáček: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, approved
Edward Haas: Verified
--
To view, visit https://gerrit.ovirt.org/72312
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I24a940f688a6bbf41ac610f20781b03b698accbf
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: Expose an existing bug in network restoration
......................................................................
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/72313/2/lib/vdsm/network/libvirt.py
File lib/vdsm/network/libvirt.py:
Line 133: def is_libvirt_network(netname):
Line 134: conn = libvirtconnection.get()
Line 135: libvirt_nets = conn.listAllNetworks()
Line 136: netname = LIBVIRT_NET_PREFIX + netname
Line 137: return bool(next((n for n in libvirt_nets if n.name() == netname), None))
Isn't it a bit too complex? why not
conn.networkLookupByName()
or
any(n.name() == netname for n in libvirt_nets)
Line 138:
Line 139:
Line 140: def is_libvirt_device(device):
Line 141: try:
--
To view, visit https://gerrit.ovirt.org/72313
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifad0c04df9a36fba43ee678bbec4f3500b6a98ec
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: restore-net now remove nets/bonds that are not safe persisted
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/72312
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I24a940f688a6bbf41ac610f20781b03b698accbf
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: mailbox: Improve log when checksum fails
......................................................................
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/73074/3/lib/vdsm/storage/mailbox.py
File lib/vdsm/storage/mailbox.py:
PS3, Line 621: assert len(mailbox) == MAILBOX_SIZE
this addition is more than just log improvement. could you explain it in the commit message?
--
To view, visit https://gerrit.ovirt.org/73074
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2c07435c8fe222d75b212956ef3e45c2b3510c71
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: storage: move dispatcher to lib/vdsm/storage
......................................................................
storage: move dispatcher to lib/vdsm/storage
Change-Id: Icd831393acc04a3e9658aefd93c2d026692f2628
Signed-off-by: Irit Goihman <igoihman(a)redhat.com>
---
M lib/vdsm/storage/Makefile.am
R lib/vdsm/storage/dispatcher.py
M vdsm.spec.in
M vdsm/clientIF.py
M vdsm/storage/Makefile.am
M vdsm/storage/hsm.py
M vdsm/vdsmd.py
7 files changed, 8 insertions(+), 7 deletions(-)
Approvals:
Nir Soffer: Looks good to me, approved
Jenkins CI: Passed CI tests
Irit Goihman: Verified
--
To view, visit https://gerrit.ovirt.org/69734
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icd831393acc04a3e9658aefd93c2d026692f2628
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: ngn: grab OS version according with /etc/os-release
......................................................................
ngn: grab OS version according with /etc/os-release
Currently, OS version can be extracted from
RPM naming like: redhat-release-server-7.3-6.el7.rpm, in this case:
version: 7.3, release 6.el7
However, for NGN systems, redhat-release-server rpm is not available,
only ovirt-release-host-node and redhat-release-virtualization-host.
Based on that, this patch extract version from /etc/os-release (VERSION_ID).
Change-Id: I1f35d8f2221c07a38e9d75b96324315266b0d51a
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1368364
Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com>
---
M lib/vdsm/osinfo.py
1 file changed, 48 insertions(+), 8 deletions(-)
Approvals:
Piotr Kliczewski: Looks good to me, approved
Douglas Schilling Landgraf: Verified
Martin Peřina: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/72829
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1f35d8f2221c07a38e9d75b96324315266b0d51a
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com>
Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Ryan Barry <rbarry(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yuval Turgeman <yturgema(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: ngn: grab OS version according with /etc/os-release
......................................................................
Patch Set 5: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/72829
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1f35d8f2221c07a38e9d75b96324315266b0d51a
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com>
Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Ryan Barry <rbarry(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yuval Turgeman <yturgema(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net tests: skip test_setupNetworks_on_external_vlaned_bond with ifcfg persistence
......................................................................
net tests: skip test_setupNetworks_on_external_vlaned_bond with ifcfg persistence
vdsm-stone-net-config deletes netconfback content and so restoration
of the externally created bond as it is only stored in netconfback
at ifcfg persistence.
Change-Id: I05f4dfa3954f0749301aab96ae933fff4595c4b7
Signed-off-by: Leon Goldberg <lgoldber(a)redhat.com>
---
M tests/functional/networkTests.py
1 file changed, 3 insertions(+), 0 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
Leon Goldberg: Verified
Edward Haas: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/72976
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I05f4dfa3954f0749301aab96ae933fff4595c4b7
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>