vdsm-patches February 2017

vdsm-patches@lists.fedorahosted.org

1 participants
297 discussions

Change in vdsm[master]: net: restore-net now remove nets/bonds that are not safe per...
by Code Review 25 Feb '17

25 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has submitted this change and it was merged. Change subject: net: restore-net now remove nets/bonds that are not safe persisted ...................................................................... net: restore-net now remove nets/bonds that are not safe persisted On network restoration, there may be exist nets and/or bonds on the host but not in the safe persisted config. For such cases, these extra nets/bonds sould be removed, syncing with the safe persisted config. Change-Id: I24a940f688a6bbf41ac610f20781b03b698accbf Signed-off-by: Edward Haas <edwardh(a)redhat.com> --- M vdsm/vdsm-restore-net-config 1 file changed, 25 insertions(+), 11 deletions(-) Approvals: Jenkins CI: Passed CI tests Petr Horáček: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved Edward Haas: Verified -- To view, visit https://gerrit.ovirt.org/72312 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I24a940f688a6bbf41ac610f20781b03b698accbf Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas <edwardh(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in vdsm[master]: net: Expose an existing bug in network restoration
by Code Review 25 Feb '17

25 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has posted comments on this change. Change subject: net: Expose an existing bug in network restoration ...................................................................... Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/72313/2/lib/vdsm/network/libvirt.py File lib/vdsm/network/libvirt.py: Line 133: def is_libvirt_network(netname): Line 134: conn = libvirtconnection.get() Line 135: libvirt_nets = conn.listAllNetworks() Line 136: netname = LIBVIRT_NET_PREFIX + netname Line 137: return bool(next((n for n in libvirt_nets if n.name() == netname), None)) Isn't it a bit too complex? why not conn.networkLookupByName() or any(n.name() == netname for n in libvirt_nets) Line 138: Line 139: Line 140: def is_libvirt_device(device): Line 141: try: -- To view, visit https://gerrit.ovirt.org/72313 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifad0c04df9a36fba43ee678bbec4f3500b6a98ec Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas <edwardh(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-HasComments: Yes

1 0

Change in vdsm[master]: net: restore-net now remove nets/bonds that are not safe per...
by Code Review 25 Feb '17

25 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has posted comments on this change. Change subject: net: restore-net now remove nets/bonds that are not safe persisted ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/72312 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I24a940f688a6bbf41ac610f20781b03b698accbf Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas <edwardh(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-HasComments: No

1 0

Change in vdsm[master]: mailbox: Improve log when checksum fails
by Code Review 25 Feb '17

25 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has posted comments on this change. Change subject: mailbox: Improve log when checksum fails ...................................................................... Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/73074/3/lib/vdsm/storage/mailbox.py File lib/vdsm/storage/mailbox.py: PS3, Line 621: assert len(mailbox) == MAILBOX_SIZE this addition is more than just log improvement. could you explain it in the commit message? -- To view, visit https://gerrit.ovirt.org/73074 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2c07435c8fe222d75b212956ef3e45c2b3510c71 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-HasComments: Yes

1 0

Change in vdsm[master]: mailbox: Add tests for mailbox validation
by Code Review 25 Feb '17

25 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has posted comments on this change. Change subject: mailbox: Add tests for mailbox validation ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/73077 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4ec15704cc913777b5bf9dd8bd983cdec6336673 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-HasComments: No

1 0

Change in vdsm[master]: storage: move dispatcher to lib/vdsm/storage
by Code Review 25 Feb '17

25 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has submitted this change and it was merged. Change subject: storage: move dispatcher to lib/vdsm/storage ...................................................................... storage: move dispatcher to lib/vdsm/storage Change-Id: Icd831393acc04a3e9658aefd93c2d026692f2628 Signed-off-by: Irit Goihman <igoihman(a)redhat.com> --- M lib/vdsm/storage/Makefile.am R lib/vdsm/storage/dispatcher.py M vdsm.spec.in M vdsm/clientIF.py M vdsm/storage/Makefile.am M vdsm/storage/hsm.py M vdsm/vdsmd.py 7 files changed, 8 insertions(+), 7 deletions(-) Approvals: Nir Soffer: Looks good to me, approved Jenkins CI: Passed CI tests Irit Goihman: Verified -- To view, visit https://gerrit.ovirt.org/69734 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icd831393acc04a3e9658aefd93c2d026692f2628 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in vdsm[master]: ngn: grab OS version according with /etc/os-release
by Code Review 24 Feb '17

24 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has submitted this change and it was merged. Change subject: ngn: grab OS version according with /etc/os-release ...................................................................... ngn: grab OS version according with /etc/os-release Currently, OS version can be extracted from RPM naming like: redhat-release-server-7.3-6.el7.rpm, in this case: version: 7.3, release 6.el7 However, for NGN systems, redhat-release-server rpm is not available, only ovirt-release-host-node and redhat-release-virtualization-host. Based on that, this patch extract version from /etc/os-release (VERSION_ID). Change-Id: I1f35d8f2221c07a38e9d75b96324315266b0d51a Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1368364 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M lib/vdsm/osinfo.py 1 file changed, 48 insertions(+), 8 deletions(-) Approvals: Piotr Kliczewski: Looks good to me, approved Douglas Schilling Landgraf: Verified Martin Peřina: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/72829 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1f35d8f2221c07a38e9d75b96324315266b0d51a Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Ryan Barry <rbarry(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yuval Turgeman <yturgema(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in vdsm[master]: storage: move storage_mailbox to lib
by Code Review 24 Feb '17

24 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has uploaded a new change for review. Change subject: storage: move storage_mailbox to lib ...................................................................... storage: move storage_mailbox to lib Change-Id: I6bf83510617e51d72ce6dcbda63bfe35acff8fa5 Signed-off-by: Dan Kenigsberg <danken(a)redhat.com> --- M lib/vdsm/storage/Makefile.am R lib/vdsm/storage/storage_mailbox.py M tests/storage_mailbox_test.py M vdsm.spec.in M vdsm/storage/Makefile.am M vdsm/storage/blockSD.py M vdsm/storage/sp.py 7 files changed, 6 insertions(+), 5 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/30/69330/1 diff --git a/lib/vdsm/storage/Makefile.am b/lib/vdsm/storage/Makefile.am index 4cf1b33..fc76d21 100644 --- a/lib/vdsm/storage/Makefile.am +++ b/lib/vdsm/storage/Makefile.am @@ -49,6 +49,7 @@ resourceManager.py \ rwlock.py \ securable.py \ + storage_mailbox.py \ task.py \ taskManager.py \ threadPool.py \ diff --git a/vdsm/storage/storage_mailbox.py b/lib/vdsm/storage/storage_mailbox.py similarity index 99% rename from vdsm/storage/storage_mailbox.py rename to lib/vdsm/storage/storage_mailbox.py index 6a227bf..1cfd61a 100644 --- a/vdsm/storage/storage_mailbox.py +++ b/lib/vdsm/storage/storage_mailbox.py @@ -18,6 +18,7 @@ # Refer to the README and COPYING files for full details of the license # +from __future__ import absolute_import import os import errno import time diff --git a/tests/storage_mailbox_test.py b/tests/storage_mailbox_test.py index 08aa60d..4d9ed82 100644 --- a/tests/storage_mailbox_test.py +++ b/tests/storage_mailbox_test.py @@ -29,10 +29,10 @@ from testlib import VdsmTestCase as TestCaseBase from monkeypatch import MonkeyPatchScope +import vdsm.storage.storage_mailbox as sm from vdsm.utils import retry from storage.sd import DOMAIN_META_DATA -import storage.storage_mailbox as sm MAX_HOSTS = 10 MAILER_TIMEOUT = 6 diff --git a/vdsm.spec.in b/vdsm.spec.in index dfa33f3..975c4b4 100644 --- a/vdsm.spec.in +++ b/vdsm.spec.in @@ -950,7 +950,6 @@ %{_datadir}/%{vdsm_name}/storage/sd.py* %{_datadir}/%{vdsm_name}/storage/sp.py* %{_datadir}/%{vdsm_name}/storage/spbackends.py* -%{_datadir}/%{vdsm_name}/storage/storage_mailbox.py* %{_datadir}/%{vdsm_name}/storage/storageServer.py* %{_datadir}/%{vdsm_name}/storage/volume.py* %{_datadir}/%{vdsm_name}/storage/imageRepository/__init__.py* @@ -1209,6 +1208,7 @@ %{python_sitelib}/%{vdsm_name}/storage/resourceManager.py* %{python_sitelib}/%{vdsm_name}/storage/rwlock.py* %{python_sitelib}/%{vdsm_name}/storage/securable.py* +%{python_sitelib}/%{vdsm_name}/storage/storage_mailbox.py* %{python_sitelib}/%{vdsm_name}/storage/task.py* %{python_sitelib}/%{vdsm_name}/storage/taskManager.py* %{python_sitelib}/%{vdsm_name}/storage/threadPool.py* diff --git a/vdsm/storage/Makefile.am b/vdsm/storage/Makefile.am index edcd55f..777ff0a 100644 --- a/vdsm/storage/Makefile.am +++ b/vdsm/storage/Makefile.am @@ -43,7 +43,6 @@ sd.py \ sp.py \ spbackends.py \ - storage_mailbox.py \ storageServer.py \ volume.py diff --git a/vdsm/storage/blockSD.py b/vdsm/storage/blockSD.py index 4f64be8..d636f15 100644 --- a/vdsm/storage/blockSD.py +++ b/vdsm/storage/blockSD.py @@ -53,6 +53,7 @@ from vdsm.storage import multipath from vdsm.storage import resourceManager as rm from vdsm.storage.persistent import PersistentDict, DictValidator +from vdsm.storage.storage_mailbox import MAILBOX_SIZE from vdsm.storage.threadlocal import vars import vdsm.supervdsm as svdsm @@ -60,7 +61,6 @@ from sdm import volume_artifacts import blockVolume import resourceFactories -from storage_mailbox import MAILBOX_SIZE STORAGE_DOMAIN_TAG = "RHAT_storage_domain" STORAGE_UNREADY_DOMAIN_TAG = STORAGE_DOMAIN_TAG + "_UNREADY" diff --git a/vdsm/storage/sp.py b/vdsm/storage/sp.py index 3972cb7..773c7f1 100644 --- a/vdsm/storage/sp.py +++ b/vdsm/storage/sp.py @@ -40,10 +40,10 @@ from vdsm.storage import misc from vdsm.storage import mount from vdsm.storage import resourceManager as rm +from vdsm.storage import storage_mailbox from vdsm.storage import xlease from vdsm.storage.securable import secured, unsecured -import storage_mailbox import blockSD import fileSD import sd -- To view, visit https://gerrit.ovirt.org/69330 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I6bf83510617e51d72ce6dcbda63bfe35acff8fa5 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>

1 10

Change in vdsm[master]: ngn: grab OS version according with /etc/os-release
by Code Review 24 Feb '17

24 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has posted comments on this change. Change subject: ngn: grab OS version according with /etc/os-release ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/72829 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1f35d8f2221c07a38e9d75b96324315266b0d51a Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ryan Barry <rbarry(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yuval Turgeman <yturgema(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-HasComments: No

1 0

Change in vdsm[master]: net tests: skip test_setupNetworks_on_external_vlaned_bond w...
by Code Review 23 Feb '17

23 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has submitted this change and it was merged. Change subject: net tests: skip test_setupNetworks_on_external_vlaned_bond with ifcfg persistence ...................................................................... net tests: skip test_setupNetworks_on_external_vlaned_bond with ifcfg persistence vdsm-stone-net-config deletes netconfback content and so restoration of the externally created bond as it is only stored in netconfback at ifcfg persistence. Change-Id: I05f4dfa3954f0749301aab96ae933fff4595c4b7 Signed-off-by: Leon Goldberg <lgoldber(a)redhat.com> --- M tests/functional/networkTests.py 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved Leon Goldberg: Verified Edward Haas: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/72976 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I05f4dfa3954f0749301aab96ae933fff4595c4b7 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

← Newer
1
...
5
6
7
8
9
10
11
...
30
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

vdsm-patches February 2017