February 2017 - vdsm-patches - Fedora mailing-lists

Change in vdsm[master]: xmlrpc: Fail xmlrpc requests
by Code Review 09 Feb '17

09 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has posted comments on this change. Change subject: xmlrpc: Fail xmlrpc requests ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/71811 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6b6d6cef7ba16dd92281c61c2f9fa9035b9043b3 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-HasComments: No

1 0

Change in vdsm[master]: xmlrpc: Fail xmlrpc requests
by Code Review 08 Feb '17

08 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has posted comments on this change. Change subject: xmlrpc: Fail xmlrpc requests ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/71811 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6b6d6cef7ba16dd92281c61c2f9fa9035b9043b3 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-HasComments: No

1 0

Change in vdsm[ovirt-4.1]: net build: Correctly include nmnettestlib in the build
by Code Review 08 Feb '17

08 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has posted comments on this change. Change subject: net build: Correctly include nmnettestlib in the build ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/69132 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I49bd94a12440d8e3364b1bb5920d2e59ae95a8d0 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.1 Gerrit-Owner: Edward Haas <edwardh(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com> Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com> Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com> Gerrit-HasComments: No

1 0

Change in vdsm[master]: Freeze version of python2-crypto in check-merged
by Code Review 07 Feb '17

07 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has submitted this change and it was merged. Change subject: Freeze version of python2-crypto in check-merged ...................................................................... Freeze version of python2-crypto in check-merged Newer version of python2-crypto break python2-paramiko which is required by Lago. This patch adds an EPEL snapshot that contains an older version of python2-crypto and tries to enforce installing the older version to make Lago work. This patch also removes the link to EPEL in the *.repos file because EPEL is provided natively by Standard-CI Change-Id: I5fb6fbc84297254c87bfc5aa2a67799ce2d0f0f0 Signed-off-by: Barak Korren <bkorren(a)redhat.com> --- M automation/check-merged.packages.el7 M automation/check-patch.repos.el7 2 files changed, 2 insertions(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Irit Goihman: Verified; Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/71756 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5fb6fbc84297254c87bfc5aa2a67799ce2d0f0f0 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in vdsm[master]: Freeze version of python2-crypto in check-merged
by Code Review 07 Feb '17

07 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has posted comments on this change. Change subject: Freeze version of python2-crypto in check-merged ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/71756 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5fb6fbc84297254c87bfc5aa2a67799ce2d0f0f0 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-HasComments: No

1 0

Change in vdsm[master]: check-merged: give a significant name to lago_ovirt_http_pid
by Code Review 07 Feb '17

07 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has uploaded a new change for review. Change subject: check-merged: give a significant name to lago_ovirt_http_pid ...................................................................... check-merged: give a significant name to lago_ovirt_http_pid Change-Id: I2533b1a0580baa516614fd058897489d039ea0ab Signed-off-by: Dan Kenigsberg <danken(a)redhat.com> --- M automation/check-merged.sh 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/98/71698/1 diff --git a/automation/check-merged.sh b/automation/check-merged.sh index 32ef4a5..fd2350e 100755 --- a/automation/check-merged.sh +++ b/automation/check-merged.sh @@ -95,7 +95,7 @@ lago ovirt deploy lago ovirt serve & - PID=$! + local lago_ovirt_http_pid=$! fake_ksm_in_vm @@ -106,7 +106,7 @@ res="${PIPESTATUS[0]}" [ "$res" -ne 0 ] && failed="$res" - kill $PID + kill "$lago_ovirt_http_pid" lago copy-from-vm \ "$VM_NAME" \ -- To view, visit https://gerrit.ovirt.org/71698 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I2533b1a0580baa516614fd058897489d039ea0ab Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>

1 4

Change in vdsm[master]: lib: do not use virt-prefixed logger for utilities
by Code Review 07 Feb '17

07 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has submitted this change and it was merged. Change subject: lib: do not use virt-prefixed logger for utilities ...................................................................... lib: do not use virt-prefixed logger for utilities The @api.method code was born in the virt vertical, but was later placed in the common area, hoping to be useful for other verticals and used across the codebase. However, it still incorrectly uses a virt-prefixed logger, and this is conflicting with its stated goal: this is no more virt-specific code. This patch replaces the 'virt' prefix with the 'vdsm' one. Change-Id: I091fb7336db58aa38af5b01c33d6d9239afff6d4 Signed-off-by: Francesco Romani <fromani(a)redhat.com> --- M lib/vdsm/common/api.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Dan Kenigsberg: Looks good to me, approved; Passed CI tests Francesco Romani: Verified Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/71637 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I091fb7336db58aa38af5b01c33d6d9239afff6d4 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in vdsm[master]: lib: do not use virt-prefixed logger for utilities
by Code Review 07 Feb '17

07 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has posted comments on this change. Change subject: lib: do not use virt-prefixed logger for utilities ...................................................................... Patch Set 2: Code-Review+2 Continuous-Integration+1 betting on the Fedora mirror failure being transitional -- To view, visit https://gerrit.ovirt.org/71637 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I091fb7336db58aa38af5b01c33d6d9239afff6d4 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-HasComments: No

1 0

Change in vdsm[master]: Freeze version of python2-crypto in check-merged
by Code Review 07 Feb '17

07 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has posted comments on this change. Change subject: Freeze version of python2-crypto in check-merged ...................................................................... Patch Set 1: Code-Review+1 if yum `cat *packages.el7` works, I'm fine. -- To view, visit https://gerrit.ovirt.org/71756 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5fb6fbc84297254c87bfc5aa2a67799ce2d0f0f0 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-HasComments: No

1 0

Change in vdsm[master]: Freeze version of python2-crypto in check-merged
by Code Review 07 Feb '17

07 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has posted comments on this change. Change subject: Freeze version of python2-crypto in check-merged ...................................................................... Patch Set 1: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/71756/1/automation/check-merged.packages.el7 File automation/check-merged.packages.el7: Line 1: --exclude=python2-crypto-2.6.1-13* we suggest developers to install `cat` of this file prior to developing vdsm. This patch breaks things for them. Can we please this ugly hack somewhere else? Line 2: autoconf Line 3: automake Line 4: git Line 5: lago -- To view, visit https://gerrit.ovirt.org/71756 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5fb6fbc84297254c87bfc5aa2a67799ce2d0f0f0 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-HasComments: Yes

1 0

Change in vdsm[master]: check-merged: define a var as local
by Code Review 07 Feb '17

07 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has uploaded a new change for review. Change subject: check-merged: define a var as local ...................................................................... check-merged: define a var as local bash's default is ugly. variables should be defined as local unless there's a good reason to expose them. Change-Id: Ib8eeac6714fc7d540b3793f0fae33d1d8776deb4 Signed-off-by: Dan Kenigsberg <danken(a)redhat.com> --- M automation/check-merged.sh 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/97/71697/1 diff --git a/automation/check-merged.sh b/automation/check-merged.sh index e06352b..32ef4a5 100755 --- a/automation/check-merged.sh +++ b/automation/check-merged.sh @@ -84,7 +84,7 @@ function run { mkdir "$EXPORTS"/lago-logs - failed=0 + local failed=0 lago start "$VM_NAME" -- To view, visit https://gerrit.ovirt.org/71697 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib8eeac6714fc7d540b3793f0fae33d1d8776deb4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>

1 3

Change in vdsm[master]: Upgrade test - add more old repos to upgrade from
by Code Review 07 Feb '17

07 Feb '17

From Yaniv Bronhaim <ybronhei(a)redhat.com>: Yaniv Bronhaim has uploaded a new change for review. Change subject: Upgrade test - add more old repos to upgrade from ...................................................................... Upgrade test - add more old repos to upgrade from This patch adds master snapshot repo to the test. Change-Id: I62124b45b8084c49c678e03287aa71f8eabb7f70 Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com> --- M tests/functional/upgrade_vdsm_test.py 1 file changed, 9 insertions(+), 5 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/88/67788/1 diff --git a/tests/functional/upgrade_vdsm_test.py b/tests/functional/upgrade_vdsm_test.py index 792acf7..6d7433c 100644 --- a/tests/functional/upgrade_vdsm_test.py +++ b/tests/functional/upgrade_vdsm_test.py @@ -21,8 +21,10 @@ from vdsm.tool.service import service_start, service_status, service_stop from testlib import VdsmTestCase +from testlib import permutations, expandPermutations -el7_ovirt36_repo = 'http://resources.ovirt.org/pub/ovirt-3.6/rpm/el7/' +_EL7_OVIRT36_REPO_URL = 'http://resources.ovirt.org/pub/ovirt-3.6/rpm/el7/' +_EL7_MASTER_REPO_URL = 'http://resources.ovirt.org/pub/ovirt-master-snapshot/rpm/el7/' def run_command(command): @@ -56,19 +58,21 @@ run_command(['yum', 'install', '-y', 'vdsm']) service_start('vdsmd') - def service_up_test(self): + @permutations((_EL7_MASTER_REPO_URL, _EL7_OVIRT36_REPO_URL)) + def service_up_test(self, old_repo): service_start('vdsmd') vdsm_version = run_command(['rpm', '-q', 'vdsm']) - downgrade_vdsm(el7_ovirt36_repo) + downgrade_vdsm(old_repo) upgrade_vdsm() self.assertEqual(run_command(['rpm', '-q', 'vdsm']), vdsm_version) self.assertEqual(service_status('vdsmd'), 0) - def service_down_test(self): + @permutations((_EL7_MASTER_REPO_URL, _EL7_OVIRT36_REPO_URL)) + def service_down_test(self, old_repo): service_stop('vdsmd') vdsm_version = run_command(['rpm', '-q', 'vdsm']) - downgrade_vdsm(el7_ovirt36_repo) + downgrade_vdsm(old_repo) upgrade_vdsm() self.assertEqual(run_command(['rpm', '-q', 'vdsm']), vdsm_version) -- To view, visit https://gerrit.ovirt.org/67788 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I62124b45b8084c49c678e03287aa71f8eabb7f70 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>

1 1

Change in vdsm[master]: api: move vdsmapi to lib
by Code Review 06 Feb '17

06 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has posted comments on this change. Change subject: api: move vdsmapi to lib ...................................................................... Patch Set 6: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/67835 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I95a7caf4fa354c7bea7e8f15533d5748182ed5fc Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-HasComments: No

1 0

Change in vdsm[master]: lvm-conf: Handle lvmetad failed state
by Code Review 06 Feb '17

06 Feb '17

From Yaniv Bronhaim <ybronhei(a)redhat.com>: Yaniv Bronhaim has posted comments on this change. Change subject: lvm-conf: Handle lvmetad failed state ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/71677 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I83d4ffcca510f77ec229f2b077ec822b00d68de2 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-HasComments: No

1 0

Change in vdsm[master]: api: move vdsmapi to lib
by Code Review 06 Feb '17

06 Feb '17

From Yaniv Bronhaim <ybronhei(a)redhat.com>: Yaniv Bronhaim has posted comments on this change. Change subject: api: move vdsmapi to lib ...................................................................... Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/67835 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I95a7caf4fa354c7bea7e8f15533d5748182ed5fc Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-HasComments: No

1 0

Change in vdsm[ovirt-4.1]: automation: repos files should point to ovirt-4.1
by Code Review 06 Feb '17

06 Feb '17

From Yaniv Bronhaim <ybronhei(a)redhat.com>: Yaniv Bronhaim has posted comments on this change. Change subject: automation: repos files should point to ovirt-4.1 ...................................................................... Patch Set 1: I see that we still have issues with f25 and master repo is broken as well... please ack verified if fc24 and el7 are fine. looks alright to me -- To view, visit https://gerrit.ovirt.org/71710 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8df18dfd505592050ce263925a5bd33ba431f61a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.1 Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-HasComments: No

1 0

Change in vdsm[ovirt-4.1]: automation: repos files should point to ovirt-4.1
by Code Review 06 Feb '17

06 Feb '17

From Yaniv Bronhaim <ybronhei(a)redhat.com>: Yaniv Bronhaim has posted comments on this change. Change subject: automation: repos files should point to ovirt-4.1 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/71710 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8df18dfd505592050ce263925a5bd33ba431f61a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.1 Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-HasComments: No

1 0

Change in vdsm[ovirt-4.0]: hooks: Add localdisk hook
by Code Review 06 Feb '17

06 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has posted comments on this change. Change subject: hooks: Add localdisk hook ...................................................................... Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/71712/1/vdsm_hooks/localdisk/README File vdsm_hooks/localdisk/README: Line 50: The VM must be pinned to host. Any migration will cause the VM to try to Line 51: start with local disks that are not available on the new host. Line 52: Line 53: The operator need to configure the engine UserDefinedVMProperties to support Line 54: 'localdisk' with value 'lvm' better be more specific: engine-config -s UserDefinedVMProperties='localdisk=^(lvm)?$' Line 55: Line 56: TODO: -- To view, visit https://gerrit.ovirt.org/71712 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5b6ad8e8ebb4cd71bff02157f28cd2be5c31ac35 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Fred Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-HasComments: Yes

1 0

Change in vdsm[ovirt-4.1]: check-patch: retire snapshot repo in favor of 'tested'
by Code Review 06 Feb '17

06 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has posted comments on this change. Change subject: check-patch: retire snapshot repo in favor of 'tested' ...................................................................... Patch Set 1: Code-Review+2 Verified+1 ok, ok. this patch does not make things worse. -- To view, visit https://gerrit.ovirt.org/71686 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieec022ce45b268442140a35038b3accba9f8733f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.1 Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-HasComments: No

1 0

Change in vdsm[master]: vdsm-client: unbreak vdsm upgrade
by Code Review 06 Feb '17

06 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has submitted this change and it was merged. Change subject: vdsm-client: unbreak vdsm upgrade ...................................................................... vdsm-client: unbreak vdsm upgrade mark vdsm-cli as obsolete when upgrading vdsm. According to https://fedoraproject.org/wiki/Packaging:Guidelines in "Renaming/Replacing Existing Packages" section: In case a new package replaces an old one we should mark Provides: oldpackagename = $provEVR Obsoletes: oldpackagename < $obsEVR Change-Id: If94eaffecac5e2f1849f3a352dd9457530612840 Signed-off-by: Irit Goihman <igoihman(a)redhat.com> --- M vdsm.spec.in 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Nir Soffer: Looks good to me, but someone else must approve Jakub Niedermertl: Looks good to me, but someone else must approve Martin Peřina: Looks good to me, but someone else must approve Irit Goihman: Verified Dan Kenigsberg: Looks good to me, approved; Passed CI tests Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/71700 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If94eaffecac5e2f1849f3a352dd9457530612840 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in vdsm[master]: vdsm-client: unbreak vdsm upgrade
by Code Review 06 Feb '17

06 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has posted comments on this change. Change subject: vdsm-client: unbreak vdsm upgrade ...................................................................... Patch Set 2: Code-Review+2 Continuous-Integration+1 -- To view, visit https://gerrit.ovirt.org/71700 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If94eaffecac5e2f1849f3a352dd9457530612840 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-HasComments: No

1 0

Change in vdsm[master]: automation: replace snapshot repo with 'tested'
by Code Review 06 Feb '17

06 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has submitted this change and it was merged. Change subject: automation: replace snapshot repo with 'tested' ...................................................................... automation: replace snapshot repo with 'tested' tested repo provides more reliable dependencies, rather than the nightly snapshot. Change-Id: Ie3fe24f05b9e17286c1c1b2dc018c8b679ca5359 Signed-off-by: Irit Goihman <igoihman(a)redhat.com> --- M automation/check-patch.repos.el7 M automation/check-patch.repos.fc24 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Barak Korren: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Irit Goihman: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/71670 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie3fe24f05b9e17286c1c1b2dc018c8b679ca5359 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in vdsm[master]: automation: replace snapshot repo with 'tested'
by Code Review 06 Feb '17

06 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has posted comments on this change. Change subject: automation: replace snapshot repo with 'tested' ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/71670 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie3fe24f05b9e17286c1c1b2dc018c8b679ca5359 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-HasComments: No

1 0

Change in vdsm[master]: lvm-conf: Handle lvmetad failed state
by Code Review 06 Feb '17

06 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has posted comments on this change. Change subject: lvm-conf: Handle lvmetad failed state ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/71677 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I83d4ffcca510f77ec229f2b077ec822b00d68de2 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-HasComments: No

1 0

Change in vdsm[master]: vdsm-client: unbreak vdsm upgrade
by Code Review 06 Feb '17

06 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has posted comments on this change. Change subject: vdsm-client: unbreak vdsm upgrade ...................................................................... Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/71700/1//COMMIT_MSG Commit Message: Line 5: CommitDate: 2017-02-06 14:30:51 +0200 Line 6: Line 7: vdsm-client: unbreak vdsm upgrade Line 8: Line 9: mark vdsm-cli as obsolete when upgrading vdsm. could you explain the new version numbers? I never remember the Provides/Obsoletes semantics. Maybe you can add a link to the Fedora guidelines regarding them. Line 10: Line 11: Change-Id: If94eaffecac5e2f1849f3a352dd9457530612840 -- To view, visit https://gerrit.ovirt.org/71700 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If94eaffecac5e2f1849f3a352dd9457530612840 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-HasComments: Yes

1 0

Change in vdsm[master]: tests: Fix picklecopy random failures
by Code Review 06 Feb '17

06 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has posted comments on this change. Change subject: tests: Fix picklecopy random failures ...................................................................... Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/69738/2//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2017-01-05 20:31:06 +0200 Line 4: Commit: Nir Soffer <nsoffer(a)redhat.com> Line 5: CommitDate: 2017-01-05 20:42:18 +0200 Line 6: Line 7: tests: Fix picklecopy random failures The existing test was intentional. In Francesco's original patch, he stated that we must have picklecopy much much faster. Apparently it's not only faster. http://gerrit.ovirt.org/34989 We can change our mind. But it should be clear that this patch does not fix picklecopy, it simply relaxes the requirement from it. Hence I think title should change. Line 8: Line 9: We have a benchmark for picklecopy, failing randomly on travis, when Line 10: picklecopy was less than twice faster compared with deepcopy. I don't Line 11: think it is useful to fail the test randomly because of this reason, and -- To view, visit https://gerrit.ovirt.org/69738 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ice02137c9e6285401a9af29fd1b5ecd2a9c6a2cb Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-HasComments: Yes

1 0

Change in vdsm[ovirt-4.1]: check-patch: retire snapshot repo in favor of 'tested'
by Code Review 06 Feb '17

06 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has posted comments on this change. Change subject: check-patch: retire snapshot repo in favor of 'tested' ...................................................................... Patch Set 1: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/71686/1/automation/check-patch.repos.fc25 File automation/check-patch.repos.fc25: PS1, Line 1: master a 4.1 job should not pull stuff from master. it is true for the rest of the repos, as well - not only to your current change. -- To view, visit https://gerrit.ovirt.org/71686 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieec022ce45b268442140a35038b3accba9f8733f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.1 Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-HasComments: Yes

1 0

Change in vdsm[master]: spec: use native ssl implementation in Fedora
by Code Review 05 Feb '17

05 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has uploaded a new change for review. Change subject: spec: use native ssl implementation in Fedora ...................................................................... spec: use native ssl implementation in Fedora Vdsm no longer work with Fedora 25's m2crypto. Let us use the native implementaiton instead. Change-Id: Id4c0f461b93bbfbd2c9e350eaa6a7cd8d3760047 Signed-off-by: Dan Kenigsberg <danken(a)redhat.com> --- M vdsm.spec.in 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/48/71248/1 diff --git a/vdsm.spec.in b/vdsm.spec.in index dbf2267..dc37287 100644 --- a/vdsm.spec.in +++ b/vdsm.spec.in @@ -711,7 +711,9 @@ -e 's/^raw_version_revision =.*/raw_version_revision = "'"${rawversion}"'"/' \ -e 's/^software_revision =.*/software_revision = "'"${baserelease}"'"/' lib/vdsm/dsaversion.py +%if ! 0%{?fedora} >= 25 sed -i -e 's/@SSL_IMPLEMENTATION@/m2c/g' lib/vdsm/config.py +%endif sed -i -e 's\@VDSMRPCPYLIBDIR@\%{python_sitelib}/%{vdsm_name}/rpc\g' lib/vdsm/constants.py -- To view, visit https://gerrit.ovirt.org/71248 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id4c0f461b93bbfbd2c9e350eaa6a7cd8d3760047 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>

1 3

Change in vdsm[master]: after_disk_prepare: Allow hotplug and hotunplug
by Code Review 05 Feb '17

05 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has posted comments on this change. Change subject: after_disk_prepare: Allow hotplug and hotunplug ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/71646 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia60e4908c718667ca2f5f2b7dc71da24d26d6b3e Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-HasComments: No

1 0

Change in vdsm[master]: net: Drop bondings._active_slave function
by Code Review 05 Feb '17

05 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has submitted this change and it was merged. Change subject: net: Drop bondings._active_slave function ...................................................................... net: Drop bondings._active_slave function Change-Id: I1b123d192e803bb9993732472b7b7f3063f820b1 Signed-off-by: Edward Haas <edwardh(a)redhat.com> --- M lib/vdsm/network/netinfo/bonding.py 1 file changed, 1 insertion(+), 10 deletions(-) Approvals: Jenkins CI: Passed CI tests Petr Horáček: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved Edward Haas: Verified -- To view, visit https://gerrit.ovirt.org/71053 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1b123d192e803bb9993732472b7b7f3063f820b1 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas <edwardh(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in vdsm[master]: net: Modify bonding.permanent_address to use non filtered bonds
by Code Review 05 Feb '17

05 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has submitted this change and it was merged. Change subject: net: Modify bonding.permanent_address to use non filtered bonds ...................................................................... net: Modify bonding.permanent_address to use non filtered bonds Some minor modifications have been included in this patch on how /proc/net/bonding/* are parsed. Change-Id: I793e3a5dd58e064d09d9043c86d3808e21cdc656 Signed-off-by: Edward Haas <edwardh(a)redhat.com> --- M lib/vdsm/network/netinfo/bonding.py M tests/network/netinfo_test.py M tests/network/tc_test.py 3 files changed, 7 insertions(+), 3 deletions(-) Approvals: Jenkins CI: Passed CI tests Petr Horáček: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved Edward Haas: Verified -- To view, visit https://gerrit.ovirt.org/71056 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I793e3a5dd58e064d09d9043c86d3808e21cdc656 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas <edwardh(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in vdsm[master]: net: Centralize permhwaddr report handling
by Code Review 05 Feb '17

05 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has submitted this change and it was merged. Change subject: net: Centralize permhwaddr report handling ...................................................................... net: Centralize permhwaddr report handling Change-Id: Ifcde165f5b0b413f428c33d8cbc6dfce45787b82 Signed-off-by: Edward Haas <edwardh(a)redhat.com> --- M lib/vdsm/network/netinfo/cache.py M lib/vdsm/network/netinfo/nics.py 2 files changed, 15 insertions(+), 9 deletions(-) Approvals: Jenkins CI: Passed CI tests Petr Horáček: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved Edward Haas: Verified -- To view, visit https://gerrit.ovirt.org/71055 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifcde165f5b0b413f428c33d8cbc6dfce45787b82 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas <edwardh(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in vdsm[master]: net: Modify bonding.permanent_address to use non filtered bonds
by Code Review 05 Feb '17

05 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has posted comments on this change. Change subject: net: Modify bonding.permanent_address to use non filtered bonds ...................................................................... Patch Set 13: Code-Review+2 raising -- To view, visit https://gerrit.ovirt.org/71056 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I793e3a5dd58e064d09d9043c86d3808e21cdc656 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas <edwardh(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-HasComments: No

1 0

Change in vdsm[master]: net: Centralize permhwaddr report handling
by Code Review 05 Feb '17

05 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has posted comments on this change. Change subject: net: Centralize permhwaddr report handling ...................................................................... Patch Set 12: Code-Review+2 raising -- To view, visit https://gerrit.ovirt.org/71055 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifcde165f5b0b413f428c33d8cbc6dfce45787b82 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas <edwardh(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-HasComments: No

1 0

Change in vdsm[master]: check-patch: retire snapshot repo in favor of latest.tested
by Code Review 05 Feb '17

05 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has uploaded a new change for review. Change subject: check-patch: retire snapshot repo in favor of latest.tested ...................................................................... check-patch: retire snapshot repo in favor of latest.tested We should test if a patch builds agains a set of known-good dependcies ("latest.tested"), rather than a random nightly snapshot. Hopefully, with this patch, check-patch would pass, as ovirt-imageio for fc25 is to be found in the currently-referred repository. Change-Id: Ieec022ce45b268442140a35038b3accba9f8733f Signed-off-by: Dan Kenigsberg <danken(a)redhat.com> --- M automation/check-patch.repos.fc25 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/45/71645/1 diff --git a/automation/check-patch.repos.fc25 b/automation/check-patch.repos.fc25 index 27ae353..37f688c 100644 --- a/automation/check-patch.repos.fc25 +++ b/automation/check-patch.repos.fc25 @@ -1,4 +1,4 @@ -ovirt-snapshot,http://resources.ovirt.org/pub/ovirt-master-snapshot/rpm/$distro +latest.tested,http://resources.ovirt.org/repos/ovirt/experimental/master/latest.tested/rpm/$distro ovirt-snapshot-static,http://resources.ovirt.org/pub/ovirt-master-snapshot-… ovirt-ci-tools,http://resources.ovirt.org/repos/ci-tools/$distro lago,http://resources.ovirt.org/repos/lago/stable/0.0/rpm/$distro -- To view, visit https://gerrit.ovirt.org/71645 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ieec022ce45b268442140a35038b3accba9f8733f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>

1 5

Change in vdsm[master]: after_disk_prepare: Add new hook point
by Code Review 04 Feb '17

04 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has posted comments on this change. Change subject: after_disk_prepare: Add new hook point ...................................................................... Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/71641/2//COMMIT_MSG Commit Message: Line 26: } Line 27: Line 28: The VM uuid is available via the vmId environment variable. Line 29: Line 30: The hook is supported only when preparing images before starting a vm. > So the semantic you suggest are: ? why create anything on unplug? I never suggested that. I don't understand how a user could "modify the shared disk", and why the scenario you describe is any different in case of of cold plug/unplug. Line 31: Other flows preparing drives are not supported. Line 32: Line 33: Change-Id: Ib150682c4afd7f387eabf6873b10eb5eaa858417 -- To view, visit https://gerrit.ovirt.org/71641 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib150682c4afd7f387eabf6873b10eb5eaa858417 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-HasComments: Yes

1 0

Change in vdsm[master]: after_disk_prepare: Add new hook point
by Code Review 04 Feb '17

04 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has posted comments on this change. Change subject: after_disk_prepare: Add new hook point ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/71641 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib150682c4afd7f387eabf6873b10eb5eaa858417 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-HasComments: No

1 0

Change in vdsm[master]: after_disk_prepare: Add new hook point
by Code Review 04 Feb '17

04 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has posted comments on this change. Change subject: after_disk_prepare: Add new hook point ...................................................................... Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/71641/2//COMMIT_MSG Commit Message: Line 26: } Line 27: Line 28: The VM uuid is available via the vmId environment variable. Line 29: Line 30: The hook is supported only when preparing images before starting a vm. > What are the semantics of hotplug a local disk? Are we creating the disk in no removal on unplug, no auto-removal at all. I don't see a need to differentiate between cold plugging and hot plugging. But I can relate to your statement about the hook. Line 31: Other flows preparing drives are not supported. Line 32: Line 33: Change-Id: Ib150682c4afd7f387eabf6873b10eb5eaa858417 -- To view, visit https://gerrit.ovirt.org/71641 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib150682c4afd7f387eabf6873b10eb5eaa858417 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-HasComments: Yes

1 0

Change in vdsm[master]: after_disk_prepare: Add new hook point
by Code Review 04 Feb '17

04 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has posted comments on this change. Change subject: after_disk_prepare: Add new hook point ...................................................................... Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/71641/2//COMMIT_MSG Commit Message: Line 26: } Line 27: Line 28: The VM uuid is available via the vmId environment variable. Line 29: Line 30: The hook is supported only when preparing images before starting a vm. > I'm not supporting this, it does not make sense to support hotplug when we Let me rephrase my self: I see no problem in placing the hookpoint before hotplug as well. What is the problem is supporting hotunplug of a "localdisk"? Line 31: Other flows preparing drives are not supported. Line 32: Line 33: Change-Id: Ib150682c4afd7f387eabf6873b10eb5eaa858417 -- To view, visit https://gerrit.ovirt.org/71641 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib150682c4afd7f387eabf6873b10eb5eaa858417 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-HasComments: Yes

1 0

Change in vdsm[master]: vm: Add or remove a lease when a VM is running
by Code Review 04 Feb '17

04 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has submitted this change and it was merged. Change subject: vm: Add or remove a lease when a VM is running ...................................................................... vm: Add or remove a lease when a VM is running Add the capability to plug or unplug a lease while a VM is running. This will be used to move the lease to another domain if the current domain need to be put in maintenance. I stole the vm property from https://gerrit.ovirt.org/61475 since it is too late to backport it to 4.1, and I fell too dirty to copy and paste the vm fetching code in the new verbs. Change-Id: Id791c848ab5813b19da0ae45172af89497ba580b Bug-Url: https://bugzilla.redhat.com/1408825 Signed-off-by: Nir Soffer <nsoffer(a)redhat.com> --- M lib/api/vdsm-api.yml M lib/vdsm/common/exception.py M lib/vdsm/rpc/Bridge.py M vdsm/API.py M vdsm/virt/vm.py 5 files changed, 123 insertions(+), 0 deletions(-) Approvals: Nir Soffer: Verified; Passed CI tests Dan Kenigsberg: Looks good to me, approved Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/69335 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id791c848ab5813b19da0ae45172af89497ba580b Gerrit-PatchSet: 22 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com> Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in vdsm[master]: vm: Add or remove a lease when a VM is running
by Code Review 04 Feb '17

04 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has posted comments on this change. Change subject: vm: Add or remove a lease when a VM is running ...................................................................... Patch Set 22: Code-Review+2 copying score -- To view, visit https://gerrit.ovirt.org/69335 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id791c848ab5813b19da0ae45172af89497ba580b Gerrit-PatchSet: 22 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com> Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-HasComments: No

1 0

Change in vdsm[master]: lease: Add lease.find_conf helper
by Code Review 04 Feb '17

04 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has submitted this change and it was merged. Change subject: lease: Add lease.find_conf helper ...................................................................... lease: Add lease.find_conf helper Add a helper to find lease conf dict in VM conf dict, similar to the helper from drives conf. This helper is needed when hot-unplugging lease device. Change-Id: I057fb1d7f9b8222ba07fe36dfb38cbc5f651989b Bug-Url: https://bugzilla.redhat.com/1408825 Signed-off-by: Nir Soffer <nsoffer(a)redhat.com> --- M lib/vdsm/virt/vmdevices/lease.py M tests/virttests/vmlease_test.py 2 files changed, 59 insertions(+), 0 deletions(-) Approvals: Nir Soffer: Verified; Passed CI tests Dan Kenigsberg: Looks good to me, approved Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/69743 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I057fb1d7f9b8222ba07fe36dfb38cbc5f651989b Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com> Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in vdsm[master]: lease: Add lease.find_conf helper
by Code Review 04 Feb '17

04 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has posted comments on this change. Change subject: lease: Add lease.find_conf helper ...................................................................... Patch Set 11: Code-Review+2 copying score -- To view, visit https://gerrit.ovirt.org/69743 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I057fb1d7f9b8222ba07fe36dfb38cbc5f651989b Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com> Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-HasComments: No

1 0

Change in vdsm[master]: lease: Implement lease.Device.is_attached_to
by Code Review 04 Feb '17

04 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has submitted this change and it was merged. Change subject: lease: Implement lease.Device.is_attached_to ...................................................................... lease: Implement lease.Device.is_attached_to When hot-unplugging a lease, we need to wait until the device is removed, so we must implement is_attached_to method. Implemented using the lease id and the domain id, which define the lease identity. Not clear if we should check also the lease path and offset, and how (impossible) mismatch should be handled. Change-Id: I733e33dd98b6e847b306186591fefd4a7ddbfbf2 Bug-Url: https://bugzilla.redhat.com/1408825 Signed-off-by: Nir Soffer <nsoffer(a)redhat.com> --- M lib/vdsm/virt/vmdevices/lease.py M tests/virttests/vmlease_test.py 2 files changed, 64 insertions(+), 0 deletions(-) Approvals: Nir Soffer: Verified Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/69353 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I733e33dd98b6e847b306186591fefd4a7ddbfbf2 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com> Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in vdsm[master]: lease: Implement lease.Device.is_attached_to
by Code Review 04 Feb '17

04 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has posted comments on this change. Change subject: lease: Implement lease.Device.is_attached_to ...................................................................... Patch Set 14: Code-Review+2 copying score -- To view, visit https://gerrit.ovirt.org/69353 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I733e33dd98b6e847b306186591fefd4a7ddbfbf2 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com> Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-HasComments: No

1 0

Change in vdsm[master]: lease: Add lease.find_device helper
by Code Review 04 Feb '17

04 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has submitted this change and it was merged. Change subject: lease: Add lease.find_device helper ...................................................................... lease: Add lease.find_device helper Add a helper to lookup a lease device, similar to the helper for looking up drives. This will be needed to located a lease device when hot unplugging a lease. Change-Id: I63c9d478330c5b91500b685313313c71a6202cc1 Bug-Url: https://bugzilla.redhat.com/1408825 Signed-off-by: Nir Soffer <nsoffer(a)redhat.com> --- M lib/vdsm/virt/vmdevices/lease.py M tests/virttests/vmlease_test.py 2 files changed, 70 insertions(+), 0 deletions(-) Approvals: Nir Soffer: Verified Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/69352 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I63c9d478330c5b91500b685313313c71a6202cc1 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com> Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in vdsm[master]: lease: Add lease.find_device helper
by Code Review 04 Feb '17

04 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has posted comments on this change. Change subject: lease: Add lease.find_device helper ...................................................................... Patch Set 13: Code-Review+2 copying score -- To view, visit https://gerrit.ovirt.org/69352 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I63c9d478330c5b91500b685313313c71a6202cc1 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com> Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-HasComments: No

1 0

Change in vdsm[master]: lease: Check for six.PY2 instead of six.PY3
by Code Review 04 Feb '17

04 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has submitted this change and it was merged. Change subject: lease: Check for six.PY2 instead of six.PY3 ...................................................................... lease: Check for six.PY2 instead of six.PY3 We used to check for six.PY3 for skipping the tests on python 3. This test may fail and run the tests on python 4, if python 4 will be released before we port the code to python 3. Change-Id: I339aec2f3ec86befbb40cf61e5028480cf5d65f1 Signed-off-by: Nir Soffer <nsoffer(a)redhat.com> --- M tests/virttests/vmlease_test.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Nir Soffer: Verified Jenkins CI: Passed CI tests Francesco Romani: Looks good to me, approved Martin Polednik: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/70611 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I339aec2f3ec86befbb40cf61e5028480cf5d65f1 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in vdsm[master]: vm: Log device __repr__ instead of name
by Code Review 04 Feb '17

04 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has submitted this change and it was merged. Change subject: vm: Log device __repr__ instead of name ...................................................................... vm: Log device __repr__ instead of name When waiting for device removal, we assume that the device has a name, but lease devices do not have a name. Replace name with the device __repr__ implementation, providing more useful info, and supporting any device. Implement __repr__ for Drive and Interface devices so we get useful log when waiting for removal of these devices. Other devices will have the default __repr__ ("<ClassName object at 0x123456789>"). Here are example __repr__ output: <Drive name=hda, type=file, path=/block_path at 0x7f1a62934bb0> <Interface name=, type=bridge, mac=macAddr at 0x7f1a6214a850> Change-Id: I666e13cf3c58c980e4291b7903220a7551e10f85 Bug-Url: https://bugzilla.redhat.com/1408825 Signed-off-by: Nir Soffer <nsoffer(a)redhat.com> --- M lib/vdsm/virt/vmdevices/network.py M lib/vdsm/virt/vmdevices/storage.py M vdsm/virt/vm.py 3 files changed, 15 insertions(+), 3 deletions(-) Approvals: Nir Soffer: Verified; Passed CI tests Dan Kenigsberg: Looks good to me, approved Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/69351 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I666e13cf3c58c980e4291b7903220a7551e10f85 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com> Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in vdsm[master]: vm: Log device __repr__ instead of name
by Code Review 04 Feb '17

04 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has posted comments on this change. Change subject: vm: Log device __repr__ instead of name ...................................................................... Patch Set 12: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/69351 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I666e13cf3c58c980e4291b7903220a7551e10f85 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com> Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-HasComments: No

1 0

Change in vdsm[master]: after_disk_prepare: Add new hook point
by Code Review 04 Feb '17

04 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has posted comments on this change. Change subject: after_disk_prepare: Add new hook point ...................................................................... Patch Set 2: (2 comments) https://gerrit.ovirt.org/#/c/71641/2//COMMIT_MSG Commit Message: Line 24: "volumeID": "143e2e28-b2bb-42d4-93c6-835368d3d0ae" Line 25: } Line 26: } Line 27: Line 28: The VM uuid is available via the vmId environment variable. also vm-level custom properties should be. Line 29: Line 30: The hook is supported only when preparing images before starting a vm. Line 31: Other flows preparing drives are not supported. Line 32: Line 26: } Line 27: Line 28: The VM uuid is available via the vmId environment variable. Line 29: Line 30: The hook is supported only when preparing images before starting a vm. preparation before hot-plug of a VM should be supported as well. Line 31: Other flows preparing drives are not supported. Line 32: Line 33: Change-Id: Ib150682c4afd7f387eabf6873b10eb5eaa858417 -- To view, visit https://gerrit.ovirt.org/71641 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib150682c4afd7f387eabf6873b10eb5eaa858417 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-HasComments: Yes

1 0

Change in vdsm[master]: tests: make vmfakelib independent from clientIF
by Code Review 04 Feb '17

04 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has posted comments on this change. Change subject: tests: make vmfakelib independent from clientIF ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/70609 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7ddf3ec41fbd0aa06077441b461877f5b20f19d7 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-HasComments: No

1 0

Change in vdsm[master]: vdsm-tool: Add lvm configurator
by Code Review 03 Feb '17

03 Feb '17

From Yaniv Bronhaim <ybronhei(a)redhat.com>: Yaniv Bronhaim has posted comments on this change. Change subject: vdsm-tool: Add lvm configurator ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/71231 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If0e34efbcb2d8c1fac1aec3dc9e68a65957c84c2 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-HasComments: No

1 0

Change in vdsm[master]: migration: add boolean to control retries
by Code Review 03 Feb '17

03 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has submitted this change and it was merged. Change subject: migration: add boolean to control retries ...................................................................... migration: add boolean to control retries We added logic to automatically retry migrations if the destination Vdsm is over capacity. The current logic uses the progress to learn if a retry must be attempted. For this purposes, it is just safer and clearer to add one new boolean value, to be set once migration actually started. This flag is never accessed concurrently, so we don't need a full-blown threading.Event object. We should never retry failed migrations without Engine's instructions, and with the old, progress-based code, that could mistakenly happen. With the new event-based code, we make sure this is not possible anymore. Change-Id: Ie45553bf3ec3db76e520d11a68c67b5b9664dc32 Related-To: https://bugzilla.redhat.com/1414626 Backport-To: 4.1 Backport-To: 4.0 Signed-off-by: Francesco Romani <fromani(a)redhat.com> --- M lib/vdsm/virt/migration.py 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Dan Kenigsberg: Looks good to me, approved Francesco Romani: Verified; Passed CI tests Martin Polednik: Looks good to me, but someone else must approve Milan Zamazal: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/71160 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie45553bf3ec3db76e520d11a68c67b5b9664dc32 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com> Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in vdsm[master]: migration: make progress reporting reliable
by Code Review 03 Feb '17

03 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has submitted this change and it was merged. Change subject: migration: make progress reporting reliable ...................................................................... migration: make progress reporting reliable The rhbz#1414626 demonstrates some issues in our current progress handling. Since we use the progress also for logic inside the SourceThread class, this is a more serious issue than just showing a value. The first issue is that we update the progress percentage in two places: getStat(), just before reporting it, and finishSuccesfully, to make sure the progress is 100% after migration ended (rounding errors or missing updates may case it to stay at 99%). Unfortunately, getStat() can run concurrently to the migration code, so nothing prevents it from overwrite the value finishSuccessfully set. The second issue is more complex. First let's point out that there could be legitimate cases for progress going backwards. If a migration is stalling because the guess is making pages dirty too fast, the amount of data_remaining could increase. However, because both lack of guarantees about monotonic increase and the race on write, we could end up with progress = 99 after migration ended, and this could mistakenly trigger another migration attempt - which indeed happen in rhbz#1414626. The definitive fix for this harmful retry is provided in change Ie45553bf3ec3db76e520d11a68c67b5b9664dc32 Change-Id: I2663382b6b1b2b58f8e4980a23ace36f4736930d Bug-Url: https://bugzilla.redhat.com/1414626 Backport-To: 4.1 Backport-To: 4.0 Signed-off-by: Francesco Romani <fromani(a)redhat.com> --- M lib/vdsm/virt/migration.py M tests/vmmigration_test.py 2 files changed, 88 insertions(+), 7 deletions(-) Approvals: Dan Kenigsberg: Looks good to me, approved Francesco Romani: Verified; Passed CI tests Martin Polednik: Looks good to me, but someone else must approve Milan Zamazal: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/71159 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2663382b6b1b2b58f8e4980a23ace36f4736930d Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com> Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in vdsm[master]: migration: add boolean to control retries
by Code Review 03 Feb '17

03 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has posted comments on this change. Change subject: migration: add boolean to control retries ...................................................................... Patch Set 10: Code-Review+2 raising -- To view, visit https://gerrit.ovirt.org/71160 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie45553bf3ec3db76e520d11a68c67b5b9664dc32 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com> Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-HasComments: No

1 0

Change in vdsm[master]: migration: make progress reporting reliable
by Code Review 03 Feb '17

03 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has posted comments on this change. Change subject: migration: make progress reporting reliable ...................................................................... Patch Set 10: Code-Review+2 raising -- To view, visit https://gerrit.ovirt.org/71159 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2663382b6b1b2b58f8e4980a23ace36f4736930d Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com> Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-HasComments: No

1 0

Change in vdsm[master]: hooks: Add localdisk hook
by Code Review 03 Feb '17

03 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has posted comments on this change. Change subject: hooks: Add localdisk hook ...................................................................... Patch Set 9: Code-Review-1 (1 comment) nit https://gerrit.ovirt.org/#/c/71272/9/vdsm_hooks/Makefile.am File vdsm_hooks/Makefile.am: Line 47: hostusb \ Line 48: httpsisoboot \ Line 49: hugepages \ Line 50: isolatedprivatevlan \ Line 51: localdisk \ please place it in the SUBDIRS of line 21: we consider to make this a supported hook Line 52: macbind \ Line 53: nestedvt \ Line 54: noipspoof \ Line 55: numa \ -- To view, visit https://gerrit.ovirt.org/71272 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5b6ad8e8ebb4cd71bff02157f28cd2be5c31ac35 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Fred Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yaniv Kaul <ykaul(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-HasComments: Yes

1 0

Change in vdsm[master]: confmeta: Add confmeta module
by Code Review 03 Feb '17

03 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has submitted this change and it was merged. Change subject: confmeta: Add confmeta module ...................................................................... confmeta: Add confmeta module This module handles configuration files managed by vdsm, using a metadata comments header. Example file: # This file is managed by vdsm # description... #REVISION: 3 #PRIVATE: NO file contents... Example usage: >>> from vdsm.tool import confmeta >>>> confmeta.read_metadata(path) ConfigMetadata(revision=3, private=False) This module will be used to manage lvmlocal.conf file, and later will replace the system used to manage multiapth.conf. Change-Id: Icbd590853ca0acc47acd7823daf39931cd617638 Bug-Url: https://bugzilla.redhat.com/1374545 Signed-off-by: Nir Soffer <nsoffer(a)redhat.com> --- M lib/vdsm/tool/Makefile.am A lib/vdsm/tool/confmeta.py M tests/Makefile.am A tests/tool_confmeta_test.py M vdsm.spec.in 5 files changed, 259 insertions(+), 1 deletion(-) Approvals: Piotr Kliczewski: Looks good to me, but someone else must approve Nir Soffer: Verified; Passed CI tests Dan Kenigsberg: Looks good to me, approved Objections: Yaniv Bronhaim: I would prefer that you didn't submit this Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/70583 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icbd590853ca0acc47acd7823daf39931cd617638 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Mooli Tayer <mtayer(a)redhat.com> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>

1 0

Change in vdsm[ovirt-4.1]: net: vlan@bond config with ifcfg requires hwaddrs sync check
by Code Review 03 Feb '17

03 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has posted comments on this change. Change subject: net: vlan@bond config with ifcfg requires hwaddrs sync check ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/71570 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8fc13f42ec21fef1e62f326981742bd66a792429 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.1 Gerrit-Owner: Edward Haas <edwardh(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-HasComments: No

1 0

Change in vdsm[master]: confmeta: Add confmeta module
by Code Review 03 Feb '17

03 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has posted comments on this change. Change subject: confmeta: Add confmeta module ...................................................................... Patch Set 11: CI failure unrelated. The patch is more important than the reservation regarding code location, so I'm taking it in. -- To view, visit https://gerrit.ovirt.org/70583 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icbd590853ca0acc47acd7823daf39931cd617638 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Mooli Tayer <mtayer(a)redhat.com> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com> Gerrit-HasComments: No

1 0

Change in vdsm[master]: confmeta: Add confmeta module
by Code Review 03 Feb '17

03 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has posted comments on this change. Change subject: confmeta: Add confmeta module ...................................................................... Patch Set 11: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/70583 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icbd590853ca0acc47acd7823daf39931cd617638 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Mooli Tayer <mtayer(a)redhat.com> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com> Gerrit-HasComments: No

1 0

Change in vdsm[master]: virt: Handle the result of switching to post-copy properly
by Code Review 03 Feb '17

03 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has submitted this change and it was merged. Change subject: virt: Handle the result of switching to post-copy properly ...................................................................... virt: Handle the result of switching to post-copy properly When migrateStartPostCopy fails, it raises an exception. So we should catch the exception and not examine the result. Change-Id: I8dc31acbde9eef933ca4a14a24c727d90ae9c8e4 Signed-off-by: Milan Zamazal <mzamazal(a)redhat.com> Backport-To: 4.1 --- M vdsm/virt/vm.py 1 file changed, 6 insertions(+), 6 deletions(-) Approvals: Jenkins CI: Passed CI tests Francesco Romani: Looks good to me, approved Milan Zamazal: Verified -- To view, visit https://gerrit.ovirt.org/71502 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8dc31acbde9eef933ca4a14a24c727d90ae9c8e4 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal <mzamazal(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in vdsm[ovirt-4.1]: net: link.bond - handling of arp_ip_target
by Code Review 03 Feb '17

03 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has posted comments on this change. Change subject: net: link.bond - handling of arp_ip_target ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/71509 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia016edcc1d346e8c7654fd65758220db422bbe47 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.1 Gerrit-Owner: Dominik Holler <dholler(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Dominik Holler <dholler(a)redhat.com> Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-HasComments: No

1 0

Change in vdsm[ovirt-4.1]: net: Enable bond to handle empty defaults for options
by Code Review 03 Feb '17

03 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has posted comments on this change. Change subject: net: Enable bond to handle empty defaults for options ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/71508 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iecaa340921050d9b1c3586aa71f4de02ab15e97b Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.1 Gerrit-Owner: Dominik Holler <dholler(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Dominik Holler <dholler(a)redhat.com> Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-HasComments: No

1 0

Change in vdsm[master]: ssl: change protocol to tlsv1.2
by Code Review 02 Feb '17

02 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has submitted this change and it was merged. Change subject: ssl: change protocol to tlsv1.2 ...................................................................... ssl: change protocol to tlsv1.2 In order to support v1.2 we need to update the protocol version to 'sslv23' which supports the most protocols [1] and it is supported by ssl and m2c. [1] https://docs.python.org/2/library/ssl.html#socket-creation Bug-Url: https://bugzilla.redhat.com/1412552 Change-Id: I6658d331d44ccc9c42f83455d02cab209eeec9c1 Signed-off-by: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> --- M lib/vdsm/config.py.in M lib/vdsm/sslutils.py 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Piotr Kliczewski: Verified Martin Peřina: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Irit Goihman: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/70015 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6658d331d44ccc9c42f83455d02cab209eeec9c1 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Yaniv Kaul <ykaul(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in vdsm[master]: ssl: change protocol to tlsv1.2
by Code Review 02 Feb '17

02 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has posted comments on this change. Change subject: ssl: change protocol to tlsv1.2 ...................................................................... Patch Set 6: Code-Review+2 raising -- To view, visit https://gerrit.ovirt.org/70015 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6658d331d44ccc9c42f83455d02cab209eeec9c1 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Yaniv Kaul <ykaul(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-HasComments: No

1 0

Change in vdsm[ovirt-4.1]: net: replace ifcfg bond options defaults handling
by Code Review 02 Feb '17

02 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has posted comments on this change. Change subject: net: replace ifcfg bond options defaults handling ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/71552 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I28cdaaf248d14de53480873ba6baf58952f9f241 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.1 Gerrit-Owner: Dominik Holler <dholler(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Dominik Holler <dholler(a)redhat.com> Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-HasComments: No

1 0

Change in vdsm[master]: net: Drop bondings._active_slave function
by Code Review 02 Feb '17

02 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has posted comments on this change. Change subject: net: Drop bondings._active_slave function ...................................................................... Patch Set 10: when did THIS pop up? 12:39:44 > from ovirt_imageio_common import directio 12:39:44 E ImportError: No module named ovirt_imageio_common 12:39:44 12:39:44 ../lib/vdsm/kvm2ovirt.py:28: ImportError -- To view, visit https://gerrit.ovirt.org/71053 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1b123d192e803bb9993732472b7b7f3063f820b1 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas <edwardh(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-HasComments: No

1 0

Change in vdsm[master]: net: Drop bondings._active_slave function
by Code Review 02 Feb '17

02 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has posted comments on this change. Change subject: net: Drop bondings._active_slave function ...................................................................... Patch Set 9: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/71053 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1b123d192e803bb9993732472b7b7f3063f820b1 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas <edwardh(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-HasComments: No

1 0

Change in vdsm[master]: net: Introduce bond properties and refactoring options handling
by Code Review 02 Feb '17

02 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has submitted this change and it was merged. Change subject: net: Introduce bond properties and refactoring options handling ...................................................................... net: Introduce bond properties and refactoring options handling Bond properties are introduced, acting as a superset of bond options. Bond options are properties that affect bond operation and can be modified, where the properties include the options and other informative details (read only ones). The existing options handling has been adjusted to fit the new introduced properties with an aim to simplify and remove duplication. Change-Id: I7f9fe408dabb7009e07cc487d04f32b12b0322e6 Signed-off-by: Edward Haas <edwardh(a)redhat.com> --- M lib/vdsm/network/link/bond/__init__.py M lib/vdsm/network/link/bond/sysfs_driver.py M lib/vdsm/network/link/bond/sysfs_options.py M lib/vdsm/network/models.py M lib/vdsm/network/netinfo/bonding.py M lib/vdsm/tool/dump_bonding_opts.py M tests/network/link_bond_test.py M tests/network/netinfo_test.py 8 files changed, 115 insertions(+), 62 deletions(-) Approvals: Dominik Holler: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Petr Horáček: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved Edward Haas: Verified -- To view, visit https://gerrit.ovirt.org/71024 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7f9fe408dabb7009e07cc487d04f32b12b0322e6 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas <edwardh(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Dominik Holler <dholler(a)redhat.com> Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in vdsm[master]: net: Introduce bond properties and refactoring options handling
by Code Review 02 Feb '17

02 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has posted comments on this change. Change subject: net: Introduce bond properties and refactoring options handling ...................................................................... Patch Set 10: Code-Review+2 (1 comment) https://gerrit.ovirt.org/#/c/71024/3/lib/vdsm/network/link/bond/sysfs_optio… File lib/vdsm/network/link/bond/sysfs_options.py: PS3, Line 102: _ > no need to change this to lowercase or a test for this newly-public function -- To view, visit https://gerrit.ovirt.org/71024 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7f9fe408dabb7009e07cc487d04f32b12b0322e6 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas <edwardh(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Dominik Holler <dholler(a)redhat.com> Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-HasComments: Yes

1 0

Change in vdsm[master]: confmeta: Add confmeta module
by Code Review 02 Feb '17

02 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has posted comments on this change. Change subject: confmeta: Add confmeta module ...................................................................... Patch Set 10: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/70583/10//COMMIT_MSG Commit Message: Line 21: Example usage: Line 22: Line 23: >>> from vdsm.tool import confmeta Line 24: >>>> confmeta.read_metadata(path) Line 25: ConfigMetadata(revision=3, private=False) > This module handle lvm.conf, and should replace the code in multipath.conf. Yaniv and Mooli, I tend to agree with Nir: his new configurator intends only to mark configuration files as "ours" or "private". It is quite distinct from editing ini files. maybe the name "configfile" is too broad. For example, multipath.conf is also a configuration file, and it is justly not handled by the configfile configurator. Line 26: Line 27: This module will be used to manage lvmlocal.conf file, and later will Line 28: replace the system used to manage multiapth.conf. Line 29: -- To view, visit https://gerrit.ovirt.org/70583 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icbd590853ca0acc47acd7823daf39931cd617638 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Mooli Tayer <mtayer(a)redhat.com> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com> Gerrit-HasComments: Yes

1 0

Change in vdsm[ovirt-4.1]: net: Extracting SRIOV functionality
by Code Review 02 Feb '17

02 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has posted comments on this change. Change subject: net: Extracting SRIOV functionality ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/71530 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaab7317b77c5d7e35a013754f7baafce6559368d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.1 Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-HasComments: No

1 0

Change in vdsm[ovirt-4.1]: net: modify VF MAC addresses on creation to a valid address
by Code Review 02 Feb '17

02 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has posted comments on this change. Change subject: net: modify VF MAC addresses on creation to a valid address ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/71529 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib740d45206d41b330fd1b33f31765050cadbd679 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.1 Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-HasComments: No

1 0

Change in vdsm[ovirt-4.1]: net: Set and report device mac address through link.iface
by Code Review 02 Feb '17

02 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has posted comments on this change. Change subject: net: Set and report device mac address through link.iface ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/71519 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I21a63a4a36252634744e7af177706403353aaab4 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.1 Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-HasComments: No

1 0

Change in vdsm[master]: net: Extracting SRIOV functionality
by Code Review 01 Feb '17

01 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has submitted this change and it was merged. Change subject: net: Extracting SRIOV functionality ...................................................................... net: Extracting SRIOV functionality Extracting SRIOV functionality from api to a separate module. Change-Id: Iaab7317b77c5d7e35a013754f7baafce6559368d Signed-off-by: Leon Goldberg <lgoldber(a)redhat.com> --- M lib/vdsm/network/api.py A lib/vdsm/network/link/sriov.py 2 files changed, 101 insertions(+), 78 deletions(-) Approvals: Ori Ben Sasson: Verified Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved Edward Haas: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/71370 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaab7317b77c5d7e35a013754f7baafce6559368d Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com> Gerrit-Reviewer: Meni Yakove <myakove(a)redhat.com> Gerrit-Reviewer: Ori Ben Sasson <obensass(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in vdsm[master]: net: modify VF MAC addresses on creation to a valid address
by Code Review 01 Feb '17

01 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has submitted this change and it was merged. Change subject: net: modify VF MAC addresses on creation to a valid address ...................................................................... net: modify VF MAC addresses on creation to a valid address When a guest releases an SR-IOV virtual function, the virtual function's previous MAC address is being restored in host. There is currently an unresolved bug in igb driver's where it fails to reallocate the virtual function back to the host as it doesn't accept the factory (00:00:00:00:00:00) MAC address. Until the issue is resolved on the driver level, this patch implements a hack modifying the VF's MAC addresses on creation to valid addressess that will be accepted upon reallocation. Change-Id: Ib740d45206d41b330fd1b33f31765050cadbd679 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1410076 Signed-off-by: Leon Goldberg <lgoldber(a)redhat.com> --- M lib/vdsm/network/api.py 1 file changed, 28 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved Leon Goldberg: Verified Edward Haas: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/71029 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib740d45206d41b330fd1b33f31765050cadbd679 Gerrit-PatchSet: 39 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com> Gerrit-Reviewer: Meni Yakove <myakove(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in vdsm[master]: net: Extracting SRIOV functionality
by Code Review 01 Feb '17

01 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has posted comments on this change. Change subject: net: Extracting SRIOV functionality ...................................................................... Patch Set 11: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/71370 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaab7317b77c5d7e35a013754f7baafce6559368d Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com> Gerrit-Reviewer: Meni Yakove <myakove(a)redhat.com> Gerrit-Reviewer: Ori Ben Sasson <obensass(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-HasComments: No

1 0

Change in vdsm[master]: net: modify VF MAC addresses on creation to a valid address
by Code Review 01 Feb '17

01 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has posted comments on this change. Change subject: net: modify VF MAC addresses on creation to a valid address ...................................................................... Patch Set 39: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/71029 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib740d45206d41b330fd1b33f31765050cadbd679 Gerrit-PatchSet: 39 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com> Gerrit-Reviewer: Meni Yakove <myakove(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-HasComments: No

1 0

Change in vdsm[master]: net: link.bond - handling of arp_ip_target
by Code Review 01 Feb '17

01 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has submitted this change and it was merged. Change subject: net: link.bond - handling of arp_ip_target ...................................................................... net: link.bond - handling of arp_ip_target Reading: To enable an unified handling of all bonding options, the bond option arp_ip_target is internally converted in the representation which is accepted by the ifcfg-bond* files. In details, the bond option arp_ip_target could contain multiple values, which are separated by space in /sys/class/net/%s/bonding/arp_ip_target. Separate this values inside vdsm by comma, to enable an unified handling for all bonding options. Setting: Enable the bond option arp_ip_target to be set by BondSysFS.set_options. Adding and removing values by writing to /sys/class/net/%s/bonding/arp_ip_target requires a command-like interface. Extend link.bond to handle this interface. Add an unit and a functional test for setting and reading arp_ip_target. Change-Id: Ia016edcc1d346e8c7654fd65758220db422bbe47 Bug-Url: https://bugzilla.redhat.com/1412563 Signed-off-by: Dominik Holler <dholler(a)redhat.com> --- M lib/vdsm/network/link/bond/sysfs_options.py M tests/network/func_bond_basic_test.py M tests/network/link_bond_test.py 3 files changed, 121 insertions(+), 7 deletions(-) Approvals: Dominik Holler: Verified Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved Edward Haas: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/70943 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia016edcc1d346e8c7654fd65758220db422bbe47 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dominik Holler <dholler(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Dominik Holler <dholler(a)redhat.com> Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in vdsm[master]: net: link.bond - handling of arp_ip_target
by Code Review 01 Feb '17

01 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has posted comments on this change. Change subject: net: link.bond - handling of arp_ip_target ...................................................................... Patch Set 11: Code-Review+2 raising -- To view, visit https://gerrit.ovirt.org/70943 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia016edcc1d346e8c7654fd65758220db422bbe47 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dominik Holler <dholler(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Dominik Holler <dholler(a)redhat.com> Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-HasComments: No

1 0

Change in vdsm[master]: net: vlan@bond config with ifcfg requires hwaddrs sync check
by Code Review 01 Feb '17

01 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has submitted this change and it was merged. Change subject: net: vlan@bond config with ifcfg requires hwaddrs sync check ...................................................................... net: vlan@bond config with ifcfg requires hwaddrs sync check Bonds are expected to inherit one of its slaves mac address, but in some cases (mainly when its slaves are detached temporary) the bond is left with its own generated address. In such scenarios, a VLAN which may be configured over it will inherit its temporary address and stick with it. At the time the slaves re-attach to the bond, the VLAN interface will not have the same address as the bond. This has been identified as a problem when adding a network over an existing vlan@bond NM setup. With this patch, when the ifcfg configurator attempts to configure a vlan over a bond, it will check post the ifup if the slave-bond-vlan mac addresses are in sync. In case they are not, the vlan is taken down (ifdown) and recreated. Change-Id: I8fc13f42ec21fef1e62f326981742bd66a792429 Bug-Url: https://bugzilla.redhat.com/1414323 Signed-off-by: Edward Haas <edwardh(a)redhat.com> --- M lib/vdsm/network/configurators/ifcfg.py 1 file changed, 41 insertions(+), 3 deletions(-) Approvals: Jenkins CI: Passed CI tests Petr Horáček: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved Edward Haas: Verified -- To view, visit https://gerrit.ovirt.org/71204 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8fc13f42ec21fef1e62f326981742bd66a792429 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas <edwardh(a)redhat.com> Gerrit-Reviewer: Anonymous Coward #1001177 Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michael Burman <mburman(a)redhat.com> Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in vdsm[master]: net test: Add network over a configured NM bond+vlan.
by Code Review 01 Feb '17

01 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has submitted this change and it was merged. Change subject: net test: Add network over a configured NM bond+vlan. ...................................................................... net test: Add network over a configured NM bond+vlan. Includes checks of hwaddress (mac) between the bond, vlan and the bridge (requiring them to be identical). Change-Id: Ia2d5b29b0ee4b72bd5b2170a154696ff48560a4f Signed-off-by: Edward Haas <edwardh(a)redhat.com> --- M tests/network/func_net_basic_test.py M tests/network/nmnettestlib.py 2 files changed, 68 insertions(+), 13 deletions(-) Approvals: Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved Edward Haas: Verified -- To view, visit https://gerrit.ovirt.org/71203 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia2d5b29b0ee4b72bd5b2170a154696ff48560a4f Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas <edwardh(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in vdsm[master]: net: vlan@bond config with ifcfg requires hwaddrs sync check
by Code Review 01 Feb '17

01 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has posted comments on this change. Change subject: net: vlan@bond config with ifcfg requires hwaddrs sync check ...................................................................... Patch Set 10: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/71204 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8fc13f42ec21fef1e62f326981742bd66a792429 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas <edwardh(a)redhat.com> Gerrit-Reviewer: Anonymous Coward #1001177 Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michael Burman <mburman(a)redhat.com> Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-HasComments: No

1 0

Change in vdsm[master]: net test: Add network over a configured NM bond+vlan.
by Code Review 01 Feb '17

01 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has posted comments on this change. Change subject: net test: Add network over a configured NM bond+vlan. ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/71203 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia2d5b29b0ee4b72bd5b2170a154696ff48560a4f Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas <edwardh(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-HasComments: No

1 0

Change in vdsm[master]: fileSD: escape values passed to glob.glob
by Code Review 01 Feb '17

01 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has posted comments on this change. Change subject: fileSD: escape values passed to glob.glob ...................................................................... Patch Set 11: -Code-Review -- To view, visit https://gerrit.ovirt.org/69835 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id13b5adadc8e2a2be0d32105cb22b35544db1fad Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-HasComments: No

1 0

Change in vdsm[master]: JsonRpcTests: add dest parameter to constructClient
by Code Review 01 Feb '17

01 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has submitted this change and it was merged. Change subject: JsonRpcTests: add dest parameter to constructClient ...................................................................... JsonRpcTests: add dest parameter to constructClient In order to support new subscription tests, constructClient should get destination parameter, allowing to add more subscriptions. Change-Id: I05f5546e8055eada53416db57bb42a0a229c86ff Signed-off-by: Irit Goihman <igoihman(a)redhat.com> --- M tests/integration/jsonRpcHelper.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Piotr Kliczewski: Looks good to me, approved Jenkins CI: Passed CI tests Irit Goihman: Verified -- To view, visit https://gerrit.ovirt.org/71349 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I05f5546e8055eada53416db57bb42a0a229c86ff Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in vdsm[master]: JsonRpcTests: add test for client subscribe
by Code Review 01 Feb '17

01 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has submitted this change and it was merged. Change subject: JsonRpcTests: add test for client subscribe ...................................................................... JsonRpcTests: add test for client subscribe Change-Id: I7d98d0ef817a25cc1a6ffaaab9e40136f7e37481 Signed-off-by: Irit Goihman <igoihman(a)redhat.com> --- M tests/integration/jsonRpcTests.py 1 file changed, 22 insertions(+), 0 deletions(-) Approvals: Piotr Kliczewski: Looks good to me, approved Jenkins CI: Passed CI tests Irit Goihman: Verified -- To view, visit https://gerrit.ovirt.org/71350 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7d98d0ef817a25cc1a6ffaaab9e40136f7e37481 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in vdsm[master]: tests: add optional username test to kvm2ovirt
by Code Review 01 Feb '17

01 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has submitted this change and it was merged. Change subject: tests: add optional username test to kvm2ovirt ...................................................................... tests: add optional username test to kvm2ovirt kvm2ovirt have optional username and password, adding test to cover missing username and password Change-Id: I6a517bd55be92aef3d62035073c84ef26d31e111 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M tests/kvm2ovirt_test.py 1 file changed, 31 insertions(+), 0 deletions(-) Approvals: Shahar Havivi: Verified Jenkins CI: Passed CI tests Francesco Romani: Looks good to me, approved Tomas Golembiovsky: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/70729 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6a517bd55be92aef3d62035073c84ef26d31e111 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tomas Golembiovsky <tgolembi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in vdsm[master]: virt: Added 'prepared' context manager
by Code Review 01 Feb '17

01 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has submitted this change and it was merged. Change subject: virt: Added 'prepared' context manager ...................................................................... virt: Added 'prepared' context manager Added context manager to prepare a group of objects (for example, disk images) for an operation. Each images must implement prepare() and teardown() methods. When entering the context, all images are prepared in the order they are passed. When exiting the context (or upon error) the images are torn down in reverse order. If an exception was raised inside the context, that exception will be propagated regardless of any exceptions that may be thrown by teardown() methods. Usage example: with prepared(images): do_some_operation(images) Change-Id: Ibe9d04599dfc1700f215a7765775d60cb314ff0a Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com> --- M lib/vdsm/virt/utils.py A tests/virttests/prepared_test.py 2 files changed, 220 insertions(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Shmuel Leib Melamud: Verified Francesco Romani: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/71358 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibe9d04599dfc1700f215a7765775d60cb314ff0a Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in vdsm[master]: tests: fix integration tests
by Code Review 01 Feb '17

01 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has submitted this change and it was merged. Change subject: tests: fix integration tests ...................................................................... tests: fix integration tests This patch fixes an issue with integration tests which are not part of general build process, getting the following error: AttributeError: '_DummyBridge' object has no attribute 'dispatch' We use to use __getattr__ method but we replaced it with dispatch not to swap '.' with '_'. Related-To: https://gerrit.ovirt.org/53472 Change-Id: I98dfe4c863b2780f7d28b62a857e2fffa5f40acd Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com> --- M tests/integration/jsonRpcTests.py 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: Piotr Kliczewski: Verified Jenkins CI: Passed CI tests Irit Goihman: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/55871 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I98dfe4c863b2780f7d28b62a857e2fffa5f40acd Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in vdsm[master]: net: Enable bond to handle empty defaults for options
by Code Review 01 Feb '17

01 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has submitted this change and it was merged. Change subject: net: Enable bond to handle empty defaults for options ...................................................................... net: Enable bond to handle empty defaults for options If an option of a bonding is not touched during setting the options of the bonding, the option is reset to its default value, even if the default value is empty. Change-Id: Iecaa340921050d9b1c3586aa71f4de02ab15e97b Signed-off-by: Dominik Holler <dholler(a)redhat.com> --- M lib/vdsm/network/link/bond/sysfs_options.py 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Dominik Holler: Verified Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved Edward Haas: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/71471 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iecaa340921050d9b1c3586aa71f4de02ab15e97b Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dominik Holler <dholler(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Dominik Holler <dholler(a)redhat.com> Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in vdsm[master]: tests: fix integration tests
by Code Review 01 Feb '17

01 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has posted comments on this change. Change subject: tests: fix integration tests ...................................................................... Patch Set 10: Code-Review+2 raising -- To view, visit https://gerrit.ovirt.org/55871 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I98dfe4c863b2780f7d28b62a857e2fffa5f40acd Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-HasComments: No

1 0

Change in vdsm[master]: jsonRpcTests: add missing event schema
by Code Review 01 Feb '17

01 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has submitted this change and it was merged. Change subject: jsonRpcTests: add missing event schema ...................................................................... jsonRpcTests: add missing event schema doubleResponse test is failing because of missing event schema in bridge object. Change-Id: Idb5edcb881c8a2b2481787196b81179a9981e4c8 Signed-off-by: Irit Goihman <igoihman(a)redhat.com> --- M tests/integration/jsonRpcTests.py 1 file changed, 11 insertions(+), 1 deletion(-) Approvals: Piotr Kliczewski: Looks good to me, approved Jenkins CI: Passed CI tests Irit Goihman: Verified -- To view, visit https://gerrit.ovirt.org/71339 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idb5edcb881c8a2b2481787196b81179a9981e4c8 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in vdsm[master]: JsonRpcClient: add subcribe and unsubscribe
by Code Review 01 Feb '17

01 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has submitted this change and it was merged. Change subject: JsonRpcClient: add subcribe and unsubscribe ...................................................................... JsonRpcClient: add subcribe and unsubscribe Until now, we were only able to send jsonrpc commands in request queue and get responses in response queue. Now we are able to subscribe/unsubscribe to/from specific queue and receive notifications. Change-Id: I3e35b82762a101cc0034995b7c0e506ec0a803d8 Signed-off-by: Irit Goihman <igoihman(a)redhat.com> --- M lib/yajsonrpc/__init__.py M lib/yajsonrpc/stompreactor.py 2 files changed, 15 insertions(+), 0 deletions(-) Approvals: Piotr Kliczewski: Looks good to me, approved Jenkins CI: Passed CI tests Irit Goihman: Verified -- To view, visit https://gerrit.ovirt.org/70110 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3e35b82762a101cc0034995b7c0e506ec0a803d8 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in vdsm[master]: net: Enable bond to handle empty defaults for options
by Code Review 01 Feb '17

01 Feb '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has posted comments on this change. Change subject: net: Enable bond to handle empty defaults for options ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/71471 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iecaa340921050d9b1c3586aa71f4de02ab15e97b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dominik Holler <dholler(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Dominik Holler <dholler(a)redhat.com> Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-HasComments: No

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

vdsm-patches February 2017