Change in vdsm[master]: virt: Added 'prepared' context manager
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: virt: Added 'prepared' context manager
......................................................................
virt: Added 'prepared' context manager
Added context manager to prepare a group of objects (for example, disk images)
for an operation. Each images must implement prepare() and teardown() methods.
When entering the context, all images are prepared in the order they are
passed. When exiting the context (or upon error) the images are torn
down in reverse order. If an exception was raised inside the context,
that exception will be propagated regardless of any exceptions that may
be thrown by teardown() methods.
Usage example:
with prepared(images):
do_some_operation(images)
Change-Id: Ibe9d04599dfc1700f215a7765775d60cb314ff0a
Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com>
---
M lib/vdsm/virt/utils.py
A tests/virttests/prepared_test.py
2 files changed, 220 insertions(+), 1 deletion(-)
Approvals:
Jenkins CI: Passed CI tests
Shmuel Leib Melamud: Verified
Francesco Romani: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/71358
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibe9d04599dfc1700f215a7765775d60cb314ff0a
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 2 months
Change in vdsm[master]: tests: fix integration tests
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: tests: fix integration tests
......................................................................
tests: fix integration tests
This patch fixes an issue with integration tests which are not part of
general build process, getting the following error:
AttributeError: '_DummyBridge' object has no attribute 'dispatch'
We use to use __getattr__ method but we replaced
it with dispatch not to swap '.' with '_'.
Related-To: https://gerrit.ovirt.org/53472
Change-Id: I98dfe4c863b2780f7d28b62a857e2fffa5f40acd
Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com>
---
M tests/integration/jsonRpcTests.py
1 file changed, 6 insertions(+), 0 deletions(-)
Approvals:
Piotr Kliczewski: Verified
Jenkins CI: Passed CI tests
Irit Goihman: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/55871
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I98dfe4c863b2780f7d28b62a857e2fffa5f40acd
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 2 months
Change in vdsm[master]: net: Enable bond to handle empty defaults for options
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: Enable bond to handle empty defaults for options
......................................................................
net: Enable bond to handle empty defaults for options
If an option of a bonding is not touched during setting the options
of the bonding, the option is reset to its default value, even if the
default value is empty.
Change-Id: Iecaa340921050d9b1c3586aa71f4de02ab15e97b
Signed-off-by: Dominik Holler <dholler(a)redhat.com>
---
M lib/vdsm/network/link/bond/sysfs_options.py
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Dominik Holler: Verified
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
Edward Haas: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/71471
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iecaa340921050d9b1c3586aa71f4de02ab15e97b
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dominik Holler <dholler(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dominik Holler <dholler(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 2 months
Change in vdsm[master]: tests: fix integration tests
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: tests: fix integration tests
......................................................................
Patch Set 10: Code-Review+2
raising
--
To view, visit https://gerrit.ovirt.org/55871
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I98dfe4c863b2780f7d28b62a857e2fffa5f40acd
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 2 months
Change in vdsm[master]: jsonRpcTests: add missing event schema
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: jsonRpcTests: add missing event schema
......................................................................
jsonRpcTests: add missing event schema
doubleResponse test is failing because of missing
event schema in bridge object.
Change-Id: Idb5edcb881c8a2b2481787196b81179a9981e4c8
Signed-off-by: Irit Goihman <igoihman(a)redhat.com>
---
M tests/integration/jsonRpcTests.py
1 file changed, 11 insertions(+), 1 deletion(-)
Approvals:
Piotr Kliczewski: Looks good to me, approved
Jenkins CI: Passed CI tests
Irit Goihman: Verified
--
To view, visit https://gerrit.ovirt.org/71339
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idb5edcb881c8a2b2481787196b81179a9981e4c8
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 2 months
Change in vdsm[master]: JsonRpcClient: add subcribe and unsubscribe
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: JsonRpcClient: add subcribe and unsubscribe
......................................................................
JsonRpcClient: add subcribe and unsubscribe
Until now, we were only able to send jsonrpc commands
in request queue and get responses in response queue.
Now we are able to subscribe/unsubscribe to/from specific
queue and receive notifications.
Change-Id: I3e35b82762a101cc0034995b7c0e506ec0a803d8
Signed-off-by: Irit Goihman <igoihman(a)redhat.com>
---
M lib/yajsonrpc/__init__.py
M lib/yajsonrpc/stompreactor.py
2 files changed, 15 insertions(+), 0 deletions(-)
Approvals:
Piotr Kliczewski: Looks good to me, approved
Jenkins CI: Passed CI tests
Irit Goihman: Verified
--
To view, visit https://gerrit.ovirt.org/70110
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3e35b82762a101cc0034995b7c0e506ec0a803d8
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 2 months
Change in vdsm[master]: net: Enable bond to handle empty defaults for options
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: Enable bond to handle empty defaults for options
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/71471
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iecaa340921050d9b1c3586aa71f4de02ab15e97b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dominik Holler <dholler(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dominik Holler <dholler(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-HasComments: No
7 years, 2 months