Change in vdsm[master]: tests: Fix flaky picklecopy benchmark
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: tests: Fix flaky picklecopy benchmark
......................................................................
tests: Fix flaky picklecopy benchmark
We have a benchmark for picklecopy, failing randomly on travis, when
picklecopy was less than twice faster compared with deepcopy. I don't
think it is useful to fail the test randomly because of this reason, and
I don't think picklecopy should be significantly faster then deepcopy to
be useful. This code is much simpler then deepcopy and even if it is not
significantly faster, I prefer to use picklecopy.
The tests prints now the results to make this easier to debug. To see
the timing run the tests with the -s option:
$ ./run_tests_local.sh utils_tests.py -s
...
utils_test.TestPickleCopy
test_picklecopy_exact OK
test_picklecopy_faster deepcopy: 0.194, picklecopy: 0.053 OK
...
Change-Id: Ice02137c9e6285401a9af29fd1b5ecd2a9c6a2cb
Signed-off-by: Nir Soffer <nsoffer(a)redhat.com>
---
M tests/utils_test.py
1 file changed, 10 insertions(+), 13 deletions(-)
Approvals:
Nir Soffer: Verified
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
Francesco Romani: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/69738
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ice02137c9e6285401a9af29fd1b5ecd2a9c6a2cb
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years
Change in vdsm[master]: net: Allow VLAN on top of a bonding slave
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: Allow VLAN on top of a bonding slave
......................................................................
Patch Set 1: Code-Review-1
--
To view, visit https://gerrit.ovirt.org/74707
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I20dd5e3716183286344fe17aaed95946f4718c38
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dominik Holler <dholler(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dominik Holler <dholler(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years
Change in vdsm[master]: net: Allow VLAN on top of a bonding slave
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: Allow VLAN on top of a bonding slave
......................................................................
Patch Set 1:
what is the use case for this? please elaborate in the commit message.
to get in, this requires its own func_test; or otherwise it would be broken.
--
To view, visit https://gerrit.ovirt.org/74707
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I20dd5e3716183286344fe17aaed95946f4718c38
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dominik Holler <dholler(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dominik Holler <dholler(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years
Change in vdsm[master]: storage: group disk indices of scsi and sata interfaces
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: storage: group disk indices of scsi and sata interfaces
......................................................................
storage: group disk indices of scsi and sata interfaces
Both interfaces use sd* as a name for their node. We have to make sure
they don't collide.
Change-Id: I8b20c12e16e563f863448f3dbade3c0800fb3233
Signed-off-by: Martin Polednik <mpolednik(a)redhat.com>
---
M vdsm/virt/vm.py
1 file changed, 19 insertions(+), 3 deletions(-)
Approvals:
Shahar Havivi: Verified; Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Francesco Romani: Looks good to me, approved
Martin Polednik: Verified
--
To view, visit https://gerrit.ovirt.org/74747
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8b20c12e16e563f863448f3dbade3c0800fb3233
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years
Change in vdsm[master]: storage: add tests for drive indice generating code
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: storage: add tests for drive indice generating code
......................................................................
storage: add tests for drive indice generating code
The code is quite tied to the Vm class and we should eventually
investigate how to untangle it, but let's start with tests.
Change-Id: Ibf52aebc8011a7e179d83d0432b5407f5b617f47
Signed-off-by: Martin Polednik <mpolednik(a)redhat.com>
---
M tests/vm_test.py
1 file changed, 54 insertions(+), 0 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Francesco Romani: Looks good to me, approved
Martin Polednik: Verified
--
To view, visit https://gerrit.ovirt.org/74764
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibf52aebc8011a7e179d83d0432b5407f5b617f47
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years
Change in vdsm[master]: tests: Fix flaky picklecopy benchmark
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: tests: Fix flaky picklecopy benchmark
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/69738
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ice02137c9e6285401a9af29fd1b5ecd2a9c6a2cb
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years
Change in vdsm[master]: virt: Add artificial delay after migration on destination
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: virt: Add artificial delay after migration on destination
......................................................................
virt: Add artificial delay after migration on destination
When a migration successfully finishes, we report two different events to
Engine:
- VM status change to up status from the destination.
- Final migration progress with downtime from the source.
Those events may arrive to Engine in arbitrary order. But Engine developers
would like to already know the downtime at the time the migration is finished
from their view (i.e. they are informed that VM status is changed to up status
on the destination).
One solution would be to synchronize the two hosts before setting the VM to up
status on the destination. Although that is possible, a simpler solution is
preferable. The easiest workaround is to add some fixed delay after migration
is finished on the destination and before up status is set. That doesn't
guarantee the proper order of events, but increases chances that the downtime
event is received by Engine before the up state event. If the order of the
events is still wrong, downtime won't be displayed in Engine. This is not much
problem if it happens only rarely.
Change-Id: I2b9500a0d9c7824a8b253817634a9a73eed23d27
Bug-Url: https://bugzilla.redhat.com/1427566
Backport-To: 4.1
Signed-off-by: Milan Zamazal <mzamazal(a)redhat.com>
---
M vdsm/virt/vm.py
1 file changed, 5 insertions(+), 0 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Shmuel Leib Melamud: Verified; Looks good to me, but someone else must approve
Francesco Romani: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/74483
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2b9500a0d9c7824a8b253817634a9a73eed23d27
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years
Change in vdsm[master]: virt: Add artificial delay after migration on destination
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: virt: Add artificial delay after migration on destination
......................................................................
Patch Set 2:
horrible raceful solution
--
To view, visit https://gerrit.ovirt.org/74483
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2b9500a0d9c7824a8b253817634a9a73eed23d27
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years
Change in vdsm[master]: xmlrpc: stop detection
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: xmlrpc: stop detection
......................................................................
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/72740/3/lib/vdsm/rpc/bindingxmlrpc.py
File lib/vdsm/rpc/bindingxmlrpc.py:
Line 1319
Line 1320
Line 1321
Line 1322
Line 1323
> Why do we want to handle any request if we know it is not correct?
Nir is just being slightly more friendly to a random Joe using vdsClient to contact vdsm-4.20. That user would see a clearer error message.
It's neither important, nor wrong, in my opinion. I'd rather not see important topic stall on this issue.
--
To view, visit https://gerrit.ovirt.org/72740
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6ab7d42efab98f23736d323b2b0b614a568b7112
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
7 years
Change in vdsm[master]: storage: use defaultdict for used indices
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: storage: use defaultdict for used indices
......................................................................
storage: use defaultdict for used indices
Reduces the amount of boilerplate. No change in functionality.
Change-Id: Iddb561a3fe0a0dc478c942210a3d51937ef70d27
Signed-off-by: Martin Polednik <mpolednik(a)redhat.com>
---
M vdsm/virt/vm.py
1 file changed, 2 insertions(+), 6 deletions(-)
Approvals:
Shahar Havivi: Verified; Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Francesco Romani: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/74746
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iddb561a3fe0a0dc478c942210a3d51937ef70d27
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years