Change in vdsm[master]: xmlrpc: stop detection
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: xmlrpc: stop detection
......................................................................
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/72740/3//COMMIT_MSG
Commit Message:
Line 8:
Line 9: Xmlrpc detector was responsible to detect http post which was used by
Line 10: xmlrpc and get and put methods used by image upload and download logic.
Line 11: We do not need to detect post anymore but we still need to detect put
Line 12: and get methods.
> When we remove POST the connection would be closed since none of the protoc
I don't see a very strong reason to keep the verbose error message for POST.
However, can we go on removing the bulk of the xmlrpc code and revisit this question later?
Line 13:
Line 14:
Line 15: Change-Id: I6ab7d42efab98f23736d323b2b0b614a568b7112
--
To view, visit https://gerrit.ovirt.org/72740
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6ab7d42efab98f23736d323b2b0b614a568b7112
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
7 years
Change in vdsm[master]: net tests: libvirt_test - extract custom assertions
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net tests: libvirt_test - extract custom assertions
......................................................................
net tests: libvirt_test - extract custom assertions
Change-Id: I202d943136298200cbc03224b013493848886c81
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
---
M tests/network/libvirt_test.py
1 file changed, 5 insertions(+), 3 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Petr Horáček: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, approved
Edward Haas: Verified
--
To view, visit https://gerrit.ovirt.org/74389
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I202d943136298200cbc03224b013493848886c81
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years
Change in vdsm[master]: virt net: Create libvirt network only when needed
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: virt net: Create libvirt network only when needed
......................................................................
virt net: Create libvirt network only when needed
The libvirt network is needed only for VM/s with graphics, therefore its
creation and deletion should be dependent directly on it.
On each graphic entity setup, the network will be created if it has not
existed before.
Deletion will occur on teardown if the current instance is the last
one which uses the specific network.
This patch is focused on virt changes, the following patches drops
libvirt creation and deletion from the host networking code.
Change-Id: Ie55b08e9bdffcd8ea663b647c6d6dcf3363b9847
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
---
M lib/vdsm/network/api.py
M lib/vdsm/network/libvirt.py
M lib/vdsm/virt/vmdevices/graphics.py
M tests/network/libvirt_test.py
4 files changed, 127 insertions(+), 1 deletion(-)
Approvals:
Jenkins CI: Passed CI tests
Petr Horáček: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, approved
Francesco Romani: Looks good to me, but someone else must approve
Edward Haas: Verified
--
To view, visit https://gerrit.ovirt.org/74390
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie55b08e9bdffcd8ea663b647c6d6dcf3363b9847
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years
Change in vdsm[master]: net: Expose translation of iface from config to netinfo
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: Expose translation of iface from config to netinfo
......................................................................
net: Expose translation of iface from config to netinfo
The translation function has been publicly expose from the
netinfo.cache in order to use it in the following patches.
Change-Id: Idcb7c5ff8f15820cd36ca0533dbd360df4ac519e
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
---
M lib/vdsm/network/netinfo/cache.py
1 file changed, 4 insertions(+), 4 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Petr Horáček: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, approved
Edward Haas: Verified
--
To view, visit https://gerrit.ovirt.org/74490
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idcb7c5ff8f15820cd36ca0533dbd360df4ac519e
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years
Change in vdsm[master]: virt net: Introduce setup to Graphics and refactor displayNe...
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: virt net: Introduce setup to Graphics and refactor displayNetwork init
......................................................................
virt net: Introduce setup to Graphics and refactor displayNetwork init
Introducing setup method to Graphics, to provide setup/teardown steps.
displayIp decoding has been moved to the setup step to allow in the
following patches to create the libvirt network on demand if missing.
Change-Id: Ie83e964e8647882d96028fa149ef78f5f0502272
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
---
M lib/vdsm/virt/vmdevices/graphics.py
M tests/device_test.py
2 files changed, 19 insertions(+), 14 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Petr Horáček: Looks good to me, but someone else must approve
Francesco Romani: Looks good to me, approved
Martin Polednik: Looks good to me, but someone else must approve
Edward Haas: Verified
--
To view, visit https://gerrit.ovirt.org/74321
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie83e964e8647882d96028fa149ef78f5f0502272
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years
Change in vdsm[master]: net: Do not create libvirt networks for each host network
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: Do not create libvirt networks for each host network
......................................................................
net: Do not create libvirt networks for each host network
Libvirt networks are created by virt on a per need basis (when a VM with
graphics is instantiated).
With this patch libvirt networks are no longer created in parallel to
the vdsm/host network.
Change-Id: I62b25f0129247bba0fc6a4c40e534598f47f9fbc
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
---
M lib/vdsm/network/configurators/__init__.py
M lib/vdsm/network/configurators/ifcfg.py
M lib/vdsm/network/configurators/iproute2.py
M lib/vdsm/network/legacy_switch.py
M lib/vdsm/network/libvirt.py
M tests/network/conf_test.py
6 files changed, 10 insertions(+), 45 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Petr Horáček: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, approved
Edward Haas: Verified
--
To view, visit https://gerrit.ovirt.org/74471
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I62b25f0129247bba0fc6a4c40e534598f47f9fbc
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years
Change in vdsm[master]: net: Do not create libvirt networks for each host network
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: Do not create libvirt networks for each host network
......................................................................
Patch Set 6: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/74471
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I62b25f0129247bba0fc6a4c40e534598f47f9fbc
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years
Change in vdsm[master]: net: Expose translation of iface from config to netinfo
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: Expose translation of iface from config to netinfo
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/74490
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idcb7c5ff8f15820cd36ca0533dbd360df4ac519e
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years
Change in vdsm[master]: virt net: Create libvirt network only when needed
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: virt net: Create libvirt network only when needed
......................................................................
Patch Set 7: Code-Review+2
(1 comment)
https://gerrit.ovirt.org/#/c/74390/7/lib/vdsm/network/libvirt.py
File lib/vdsm/network/libvirt.py:
PS7, Line 97: NetworksUsersCache
> not a fan of class-as-namespace approach (also known as staticmethod fest)
I kinda like it...
--
To view, visit https://gerrit.ovirt.org/74390
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie55b08e9bdffcd8ea663b647c6d6dcf3363b9847
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
7 years
Change in vdsm[master]: wip:dpdk: add dpdkvhostuser port
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: wip:dpdk: add dpdkvhostuser port
......................................................................
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/74327/5/lib/vdsm/virt/vmdevices/network.py
File lib/vdsm/virt/vmdevices/network.py:
Line 146: if self.vlanId is not None:
Line 147: vlan = iface.appendChildWithArgs('vlan')
Line 148: vlan.appendChildWithArgs('tag', id=str(self.vlanId))
Line 149:
Line 150: elif self.device == 'vhostuser':
I think that this should depend on an explicit request from Engine, e.g.
if tobool(self.conf['custom']['vhostuser']):
Line 151: ovs_bridge = supervdsm.getProxy().ovs_bridge(self.network)
Line 152: self._source_ovsdpdk_bridge(iface, ovs_bridge['name'])
Line 153:
Line 154: else:
--
To view, visit https://gerrit.ovirt.org/74327
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie81cf52f17ffe01713dd6502d68c4b17c64e5335
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
7 years