Change in vdsm[master]: net: Route removal should not ignore the table it is in
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: Route removal should not ignore the table it is in
......................................................................
Patch Set 1: Code-Review+1
this bug had funcitonal effect. don't we want to had an assertion to one of our functional tests?
--
To view, visit https://gerrit.ovirt.org/77321
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I628d5db06e567a13056dbf83ad7b4d17d79b4ac6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
6 years, 10 months
Change in vdsm[master]: network: isolate libnl constants, EVENTS
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: network: isolate libnl constants, EVENTS
......................................................................
Patch Set 2:
unrelated to patch
18:20:56 ======================================================================
18:20:56 FAIL: test_commit('1.1', 0, 1, False) (qemuimg_test.TestCommit)
18:20:56 ----------------------------------------------------------------------
18:20:56 Traceback (most recent call last):
18:20:56 File "/home/jenkins/workspace/vdsm_master_check-patch-fc25-x86_64/vdsm/tests/testlib.py", line 142, in wrapper
18:20:56 return f(self, *args)
18:20:56 File "/home/jenkins/workspace/vdsm_master_check-patch-fc25-x86_64/vdsm/tests/qemuimg_test.py", line 428, in test_commit
18:20:56 self.assertEqual(os.stat(vol).st_blocks, blocks)
18:20:56 AssertionError: 648 != 776
--
To view, visit https://gerrit.ovirt.org/77421
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8252b9b086840fe608d6a4a4cfa162da32aed587
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horacek <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
6 years, 10 months
Change in vdsm[master]: network: isolate libnl bindings, *2str functions
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: network: isolate libnl bindings, *2str functions
......................................................................
network: isolate libnl bindings, *2str functions
Change-Id: Iac4aa41657a435d69f4a791b5552fe09e7e5083e
Signed-off-by: Petr Horacek <phoracek(a)redhat.com>
---
M lib/vdsm/network/netlink/__init__.py
M lib/vdsm/network/netlink/addr.py
M lib/vdsm/network/netlink/libnl.py
M lib/vdsm/network/netlink/link.py
M lib/vdsm/network/netlink/route.py
5 files changed, 123 insertions(+), 91 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Petr Horáček: Verified
Edward Haas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/76829
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iac4aa41657a435d69f4a791b5552fe09e7e5083e
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horacek <phoracek(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 10 months
Change in vdsm[master]: network: isolate libnl bindings, error function
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: network: isolate libnl bindings, error function
......................................................................
network: isolate libnl bindings, error function
Also use nl_geterror with error code argument, since nl_geterror
without arguments is not documented in libnl codebase.
Change-Id: I1429d694a9deedb6509dc659fc9255631ac972e5
Signed-off-by: Petr Horacek <phoracek(a)redhat.com>
---
M lib/vdsm/network/netlink/Makefile.am
M lib/vdsm/network/netlink/__init__.py
M lib/vdsm/network/netlink/addr.py
A lib/vdsm/network/netlink/libnl.py
M lib/vdsm/network/netlink/link.py
M lib/vdsm/network/netlink/monitor.py
M lib/vdsm/network/netlink/route.py
M vdsm.spec.in
8 files changed, 100 insertions(+), 35 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Petr Horáček: Verified
Edward Haas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/76828
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1429d694a9deedb6509dc659fc9255631ac972e5
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horacek <phoracek(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 10 months
Change in vdsm[master]: net: Use cmd.exec_* in networkmanager module
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: Use cmd.exec_* in networkmanager module
......................................................................
net: Use cmd.exec_* in networkmanager module
Change-Id: I41af146dd5ffc588314b6cb5ef6acf249eca7405
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
---
M lib/vdsm/network/nm/networkmanager.py
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Petr Horáček: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, approved
Edward Haas: Verified
--
To view, visit https://gerrit.ovirt.org/77292
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I41af146dd5ffc588314b6cb5ef6acf249eca7405
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 10 months
Change in vdsm[master]: net: Use cmd.exec_* in vsctl module
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: Use cmd.exec_* in vsctl module
......................................................................
net: Use cmd.exec_* in vsctl module
Change-Id: I1b0b2fe55b274828abe53622a7e4557c2b8dc0b8
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
---
M lib/vdsm/network/ovs/driver/vsctl.py
1 file changed, 4 insertions(+), 3 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Petr Horáček: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, approved
Edward Haas: Verified
--
To view, visit https://gerrit.ovirt.org/77293
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1b0b2fe55b274828abe53622a7e4557c2b8dc0b8
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 10 months
Change in vdsm[master]: net: Use cmd.exec_* in ipwrapper module
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: Use cmd.exec_* in ipwrapper module
......................................................................
net: Use cmd.exec_* in ipwrapper module
netns_exec has been modified to use an async executor in the form of
Popen.
Change-Id: I50b4fe3eadb629673d3d45c255403f4fb35c5131
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
---
M lib/vdsm/network/ipwrapper.py
M tests/network/nettestlib.py
2 files changed, 33 insertions(+), 38 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Petr Horáček: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, approved
Edward Haas: Verified
--
To view, visit https://gerrit.ovirt.org/77295
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I50b4fe3eadb629673d3d45c255403f4fb35c5131
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 10 months
Change in vdsm[master]: net: Use cmd.exec_* in tc package
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: Use cmd.exec_* in tc package
......................................................................
net: Use cmd.exec_* in tc package
Change-Id: Ib70d6a30013ee8c1b988549e7f2a03005ba6b86b
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
---
M lib/vdsm/network/tc/_wrapper.py
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Petr Horáček: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, approved
Edward Haas: Verified
--
To view, visit https://gerrit.ovirt.org/77294
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib70d6a30013ee8c1b988549e7f2a03005ba6b86b
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 10 months
Change in vdsm[master]: net: Use cmd.exec_* in ipwrapper module
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: Use cmd.exec_* in ipwrapper module
......................................................................
Patch Set 9: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/77295
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I50b4fe3eadb629673d3d45c255403f4fb35c5131
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
6 years, 10 months
Change in vdsm[master]: net: Use cmd.exec_* in tc package
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: Use cmd.exec_* in tc package
......................................................................
Patch Set 9: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/77294
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib70d6a30013ee8c1b988549e7f2a03005ba6b86b
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
6 years, 10 months