Change in vdsm[master]: virt: devices: smartcard: add from_xml_tree
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: virt: devices: smartcard: add from_xml_tree
......................................................................
Patch Set 30: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/72957
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I59b5de1581c1a7efd05a89a2a5e0c895a85ccc3e
Gerrit-PatchSet: 30
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
6 years, 11 months
Change in vdsm[master]: virt: devices: controller: add from_xml_tree
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: virt: devices: controller: add from_xml_tree
......................................................................
Patch Set 30: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/72956
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I30c844a427c3543724160d4cb5ae8e99972fa525
Gerrit-PatchSet: 30
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
6 years, 11 months
Change in vdsm[master]: pylint: v2v: fix missing attributes
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: pylint: v2v: fix missing attributes
......................................................................
pylint: v2v: fix missing attributes
Fixes a pylint bug: some exception do not have one required attribute.
Change-Id: I843dbc32112198740daea4ade5664f25174462d9
Backport-To: 4.1
Signed-off-by: Francesco Romani <fromani(a)redhat.com>
---
M lib/vdsm/v2v.py
M tests/v2v_test.py
2 files changed, 19 insertions(+), 0 deletions(-)
Approvals:
Nir Soffer: Looks good to me, approved
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, but someone else must approve
Francesco Romani: Verified
--
To view, visit https://gerrit.ovirt.org/76305
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I843dbc32112198740daea4ade5664f25174462d9
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 11 months
Change in vdsm[master]: pylint: v2v: initialize attribute in __init__
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: pylint: v2v: initialize attribute in __init__
......................................................................
pylint: v2v: initialize attribute in __init__
pylint was complaining about a missing attribute, this
patch fixes that making the code a bit easier to follow.
Change-Id: I54c58549ad2dbd85bbf7e1d0663dfefefde02ab1
Signed-off-by: Francesco Romani <fromani(a)redhat.com>
---
M lib/vdsm/v2v.py
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Nir Soffer: Looks good to me, approved
Jenkins CI: Passed CI tests
Francesco Romani: Verified
--
To view, visit https://gerrit.ovirt.org/76186
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I54c58549ad2dbd85bbf7e1d0663dfefefde02ab1
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 11 months
Change in vdsm[master]: pylint: vm: simplify the exception flow
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: pylint: vm: simplify the exception flow
......................................................................
pylint: vm: simplify the exception flow
Reorganize the exception flow to make it (a bit) easier to follow,
and to make pylint happy.
Change-Id: Ib35036f35be4df6462676018eb4d0b69fc69bf65
Signed-off-by: Francesco Romani <fromani(a)redhat.com>
---
M vdsm/virt/vm.py
1 file changed, 16 insertions(+), 6 deletions(-)
Approvals:
Nir Soffer: Looks good to me, approved
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, but someone else must approve
Francesco Romani: Verified
--
To view, visit https://gerrit.ovirt.org/76185
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib35036f35be4df6462676018eb4d0b69fc69bf65
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 11 months
Change in vdsm[master]: ssl: improve certificate check
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: ssl: improve certificate check
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/76307
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib302f5c134ef8a03d2721f67af7771c09ffe52fb
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
6 years, 11 months
Change in vdsm[master]: ssl: improve certificate check
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: ssl: improve certificate check
......................................................................
Patch Set 1: Code-Review-1
itertools.concat could have been a bit cooler, but I like the patch.
You should add a test for multi-named host though.
--
To view, visit https://gerrit.ovirt.org/76307
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib302f5c134ef8a03d2721f67af7771c09ffe52fb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
6 years, 11 months
Change in vdsm[master]: pylint: v2v: fix missing attributes
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: pylint: v2v: fix missing attributes
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/76305
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I843dbc32112198740daea4ade5664f25174462d9
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
6 years, 11 months
Change in vdsm[master]: pylint: virt: fix missing attribute
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: pylint: virt: fix missing attribute
......................................................................
pylint: virt: fix missing attribute
Let's initialize the attribute in __init__ instead of using hasattr.
Change-Id: Iad67878fd053e28205384fa3e7e8375651348c66
Signed-off-by: Francesco Romani <fromani(a)redhat.com>
---
M lib/vdsm/virt/vmdevices/storage.py
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Nir Soffer: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
Francesco Romani: Verified
--
To view, visit https://gerrit.ovirt.org/76184
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iad67878fd053e28205384fa3e7e8375651348c66
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 11 months
Change in vdsm[master]: ssl: client cert check for IPv4 mapped addresses
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: ssl: client cert check for IPv4 mapped addresses
......................................................................
Patch Set 9:
(3 comments)
https://gerrit.ovirt.org/#/c/76197/9/lib/vdsm/sslutils.py
File lib/vdsm/sslutils.py:
PS9, Line 255: [0]
unrelated, but we should replace this with
return any(cert_common_name.lower() == hostname.lower() for hostname in socket.gethostbyaddr(src_addr))
to allow hosts with multiple names.
Line 254: return (cert_common_name.lower() ==
Line 255: socket.gethostbyaddr(src_addr)[0].lower())
Line 256:
Line 257: @staticmethod
Line 258: def _ip_address_normalization(addr):
nit: functions should better be named as verbs, e.g. normalize_ip_address, not nouns.
Line 259: """
Line 260: When we used mapped ipv4 (starting with ::FFFF/96) we need to
Line 261: normalize it to ipv4 in order to compare it with value used
Line 262: in commonName in the certificate.
Line 265: ip = IPAddress(addr)
Line 266: if ip.is_ipv4_mapped():
Line 267: addr = str(ip.ipv4())
Line 268: except AddrFormatError:
Line 269: # used name not address
this applies only to cert_common_name, never to src_name.
I think this exception-andling should be taken to compare_names, which should run
return (cert_common_name.lower() ==
socket.gethostbyaddr(src_addr)[0].lower())
in the "except" clause.
Line 270: pass
Line 271:
Line 272: return addr
Line 273:
--
To view, visit https://gerrit.ovirt.org/76197
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic012664db7181ab703ec4de53a0ba7c225bb73f9
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
6 years, 11 months