Change in vdsm[master]: net: Embed vdsm-restore-net-config into vdsm.network
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: Embed vdsm-restore-net-config into vdsm.network
......................................................................
net: Embed vdsm-restore-net-config into vdsm.network
vdsm-restore-net-config has been run as an executable.
This patch moved the executable python file into vdsm.network
package and runs it by importing & calling it.
Change-Id: I9c3d0ca93179aeb98a89f68265e368d13924f21e
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
---
M lib/vdsm/network/Makefile.am
M lib/vdsm/network/api.py
R lib/vdsm/network/restore_net_config.py
M lib/vdsm/supervdsm_api/network.py
M lib/vdsm/tool/network.py
M tests/functional/networkTests.py
M tox.ini
M vdsm.spec.in
M vdsm/Makefile.am
9 files changed, 31 insertions(+), 75 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
Edward Haas: Verified
--
To view, visit https://gerrit.ovirt.org/76085
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9c3d0ca93179aeb98a89f68265e368d13924f21e
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 11 months
Change in vdsm[master]: tool net: Output to stderr when logging setup fails for rest...
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: tool net: Output to stderr when logging setup fails for restore-net
......................................................................
tool net: Output to stderr when logging setup fails for restore-net
Change-Id: I7cf09b491b0df7e764c13dd921dd1bab9b958ab8
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
---
M lib/vdsm/tool/network.py
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Petr Horáček: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, approved
Edward Haas: Verified
--
To view, visit https://gerrit.ovirt.org/76179
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7cf09b491b0df7e764c13dd921dd1bab9b958ab8
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 11 months
Change in vdsm[master]: tool net: Output to stderr when logging setup fails for rest...
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: tool net: Output to stderr when logging setup fails for restore-net
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/76179
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7cf09b491b0df7e764c13dd921dd1bab9b958ab8
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
6 years, 11 months
Change in vdsm[master]: net: Embed vdsm-restore-net-config into vdsm.network
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: Embed vdsm-restore-net-config into vdsm.network
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/76085
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9c3d0ca93179aeb98a89f68265e368d13924f21e
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
6 years, 11 months