Change in vdsm[master]: net: Use cmd.exec_* in vsctl module
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: Use cmd.exec_* in vsctl module
......................................................................
Patch Set 9: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/77293
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1b0b2fe55b274828abe53622a7e4557c2b8dc0b8
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
6 years, 11 months
Change in vdsm[master]: net: Use cmd.exec_* in networkmanager module
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: Use cmd.exec_* in networkmanager module
......................................................................
Patch Set 9: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/77292
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I41af146dd5ffc588314b6cb5ef6acf249eca7405
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
6 years, 11 months
Change in vdsm[master]: net: Use cmd.exec_* in ifcfg module
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: Use cmd.exec_* in ifcfg module
......................................................................
net: Use cmd.exec_* in ifcfg module
Change-Id: I92282be9331b5b38f909b5bb09e5e68e996bf692
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
---
M lib/vdsm/network/configurators/ifcfg.py
1 file changed, 11 insertions(+), 17 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Petr Horáček: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, approved
Edward Haas: Verified
--
To view, visit https://gerrit.ovirt.org/77290
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I92282be9331b5b38f909b5bb09e5e68e996bf692
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 11 months
Change in vdsm[master]: net: Use cmd.exec_* in link.dpdk module
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: Use cmd.exec_* in link.dpdk module
......................................................................
net: Use cmd.exec_* in link.dpdk module
Change-Id: Ib657f6dc4d2be207a2c8656aea5224c4788baf1f
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
---
M lib/vdsm/network/link/dpdk.py
M tests/network/dpdk_test.py
2 files changed, 5 insertions(+), 5 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Irit Goihman: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, approved
Edward Haas: Verified
--
To view, visit https://gerrit.ovirt.org/77291
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib657f6dc4d2be207a2c8656aea5224c4788baf1f
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 11 months
Change in vdsm[master]: net: Use cmd.exec_* in link.dpdk module
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: Use cmd.exec_* in link.dpdk module
......................................................................
Patch Set 9: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/77291
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib657f6dc4d2be207a2c8656aea5224c4788baf1f
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
6 years, 11 months
Change in vdsm[master]: net: Use cmd.exec_* in ifcfg module
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: Use cmd.exec_* in ifcfg module
......................................................................
Patch Set 9: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/77290
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I92282be9331b5b38f909b5bb09e5e68e996bf692
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
6 years, 11 months
Change in vdsm[master]: janitorial: drop another unused constant
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has uploaded a new change for review.
Change subject: janitorial: drop another unused constant
......................................................................
janitorial: drop another unused constant
Prehistoric commit 806420 stopped using this constant.
Change-Id: I1fbdeaf372f8a133f6fad05ac09b83fe739f54c1
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com>
---
M lib/vdsm/storage/lvm.py
1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/31/77431/1
diff --git a/lib/vdsm/storage/lvm.py b/lib/vdsm/storage/lvm.py
index d0e8ca4..b01bb94 100644
--- a/lib/vdsm/storage/lvm.py
+++ b/lib/vdsm/storage/lvm.py
@@ -85,7 +85,6 @@
# VG states
VG_OK = "OK"
VG_PARTIAL = "PARTIAL"
-VG_UNKNOWN = "UNKNOWN"
SEPARATOR = "|"
LVM_NOBACKUP = ("--autobackup", "n")
--
To view, visit https://gerrit.ovirt.org/77431
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1fbdeaf372f8a133f6fad05ac09b83fe739f54c1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
6 years, 11 months
Change in vdsm[master]: janitorial: drop unused constant
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has uploaded a new change for review.
Change subject: janitorial: drop unused constant
......................................................................
janitorial: drop unused constant
vdsmcert is defined twice in constants.py, only one definition is ever
used.
Change-Id: Iff7080b6d30a809e1660e924abecc72d9b64e34d
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com>
---
M lib/vdsm/constants.py.in
1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/30/77430/1
diff --git a/lib/vdsm/constants.py.in b/lib/vdsm/constants.py.in
index f2423cf..7c0d209 100644
--- a/lib/vdsm/constants.py.in
+++ b/lib/vdsm/constants.py.in
@@ -83,7 +83,6 @@
P_VDSM_STORAGE = os.path.join(P_VDSM_RUN, 'storage/')
P_VDSM_CONF = '@CONFDIR@/' # NOQA: E501 (potentially long line)
P_VDSM_KEYS = '/etc/pki/vdsm/keys/'
-P_VDSM_CERT = '/etc/pki/vdsm/certs/vdsmcert.pem'
P_VDSM_CLIENT_LOG = '@VDSMRUNDIR(a)/client.log' # NOQA: E501 (potentially long line)
P_VDSM_LOG = '@VDSMLOGDIR@' # NOQA: E501 (potentially long line)
--
To view, visit https://gerrit.ovirt.org/77430
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iff7080b6d30a809e1660e924abecc72d9b64e34d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
6 years, 11 months
Change in vdsm[master]: net api: introduce remove_ovs_port function
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net api: introduce remove_ovs_port function
......................................................................
net api: introduce remove_ovs_port function
remove_ovs_port is needed for vhostuser port.
In this case, the port isn't deleted automatically when
vm is destroyed and we need to call this function explicitly.
Change-Id: Ie39d7922e539eea4c0676d5769f5d03557181e28
Signed-off-by: Irit Goihman <igoihman(a)redhat.com>
---
M lib/vdsm/network/api.py
M lib/vdsm/network/netswitch/configurator.py
M lib/vdsm/network/ovs/switch.py
M lib/vdsm/supervdsm_api/network.py
4 files changed, 17 insertions(+), 1 deletion(-)
Approvals:
Jenkins CI: Passed CI tests
Irit Goihman: Verified
Edward Haas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/77261
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie39d7922e539eea4c0676d5769f5d03557181e28
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 11 months
Change in vdsm[master]: net api: introduce add_ovs_vhostuser_port command
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net api: introduce add_ovs_vhostuser_port command
......................................................................
net api: introduce add_ovs_vhostuser_port command
The function is responsoble for adding a vhostuser
interface to ovs bridge.
Change-Id: I489fc9f7c6cc91749475beddb967d5e4ff0d2b14
Signed-off-by: Irit Goihman <igoihman(a)redhat.com>
---
M lib/vdsm/network/api.py
M lib/vdsm/network/netswitch/configurator.py
M lib/vdsm/network/ovs/switch.py
M lib/vdsm/supervdsm_api/network.py
4 files changed, 18 insertions(+), 1 deletion(-)
Approvals:
Jenkins CI: Passed CI tests
Irit Goihman: Verified
Edward Haas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/77419
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I489fc9f7c6cc91749475beddb967d5e4ff0d2b14
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 11 months