Change in vdsm[master]: net: Use cmd.exec_* in dhclient module
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: Use cmd.exec_* in dhclient module
......................................................................
net: Use cmd.exec_* in dhclient module
Change-Id: I432d569643988d51dde50b3588342b580573bfa0
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
---
M lib/vdsm/network/ip/dhclient.py
1 file changed, 7 insertions(+), 9 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Petr Horáček: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, approved
Edward Haas: Verified
--
To view, visit https://gerrit.ovirt.org/77289
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I432d569643988d51dde50b3588342b580573bfa0
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 11 months
Change in vdsm[master]: net: Introduce a simplified cmd exec implementation
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: Introduce a simplified cmd exec implementation
......................................................................
net: Introduce a simplified cmd exec implementation
The network package is frequently utilizing the execCmd function to
execute shell based commands.
This patch introduces a simplified version of execCmd, focused on the
limited needs of the network package.
The new cmd module exposes a blocking exec function (exec_sync) and a
systemd exec function.
In the following patches, the users of execCmd will get migrated to the
new cmd module implementations, reducing the dependency on the generic
VDSM libs.
Change-Id: I37380d51b648bd64792b6c26419dd33c96392ddd
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
---
M lib/vdsm/network/Makefile.am
A lib/vdsm/network/cmd.py
A tests/network/cmd_test.py
M vdsm.spec.in
4 files changed, 104 insertions(+), 0 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
Edward Haas: Verified
Objections:
Petr Horáček: I would prefer that you didn't submit this
--
To view, visit https://gerrit.ovirt.org/77288
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I37380d51b648bd64792b6c26419dd33c96392ddd
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 11 months
Change in vdsm[master]: net: Use cmd.exec_* in dhclient module
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: Use cmd.exec_* in dhclient module
......................................................................
Patch Set 6: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/77289
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I432d569643988d51dde50b3588342b580573bfa0
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
6 years, 11 months
Change in vdsm[master]: net: Run NM tests only if systemctl is available
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: Run NM tests only if systemctl is available
......................................................................
net: Run NM tests only if systemctl is available
NM tests have been excluded from the 'check' test pool by marking them
as functional. But this approach in practice expluded them from ever
running.
This patch checks for the availability of systemctl and skips the test
module if not available.
Nodes that do not have NM running, should skip these tests.
Change-Id: Ib92d10cc962d1c0743bdb854fa5bc77ad83d9d6f
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
---
M tests/network/nettestlib.py
M tests/network/nm_test.py
M tests/network/nmdbus_test.py
3 files changed, 25 insertions(+), 9 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Petr Horáček: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, approved
Edward Haas: Verified
--
To view, visit https://gerrit.ovirt.org/77208
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib92d10cc962d1c0743bdb854fa5bc77ad83d9d6f
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 11 months
Change in vdsm[master]: net test: Modify and clean TestNMConnectionSettings tests
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net test: Modify and clean TestNMConnectionSettings tests
......................................................................
net test: Modify and clean TestNMConnectionSettings tests
Cleaning up some of the tests overhead and complexity by using the
nm_connections returned value (the list of created connections).
Change-Id: I845e2cf34836a2b74def7cacddd4beb952decc63
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
---
M tests/network/nmdbus_test.py
1 file changed, 20 insertions(+), 32 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Petr Horáček: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, approved
Edward Haas: Verified
--
To view, visit https://gerrit.ovirt.org/77283
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I845e2cf34836a2b74def7cacddd4beb952decc63
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 11 months
Change in vdsm[master]: net: Introduce a simplified cmd exec implementation
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: Introduce a simplified cmd exec implementation
......................................................................
Patch Set 6: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/77288
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I37380d51b648bd64792b6c26419dd33c96392ddd
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
6 years, 11 months
Change in vdsm[master]: net test: Modify and clean TestNMConnectionSettings tests
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net test: Modify and clean TestNMConnectionSettings tests
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/77283
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I845e2cf34836a2b74def7cacddd4beb952decc63
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
6 years, 11 months
Change in vdsm[master]: net: Run NM tests only if systemctl is available
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: Run NM tests only if systemctl is available
......................................................................
Patch Set 10: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/77208
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib92d10cc962d1c0743bdb854fa5bc77ad83d9d6f
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
6 years, 11 months
Change in vdsm[master]: net: Introduce a simplified cmd exec implementation
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: Introduce a simplified cmd exec implementation
......................................................................
Patch Set 6: Code-Review+1
I hate raw=False, and other modifications of returning type, anyway. Please do NOT introduce raw and sync to network.execcmd.
--
To view, visit https://gerrit.ovirt.org/77288
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I37380d51b648bd64792b6c26419dd33c96392ddd
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
6 years, 11 months
Change in vdsm[master]: net: Remove iproute2 configurator
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: Remove iproute2 configurator
......................................................................
net: Remove iproute2 configurator
ifcfg and iproute2 are the existing available net configurators but
iproute2 has not been maintained (or tested) for some time now.
It is also not in use by any module.
As we plan to replace the configurators as defined today, there is no
reason to keep iproute2 in the code base.
Change-Id: I8a5de53fa64a74fffbf97ca9655a7303f17ae25c
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
---
M lib/vdsm/config.py.in
M lib/vdsm/network/configurators/Makefile.am
D lib/vdsm/network/configurators/iproute2.py
M lib/vdsm/network/legacy_switch.py
M lib/vdsm/network/netswitch/configurator.py
M lib/vdsm/network/sourceroute.py
M tests/Makefile.am
M tests/functional/networkTests.py
M tests/network/config_network_test.py
M tests/network/func_dns_test.py
D tests/network/iproute2_test.py
M vdsm.spec.in
12 files changed, 18 insertions(+), 467 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Petr Horáček: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, approved
Edward Haas: Verified
--
To view, visit https://gerrit.ovirt.org/77152
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8a5de53fa64a74fffbf97ca9655a7303f17ae25c
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 11 months