Change in vdsm[master]: net: Remove iproute2 configurator
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: Remove iproute2 configurator
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/77152
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8a5de53fa64a74fffbf97ca9655a7303f17ae25c
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
6 years, 11 months
Change in vdsm[master]: net: Use cmd.exec_* in ipwrapper module
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: Use cmd.exec_* in ipwrapper module
......................................................................
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/77295/4/lib/vdsm/network/ipwrapper.py
File lib/vdsm/network/ipwrapper.py:
Line 613: def netns_delete(name):
Line 614: _exec_cmd([_IP_BINARY.cmd, 'netns', 'delete', name])
Line 615:
Line 616:
Line 617: def netns_exec(netns_name, command):
the async behavior is very odd, and worths a docstring alert
Line 618: cmds = [_IP_BINARY.cmd, 'netns', 'exec', netns_name] + command
Line 619: return Popen(cmds)
Line 620:
Line 621:
--
To view, visit https://gerrit.ovirt.org/77295
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I50b4fe3eadb629673d3d45c255403f4fb35c5131
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
6 years, 11 months
Change in vdsm[master]: net: Use cmd.exec_* in ipwrapper module
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: Use cmd.exec_* in ipwrapper module
......................................................................
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/77295
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I50b4fe3eadb629673d3d45c255403f4fb35c5131
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
6 years, 11 months
Change in vdsm[master]: net: Use cmd.exec_* in link.dpdk module
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: Use cmd.exec_* in link.dpdk module
......................................................................
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/77291
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib657f6dc4d2be207a2c8656aea5224c4788baf1f
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
6 years, 11 months
Change in vdsm[master]: net: Use cmd.exec_* in ifcfg module
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: Use cmd.exec_* in ifcfg module
......................................................................
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/77290
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I92282be9331b5b38f909b5bb09e5e68e996bf692
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
6 years, 11 months
Change in vdsm[master]: net: Use cmd.exec_* in dhclient module
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: Use cmd.exec_* in dhclient module
......................................................................
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/77289
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I432d569643988d51dde50b3588342b580573bfa0
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
6 years, 11 months
Change in vdsm[master]: net: Introduce a simplified cmd exec implementation
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: Introduce a simplified cmd exec implementation
......................................................................
Patch Set 4: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/77288/4/lib/vdsm/network/cmd.py
File lib/vdsm/network/cmd.py:
PS4, Line 36: None
I don't think that out can ever be None with stdout=subprocess.PIPE, so I prefer not to handle this case.
And if we're forced to squash here None into the empty string, we probably have to do the same to stderr.
--
To view, visit https://gerrit.ovirt.org/77288
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I37380d51b648bd64792b6c26419dd33c96392ddd
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
6 years, 11 months
Change in vdsm[master]: net test: Use a single slave in the NM vlan-bond-slave sync ...
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net test: Use a single slave in the NM vlan-bond-slave sync test
......................................................................
net test: Use a single slave in the NM vlan-bond-slave sync test
The test_add_net_based_on_existing_vlan_bond_nm_setup test has randomly
failed due to the slaves mac address swap (the bond mac is assigned
based on the first slave added).
Until the NM and ifcfg/initscripts use a consitent order to load the
slaves, the test will use a single slave.
Note that the test itself was focused on the vlan iface mac being
identical to the bond mac and not on the consistency of the slave load
order.
Change-Id: I65ef31973198914e22d0d8da08b6a81e386ca533
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
---
M tests/network/func_net_basic_test.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jenkins CI: Passed CI tests
Petr Horáček: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, approved
Edward Haas: Verified
--
To view, visit https://gerrit.ovirt.org/77089
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I65ef31973198914e22d0d8da08b6a81e386ca533
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 11 months
Change in vdsm[master]: net test: Refactor NM tests and its test lib
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net test: Refactor NM tests and its test lib
......................................................................
net test: Refactor NM tests and its test lib
The patch includes NM tests setup and teardown functionality, making
sure the resources are cleaned from the VDSM configuration.
The dummy nics that have been used as slaves to the NM bond are now
created at the test level (and not in the test lib) to allow more
control and reduce the complexity in the test lib.
Change-Id: I6dd262c40607088613ab9be4f1911e11f1926e47
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
---
M tests/network/func_net_basic_test.py
M tests/network/nm_test.py
M tests/network/nmdbus_test.py
M tests/network/nmnettestlib.py
4 files changed, 136 insertions(+), 118 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Petr Horáček: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, approved
Edward Haas: Verified
--
To view, visit https://gerrit.ovirt.org/77088
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6dd262c40607088613ab9be4f1911e11f1926e47
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 11 months
Change in vdsm[master]: net: Wait for link-up when creating a bond through link.bond
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: Wait for link-up when creating a bond through link.bond
......................................................................
net: Wait for link-up when creating a bond through link.bond
The test _test_add_network_with_multiple_vlans_over_a_bond failed
frequently while NM is running due to the bond iface link state (it was
down).
This patch gives the bond a chance to update its link state to UP before
the setup flow continues (giving a 2 sec timeout).
Change-Id: I7d8e1fe47881ff4e133524fca4a070d481e84e15
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
---
M lib/vdsm/network/link/bond/__init__.py
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Jenkins CI: Passed CI tests
Petr Horáček: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, approved
Edward Haas: Verified
--
To view, visit https://gerrit.ovirt.org/77092
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7d8e1fe47881ff4e133524fca4a070d481e84e15
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 11 months