vdsm-patches June 2017

vdsm-patches@lists.fedorahosted.org

1 participants
244 discussions

Change in vdsm[master]: mailbox: Make run() private
by Code Review 29 Jun '17

29 Jun '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/78799 ) Change subject: mailbox: Make run() private ...................................................................... mailbox: Make run() private The run() method of the mailbox threads is not part of the interface; it is used as the thread target function, and it should not be invoked by any other code. Rename the methods to make this clear. Change-Id: Ie954296eb54341c9277d05819660ccf86d89828d Signed-off-by: Nir Soffer <nsoffer(a)redhat.com> --- M lib/vdsm/storage/mailbox.py 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Adam Litke: Looks good to me, approved Nir Soffer: Verified Jenkins CI: Passed CI tests Freddy Rolland: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/78799 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie954296eb54341c9277d05819660ccf86d89828d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in vdsm[master]: tests: Mark slow and stress tests using pytest.mark
by Code Review 29 Jun '17

29 Jun '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/78633 ) Change subject: tests: Mark slow and stress tests using pytest.mark ...................................................................... tests: Mark slow and stress tests using pytest.mark Replace @slowtest and @stresstest with pytest.marks. When running from tox, slow and stress tests do not run but are not skipped; instead these they are reported as "deselected": 314 passed, 40 skipped, 91 deselected, 29 warnings in 22.40 seconds When running directly, for example when running a single module tests, all tests run by default: $ pytest storage/asyncevent_test.py ==================================================================================== test session starts ===================================================================================== platform linux -- Python 3.5.3, pytest-3.1.0, py-1.4.33, pluggy-0.4.0 rootdir: /home/nsoffer/src/vdsm/tests, inifile: collected 67 items storage/asyncevent_test.py ................................................................... ================================================================================= 67 passed in 8.38 seconds ================================================================================== To run only fast tests, disable slow or stress tests: $ pytest -m "not (slow or stress)" storage/asyncevent_test.py ==================================================================================== test session starts ===================================================================================== platform linux -- Python 3.5.3, pytest-3.1.0, py-1.4.33, pluggy-0.4.0 rootdir: /home/nsoffer/src/vdsm/tests, inifile: collected 67 items storage/asyncevent_test.py ................................ ==================================================================================== 35 tests deselected ===================================================================================== ========================================================================== 32 passed, 35 deselected in 0.92 seconds ========================================================================== Change-Id: I57eac4ad7eeadc4f95000d8bedc1651ecb8bcf60 Signed-off-by: Nir Soffer <nsoffer(a)redhat.com> --- M tests/storage/asyncevent_test.py M tests/storage/asyncutils_test.py M tests/storage/blockvolume_test.py M tests/storage/check_test.py M tests/storage/mount_test.py M tests/storage/qcow2_test.py M tests/storage/resourcemanager_test.py M tests/storage/rwlock_test.py M tests/storage/xlease_test.py M tox.ini 10 files changed, 57 insertions(+), 48 deletions(-) Approvals: Adam Litke: Looks good to me, approved Nir Soffer: Verified Jenkins CI: Passed CI tests Irit Goihman: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/78633 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I57eac4ad7eeadc4f95000d8bedc1651ecb8bcf60 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in vdsm[master]: python3: Run iscsi_test on python 3
by Code Review 29 Jun '17

29 Jun '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has posted comments on this change. Change subject: python3: Run iscsi_test on python 3 ...................................................................... Patch Set 10: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/78629 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia6716d1bfdee1507e3906f06237cc1181ad5515f Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-HasComments: No

1 0

Change in vdsm[master]: hugepages: add support for shared pages
by Code Review 29 Jun '17

29 Jun '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/77808 ) Change subject: hugepages: add support for shared pages ...................................................................... hugepages: add support for shared pages When we create a VM with a vhostuser vnic banckend, we need shared hugepages in order to enable communication. In order to enable it, we require a 'hugepages_shared' custom property. The configuration on engine host is as follows: $ engine-config -s "UserDefinedVMProperties=hugepages=[0-9];hugepages_shared=(true|false)" Change-Id: Ib0eb7b20a16e3e4a0d57da02ff7490136071dd8f Signed-off-by: Irit Goihman <igoihman(a)redhat.com> --- M lib/vdsm/virt/libvirtxml.py M tests/vm_test.py M vdsm/virt/vm.py 3 files changed, 37 insertions(+), 5 deletions(-) Approvals: Jenkins CI: Passed CI tests Irit Goihman: Verified Francesco Romani: Looks good to me, approved Martin Polednik: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/77808 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib0eb7b20a16e3e4a0d57da02ff7490136071dd8f Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in vdsm[master]: gluster: add vdsm apis for webhooks in gluster eventing
by Code Review 29 Jun '17

29 Jun '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/67168 ) Change subject: gluster: add vdsm apis for webhooks in gluster eventing ...................................................................... gluster: add vdsm apis for webhooks in gluster eventing Webhooks can be registered in glusterfs to receive various events generated to gluster. This patchs adds the required vdsm verbs to support add, update, delete and syncing of webhooks. This needs glusterfs-events pacakges to be installed on the glusterfs servers. Change-Id: I239d77feacf7698b69b4fb224f6762026c2c78f9 Bug-Url: https://bugzilla.redhat.com/1379309 Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com> --- M automation/check-patch.repos.el7 M lib/vdsm/api/vdsm-api-gluster.yml M lib/vdsm/gluster/Makefile.am M lib/vdsm/gluster/__init__.py M lib/vdsm/gluster/api.py M lib/vdsm/gluster/apiwrapper.py A lib/vdsm/gluster/events.py M lib/vdsm/gluster/exception.py M vdsm.spec.in 9 files changed, 194 insertions(+), 10 deletions(-) Approvals: Piotr Kliczewski: Looks good to me, approved Jenkins CI: Passed CI tests Sahina Bose: Verified -- To view, visit https://gerrit.ovirt.org/67168 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I239d77feacf7698b69b4fb224f6762026c2c78f9 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ramesh N <ramesh.mail2u(a)gmail.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Ramesh N <ramesh.mail2u(a)gmail.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in vdsm[master]: tests: Fix mailbox thread leak test
by Code Review 28 Jun '17

28 Jun '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has posted comments on this change. Change subject: tests: Fix mailbox thread leak test ...................................................................... Patch Set 7: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/78589 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I67aaf03e382c730757e8d3d208267d177ea325c6 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-HasComments: No

1 0

Change in vdsm[master]: place sos plugin under lib
by Code Review 28 Jun '17

28 Jun '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has uploaded a new change for review. Change subject: place sos plugin under lib ...................................................................... place sos plugin under lib Change-Id: Ide3f93d8d737e6e3b86c04e3751ef9bc8f774b09 Signed-off-by: Dan Kenigsberg <danken(a)redhat.com> --- M .gitignore M configure.ac M lib/Makefile.am R lib/sos/Makefile.am R lib/sos/vdsm.py.in M vdsm/Makefile.am 6 files changed, 4 insertions(+), 5 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/86/78586/1 diff --git a/.gitignore b/.gitignore index 7251e4f..55117bf 100644 --- a/.gitignore +++ b/.gitignore @@ -31,6 +31,7 @@ lib/vdsm/config.py lib/vdsm/constants.py lib/vdsm/dsaversion.py +lib/vdsm/sos/vdsm.py lib/vdsm/storage/lvm.env lib/vdsm/storage/protect/spmprotect.sh lib/vdsm/storage/vdsm-lvm.rules @@ -71,10 +72,8 @@ tests/other.key vdsm-*.tar.gz vdsm.spec -vdsm/sos/vdsm.py vdsm/vdscli.py vdsm/vdsm-gencerts.sh -vdsm/vdsm-sosplugin.py static/usr/share/man/man1/vdsm-tool.1 static/usr/share/man/man8/vdsmd.8 vdsm/rpc/vdsm-api.html diff --git a/configure.ac b/configure.ac index d65324f..8cad1ca 100644 --- a/configure.ac +++ b/configure.ac @@ -373,6 +373,7 @@ init/Makefile init/systemd/Makefile lib/Makefile + lib/sos/Makefile lib/vdsm/Makefile lib/vdsm/api/Makefile lib/vdsm/common/Makefile @@ -429,7 +430,6 @@ tests/storage/Makefile tests/virttests/Makefile vdsm/Makefile - vdsm/sos/Makefile vdsm/virt/Makefile vdsm_hooks/Makefile vdsm_hooks/allocate_net/Makefile diff --git a/lib/Makefile.am b/lib/Makefile.am index 5197896..ed18725 100644 --- a/lib/Makefile.am +++ b/lib/Makefile.am @@ -19,4 +19,4 @@ # include $(top_srcdir)/build-aux/Makefile.subs -SUBDIRS = vdsm vdsmclient yajsonrpc +SUBDIRS = sos vdsm vdsmclient yajsonrpc diff --git a/vdsm/sos/Makefile.am b/lib/sos/Makefile.am similarity index 100% rename from vdsm/sos/Makefile.am rename to lib/sos/Makefile.am diff --git a/vdsm/sos/vdsm.py.in b/lib/sos/vdsm.py.in similarity index 100% rename from vdsm/sos/vdsm.py.in rename to lib/sos/vdsm.py.in diff --git a/vdsm/Makefile.am b/vdsm/Makefile.am index abeaf62..2fe9f54 100644 --- a/vdsm/Makefile.am +++ b/vdsm/Makefile.am @@ -18,7 +18,7 @@ # Refer to the README and COPYING files for full details of the license # -SUBDIRS = sos virt +SUBDIRS = virt include $(top_srcdir)/build-aux/Makefile.subs -- To view, visit https://gerrit.ovirt.org/78586 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ide3f93d8d737e6e3b86c04e3751ef9bc8f774b09 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>

1 4

Change in vdsm[master]: net: Generate dump bonding options on boot and upgrade
by Code Review 28 Jun '17

28 Jun '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has submitted this change and it was merged. Change subject: net: Generate dump bonding options on boot and upgrade ...................................................................... net: Generate dump bonding options on boot and upgrade Compatible bonding options aren't guaranteed across different kernel versions, so a scenario where the kernel is upgraded and incompatible default options are lingering will cause problems. Instead of shipping with default options, dump bonding defaults on boot via network-init service and installation/upgrade via a new dedicated configurator. Bug-Id: https://bugzilla.redhat.com/1458549 Change-Id: I98f7c691a2a86d152ebcb81e1d96f9b0d83fa698 Signed-off-by: Leon Goldberg <lgoldber(a)redhat.com> --- M configure.ac M lib/vdsm/tool/configurators/Makefile.am A lib/vdsm/tool/configurators/bond_defaults.py M static/Makefile.am M static/usr/lib/systemd/system/vdsm-network-init.service.in M tests/network/Makefile.am M tests/network/nettestlib.py A tests/network/static/Makefile.am R tests/network/static/bonding-defaults.json R tests/network/static/bonding-name2numeric.json M vdsm.spec.in 11 files changed, 92 insertions(+), 6 deletions(-) Approvals: Jenkins CI: Passed CI tests Leon Goldberg: Verified Edward Haas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/78006 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I98f7c691a2a86d152ebcb81e1d96f9b0d83fa698 Gerrit-PatchSet: 33 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in vdsm[master]: stomp: introduce restore_subscriptions in client
by Code Review 28 Jun '17

28 Jun '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has submitted this change and it was merged. Change subject: stomp: introduce restore_subscriptions in client ...................................................................... stomp: introduce restore_subscriptions in client restore_subscriptions is required for persisting subscriptions after client reconnects to server. Change-Id: I9815faf5314c3b932067576ef044cf3bee0869e9 Signed-off-by: Irit Goihman <igoihman(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1376843 --- M lib/yajsonrpc/stomp.py M tests/stompasyncclient_test.py 2 files changed, 19 insertions(+), 0 deletions(-) Approvals: Piotr Kliczewski: Looks good to me, approved Jenkins CI: Passed CI tests Irit Goihman: Verified -- To view, visit https://gerrit.ovirt.org/78535 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9815faf5314c3b932067576ef044cf3bee0869e9 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in vdsm[master]: stomp: stop using hard coded values for heartbeats
by Code Review 28 Jun '17

28 Jun '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has submitted this change and it was merged. Change subject: stomp: stop using hard coded values for heartbeats ...................................................................... stomp: stop using hard coded values for heartbeats We wish to support incoming heartbeats in JSONRPC client in order to implement reconnect mechanism. AsyncClient connect method used to send HEARTBEAT header with hard coded values, which are now configurable and enable both ways heartbeats. Change-Id: I19cfec389e9d24d70e64617471df0d1dceb4229f Signed-off-by: Irit Goihman <igoihman(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1376843 --- M lib/yajsonrpc/stomp.py M lib/yajsonrpc/stompreactor.py M tests/stompasyncclient_test.py 3 files changed, 27 insertions(+), 8 deletions(-) Approvals: Piotr Kliczewski: Looks good to me, approved Jenkins CI: Passed CI tests Irit Goihman: Verified -- To view, visit https://gerrit.ovirt.org/78293 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I19cfec389e9d24d70e64617471df0d1dceb4229f Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

vdsm-patches June 2017