Change in vdsm[master]: stomp: handle timeout in server side
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: stomp: handle timeout in server side
......................................................................
stomp: handle timeout in server side
When the server stops receiving incoming heartbeats, it should
cleanup subscriptions and close the fd.
Signed-off-by: Irit Goihman <igoihman(a)redhat.com>
Change-Id: Ic83ccb947771e79cb08d9d9fa3b1da64d074fda5
Bug-Url: https://bugzilla.redhat.com/1376843
---
M lib/yajsonrpc/stompreactor.py
M tests/stompadapter_test.py
2 files changed, 57 insertions(+), 4 deletions(-)
Approvals:
Piotr Kliczewski: Looks good to me, approved
Yaniv Bronhaim: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Irit Goihman: Verified
--
To view, visit https://gerrit.ovirt.org/78614
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic83ccb947771e79cb08d9d9fa3b1da64d074fda5
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 10 months
Change in vdsm[master]: stomp: handle timeout in server side
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: stomp: handle timeout in server side
......................................................................
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/78614
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic83ccb947771e79cb08d9d9fa3b1da64d074fda5
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
6 years, 10 months
Change in vdsm[master]: place [gs]et-conf-item scripts under libexec
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has uploaded a new change for review.
Change subject: place [gs]et-conf-item scripts under libexec
......................................................................
place [gs]et-conf-item scripts under libexec
These are helper scripts used only by vdsm startup script
Change-Id: I983bdca05df8c66e594211243fb99327c9c3d250
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com>
---
M init/vdsmd_init_common.sh.in
M static/Makefile.am
R static/libexec/vdsm/get-conf-item
R static/libexec/vdsm/set-conf-item
M tox.ini
M vdsm.spec.in
M vdsm/Makefile.am
7 files changed, 11 insertions(+), 7 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/50/78550/1
diff --git a/init/vdsmd_init_common.sh.in b/init/vdsmd_init_common.sh.in
index 4e50ecb..2a6f5c3 100755
--- a/init/vdsmd_init_common.sh.in
+++ b/init/vdsmd_init_common.sh.in
@@ -109,7 +109,7 @@
_CONF_FILE="@CONFDIR(a)/vdsm.conf"
-_GETCONFITEM="@VDSMDIR@/get-conf-item"
+_GETCONFITEM="@LIBEXECDIR@/get-conf-item"
_DOM_METADATA_BACKUP_DIR="@VDSMLOGDIR@/backup"
_mk_data_center() {
diff --git a/static/Makefile.am b/static/Makefile.am
index 1ad329e..85414e5 100644
--- a/static/Makefile.am
+++ b/static/Makefile.am
@@ -111,11 +111,17 @@
libvirtpassworddir = $(vdsmtsdir)/keys
libvirtpassword_DATA = ./$(libvirtpassworddir)/libvirt_password
+
cronhourlydir = $(sysconfdir)/cron.hourly
dist_cronhourly_SCRIPTS = \
./etc/cron.hourly/vdsm-logrotate \
$(NULL)
+dist_vdsmexec_SCRIPTS = \
+ ./libexec/vdsm/get-conf-item \
+ ./libexec/vdsm/set-conf-item \
+ $(NULL)
+
networkmanagerdir = $(sysconfdir)/NetworkManager/conf.d
networkmanager_DATA = \
diff --git a/vdsm/get-conf-item b/static/libexec/vdsm/get-conf-item
similarity index 100%
rename from vdsm/get-conf-item
rename to static/libexec/vdsm/get-conf-item
diff --git a/vdsm/set-conf-item b/static/libexec/vdsm/set-conf-item
similarity index 100%
rename from vdsm/set-conf-item
rename to static/libexec/vdsm/set-conf-item
diff --git a/tox.ini b/tox.ini
index ce405b9..a69e06b 100644
--- a/tox.ini
+++ b/tox.ini
@@ -52,8 +52,8 @@
init/daemonAdapter \
lib/vdsm/storage/curl-img-wrap \
lib/vdsm/storage/fc-scan \
- vdsm/get-conf-item \
- vdsm/set-conf-item
+ static/libexec/vdsm/get-conf-item \
+ static/libexec/vdsm/set-conf-item
[flake8]
diff --git a/vdsm.spec.in b/vdsm.spec.in
index 3210c8f..368dc59 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -985,8 +985,8 @@
%dir %{_libexecdir}/%{vdsm_name}/hooks/before_ifcfg_write
%dir %{_libexecdir}/%{vdsm_name}/hooks/after_ifcfg_write
-%{_datadir}/%{vdsm_name}/get-conf-item
-%{_datadir}/%{vdsm_name}/set-conf-item
+%{_libexecdir}/%{vdsm_name}/get-conf-item
+%{_libexecdir}/%{vdsm_name}/set-conf-item
%{python_sitelib}/sos/plugins/vdsm.py*
%{_udevrulesdir}/12-vdsm-lvm.rules
/etc/security/limits.d/99-vdsm.conf
diff --git a/vdsm/Makefile.am b/vdsm/Makefile.am
index 6d42a5c..3675e3b 100644
--- a/vdsm/Makefile.am
+++ b/vdsm/Makefile.am
@@ -38,8 +38,6 @@
mk_sysprep_floppy
dist_vdsm_SCRIPTS = \
- get-conf-item \
- set-conf-item \
vdsmd \
$(NULL)
--
To view, visit https://gerrit.ovirt.org/78550
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I983bdca05df8c66e594211243fb99327c9c3d250
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
6 years, 10 months
Change in vdsm[master]: network: move ip.address to its separate package
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: network: move ip.address to its separate package
......................................................................
network: move ip.address to its separate package
In following patches IPAddress API and its implementation will be
introduced.
Change-Id: I9dff0698811e53afe1fea474e4a7baaa5ef6960f
Signed-off-by: Petr Horacek <phoracek(a)redhat.com>
---
M configure.ac
M lib/vdsm/network/ip/Makefile.am
A lib/vdsm/network/ip/address/Makefile.am
R lib/vdsm/network/ip/address/__init__.py
M vdsm.spec.in
5 files changed, 27 insertions(+), 1 deletion(-)
Approvals:
Jenkins CI: Passed CI tests
Petr Horáček: Verified
Edward Haas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/76530
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9dff0698811e53afe1fea474e4a7baaa5ef6960f
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horacek <phoracek(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 10 months
Change in vdsm[ovirt-4.1]: Require abrt-cli for vdsm sos plugin
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has uploaded a new change for review.
Change subject: Require abrt-cli for vdsm sos plugin
......................................................................
Require abrt-cli for vdsm sos plugin
vdsm sos plugin uses abrt-cli output. without requiring that, sos output
will print an error. reasonable to require that as part of vdsm.
Change-Id: Id7a6cd0077b460b1b11a33e0ea23056f096f0143
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=917062
Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com>
---
M vdsm.spec.in
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/97/78497/1
diff --git a/vdsm.spec.in b/vdsm.spec.in
index f134767..3c6c5e2 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -110,6 +110,7 @@
Requires: nfs-utils
Requires: m2crypto
Requires: libnl3
+Requires: abrt-cli
Requires: abrt-addon-vmcore
Requires: abrt-addon-ccpp
Requires: abrt-addon-python
--
To view, visit https://gerrit.ovirt.org/78497
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id7a6cd0077b460b1b11a33e0ea23056f096f0143
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
6 years, 10 months
Change in vdsm[master]: tests: Make mailbox_test compatible with pytest
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: tests: Make mailbox_test compatible with pytest
......................................................................
Patch Set 6:
I think that you should dig into history in order to verify that the test is no longer needed, or even better, to replace it.
--
To view, visit https://gerrit.ovirt.org/78589
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I67aaf03e382c730757e8d3d208267d177ea325c6
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
6 years, 10 months
Change in vdsm[master]: net: Generate dump bonding options on boot and upgrade
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: Generate dump bonding options on boot and upgrade
......................................................................
Patch Set 30: Code-Review-1
Requires manual rebase
--
To view, visit https://gerrit.ovirt.org/78006
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I98f7c691a2a86d152ebcb81e1d96f9b0d83fa698
Gerrit-PatchSet: 30
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
6 years, 10 months
Change in vdsm[master]: python3: Improve uuid packing tests
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: python3: Improve uuid packing tests
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/78703
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I85f50b9393b14c35c8e532938e8a627d860dee7b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
6 years, 10 months
Change in vdsm[master]: stomp: handle incoming heartbeats
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: stomp: handle incoming heartbeats
......................................................................
stomp: handle incoming heartbeats
According to stomp specification, Heart-beating can optionally be used
to test the healthiness of the underlying TCP connection and to make sure
that the remote end is alive and kicking. [1]
until now, we ignored incoming heartbeats and raised ValueError
when their value was not 0.
This patch gets the incoming heartbeats and updates the
dispatcher according to their value.
incoming heartbeat will be updated every time a new frame will be
received, indicating connection is still active.
If timeout has exceeded, the frame handler (client or server) will handle
it according to its implementation.
[1] https://stomp.github.io/stomp-specification-1.2.html#Heart-beating
Change-Id: Ib9558ecddef3b57d37cfe4257c1c0ab4f2015064
Signed-off-by: Irit Goihman <igoihman(a)redhat.com>
Bug-Url: https://bugzilla.redhat.com/1376843
---
M lib/yajsonrpc/stomp.py
M tests/stompasyncdispatcher_test.py
2 files changed, 38 insertions(+), 7 deletions(-)
Approvals:
Piotr Kliczewski: Looks good to me, approved
Yaniv Bronhaim: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Irit Goihman: Verified
--
To view, visit https://gerrit.ovirt.org/78218
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib9558ecddef3b57d37cfe4257c1c0ab4f2015064
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 10 months
Change in vdsm[master]: spec: make sure infra package is deleted on upgrade
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: spec: make sure infra package is deleted on upgrade
......................................................................
spec: make sure infra package is deleted on upgrade
infra package should be removed when upgrading to vdsm
4.19 version (and above).
The previous rule didn't cover 4.18.x versions so the package
wasn't deleted on upgrade.
Change-Id: I8c975bffe713b716dfa9a8bc1bbee6d9a24fb144
Signed-off-by: Irit Goihman <igoihman(a)redhat.com>
Bug-Url: https://bugzilla.redhat.com/1460140
---
M vdsm.spec.in
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Piotr Kliczewski: Looks good to me, approved
Yaniv Bronhaim: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Irit Goihman: Verified
Francesco Romani: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/78357
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8c975bffe713b716dfa9a8bc1bbee6d9a24fb144
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 10 months