From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: pytest: Set locale properly for pytest based tests
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/80027
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6d75e19bb72c054ec90b2bab2539cd8544d3fe39
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: build: remove constants.py from dist package
......................................................................
Patch Set 1:
Tomas, it does not have to be part of `make check`. If it helps you, you can introduce it to make-check.sh.
--
To view, visit https://gerrit.ovirt.org/79925
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I36820d3c458c5d162dcb8fbe2baf1c9647c9032d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Golembiovsky <tgolembi(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tomas Golembiovsky <tgolembi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: api: log only external pings
......................................................................
Patch Set 13: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/78142/13//COMMIT_MSG
Commit Message:
Line 15: is successful (pinged from localhost) although the host lost its
Line 16: network connectivity.
Line 17:
Line 18: With this patch we confirm connectivity (touch P_VDSM_CLIENT_LOG)
Line 19: only when ping is used by a non-localhost caller.
per discussion with Petr, I am convinced that we cannot just change the existing verb (since there still might be someone running Engine on a Vdsm host).
We'd better deprecate ping, and create 2 new verbs:
- ping2 (or echo or whatever to check connectivity)
- confirm_connectivity (for explict confirmation of connectivity)
Line 20:
Line 21: Change-Id: I9eff40244f38d5707f9e1cec64d20bcd68415b2d
--
To view, visit https://gerrit.ovirt.org/78142
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9eff40244f38d5707f9e1cec64d20bcd68415b2d
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Petr Horacek <phoracek(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79948 )
Change subject: gluster: Disable blivet tests also on Fedora 26
......................................................................
gluster: Disable blivet tests also on Fedora 26
Same issue seen on rawhide exists also in Fedora 26.
See https://bugzilla.redhat.com/1450607.
Change-Id: I939f2791c3dbf0892704193ebc63d5accc5f99d8
Signed-off-by: Nir Soffer <nsoffer(a)redhat.com>
---
M tests/check_imports.py
M tests/gluster_cli_test.py
2 files changed, 4 insertions(+), 3 deletions(-)
Approvals:
Nir Soffer: Verified
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
Edward Haas: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/79948
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I939f2791c3dbf0892704193ebc63d5accc5f99d8
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79947 )
Change subject: travis: Add Fedora 26 build
......................................................................
travis: Add Fedora 26 build
Change-Id: Ie036c6d6ac928210670460a748b05bfe967ab980
Signed-off-by: Nir Soffer <nsoffer(a)redhat.com>
---
M .travis.yml
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Nir Soffer: Verified
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
Edward Haas: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/79947
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie036c6d6ac928210670460a748b05bfe967ab980
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79946 )
Change subject: dockerfile: Remove Fedora 24 image
......................................................................
dockerfile: Remove Fedora 24 image
We stopped using this image since commit 33e80260b1cf (rawhide: Add
travis Fedora rawhide build) on May 7, and Fedora 24 is approaching end
of life soon.
Change-Id: I846dc05a451423f85fd2864fc913cc74d7aeffa7
Signed-off-by: Nir Soffer <nsoffer(a)redhat.com>
---
D docker/Dockerfile.fedora.24
1 file changed, 0 insertions(+), 57 deletions(-)
Approvals:
Nir Soffer: Verified
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
Edward Haas: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/79946
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I846dc05a451423f85fd2864fc913cc74d7aeffa7
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: dockerfile: Remove Fedora 24 image
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/79946
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I846dc05a451423f85fd2864fc913cc74d7aeffa7
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: sb validator: raise on missing sb device.
......................................................................
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/79953/1//COMMIT_MSG
Commit Message:
Line 5: CommitDate: 2017-07-29 16:32:40 +0300
Line 6:
Line 7: net: sb validator: raise on missing sb device.
Line 8:
Line 9: If no nic and no bond were given to a network, raise.
why? we wanted to have nicless (bridge-only) networks.
Line 10:
Line 11: Change-Id: I6f3503faa5c84155ed667e2a474d1dc148798e35
--
To view, visit https://gerrit.ovirt.org/79953
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6f3503faa5c84155ed667e2a474d1dc148798e35
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: tests: add "param" to test_add_net_missing_sb_device_fails
......................................................................
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/79952/1//COMMIT_MSG
Commit Message:
Line 7: net: tests: add "param" to test_add_net_missing_sb_device_fails
Line 8:
Line 9: In order to differentiate between the non-existent nic and
Line 10: not supplied nic (sb) parameter, "param" was added to the
Line 11: tests' signature (test_add_net_missing_sb_device_param_fails).
sorry, but I don't understand what "param" means
Line 12:
Line 13: Change-Id: I8d4d4654dcbe70aac586971530d9b1bf13bcb728
--
To view, visit https://gerrit.ovirt.org/79952
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8d4d4654dcbe70aac586971530d9b1bf13bcb728
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79945 )
Change subject: dockerfile: Add Fedora 26 image
......................................................................
dockerfile: Add Fedora 26 image
Change-Id: Ia63d38c578094b88602477418923acb96ac196ab
Signed-off-by: Nir Soffer <nsoffer(a)redhat.com>
---
A docker/Dockerfile.fedora.26
1 file changed, 59 insertions(+), 0 deletions(-)
Approvals:
Nir Soffer: Verified
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
Edward Haas: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/79945
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia63d38c578094b88602477418923acb96ac196ab
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: Introduce the LLDPAD driver with an LLDP interface
......................................................................
Patch Set 18:
CI-1 due to
./lib/vdsm/network/lldpad/lldptool.py:126:80: E501 line too long (83 > 79 characters)
--
To view, visit https://gerrit.ovirt.org/78117
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaaa889789f7bbcc1cb3d9a9d0c8b02f1cf83bea9
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dominik Holler <dholler(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Yaniv Kaul <ykaul(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79664 )
Change subject: m2c: uses different protocol constant names
......................................................................
m2c: uses different protocol constant names
M2crypto uses the same name scheme as openssl which differs from ssl
module. SSL_OP_NO_TLSv1_1 is not defined m2c master upstream.
Label: ovirt-4.1-only
Bug-Url: https://bugzilla.redhat.com/1473344
Change-Id: I6c05bddfba94d85e2c48122b6fd56d8f336d01f5
Signed-off-by: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
---
M lib/vdsm/m2cutils.py
1 file changed, 7 insertions(+), 1 deletion(-)
Approvals:
Piotr Kliczewski: Verified
Jenkins CI: Passed CI tests
Irit Goihman: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, approved
Francesco Romani: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/79664
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6c05bddfba94d85e2c48122b6fd56d8f336d01f5
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: m2c: uses different protocol constant names
......................................................................
Patch Set 4: Code-Review+2
(1 comment)
https://gerrit.ovirt.org/#/c/79664/4/lib/vdsm/m2cutils.py
File lib/vdsm/m2cutils.py:
Line 37: except ImportError as e:
Line 38: raise compat.Unsupported(str(e))
Line 39:
Line 40: CLIENT_PROTOCOL = "sslv23"
Line 41: SSL_OP_NO_TLSv1_1 = 268435456
0x10000000 is SOOO much more readable.
Line 42:
Line 43: DEFAULT_ACCEPT_TIMEOUT = 5
Line 44: SOCKET_DEFAULT_TIMEOUT = socket._GLOBAL_DEFAULT_TIMEOUT
Line 45:
--
To view, visit https://gerrit.ovirt.org/79664
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6c05bddfba94d85e2c48122b6fd56d8f336d01f5
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: ssl: handle handshake errors
......................................................................
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/79668/7/lib/vdsm/sslutils.py
File lib/vdsm/sslutils.py:
Line 254: elif err.args[0] == ssl.SSL_ERROR_WANT_WRITE:
Line 255: self.want_write = True
Line 256: else:
Line 257: dispatcher.close()
Line 258: except socket.error:
silently ignoring these two errors is counter intuitive. Maybe you can add a comment for future developers?
Line 259: dispatcher.close()
Line 260: else:
Line 261: self.want_read = self.want_write = True
Line 262: self._is_handshaking = False
--
To view, visit https://gerrit.ovirt.org/79668
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I99cfa35e608f429640455c35495be1783854e3da
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: jsonrpc tests: Discard the dependency on the network package
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/79950
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I708c50567e4ec9b2c72cd34f8435ccb66aac7281
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: gluster: Disable blivet tests also on Fedora 26
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/79948
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I939f2791c3dbf0892704193ebc63d5accc5f99d8
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: travis: Add Fedora 26 build
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/79947
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie036c6d6ac928210670460a748b05bfe967ab980
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: dockerfile: Remove Fedora 24 image
......................................................................
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/79946/2//COMMIT_MSG
Commit Message:
Line 3: AuthorDate: 2017-07-29 01:33:15 +0300
Line 4: Commit: Nir Soffer <nsoffer(a)redhat.com>
Line 5: CommitDate: 2017-07-29 02:23:48 +0300
Line 6:
Line 7: dockerfile: Remove Fedora 24 image
can you add a word regarding why, and why it does not hurt anybody?
Line 8:
Line 9: Change-Id: I846dc05a451423f85fd2864fc913cc74d7aeffa7
--
To view, visit https://gerrit.ovirt.org/79946
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I846dc05a451423f85fd2864fc913cc74d7aeffa7
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: dockerfile: Add Fedora 26 image
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/79945
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia63d38c578094b88602477418923acb96ac196ab
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79905 )
Change subject: net: tests: Migrate testFailWithInvalidParams to the new func tests
......................................................................
net: tests: Migrate testFailWithInvalidParams to the new func tests
Change-Id: I848f360e3e4f0e8cda17870f53ce27af25252343
Signed-off-by: Leon Goldberg <lgoldber(a)redhat.com>
---
M tests/functional/networkTests.py
M tests/network/func_bond_basic_test.py
M tests/network/func_net_basic_test.py
3 files changed, 23 insertions(+), 12 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Leon Goldberg: Verified
Edward Haas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/79905
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I848f360e3e4f0e8cda17870f53ce27af25252343
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79638 )
Change subject: hooking: move to lib
......................................................................
hooking: move to lib
As part of broader migration we move hooking.py away from vdsm dir.
Change-Id: If2f1581d75cfb33868af41d1b116f56af89801a5
Signed-off-by: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
---
M Makefile.am
M configure.ac
M lib/vdsm/Makefile.am
A lib/vdsm/hook/Makefile.am
A lib/vdsm/hook/__init__.py
R lib/vdsm/hook/hooking.py
M lib/vdsm/hooks.py
M vdsm.spec.in
M vdsm/Makefile.am
9 files changed, 33 insertions(+), 7 deletions(-)
Approvals:
Piotr Kliczewski: Verified
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/79638
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If2f1581d75cfb33868af41d1b116f56af89801a5
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: hooking: move to lib
......................................................................
Patch Set 9: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/79638
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If2f1581d75cfb33868af41d1b116f56af89801a5
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79744 )
Change subject: RPC: Fix tests in integration/jsonRpcTests.py
......................................................................
RPC: Fix tests in integration/jsonRpcTests.py
The tests were broken by patch:
https://gerrit.ovirt.org/#/c/79299/
This patch fixes them.
Change-Id: Icde4642ae8c541422aedee73cfedb57c7856cf8e
Signed-off-by: Andrej Krejcir <akrejcir(a)redhat.com>
---
M tests/integration/jsonRpcHelper.py
1 file changed, 5 insertions(+), 3 deletions(-)
Approvals:
Piotr Kliczewski: Looks good to me, approved
Jenkins CI: Passed CI tests
Andrej Krejcir: Verified
--
To view, visit https://gerrit.ovirt.org/79744
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icde4642ae8c541422aedee73cfedb57c7856cf8e
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: RPC: Fix tests in integration/jsonRpcTests.py
......................................................................
Patch Set 7:
so very sorry, I forgot all about these tests.
--
To view, visit https://gerrit.ovirt.org/79744
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icde4642ae8c541422aedee73cfedb57c7856cf8e
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: build: remove constants.py from dist package
......................................................................
Patch Set 1:
Tomas, can you suggest a test that would make sure we do not break your use case again?
--
To view, visit https://gerrit.ovirt.org/79925
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I36820d3c458c5d162dcb8fbe2baf1c9647c9032d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Golembiovsky <tgolembi(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: tests: Migrate testFailWithInvalidParams to the new func tests
......................................................................
Patch Set 2: Code-Review-1
requires manual rebase
--
To view, visit https://gerrit.ovirt.org/79905
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I848f360e3e4f0e8cda17870f53ce27af25252343
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79438 )
Change subject: net: tests: Migrate testFailWithInvalidIpConfig to the new func tests
......................................................................
net: tests: Migrate testFailWithInvalidIpConfig to the new func tests
Change-Id: I4a46e5e5e210fd4d17b70d1f77405ffbadedb44d
Signed-off-by: Leon Goldberg <lgoldber(a)redhat.com>
---
M tests/functional/networkTests.py
A tests/network/func_net_ip_test.py
2 files changed, 75 insertions(+), 16 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Leon Goldberg: Verified
Edward Haas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/79438
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4a46e5e5e210fd4d17b70d1f77405ffbadedb44d
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has uploaded a new change for review.
Change subject: net test: use static bonding defaults if dump fails
......................................................................
net test: use static bonding defaults if dump fails
sysfs_options_mapper.dump_bonding_options may fail during the test if
its target directory is missing. In such a case, take the shipped
defaults.
Change-Id: I33a6ecc14f6d1a2f7cc9da9bfaff4fad13fa8055
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com>
---
M tests/network/nettestlib.py
1 file changed, 7 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/89/79889/1
diff --git a/tests/network/nettestlib.py b/tests/network/nettestlib.py
index 7395755..79f55f4 100644
--- a/tests/network/nettestlib.py
+++ b/tests/network/nettestlib.py
@@ -532,13 +532,18 @@
bonding_name2num_fpath = ALTERNATIVE_BONDING_NAME2NUMERIC_PATH
if _has_sysfs_bond_permission():
- sysfs_options_mapper.dump_bonding_options()
+ try:
+ sysfs_options_mapper.dump_bonding_options()
+ except SystemError as e:
+ if e.errno != errno.ENOENT:
+ raise
if os.path.exists(BONDING_DEFAULTS):
bonding_defaults_fpath = BONDING_DEFAULTS
if os.path.exists(sysfs_options_mapper.BONDING_NAME2NUMERIC_PATH):
- bonding_name2num_fpath = sysfs_options_mapper.BONDING_NAME2NUMERIC_PATH
+ bonding_name2num_fpath = \
+ sysfs_options_mapper.BONDING_NAME2NUMERIC_PATH
return bonding_defaults_fpath, bonding_name2num_fpath
--
To view, visit https://gerrit.ovirt.org/79889
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I33a6ecc14f6d1a2f7cc9da9bfaff4fad13fa8055
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has uploaded a new change for review.
Change subject: testrunner: mock vdsm.common.constants.P_VDSM
......................................................................
testrunner: mock vdsm.common.constants.P_VDSM
As long as we keep vdsm.constants as proxy to vdsm.common.constants, we
need to keep them align also when mocked.
Change-Id: I39231c2e9d4b883de0294d90f42860d72edc67f4
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com>
---
M tests/testrunner.py
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/11/79911/1
diff --git a/tests/testrunner.py b/tests/testrunner.py
index e4dab3b..7586158 100644
--- a/tests/testrunner.py
+++ b/tests/testrunner.py
@@ -49,6 +49,7 @@
"instead of installed ones.\n")
if findRemove(sys.argv, "--local-modules"):
from vdsm import constants
- constants.P_VDSM = "../vdsm/"
+ from vdsm.common import common_constants
+ common_constants.P_VDSM = constants.P_VDSM = "../vdsm/"
testlib.run()
--
To view, visit https://gerrit.ovirt.org/79911
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I39231c2e9d4b883de0294d90f42860d72edc67f4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: storage: Add LibgfApi support as additional feature
......................................................................
Patch Set 6: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/79605
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0aac04c144ae647aad1c0714379246060f4e991f
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Raz Tamir <ratamir(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: m2c: uses different protocol constant names
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
https://gerrit.ovirt.org/#/c/79664/3/lib/vdsm/m2cutils.py
File lib/vdsm/m2cutils.py:
Line 331: excludes = 0
Line 332:
Line 333: for no_protocol in config.get('vars', 'ssl_excludes').split(','):
Line 334: if no_protocol != '':
Line 335: protocol = 'SSL_' + no_protocol.strip()
> SSL_OP_NO_TLSv1_1 is not supported. Only two values are supported as specif
didn't we say that we'll just support both ..? you agreed. just add the SSL_ prefix if it was not provided.
But I don't mind to restrict it.
Line 336: if protocol == 'SSL_OP_NO_TLSv1_1':
Line 337: # not all m2crypto provide this constant
Line 338: excludes |= 268435456
Line 339: else:
--
To view, visit https://gerrit.ovirt.org/79664
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6c05bddfba94d85e2c48122b6fd56d8f336d01f5
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: Revert "Revert "storage: Made diskType a real property.""
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/79800
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id98229bd3705fc056d54d9eb536d74c7b7729f47
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-HasComments: No
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: Revert "Revert "storage: Added disk type change logging""
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/79801
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia2e875c82b672384d04b23907292a8b7dfd5dcc3
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-HasComments: No
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: storage: Add LibgfApi support as additional feature
......................................................................
Patch Set 3: Code-Review-1
the bug is set for 4.1.5. let's stall this patch until 4.1.4 is out.
otherwise, we may need to fork out ovirt-4.1.4 branch.
--
To view, visit https://gerrit.ovirt.org/79605
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0aac04c144ae647aad1c0714379246060f4e991f
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has uploaded a new change for review.
Change subject: introduce common.constants
......................................................................
introduce common.constants
Several constants are used by all vdsm subsystems. This patch itroduces
common.constants to host them. I do not simply move vdsm.constants into
vdsm.common.constants in order to scrutinize better which constants are
placed in common.
Change-Id: I8568a806f9195007620d15eff59e72b55042557b
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com>
---
M .gitignore
M lib/vdsm/common/Makefile.am
A lib/vdsm/common/constants.py.in
M lib/vdsm/constants.py.in
4 files changed, 40 insertions(+), 4 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/92/79692/1
diff --git a/.gitignore b/.gitignore
index e334131..7786c6c 100644
--- a/.gitignore
+++ b/.gitignore
@@ -27,6 +27,7 @@
init/systemd/vdsm-tmpfiles.d.conf
init/vdsmd_init_common.sh
lib/vdsm/api/vdsm-api.html
+lib/vdsm/common/constants.py
lib/vdsm/config.py
lib/vdsm/constants.py
lib/vdsm/dsaversion.py
diff --git a/lib/vdsm/common/Makefile.am b/lib/vdsm/common/Makefile.am
index a7ed5da..447e4e8 100644
--- a/lib/vdsm/common/Makefile.am
+++ b/lib/vdsm/common/Makefile.am
@@ -21,4 +21,13 @@
SUBDIRS = network
vdsmcommondir = $(vdsmpylibdir)/common
+
+nodist_vdsmcommon_PYTHON = \
+ constants.py \
+ $(NULL)
+
dist_vdsmcommon_PYTHON = *.py
+
+EXTRA_DIST = \
+ constants.py.in \
+ $(NULL)
diff --git a/lib/vdsm/common/constants.py.in b/lib/vdsm/common/constants.py.in
new file mode 100644
index 0000000..e657f06
--- /dev/null
+++ b/lib/vdsm/common/constants.py.in
@@ -0,0 +1,26 @@
+#
+# Copyright 2009-2017 Red Hat, Inc.
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 2 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
+#
+# Refer to the README and COPYING files for full details of the license
+#
+
+from __future__ import absolute_import
+
+P_VDSM = '@VDSMDIR@/' # NOQA: E501 (potentially long line)
+P_VDSM_HOOKS = '@HOOKSDIR@/' # NOQA: E501 (potentially long line)
+P_VDSM_LIB = '@VDSMLIBDIR@/' # NOQA: E501 (potentially long line)
+P_VDSM_RUN = '@VDSMRUNDIR@/' # NOQA: E501 (potentially long line)
diff --git a/lib/vdsm/constants.py.in b/lib/vdsm/constants.py.in
index 32c87d9..7b2a055 100644
--- a/lib/vdsm/constants.py.in
+++ b/lib/vdsm/constants.py.in
@@ -23,6 +23,10 @@
from __future__ import absolute_import
import os
+from vdsm.common.constants import ( # NOQA: F401 (intentionally exposed here)
+ P_VDSM, P_VDSM_HOOKS, P_VDSM_LIB,
+ P_VDSM_RUN)
+
GLUSTER_MGMT_ENABLED = bool(@GLUSTER_MGMT@)
# SMBIOS manufacturer
@@ -72,10 +76,6 @@
#
P_LIBVIRT_VMCHANNELS = '/var/lib/libvirt/qemu/channels/'
P_OVIRT_VMCONSOLES = '/var/run/ovirt-vmconsole-console/'
-P_VDSM = '@VDSMDIR@/' # NOQA: E501 (potentially long line)
-P_VDSM_HOOKS = '@HOOKSDIR@/' # NOQA: E501 (potentially long line)
-P_VDSM_LIB = '@VDSMLIBDIR@/' # NOQA: E501 (potentially long line)
-P_VDSM_RUN = '@VDSMRUNDIR@/' # NOQA: E501 (potentially long line)
P_VDSM_STORAGE = os.path.join(P_VDSM_RUN, 'storage/')
P_VDSM_CONF = '@CONFDIR@/' # NOQA: E501 (potentially long line)
P_VDSM_KEYS = '/etc/pki/vdsm/keys/'
--
To view, visit https://gerrit.ovirt.org/79692
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8568a806f9195007620d15eff59e72b55042557b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has uploaded a new change for review.
Change subject: net.tc_tests: mock BONDING_DEFAULTS
......................................................................
net.tc_tests: mock BONDING_DEFAULTS
I don't really understand how this popped up suddely, but various
tc_tests failed on CI due to trying to read from
/usr/share/vdsm/bonding-defaults.json
Change-Id: I99824c5b1fad63b5f07b4ad40c3e134cc98d91c6
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com>
---
M tests/network/tc_test.py
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/02/79702/1
diff --git a/tests/network/tc_test.py b/tests/network/tc_test.py
index 4cb8aa6..dd9b3a3 100644
--- a/tests/network/tc_test.py
+++ b/tests/network/tc_test.py
@@ -400,6 +400,7 @@
@MonkeyClass(libvirtconnection, 'get', Connection)
@expandPermutations
+(a)mock.patch.object(sysfs_options, 'BONDING_DEFAULTS', bonding_default_fpath())
class TestConfigureOutbound(TestCaseBase):
def setUp(self):
self.device = Dummy()
--
To view, visit https://gerrit.ovirt.org/79702
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I99824c5b1fad63b5f07b4ad40c3e134cc98d91c6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79810 )
Change subject: net tests: Patch BONDING_DEFAULTS on package level
......................................................................
net tests: Patch BONDING_DEFAULTS on package level
Multiple tests are dependent on BONDING_DEFAULTS.
Several tests (see tc_test module) are dependent on the bonding defaults
but do not specify it (by patching it).
These tests have been passing so far by chance: one of the patched tests
have been chosen to run first.
If an unpatched test runs first, it will fail.
This patch is patching the BONDING_DEFAULTS at package level once,
removing the need to patch individual tests.
Change-Id: I7ea0c3783b4b9224320dc643b801d93808b14fee
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
---
M tests/network/__init__.py
M tests/network/link_bond_test.py
M tests/network/models_test.py
M tests/network/netinfo_test.py
4 files changed, 18 insertions(+), 13 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
Edward Haas: Verified
--
To view, visit https://gerrit.ovirt.org/79810
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7ea0c3783b4b9224320dc643b801d93808b14fee
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net tests: Patch BONDING_DEFAULTS on package level
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/79810
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7ea0c3783b4b9224320dc643b801d93808b14fee
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: m2c: uses different protocol constant names
......................................................................
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/79664/3/lib/vdsm/m2cutils.py
File lib/vdsm/m2cutils.py:
Line 331: excludes = 0
Line 332:
Line 333: for no_protocol in config.get('vars', 'ssl_excludes').split(','):
Line 334: if no_protocol != '':
Line 335: protocol = 'SSL_' + no_protocol.strip()
if user entered SSL_OP_NO_TLSv1_1 now you have a bug
Line 336: if protocol == 'SSL_OP_NO_TLSv1_1':
Line 337: # not all m2crypto provide this constant
Line 338: excludes |= 268435456
Line 339: else:
--
To view, visit https://gerrit.ovirt.org/79664
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6c05bddfba94d85e2c48122b6fd56d8f336d01f5
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has uploaded a new change for review.
Change subject: move constants.SUPPORTED_DOMAIN_VERSIONS to storage.constants
......................................................................
move constants.SUPPORTED_DOMAIN_VERSIONS to storage.constants
DOMAIN_VERSIONS and SUPPORTED_DOMAIN_VERSIONS belong to storage
subsystem.
Change-Id: Ib8ed048c8f36964a209186ebfefd62a899700277
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com>
---
M lib/vdsm/API.py
M lib/vdsm/constants.py.in
M lib/vdsm/storage/constants.py
M lib/vdsm/storage/hsm.py
M lib/vdsm/storage/sd.py
5 files changed, 13 insertions(+), 13 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/32/79732/1
diff --git a/lib/vdsm/API.py b/lib/vdsm/API.py
index 8e7f745..0bbfb45 100644
--- a/lib/vdsm/API.py
+++ b/lib/vdsm/API.py
@@ -932,7 +932,7 @@
return self._irs.attachStorageDomain(self._UUID, storagepoolID)
def create(self, domainType, typeArgs, name, domainClass,
- version=constants.SUPPORTED_DOMAIN_VERSIONS[0]):
+ version=sc.SUPPORTED_DOMAIN_VERSIONS[0]):
return self._irs.createStorageDomain(domainType, self._UUID, name,
typeArgs, domainClass, version)
diff --git a/lib/vdsm/constants.py.in b/lib/vdsm/constants.py.in
index 68c8b7a..a123a26 100644
--- a/lib/vdsm/constants.py.in
+++ b/lib/vdsm/constants.py.in
@@ -51,16 +51,6 @@
# Libvirt selinux
LIBVIRT_SELINUX = '@ENABLE_LIBVIRT_SELINUX@' == 'yes'
-
-# This is the domain version translation list
-# DO NOT CHANGE OLD VALUES ONLY APPEND
-DOMAIN_VERSIONS = (0, 2, 3, 4)
-
-# This contains the domains versions that this VDSM
-# accepts currently its all of the version but in the
-# future we might slice it (eg. tuple(DOMAIN_VERSION[1:]))
-SUPPORTED_DOMAIN_VERSIONS = DOMAIN_VERSIONS
-
MEGAB = 2 ** 20 # = 1024 ** 2 = 1 MiB
GIB = 1024 * MEGAB
diff --git a/lib/vdsm/storage/constants.py b/lib/vdsm/storage/constants.py
index d08f688..8ee108e 100644
--- a/lib/vdsm/storage/constants.py
+++ b/lib/vdsm/storage/constants.py
@@ -185,3 +185,13 @@
TAG_PREFIX_IMAGE,
TAG_PREFIX_MD,
TAG_PREFIX_MDNUMBLKS]
+
+
+# This is the domain version translation list
+# DO NOT CHANGE OLD VALUES ONLY APPEND
+DOMAIN_VERSIONS = (0, 2, 3, 4)
+
+# This contains the domains versions that this VDSM
+# accepts currently its all of the version but in the
+# future we might slice it (eg. tuple(DOMAIN_VERSION[1:]))
+SUPPORTED_DOMAIN_VERSIONS = DOMAIN_VERSIONS
diff --git a/lib/vdsm/storage/hsm.py b/lib/vdsm/storage/hsm.py
index 3d04b80..418ff6f 100644
--- a/lib/vdsm/storage/hsm.py
+++ b/lib/vdsm/storage/hsm.py
@@ -2489,7 +2489,7 @@
@public
def createStorageDomain(self, storageType, sdUUID, domainName,
typeSpecificArg, domClass,
- domVersion=constants.SUPPORTED_DOMAIN_VERSIONS[0],
+ domVersion=sc.SUPPORTED_DOMAIN_VERSIONS[0],
options=None):
"""
Creates a new storage domain.
diff --git a/lib/vdsm/storage/sd.py b/lib/vdsm/storage/sd.py
index d1964ba..d66a1a2 100644
--- a/lib/vdsm/storage/sd.py
+++ b/lib/vdsm/storage/sd.py
@@ -206,7 +206,7 @@
def validateDomainVersion(version):
- if version not in constants.SUPPORTED_DOMAIN_VERSIONS:
+ if version not in sc.SUPPORTED_DOMAIN_VERSIONS:
raise se.UnsupportedDomainVersion(version)
--
To view, visit https://gerrit.ovirt.org/79732
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib8ed048c8f36964a209186ebfefd62a899700277
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has uploaded a new change for review.
Change subject: move constants.SUPPORTED_BLOCKSIZE to its sole user
......................................................................
move constants.SUPPORTED_BLOCKSIZE to its sole user
Change-Id: I2845bd782b2641accfa1b3bd27a6a47c5723ae06
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com>
---
M lib/vdsm/constants.py.in
M lib/vdsm/storage/lvm.py
2 files changed, 3 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/31/79731/1
diff --git a/lib/vdsm/constants.py.in b/lib/vdsm/constants.py.in
index 2d16d31..68c8b7a 100644
--- a/lib/vdsm/constants.py.in
+++ b/lib/vdsm/constants.py.in
@@ -55,7 +55,6 @@
# This is the domain version translation list
# DO NOT CHANGE OLD VALUES ONLY APPEND
DOMAIN_VERSIONS = (0, 2, 3, 4)
-SUPPORTED_BLOCKSIZE = (512,)
# This contains the domains versions that this VDSM
# accepts currently its all of the version but in the
diff --git a/lib/vdsm/storage/lvm.py b/lib/vdsm/storage/lvm.py
index 3421d20..7d26d9c 100644
--- a/lib/vdsm/storage/lvm.py
+++ b/lib/vdsm/storage/lvm.py
@@ -71,6 +71,8 @@
LV_ATTR = namedtuple("LV_ATTR", LV_ATTR_BITS)
Stub = namedtuple("Stub", "name, stale")
+SUPPORTED_BLOCKSIZE = (512,)
+
class Unreadable(Stub):
__slots__ = ()
@@ -1095,7 +1097,7 @@
pvBlkSize = _getpvblksize(pv)
logPvBlkSize, phyPvBlkSize = pvBlkSize
- if logPvBlkSize not in constants.SUPPORTED_BLOCKSIZE:
+ if logPvBlkSize not in SUPPORTED_BLOCKSIZE:
raise se.DeviceBlockSizeError(pvBlkSize)
if phyPvBlkSize < logPvBlkSize:
--
To view, visit https://gerrit.ovirt.org/79731
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2845bd782b2641accfa1b3bd27a6a47c5723ae06
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has uploaded a new change for review.
Change subject: Makefile: replace astrisks with equal signs
......................................................................
Makefile: replace astrisks with equal signs
Tripple astrisks are used to mark failures in make and other utilities.
Let us use '===' instead for comments.
Change-Id: I0a7f41effd11152195ff4bd7e499ca585fd3349f
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com>
---
M tests/Makefile.am
1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/50/79750/1
diff --git a/tests/Makefile.am b/tests/Makefile.am
index 464850f..734e80d 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -304,16 +304,16 @@
@true
check-net:
- @echo '*** Running networking tests. ***'
+ @echo '=== Running networking tests. ==='
@$(top_srcdir)/tests/run_tests_local.sh $(network_modules)
check-virt:
- @echo '*** Running virt tests. ***'
+ @echo '=== Running virt tests. ==='
@$(top_srcdir)/tests/run_tests_local.sh $(virt_modules)
check:
- @echo '*** Running tests. To skip this step place NOSE_EXCLUDE=.* ***'
- @echo '*** into your environment. Do not submit untested code! ***'
+ @echo '=== Running tests. To skip this step place NOSE_EXCLUDE=.* ==='
+ @echo '=== into your environment. Do not submit untested code! ==='
$(top_srcdir)/tests/run_tests_local.sh $(run_modules)
if [ "$(PYTHON3_SUPPORT)" == "1" ]; then \
all_modules=`mktemp`; \
--
To view, visit https://gerrit.ovirt.org/79750
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0a7f41effd11152195ff4bd7e499ca585fd3349f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/76153 )
Change subject: network: add IPAddressApi and its iproute implementation
......................................................................
network: add IPAddressApi and its iproute implementation
Change-Id: I8f90df4142aee11cf1cba1293fb89ebc7cace1ac
Signed-off-by: Petr Horacek <phoracek(a)redhat.com>
---
M automation/check-merged.packages.el7
M automation/check-merged.packages.fc24
M automation/check-patch.packages.el7
M automation/check-patch.packages.fc24
M automation/check-patch.packages.fc25
M docker/Dockerfile.centos
M docker/Dockerfile.fedora.25
M docker/Dockerfile.fedora.rawhide
M lib/vdsm/network/ip/address/__init__.py
A lib/vdsm/network/ip/address/iproute2.py
M lib/vdsm/network/ipwrapper.py
M tests/network/ip_address_test.py
M vdsm.spec.in
13 files changed, 445 insertions(+), 19 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Petr Horáček: Verified
Edward Haas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/76153
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8f90df4142aee11cf1cba1293fb89ebc7cace1ac
Gerrit-PatchSet: 30
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horacek <phoracek(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/78660 )
Change subject: RPC: Refactor JSON RPC exceptions
......................................................................
RPC: Refactor JSON RPC exceptions
JsonRpcError class is now derived from ContextException
and other derived exceptions use the context to
provide more information.
For example, new error message for JsonRpcMethodNotFoundError is:
The method does not exist or is not available: {'method': 'some_missing_method'}
Also added a new class JsonRpcServerError, that can have
any code and message.
Change-Id: Ifdaf434aec6c65e7a896e5594fba711193cd2958
Signed-off-by: Andrej Krejcir <akrejcir(a)redhat.com>
---
M lib/vdsm/common/exception.py
M lib/vdsm/jsonrpcvdscli.py
M lib/vdsm/rpc/Bridge.py
M lib/yajsonrpc/__init__.py
M tests/bridge_test.py
M tests/integration/jsonRpcTests.py
M tests/stomp_test.py
M tests/vdsmapi_test.py
8 files changed, 97 insertions(+), 91 deletions(-)
Approvals:
Piotr Kliczewski: Looks good to me, approved
Nir Soffer: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Andrej Krejcir: Verified
--
To view, visit https://gerrit.ovirt.org/78660
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifdaf434aec6c65e7a896e5594fba711193cd2958
Gerrit-PatchSet: 37
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79665 )
Change subject: RPC: Fix error messages in JsonRpcResponse
......................................................................
RPC: Fix error messages in JsonRpcResponse
JsonRpcResponse.error is now always an exception
object derived from JsonRpcError.
Previously it could also be a dictionary which caused problems.
Change-Id: Ie9a4b318dfca66e8b50eb44fe9a24fb43ee32275
Signed-off-by: Andrej Krejcir <akrejcir(a)redhat.com>
---
M lib/vdsm/client.py
M lib/vdsm/jsonrpcvdscli.py
M lib/yajsonrpc/__init__.py
M tests/integration/jsonRpcTests.py
4 files changed, 9 insertions(+), 8 deletions(-)
Approvals:
Piotr Kliczewski: Looks good to me, approved
Nir Soffer: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Andrej Krejcir: Verified
--
To view, visit https://gerrit.ovirt.org/79665
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie9a4b318dfca66e8b50eb44fe9a24fb43ee32275
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has uploaded a new change for review.
Change subject: sslutils: add info to SSLHandshake errors
......................................................................
sslutils: add info to SSLHandshake errors
Include name of peer and its full certificate if they do not match,
in order to understand which non-legitimate client attempts to connect.
Change-Id: I0cb2d7e0c6c86ca12a34be13b07bc960e3ad313e
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com>
---
M lib/vdsm/sslutils.py
1 file changed, 6 insertions(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/21/76221/1
diff --git a/lib/vdsm/sslutils.py b/lib/vdsm/sslutils.py
index 10fc172..8c349ca 100644
--- a/lib/vdsm/sslutils.py
+++ b/lib/vdsm/sslutils.py
@@ -219,9 +219,12 @@
if self._is_handshaking:
self._handshake(dispatcher)
else:
- if not self._verify_host(dispatcher.socket.getpeercert(),
- dispatcher.socket.getpeername()[0]):
- self.log.error("peer certificate does not match host name")
+ peercert = dispatcher.socket.getpeercert()
+ peername = dispatcher.socket.getpeername()[0]
+ if not self._verify_host(peercert, peername):
+ self.log.error(
+ "peer certificate '%s' does not match host name '%s'",
+ peercert, peername)
dispatcher.socket.close()
return
--
To view, visit https://gerrit.ovirt.org/76221
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0cb2d7e0c6c86ca12a34be13b07bc960e3ad313e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: m2c: uses different protocol constant names
......................................................................
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/79664/2//COMMIT_MSG
Commit Message:
Line 9: M2crypto uses the same name scheme as openssl which differs from ssl
Line 10: module. SSL_OP_NO_TLSv1_1 is not available on some of m2c versions.
Line 11:
Line 12:
Line 13: Label: ovirt-4.1-only
> There is no need to write anything about m2c being removed from master.
sounds reasonable to me to say why its ovirt-4.1 only.. but as you wish
Line 14: Bug-Url: https://bugzilla.redhat.com/1473344
Line 15: Change-Id: I6c05bddfba94d85e2c48122b6fd56d8f336d01f5
--
To view, visit https://gerrit.ovirt.org/79664
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6c05bddfba94d85e2c48122b6fd56d8f336d01f5
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: ssl: handle handshake errors
......................................................................
Patch Set 4:
(2 comments)
https://gerrit.ovirt.org/#/c/79668/4//COMMIT_MSG
Commit Message:
Line 5: CommitDate: 2017-07-24 12:08:16 +0200
Line 6:
Line 7: ssl: handle handshake errors
Line 8:
Line 9: We need to make sure to close socket when handshake fails.
what happened otherwise?
Line 10:
Line 11:
Line 12: Bug-url: https://bugzilla.redhat.com/1473295
Line 13: Change-Id: I99cfa35e608f429640455c35495be1783854e3da
https://gerrit.ovirt.org/#/c/79668/4/lib/vdsm/sslutils.py
File lib/vdsm/sslutils.py:
Line 250: self.want_read = True
Line 251: elif err.args[0] == ssl.SSL_ERROR_WANT_WRITE:
Line 252: self.want_write = True
Line 253: else:
Line 254: dispatcher.close()
don't we need the above treatment ?
Line 255: except socket.error:
Line 256: dispatcher.close()
Line 257: else:
Line 258: self.want_read = self.want_write = True
--
To view, visit https://gerrit.ovirt.org/79668
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I99cfa35e608f429640455c35495be1783854e3da
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: tool: clear networks configured by VDSM
......................................................................
Patch Set 4:
(2 comments)
https://gerrit.ovirt.org/#/c/79495/4//COMMIT_MSG
Commit Message:
PS4, Line 10: but default route
> So if the management is not really with the default route, then we loose th
ack for a compulsory argument. When it is not supplied by the user, the error message prints the default route network as a suggestion.
https://gerrit.ovirt.org/#/c/79495/4/lib/vdsm/tool/network.py
File lib/vdsm/tool/network.py:
PS4, Line 104: net_api.network_caps()
> Why can't you use just the caps? This will reduce the need to depend on the
we'd like to keep the management network, but remove its bridge in case it exists; if we do not use KernelConfig, we'd have to reimplement some of it here.
--
To view, visit https://gerrit.ovirt.org/79495
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I63702da4dd1c5a0328797f524734813ef251bdb6
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horacek <phoracek(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: password: Move to vdsm.common
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/79700
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If3e996c02acc76e3bd15c3aa656f7341c82c1e6f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: hooking: move to lib
......................................................................
Patch Set 7:
(2 comments)
https://gerrit.ovirt.org/#/c/79638/7/tests/run_tests_local.sh.in
File tests/run_tests_local.sh.in:
Line 23
Line 24
Line 25
Line 26
Line 27
why is `client` related and removed?
https://gerrit.ovirt.org/#/c/79638/7/vdsm.spec.in
File vdsm.spec.in:
PS7, Line 732: PYLIBDIR
> I do not like it but if we want to have this module in lib/vdsm I do not se
I'd keep it completely out of the constants.py junkyard. Howe about taking
os.path.dirname(vdsm.hook.__file__)
whereever the path is needed? (frankly, I think that there's only a single user, in hooks.py)
--
To view, visit https://gerrit.ovirt.org/79638
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If2f1581d75cfb33868af41d1b116f56af89801a5
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: m2c: uses different protocol constant names
......................................................................
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/79664/2//COMMIT_MSG
Commit Message:
Line 9: M2crypto uses the same name scheme as openssl which differs from ssl
Line 10: module. SSL_OP_NO_TLSv1_1 is not available on some of m2c versions.
Line 11:
Line 12:
Line 13: Label: ovirt-4.1-only
> m2c was removed from master
i know. i would write it here
Line 14: Bug-Url: https://bugzilla.redhat.com/1473344
Line 15: Change-Id: I6c05bddfba94d85e2c48122b6fd56d8f336d01f5
--
To view, visit https://gerrit.ovirt.org/79664
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6c05bddfba94d85e2c48122b6fd56d8f336d01f5
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: ssl: handle handshake errors
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/79668/1/lib/vdsm/sslutils.py
File lib/vdsm/sslutils.py:
Line 187: self._handshake(dispatcher)
Line 188: except socket.error:
Line 189: self.log.error("Handshake failed")
Line 190: dispatcher.socket.close()
Line 191: return
seems like _handshake itself takes care of exceptions.. if you need to handle socker.error somewhere its there and not here
Line 192: else:
Line 193: if config.getboolean('vars', 'verify_client_cert'):
Line 194: if not self._verify_host(dispatcher.socket.getpeercert(),
Line 195: dispatcher.socket.getpeername()[0]):
--
To view, visit https://gerrit.ovirt.org/79668
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I99cfa35e608f429640455c35495be1783854e3da
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: m2c: uses different protocol constant names
......................................................................
Patch Set 2: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/79664/2//COMMIT_MSG
Commit Message:
Line 9: M2crypto uses the same name scheme as openssl which differs from ssl
Line 10: module. SSL_OP_NO_TLSv1_1 is not available on some of m2c versions.
Line 11:
Line 12:
Line 13: Label: ovirt-4.1-only
why is it 4.1 only?
Line 14: Bug-Url: https://bugzilla.redhat.com/1473344
Line 15: Change-Id: I6c05bddfba94d85e2c48122b6fd56d8f336d01f5
--
To view, visit https://gerrit.ovirt.org/79664
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6c05bddfba94d85e2c48122b6fd56d8f336d01f5
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: m2c: uses different protocol constant names
......................................................................
Patch Set 2:
(2 comments)
https://gerrit.ovirt.org/#/c/79664/2/lib/vdsm/config.py.in
File lib/vdsm/config.py.in:
Line 237: ('ssl_excludes', '',
Line 238: 'Comma separated protocol values as defined in '
Line 239: 'https://docs.python.org/2/library/ssl.html. '
Line 240: 'e.g. for ssl OP_NO_TLSv1, OP_NO_TLSv1_1 '
Line 241: ' for m2crypto SSL_OP_NO_TLSv1, SSL_OP_NO_TLSv1_1 '
funny.. just except both and do the conversion yourself based on the implementation you use. it will make the user's life easier
Line 242: 'By default tlv1, tlsv1.1 and tlsv1.2 are '
Line 243: 'enabled.'),
Line 244:
Line 245: ('connection_stats_timeout', '3600',
https://gerrit.ovirt.org/#/c/79664/2/lib/vdsm/m2cutils.py
File lib/vdsm/m2cutils.py:
Line 336: # not all m2crypto provide this constant
Line 337: excludes |= 268435456
Line 338: else:
Line 339: excludes |= getattr(m2, no_protocol.strip())
Line 340:
you are calling no_protocol.strip() in the condition, so the attr probably exists.. what constant m2crypto is not provided?
--
To view, visit https://gerrit.ovirt.org/79664
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6c05bddfba94d85e2c48122b6fd56d8f336d01f5
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: qemuimg: Move to vdsm.storage
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/79701
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id8391c9e7806800287454fc5a4c09ef5203e2500
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has uploaded a new change for review.
Change subject: [WIP] net.api: expose cancel_rollback()
......................................................................
[WIP] net.api: expose cancel_rollback()
When connectivityCheck=True is passed to the setupNetworks verb, an
automatically roll back is performed, unless unless cancel_rollback()
command is requested by the client. Note that Vdsm does not have an
explicit cancel_rollback verb. cancel_rollback is called as a side
effect of the ping verb.
Change-Id: If42316ac6ecd694e398534e3e87b915aeb4f1f38
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com>
---
M lib/vdsm/constants.py.in
M lib/vdsm/network/api.py
M lib/vdsm/network/connectivity.py
M vdsm/API.py
4 files changed, 9 insertions(+), 10 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/99/79299/1
diff --git a/lib/vdsm/constants.py.in b/lib/vdsm/constants.py.in
index 32c87d9..7ad3eb1 100644
--- a/lib/vdsm/constants.py.in
+++ b/lib/vdsm/constants.py.in
@@ -80,7 +80,6 @@
P_VDSM_CONF = '@CONFDIR@/' # NOQA: E501 (potentially long line)
P_VDSM_KEYS = '/etc/pki/vdsm/keys/'
-P_VDSM_CLIENT_LOG = '@VDSMRUNDIR@/client.log' # NOQA: E501 (potentially long line)
P_VDSM_LOG = '@VDSMLOGDIR@' # NOQA: E501 (potentially long line)
P_VDSM_NODE_ID = '/etc/vdsm/vdsm.id'
diff --git a/lib/vdsm/network/api.py b/lib/vdsm/network/api.py
index cb7210f..8c4113e 100644
--- a/lib/vdsm/network/api.py
+++ b/lib/vdsm/network/api.py
@@ -27,6 +27,7 @@
from vdsm import hooks
+from vdsm.common.fileutils import touch_file
from vdsm.network import netswitch
from vdsm.network import sourceroute
from vdsm.network.configurators.ifcfg import ConfigWriter
@@ -281,3 +282,7 @@
def remove_ovs_port(bridge, port):
netswitch.configurator.ovs_remove_port(bridge, port)
+
+
+def cancel_rollback():
+ touch_file(constants.P_VDSM_CLIENT_LOG)
diff --git a/lib/vdsm/network/connectivity.py b/lib/vdsm/network/connectivity.py
index 3b2402d..11e5601 100644
--- a/lib/vdsm/network/connectivity.py
+++ b/lib/vdsm/network/connectivity.py
@@ -30,6 +30,7 @@
from .errors import ConfigNetworkError
CONNECTIVITY_TIMEOUT_DEFAULT = 4
+P_VDSM_CLIENT_LOG = constants.P_VDSM_RUN + 'client.log'
def _get_connectivity_timeout(options):
@@ -50,7 +51,7 @@
start = time.time()
while timeout >= 0:
try:
- if os.stat(constants.P_VDSM_CLIENT_LOG).st_mtime > start:
+ if os.stat(P_VDSM_CLIENT_LOG).st_mtime > start:
return True
except OSError as e:
if e.errno == errno.ENOENT:
diff --git a/vdsm/API.py b/vdsm/API.py
index fc928a7..056f61e 100644
--- a/vdsm/API.py
+++ b/vdsm/API.py
@@ -22,6 +22,7 @@
import os
+from vdsm.network.api import cancel_rollback
from vdsm.network.errors import ConfigNetworkError
from vdsm import commands
@@ -78,13 +79,6 @@
throttledlog.throttle('getAllVmStats', 100)
-
-
-def updateTimestamp():
- # The setup API uses this log file to determine if this host is still
- # accessible. We use a file (rather than an event) because setup is
- # performed by a separate, root process.
- fileutils.touch_file(constants.P_VDSM_CLIENT_LOG)
class APIBase(object):
@@ -1237,7 +1231,7 @@
def ping(self):
"Ping the server. Useful for tests"
- updateTimestamp()
+ cancel_rollback()
return {'status': doneCode}
def getCapabilities(self):
--
To view, visit https://gerrit.ovirt.org/79299
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If42316ac6ecd694e398534e3e87b915aeb4f1f38
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79158 )
Change subject: net: Get iface mtu using netlink instead of sysfs
......................................................................
net: Get iface mtu using netlink instead of sysfs
link.iface module mostly uses netlink to fetch iface properties.
For consistency and efficiency, mtu is now collected through netlink.
Change-Id: I219e226957cddde922f11a6f490d3f8b89a620c4
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
---
M lib/vdsm/network/link/iface.py
M lib/vdsm/network/netinfo/cache.py
2 files changed, 3 insertions(+), 5 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Petr Horáček: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, approved
Edward Haas: Verified
--
To view, visit https://gerrit.ovirt.org/79158
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I219e226957cddde922f11a6f490d3f8b89a620c4
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79123 )
Change subject: net: Remove getMaxMtu function and inline it in the caller
......................................................................
net: Remove getMaxMtu function and inline it in the caller
getMaxMtu implementation is trivial enough not to require a special
function.
This patch is contributing to the netinfo cleanup effort.
Change-Id: Ibdbff5892c02bcf5fb2267704d3c32d07adbe3ee
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
---
M lib/vdsm/network/configurators/__init__.py
M lib/vdsm/network/netinfo/mtus.py
M tests/network/config_network_test.py
3 files changed, 2 insertions(+), 18 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Petr Horáček: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, approved
Edward Haas: Verified
--
To view, visit https://gerrit.ovirt.org/79123
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibdbff5892c02bcf5fb2267704d3c32d07adbe3ee
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79156 )
Change subject: net: Remove netinfo.mtus module and relocate content
......................................................................
net: Remove netinfo.mtus module and relocate content
The getMtu funtion has been relocated to link.iface and renamed to
get_mtu.
This patch is another step towards cleaning up netinfo package.
Change-Id: I8a3f09c81a42e27c4055bb0f364f76fb7fa1b6ea
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
---
M lib/vdsm/network/configurators/__init__.py
M lib/vdsm/network/legacy_switch.py
M lib/vdsm/network/link/iface.py
M lib/vdsm/network/models.py
M lib/vdsm/network/netinfo/Makefile.am
M lib/vdsm/network/netinfo/cache.py
D lib/vdsm/network/netinfo/mtus.py
M lib/vdsm/network/ovs/info.py
M tests/network/config_network_test.py
M tests/network/models_test.py
M tests/network/ovs_info_test.py
11 files changed, 27 insertions(+), 55 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Petr Horáček: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, approved
Edward Haas: Verified
--
To view, visit https://gerrit.ovirt.org/79156
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8a3f09c81a42e27c4055bb0f364f76fb7fa1b6ea
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: Remove netinfo.mtus module and relocate content
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/79156
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8a3f09c81a42e27c4055bb0f364f76fb7fa1b6ea
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: Remove getMaxMtu function and inline it in the caller
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/79123
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdbff5892c02bcf5fb2267704d3c32d07adbe3ee
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: hooking: move to static
......................................................................
Patch Set 4:
I know that this was my stupid suggestion, but folloeing Nir's comment about another module, I think that it would be better to keep (and deploy) hooking.py in a python subsubsubpackage of vdsm. We need to add tests for this tiny module, and making it easily importable would make it simpler.
--
To view, visit https://gerrit.ovirt.org/79638
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If2f1581d75cfb33868af41d1b116f56af89801a5
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: tool: remove dummy bridge
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/79596
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icd78fba239b37d2c556f37c63438ee076516560b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horacek <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: tool: clear networks configured by VDSM
......................................................................
Patch Set 4: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/79495/4/lib/vdsm/tool/network.py
File lib/vdsm/tool/network.py:
Line 110: networks_request[net] = attrs
Line 111: networks_request[net]['bridged'] = False
Line 112: else:
Line 113: networks_request[net] = {'remove': True}
Line 114: net_api.setupNetworks(networks_request, {}, {'connectivityCheck': False})
I believe you need to setSafeConfig
--
To view, visit https://gerrit.ovirt.org/79495
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I63702da4dd1c5a0328797f524734813ef251bdb6
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horacek <phoracek(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: RPC: Refactor JSON RPC exceptions
......................................................................
Patch Set 29:
(1 comment)
https://gerrit.ovirt.org/#/c/78660/29//COMMIT_MSG
Commit Message:
Line 13: For example, new error message for JsonRpcMethodNotFoundError is:
Line 14: The method does not exist or is not available: {'method': 'some_missing_method'}
Line 15:
Line 16: Also added a new class JsonRpcGeneralError, that can have
Line 17: any code and message.
> I see... I think, it would be better to put the changes of exceptions to an
Nir, Seems like you have amazing design and appropriate behavior that you would like to have in all vdsm code as maintainer - it sounds amazing. but all those comments can't show me what you want to create - its too long and I can't allow follow the context. please create design document for your desire of how handling error\exception should be in vdsm - what way of using this hierarchy is valid and what is not- like may I create interfaces? can I call super? can I use same message but two different codes? whatever you love, just write it in a way that we will be able to follow your way ... if you did so already, please share it and sorry for the interruption :)
Line 18:
Line 19: Change-Id: Ifdaf434aec6c65e7a896e5594fba711193cd2958
--
To view, visit https://gerrit.ovirt.org/78660
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifdaf434aec6c65e7a896e5594fba711193cd2958
Gerrit-PatchSet: 29
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: Allow QoS caps to ignore nets with multiple sb nics
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/79621
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icf9aad74622262f841657d1687babea60623d065
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michael Burman <mburman(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: hooks: support to read/write the raw domain XML
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/79489
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I009c7d03337bf267f9cf7b1b32e884d987d6adb3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: Get iface mtu using netlink instead of sysfs
......................................................................
Patch Set 2: Code-Review+2
no sure about efficiency, but new code looks nicer
--
To view, visit https://gerrit.ovirt.org/79158
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I219e226957cddde922f11a6f490d3f8b89a620c4
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: tool: clear networks configured by oVirt
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/79495/1/lib/vdsm/tool/network.py
File lib/vdsm/tool/network.py:
Line 121: networks_request[net] = {'remove': True}
Line 122: net_api.setupNetworks(networks_request, {}, {'connectivityCheck': False})
Line 123:
Line 124:
Line 125: def _remove_dummy_network():
this monstrosity is added in lib/vdsm/tool/dummybr.py. it is not a vdsm network, only a means to persist the dummy bridge.
Please add the bridge removal to dummybr.py (possibly in a separate patch)
Line 126: if os.path.exists('/sys/class/net/{}'.format(net_api.DUMMY_BRIDGE)):
Line 127: commands.execCmd([constants.EXT_BRCTL, 'delbr', net_api.DUMMY_BRIDGE])
Line 128:
Line 129: dummy_network = _get_libvirt_network_by_name(net_api.DUMMY_BRIDGE)
--
To view, visit https://gerrit.ovirt.org/79495
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I63702da4dd1c5a0328797f524734813ef251bdb6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horacek <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/76937 )
Change subject: network: remove ip from a nic used by a removed network
......................................................................
network: remove ip from a nic used by a removed network
Change-Id: I238d573202a8cef610d61c4ff52ff740ca37bf1b
Signed-off-by: Petr Horacek <phoracek(a)redhat.com>
Bug-Url: https://bugzilla.redhat.com/1432386
---
M lib/vdsm/network/configurators/ifcfg.py
M tests/network/func_net_basic_test.py
M tests/network/func_static_ip_test.py
3 files changed, 63 insertions(+), 0 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Petr Horáček: Verified
Edward Haas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/76937
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I238d573202a8cef610d61c4ff52ff740ca37bf1b
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Petr Horacek <phoracek(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79494 )
Change subject: static: use tabs for indetation in Makefile
......................................................................
static: use tabs for indetation in Makefile
Change-Id: I6a6979a2bf1a301930d88501202fd886f6197e9b
Signed-off-by: Petr Horacek <phoracek(a)redhat.com>
---
M static/Makefile.am
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jenkins CI: Passed CI tests
Dan Kenigsberg: Verified; Looks good to me, approved
Martin Polednik: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/79494
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6a6979a2bf1a301930d88501202fd886f6197e9b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Petr Horacek <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: static: use tabs for indetation in Makefile
......................................................................
Patch Set 1: Code-Review+2 Verified+1
Sorry!
--
To view, visit https://gerrit.ovirt.org/79494
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6a6979a2bf1a301930d88501202fd886f6197e9b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Petr Horacek <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79510 )
Change subject: sos: fix addCopySpecLimit call
......................................................................
sos: fix addCopySpecLimit call
sosreport 3.4 replace add_copy_spec_limit with
add_copy_spec.
commit 2e2559d4f3dd7625e52aad3314379ef1ee2afe41 replaced
this call but apperantly in prior sosreport versions,
number of parameters of add_copy_spec method was different and
caused a TypeError.
Change-Id: I52695ec43a65367b80d7291e213790dfd98ca4af
Signed-off-by: Irit Goihman <igoihman(a)redhat.com>
Bug-Url: https://bugzilla.redhat.com/1471663
---
M lib/sos/vdsm.py.in
1 file changed, 10 insertions(+), 1 deletion(-)
Approvals:
Piotr Kliczewski: Looks good to me, approved
Yaniv Bronhaim: Verified; Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/79510
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I52695ec43a65367b80d7291e213790dfd98ca4af
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: stomp: fix AsyncDispatcher next_check_interval
......................................................................
Patch Set 4: Code-Review+1
Irit's comment is correct - The discussion we have is not related to this fix. The code here is just wrong and must have this patch also in 4.1 - without any relation to the following patches
--
To view, visit https://gerrit.ovirt.org/79384
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4e7fe82f80535ff851eaf909de194419511154ba
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: stomp: fix AsyncDispatcher next_check_interval
......................................................................
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/79384/4/lib/yajsonrpc/stomp.py
File lib/yajsonrpc/stomp.py:
Line 413: self._incoming_heartbeat_in_milis == 0:
Line 414: return None
Line 415:
Line 416: if self._incoming_heartbeat_in_milis and \
Line 417: self._incoming_heartbeat_expiration_interval() < 0:
> We need timeouts, and instead of having a proper solution, we hacked this n
from what I understand the complexity is redundant in this code. we have a mess of implementations that part of them Im quite sure we don't use any more.
My problem is that I just can't map the dependencies between objects here each time I try to go over this code :| maybe its only be. but its exhausting
I'm not sure how urgent is the heartbeat feature - if it is for 4.1, lets hack this craziness again. but we can't keep doing that..
Do we still need the protocol detector? How many kind of "Dispatchers" we need? can we have only one Dispatcher implantation?
It still kills me why StompAdapterImpl and AsyncClient are not called frame handlers? why those can't be kind of dispatchers? all this hierarchy must be reconsidered and fixed.
Its long run changes that we can do in those areas.. I think we can rethink and make it much nicer... depends on priorities and desire
Line 418: self.handle_timeout()
Line 419: return None
Line 420:
Line 421: if self._outgoing_heartbeat_in_milis:
--
To view, visit https://gerrit.ovirt.org/79384
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4e7fe82f80535ff851eaf909de194419511154ba
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has uploaded a new change for review.
Change subject: gitignore: remove needless line
......................................................................
gitignore: remove needless line
commit 930686 removed this script, but forgot to clean .gitignore of it.
Change-Id: I7188a1b5ec7dc2bcb56844e3c2963708dd81cfd3
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com>
---
M .gitignore
1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/27/79427/1
diff --git a/.gitignore b/.gitignore
index 9937872..e334131 100644
--- a/.gitignore
+++ b/.gitignore
@@ -77,5 +77,4 @@
static/usr/share/man/man8/vdsmd.8
vdsm/rpc/vdsm-api.html
vdsm_hooks/openstacknet/sudoers
-vdsm_hooks/persist-vdsm-hooks
vdsm_hooks/checkips/vdsm-checkips.service
--
To view, visit https://gerrit.ovirt.org/79427
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7188a1b5ec7dc2bcb56844e3c2963708dd81cfd3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: RPC: JsonRpcClient supports multiple subscriptions
......................................................................
Patch Set 31:
(1 comment)
https://gerrit.ovirt.org/#/c/78656/31/lib/yajsonrpc/stompreactor.py
File lib/yajsonrpc/stompreactor.py:
Line 595: Set a callback which handles messages received
Line 596: from the main RPC queue.
Line 597:
Line 598: :param handler: Callback to handle incoming messages
Line 599: :type handler: function (string) -> ()
> The notation should mean, that the type of the 'handler' parameter is: 'fun
im confused what is this handler again. you should pass here JsonRpcClient instance or just the handle_message function pointer? err so not clear. for some reason I though this function gets class that implements the handle_message function
Line 600: """
Line 601: self._message_handler = handler
Line 602:
Line 603: def send(self, data, destination=None):
--
To view, visit https://gerrit.ovirt.org/78656
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f5df1a5208281241be82f9e651788eca520be64
Gerrit-PatchSet: 31
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: virt net: Interface default driver name set to 'vhost'
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/79398
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I508675f9dd40ba70803938902a1c2f8fced00504
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Meni Yakove <myakove(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79378 )
Change subject: net: NM acquire should ignore duplicate ifcfg files
......................................................................
net: NM acquire should ignore duplicate ifcfg files
When quering NM DBUS to translate a file path to a connection ID, an
error with "is not an ifcfg base file" is raised when the file is a copy
of an existing ifcfg file (a backup).
This patch ignores these king of error the same way it did for non ifcfg
files that are named with the ifcfg prefix.
Change-Id: I337db762d7c6f6247894d7f75096328f5726c273
Bug-Url: https://bugzilla.redhat.com/1441530
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
---
M lib/vdsm/network/nm/nmdbus/__init__.py
1 file changed, 6 insertions(+), 3 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
Edward Haas: Verified
--
To view, visit https://gerrit.ovirt.org/79378
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I337db762d7c6f6247894d7f75096328f5726c273
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: NM acquire should ignore duplicate ifcfg files
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/79378
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I337db762d7c6f6247894d7f75096328f5726c273
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-HasComments: No
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has removed gerrit-hooks from this change. ( https://gerrit.ovirt.org/79378 )
Change subject: net: NM acquire should ignore duplicate ifcfg files
......................................................................
Removed reviewer gerrit-hooks with the following votes:
* Verified-1 by gerrit-hooks <automation(a)ovirt.org>
--
To view, visit https://gerrit.ovirt.org/79378
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: I337db762d7c6f6247894d7f75096328f5726c273
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79349 )
Change subject: net: NM acquire should ignore duplicate ifcfg files
......................................................................
net: NM acquire should ignore duplicate ifcfg files
When quering NM DBUS to translate a file path to a connection ID, an
error with "is not an ifcfg base file" is raised when the file is a copy
of an existing ifcfg file (a backup).
This patch ignores these king of error the same way it did for non ifcfg
files that are named with the ifcfg prefix.
Change-Id: I337db762d7c6f6247894d7f75096328f5726c273
Bug-Url: https://bugzilla.redhat.com/1441530
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
---
M lib/vdsm/network/nm/nmdbus/__init__.py
1 file changed, 6 insertions(+), 3 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
Edward Haas: Verified
--
To view, visit https://gerrit.ovirt.org/79349
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I337db762d7c6f6247894d7f75096328f5726c273
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: NM acquire should ignore duplicate ifcfg files
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/79349
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I337db762d7c6f6247894d7f75096328f5726c273
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: RPC: JsonRpcClient supports multiple subscriptions
......................................................................
Patch Set 31: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/78656/31/lib/yajsonrpc/stompreactor.py
File lib/yajsonrpc/stompreactor.py:
Line 595: Set a callback which handles messages received
Line 596: from the main RPC queue.
Line 597:
Line 598: :param handler: Callback to handle incoming messages
Line 599: :type handler: function (string) -> ()
so again, what this notion means? sorry for my ignorance.
what function this handler should have? handle_message? lets make interface for that if needed
Line 600: """
Line 601: self._message_handler = handler
Line 602:
Line 603: def send(self, data, destination=None):
--
To view, visit https://gerrit.ovirt.org/78656
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f5df1a5208281241be82f9e651788eca520be64
Gerrit-PatchSet: 31
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: RPC: Small refactor of ClientRpcTransportAdapter
......................................................................
Patch Set 24:
(1 comment)
https://gerrit.ovirt.org/#/c/78655/24/lib/yajsonrpc/stompreactor.py
File lib/yajsonrpc/stompreactor.py:
Line 595: :param handler: Callback to handle incoming messages
Line 596: :type handler: function (ClientRpcTransportAdapter, string) -> ()
Line 597: """
Line 598: self._message_handler = handler
Line 599:
if you change this area again in https://gerrit.ovirt.org/#/c/78656/30/lib/yajsonrpc/stompreactor.py - just don't touch here at all - try to make this patch small as possible
Line 600: def send(self, data, destination=None):
Line 601: if not destination:
Line 602: destination = self._request_queue
Line 603:
--
To view, visit https://gerrit.ovirt.org/78655
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I19cad2983a94303cdcb07a4a5aacb074851d6b6c
Gerrit-PatchSet: 24
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: RPC: Small refactor of ClientRpcTransportAdapter
......................................................................
Patch Set 24:
(1 comment)
https://gerrit.ovirt.org/#/c/78655/24/lib/yajsonrpc/stompreactor.py
File lib/yajsonrpc/stompreactor.py:
Line 592: """
Line 593: Set a callback which handles received messages
Line 594:
Line 595: :param handler: Callback to handle incoming messages
Line 596: :type handler: function (ClientRpcTransportAdapter, string) -> ()
i don't understand this syntax.
the handle gets ClientRpcTransportAdapter and a string and return nothing? do we have some kind of message handler interface ?
Line 597: """
Line 598: self._message_handler = handler
Line 599:
Line 600: def send(self, data, destination=None):
--
To view, visit https://gerrit.ovirt.org/78655
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I19cad2983a94303cdcb07a4a5aacb074851d6b6c
Gerrit-PatchSet: 24
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/69447 )
Change subject: move vdsmd from vdsm dir
......................................................................
move vdsmd from vdsm dir
vdsmd.py moved to lib/vdsm and vdsmd script moved
to static directory
Change-Id: Ib683341bbf3e4ebdcb45c158391c21881b030633
Signed-off-by: Irit Goihman <igoihman(a)redhat.com>
---
M Makefile.am
M lib/vdsm/Makefile.am
R lib/vdsm/vdsmd.py
M static/Makefile.am
R static/usr/sbin/vdsmd
M vdsm.spec.in
M vdsm/Makefile.am
7 files changed, 5 insertions(+), 9 deletions(-)
Approvals:
Piotr Kliczewski: Looks good to me, approved
Jenkins CI: Passed CI tests
Irit Goihman: Verified
--
To view, visit https://gerrit.ovirt.org/69447
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib683341bbf3e4ebdcb45c158391c21881b030633
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/77571 )
Change subject: lib: move API
......................................................................
lib: move API
As part of bigger effort we move modules from vdsm to lib.vdsm. This
patch moves API.
Change-Id: I8eeff74f4269d886d557a912070b54c1d9d642ff
Signed-off-by: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Signed-off-by: Irit Goihman <igoihman(a)redhat.com>
---
M Makefile.am
R lib/vdsm/API.py
M lib/vdsm/Makefile.am
M lib/vdsm/network/configurators/ifcfg.py
M lib/vdsm/network/errors.py
M lib/vdsm/rpc/Bridge.py
M lib/vdsm/rpc/http.py
M lib/vdsm/storage/volume.py
M lib/vdsm/virt/vm.py
M tests/API_test.py
M tests/bridge_test.py
M tests/check_imports.py
M tests/integration/jsonRpcHelper.py
M tests/schemavalidation_test.py
M tests/vmapi_test.py
M vdsm.spec.in
M vdsm/Makefile.am
17 files changed, 17 insertions(+), 22 deletions(-)
Approvals:
Piotr Kliczewski: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Irit Goihman: Verified
Dan Kenigsberg: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/77571
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8eeff74f4269d886d557a912070b54c1d9d642ff
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/77570 )
Change subject: lib: move clientIF
......................................................................
lib: move clientIF
As part of bigger effort we move modules from vdsm to lib.vdsm. This
patch moves clientIF.
Change-Id: If00e1a8e2f4f776315fd04444a06fe3532a2d64e
Signed-off-by: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Signed-off-by: Irit Goihman <igoihman(a)redhat.com>
---
M Makefile.am
M lib/vdsm/Makefile.am
R lib/vdsm/clientIF.py
M lib/vdsm/virt/vm.py
M tests/clientif_test.py
M tests/vmapi_test.py
M vdsm.spec.in
M vdsm/API.py
M vdsm/Makefile.am
M vdsm/vdsmd.py
10 files changed, 10 insertions(+), 9 deletions(-)
Approvals:
Piotr Kliczewski: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Irit Goihman: Verified
Dan Kenigsberg: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/77570
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If00e1a8e2f4f776315fd04444a06fe3532a2d64e
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: lib: move API
......................................................................
Patch Set 7: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/77571
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8eeff74f4269d886d557a912070b54c1d9d642ff
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: lib: move clientIF
......................................................................
Patch Set 7: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/77570
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If00e1a8e2f4f776315fd04444a06fe3532a2d64e
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has uploaded a new change for review.
Change subject: API: drop needless code
......................................................................
API: drop needless code
The code dropped in this patch was required for ancient Engine versions
(pre 3.1), which are not supported for a very long time. Read more in
commit 95302a1 which introduced these calls.
Change-Id: I23c13501d20caff1c21cdd422a250ceee7cd7e24
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com>
---
M lib/vdsm/rpc/Bridge.py
M vdsm/API.py
2 files changed, 0 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/98/79298/1
diff --git a/lib/vdsm/rpc/Bridge.py b/lib/vdsm/rpc/Bridge.py
index 7d3c6f6..c93423e 100644
--- a/lib/vdsm/rpc/Bridge.py
+++ b/lib/vdsm/rpc/Bridge.py
@@ -264,7 +264,6 @@
This call is only interested in returning the VM UUIDs so pass False for
the first argument in order to suppress verbose results.
"""
- API.updateTimestamp() # required for setupNetworks flow
vmList = args.get('vmList', [])
onlyUUID = args.get('onlyUUID', True)
return API.Global().getVMList(False, vmList, onlyUUID)
diff --git a/vdsm/API.py b/vdsm/API.py
index cf7c04e..fc928a7 100644
--- a/vdsm/API.py
+++ b/vdsm/API.py
@@ -1245,7 +1245,6 @@
Report host capabilities.
"""
hooks.before_get_caps()
- updateTimestamp() # required for some ovirt-3.0.z Engines
c = caps.get()
c['netConfigDirty'] = str(self._cif._netConfigDirty)
c = hooks.after_get_caps(c)
--
To view, visit https://gerrit.ovirt.org/79298
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I23c13501d20caff1c21cdd422a250ceee7cd7e24
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has uploaded a new change for review.
Change subject: virt.sampling: drop dead code
......................................................................
virt.sampling: drop dead code
recentClient was used by the connectivity log, and should have been
dropped in commit f68cc2d7. This patch stops updating a field that no
one reads
Change-Id: Ibf858255ff91ac4fe96aecfb66f446f00e84d58f
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com>
---
M lib/vdsm/virt/sampling.py
1 file changed, 1 insertion(+), 10 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/96/79296/1
diff --git a/lib/vdsm/virt/sampling.py b/lib/vdsm/virt/sampling.py
index 189df9f..53eabb7 100644
--- a/lib/vdsm/virt/sampling.py
+++ b/lib/vdsm/virt/sampling.py
@@ -37,7 +37,7 @@
from vdsm import utils
import vdsm.common.time
from vdsm.config import config
-from vdsm.constants import P_VDSM_RUN, P_VDSM_CLIENT_LOG
+from vdsm.constants import P_VDSM_RUN
from vdsm.host import api as hostapi
from vdsm.network import ipwrapper
from vdsm.network.netinfo import nics, bonding, vlans
@@ -253,15 +253,6 @@
self.cpuCores = CpuCoreSample()
self.numaNodeMem = NumaNodeMemorySample()
ENGINE_DEFAULT_POLL_INTERVAL = 15
- try:
- self.recentClient = (
- self.timestamp - os.stat(P_VDSM_CLIENT_LOG).st_mtime <
- 2 * ENGINE_DEFAULT_POLL_INTERVAL)
- except OSError as e:
- if e.errno == errno.ENOENT:
- self.recentClient = False
- else:
- raise
_MINIMUM_SAMPLES = 1
--
To view, visit https://gerrit.ovirt.org/79296
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibf858255ff91ac4fe96aecfb66f446f00e84d58f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: NM acquire should ignore duplicate ifcfg files
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/79349/1/lib/vdsm/network/nm/nmdbus/__init__.py
File lib/vdsm/network/nm/nmdbus/__init__.py:
Line 67: """
Line 68: con_info = (None, None)
Line 69: try:
Line 70: con_info = self.ifcfg.GetIfcfgDetails(ifcfg_path)
Line 71: except DBusException as ex:
yuck, don't they have numeric exception names?
Line 72: for err_base_message in NMDbusIfcfgRH1.ERROR_INV_CON:
Line 73: if err_base_message.format(ifcfg_path) == ex.args[0]:
Line 74: return con_info
Line 75: raise
--
To view, visit https://gerrit.ovirt.org/79349
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I337db762d7c6f6247894d7f75096328f5726c273
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: virt: remove vdsm/virt directory
......................................................................
Patch Set 2: Code-Review+2
!
--
To view, visit https://gerrit.ovirt.org/79339
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I31bd6bbd28021ddf16036c129a2bb4283c7e369d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: Report lldp through new getLldp command
......................................................................
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/79093/5/lib/vdsm/network/api.py
File lib/vdsm/network/api.py:
Line 284: def remove_ovs_port(bridge, port):
Line 285: netswitch.configurator.ovs_remove_port(bridge, port)
Line 286:
Line 287:
Line 288: def lldp_info(device):
> getVMList has a "vmList" argument specifying which vmid are interesting to
I do not see an easy way (or immediate need) to specify TLVs that are interesting to the client. Let us not block on this question and return them all; if a limiting filter becomes useful, we can add an additional argument.
Line 289: """"
Line 290: Get LLDP information of a device.
Line 291:
Line 292: Returns LLDP Information
--
To view, visit https://gerrit.ovirt.org/79093
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1e5e81cfbfe9c714d8173ecd6ee20f8b59bd14fe
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dominik Holler <dholler(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dominik Holler <dholler(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: RPC: JsonRpcClient supports multiple subscriptions
......................................................................
Patch Set 28: Code-Review-1
(4 comments)
https://gerrit.ovirt.org/#/c/78656/28//COMMIT_MSG
Commit Message:
Line 10: responses and only from a single queue.
Line 11:
Line 12: Now it is possible to subscribe to multiple queues
Line 13: and receive also events as well as rpc responses.
Line 14:
how?
you need to explain here the logic you add - how the callback is being used, when we need callback when we handle_msg and how its being set
Line 15: Change-Id: I4f5df1a5208281241be82f9e651788eca520be64
https://gerrit.ovirt.org/#/c/78656/28/lib/yajsonrpc/__init__.py
File lib/yajsonrpc/__init__.py:
Line 497:
Line 498: def _handleMessage(self, message, callback=None):
Line 499: try:
Line 500: mobj = json.loads(message)
Line 501: isResponse = self._isResponse(mobj)
yes? events are not count as response? kill me, but I don't get the _isResponse implementation, so you'll tell me if its indeed work as expected
Line 502: except:
Line 503: self.log.exception("Problem parsing message from client")
Line 504: return
Line 505:
Line 522:
Line 523: req = JsonRpcRequest.fromRawObject(obj)
Line 524: if not req.isNotification():
Line 525: self.log.warning("Received non notification, ignoring")
Line 526: return
separate patch please
Line 527:
Line 528: callback(req.method, req.params)
Line 529:
Line 530: def close(self):
https://gerrit.ovirt.org/#/c/78656/28/lib/yajsonrpc/stompreactor.py
File lib/yajsonrpc/stompreactor.py:
Line 606: destination,
Line 607: headers,
Line 608: )
Line 609:
Line 610: def subscribe(self, queue_name, handler):
what is handler?
Line 611: sub_id = uuid4()
Line 612: self._subs[sub_id] = self._client.subscribe(
Line 613: queue_name,
Line 614: sub_id=str(sub_id),
--
To view, visit https://gerrit.ovirt.org/78656
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f5df1a5208281241be82f9e651788eca520be64
Gerrit-PatchSet: 28
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: RPC: Small refactor of ClientRpcTransportAdapter
......................................................................
Patch Set 22: Code-Review-1
(3 comments)
https://gerrit.ovirt.org/#/c/78655/22/lib/yajsonrpc/stompreactor.py
File lib/yajsonrpc/stompreactor.py:
Line 573: class ClientRpcTransportAdapter(object):
Line 574: def __init__(self, request_queue, response_queue, client):
Line 575: self._client = client
Line 576: self._message_handler = lambda arg: None
Line 577: self._request_queue = request_queue
how this request queue is being used?
when you send data without destination, you add it to this queue and how is it being handled?
Line 578:
Line 579: self._sub = self._client.subscribe(
Line 580: response_queue,
Line 581: sub_id=str(uuid4()),
Line 587: handler which is responsible for processing jsonrpc
Line 588: content of the message. Currently, the only handler
Line 589: is JsonRpcClient.
Line 590: """
Line 591: def set_message_handler(self, handler):
so call it - set_jsonrpc_client
Line 592: self._message_handler = handler
Line 593:
Line 594: def send(self, data, destination=None):
Line 595: if not destination:
Line 588: content of the message. Currently, the only handler
Line 589: is JsonRpcClient.
Line 590: """
Line 591: def set_message_handler(self, handler):
Line 592: self._message_handler = handler
also the var - self._jsonrpcclient
what is message handler?
Line 593:
Line 594: def send(self, data, destination=None):
Line 595: if not destination:
Line 596: destination = self._request_queue
--
To view, visit https://gerrit.ovirt.org/78655
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I19cad2983a94303cdcb07a4a5aacb074851d6b6c
Gerrit-PatchSet: 22
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: RPC: Add missing return statement when handling messages
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/79308/1/lib/yajsonrpc/__init__.py
File lib/yajsonrpc/__init__.py:
Line 482: transport, message = req
Line 483: try:
Line 484: mobj = json.loads(message)
Line 485: isResponse = self._isResponse(mobj)
Line 486: except:
if you're already here - add specific catch if possible to be more explicit
Line 487: self.log.exception("Problem parsing message from client")
Line 488: return
Line 489:
Line 490: if isResponse:
--
To view, visit https://gerrit.ovirt.org/79308
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I04ce4a5c6758e7bf0272ffac51f0cec89e3f6b8e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: RPC client: Add methods to subscribe, unsubscribe and notify
......................................................................
Patch Set 21:
I like the tests, but it sounds odd that we don't have client_test module already ... so I grabbed for it and saw some tests in stompTests - worth to put all client tests under your new test module
Thanks!
--
To view, visit https://gerrit.ovirt.org/78657
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie5b1e2eace452bf663c34c721bbe3ff9fcabb095
Gerrit-PatchSet: 21
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: RPC: Recieve and parse messages from multiple subscriptions
......................................................................
Patch Set 23:
(1 comment)
https://gerrit.ovirt.org/#/c/78656/23//COMMIT_MSG
Commit Message:
Line 7: RPC: Recieve and parse messages from multiple subscriptions
Line 8:
Line 9: JsonRpcClient parses json messages
Line 10: from multiple subscriptions and calls
Line 11: the registered callback.
> Ok, I will rephrase it.
yes, explain how, and how it was - code-wise
Line 12:
Line 13: Change-Id: I4f5df1a5208281241be82f9e651788eca520be64
--
To view, visit https://gerrit.ovirt.org/78656
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f5df1a5208281241be82f9e651788eca520be64
Gerrit-PatchSet: 23
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: api: log only external pings
......................................................................
Patch Set 6:
omg, we had quite the same thing in the past: http://gerrit.ovirt.org/30178
--
To view, visit https://gerrit.ovirt.org/78142
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9eff40244f38d5707f9e1cec64d20bcd68415b2d
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Petr Horacek <phoracek(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has uploaded a new change for review.
Change subject: openstacknet hook: do not use vdsm-internal constants
......................................................................
openstacknet hook: do not use vdsm-internal constants
Hooks should avoid vdsm internals. Luckily, EXT_BRCTL is already
defined in openstrack_utils. The hook script should use its
locally-available definition.
Change-Id: Iee6647bce1eba3042f00ec74742d0cadc8ab329a
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com>
---
M vdsm_hooks/openstacknet/after_device_create.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/54/79254/1
diff --git a/vdsm_hooks/openstacknet/after_device_create.py b/vdsm_hooks/openstacknet/after_device_create.py
index f98c166..9e5c8c1 100755
--- a/vdsm_hooks/openstacknet/after_device_create.py
+++ b/vdsm_hooks/openstacknet/after_device_create.py
@@ -34,7 +34,7 @@
from openstacknet_utils import VNIC_ID_KEY
from openstacknet_utils import devName
from openstacknet_utils import executeOrExit
-from vdsm.constants import EXT_BRCTL
+from openstacknet_utils import EXT_BRCTL
def disconnectVnic(portId):
--
To view, visit https://gerrit.ovirt.org/79254
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iee6647bce1eba3042f00ec74742d0cadc8ab329a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: RPC: Recieve and parse messages from multiple subscriptions
......................................................................
Patch Set 23:
(6 comments)
https://gerrit.ovirt.org/#/c/78656/23//COMMIT_MSG
Commit Message:
Line 7: RPC: Recieve and parse messages from multiple subscriptions
Line 8:
Line 9: JsonRpcClient parses json messages
Line 10: from multiple subscriptions and calls
Line 11: the registered callback.
I really don't understand what you're doing in that patch from the commit msg.. please explain - from the text here I understand that JsonRpcClient parse msgs, and call callbacks.. wasn't it like that before? do you add something new?
Line 12:
Line 13: Change-Id: I4f5df1a5208281241be82f9e651788eca520be64
https://gerrit.ovirt.org/#/c/78656/23/lib/yajsonrpc/__init__.py
File lib/yajsonrpc/__init__.py:
Line 363: def __init__(self, transport):
Line 364: self.log = logging.getLogger("jsonrpc.JsonRpcClient")
Line 365: transport.set_message_handler(
Line 366: lambda msg: self._handleMessage(msg)
Line 367: )
why is it needed?
Line 368:
Line 369: self._transport = transport
Line 370: self._runningRequests = {}
Line 371: self._lock = Lock()
Line 417: lambda msg: self._handleMessage(msg, callback)
Line 418: )
Line 419:
Line 420: def unsubscribe(self, sub_id):
Line 421: self._transport.unsubscribe(sub_id)
renaming - separate patch
you can make one patch for all renames. I'd love that
Line 422:
Line 423: def notify(self, event_id, dest, event_schema, params=None):
Line 424: """
Line 425: JsonRpcClient notify method, sends an event on a spesific queue
Line 454: if isinstance(obj, list):
Line 455: map(self._processIncomingResponse, obj)
Line 456: return
Line 457:
Line 458: resp = JsonRpcResponse.fromRawObject(obj)
renaming - separate patch
Line 459: with self._lock:
Line 460: if resp.id is None:
Line 461: self.log.warning(
Line 462: "Got an error from server without an ID (%s)",
Line 487: mobj = json.loads(message)
Line 488: isResponse = self._isResponse(mobj)
Line 489: except:
Line 490: self.log.exception("Problem parsing message from client")
Line 491: return
this is big change\fix... you must explain. it worth separate patch
Line 492:
Line 493: if isResponse:
Line 494: self._processIncomingResponse(mobj)
Line 495: else:
https://gerrit.ovirt.org/#/c/78656/23/lib/yajsonrpc/stompreactor.py
File lib/yajsonrpc/stompreactor.py:
Line 610
Line 611
Line 612
Line 613
Line 614
no more _handle_message calls?
--
To view, visit https://gerrit.ovirt.org/78656
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f5df1a5208281241be82f9e651788eca520be64
Gerrit-PatchSet: 23
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: RPC: Refactor ClientRpcTransportAdapter
......................................................................
Patch Set 18:
(1 comment)
https://gerrit.ovirt.org/#/c/78655/18//COMMIT_MSG
Commit Message:
Line 3: AuthorDate: 2017-06-26 11:22:07 +0200
Line 4: Commit: Andrej Krejcir <akrejcir(a)redhat.com>
Line 5: CommitDate: 2017-07-11 15:54:35 +0200
Line 6:
Line 7: RPC: Refactor ClientRpcTransportAdapter
if you call it "Refactor" - why not also to move this code out of stompreactor and have all client code in one module.common code between server to client can be maybe in this module/. what do you think?
Line 8:
Line 9: The class now subscribes in the constructor,
Line 10: instead of taking an existing subscription
Line 11: as a parameter.
--
To view, visit https://gerrit.ovirt.org/78655
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I19cad2983a94303cdcb07a4a5aacb074851d6b6c
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: RPC: Refactor ClientRpcTransportAdapter
......................................................................
Patch Set 18:
(1 comment)
https://gerrit.ovirt.org/#/c/78655/18//COMMIT_MSG
Commit Message:
Line 7: RPC: Refactor ClientRpcTransportAdapter
Line 8:
Line 9: The class now subscribes in the constructor,
Line 10: instead of taking an existing subscription
Line 11: as a parameter.
what about your addition of response queue.. also interesting to mention
Line 12:
Line 13: Change-Id: I19cad2983a94303cdcb07a4a5aacb074851d6b6c
--
To view, visit https://gerrit.ovirt.org/78655
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I19cad2983a94303cdcb07a4a5aacb074851d6b6c
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: RPC: Refactor ClientRpcTransportAdapter
......................................................................
Patch Set 18: Code-Review-1
(3 comments)
https://gerrit.ovirt.org/#/c/78655/18/lib/yajsonrpc/__init__.py
File lib/yajsonrpc/__init__.py:
Line 478
Line 479
Line 480
Line 481
Line 482
please do this change in separate patch. it doesn't look related. just removal of redundant code which is awesome!
https://gerrit.ovirt.org/#/c/78655/18/lib/yajsonrpc/stompreactor.py
File lib/yajsonrpc/stompreactor.py:
Line 584:
Line 585: """
Line 586: In order to process message we need to set message
Line 587: handler which is responsible for processing jsonrpc
Line 588: content of the message.
now we have only 1 handler? specify what type of handle i can set here
Line 589: """
Line 590: def set_message_handler(self, handler):
Line 591: self._message_handler = handler
Line 592:
Line 610: def unsubscribe(self, sub):
Line 611: self._client.unsubscribe(sub)
Line 612:
Line 613: def _handle_message(self, sub, frame):
Line 614: self._message_handler(frame.body)
please do this change in separate patch. it doesn't look related. just removal of redundant code which is awesome!
Line 615:
Line 616: def close(self):
Line 617: self._sub.unsubscribe()
Line 618: self._client.close()
--
To view, visit https://gerrit.ovirt.org/78655
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I19cad2983a94303cdcb07a4a5aacb074851d6b6c
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: hooks: reduce scope for after_disk_prepare
......................................................................
Patch Set 7:
(4 comments)
https://gerrit.ovirt.org/#/c/78529/7//COMMIT_MSG
Commit Message:
Line 9: Add a whitelist of attributes passed to and updated from
Line 10: the after_disk_prepare hook.
Line 11: No intended change in behaviour: the whitelist is modeled
Line 12: on the needs of the localdisk hook.
Line 13:
please state the motivation: we need to simplify the hook API so we can limit the data that needs to be extracted from and updated into the devicexml.
Line 14: We are not sure we will backport this to 4.1.z, but the
Line 15: patch is made ready for that.
Line 16:
Line 17: Change-Id: I5c39d893000ad2d4755b95d8ec9258840423f04d
https://gerrit.ovirt.org/#/c/78529/7/lib/vdsm/hooks.py
File lib/vdsm/hooks.py:
Line 457: flags_file = _LAUNCH_FLAGS_PATH % vm_id
Line 458: os.remove(flags_file)
Line 459:
Line 460:
Line 461: _IMPORTED_KEYS = ('path', 'format')
I would have hidden this inside its sole using module (vm.py) but I can live with this here.
Line 462: _EXPORTED_KEYS = _IMPORTED_KEYS + (
Line 463: 'device', 'type', 'imageID', 'volumeID', 'domainID', 'poolID'
Line 464: )
Line 465:
https://gerrit.ovirt.org/#/c/78529/7/static/usr/share/man/man8/vdsmd.8.in
File static/usr/share/man/man8/vdsmd.8.in:
PS7, Line 153: those
the following
PS7, Line 158: modify
modifies
--
To view, visit https://gerrit.ovirt.org/78529
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5c39d893000ad2d4755b95d8ec9258840423f04d
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: concurrent: Log BaseException when threads finish
......................................................................
Patch Set 1: Code-Review+1
did someone raise a string somewhere?!
--
To view, visit https://gerrit.ovirt.org/79241
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2570e083bb56a832fee978114ef6c7386e6860d6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79128 )
Change subject: spec: Conditionally use gluster version
......................................................................
spec: Conditionally use gluster version
Use glusterfs >=3.8 for RHEL and use
latest upstream for all other distro.
Change-Id: I838d64527ff27f9403355e6aae51832a1db971ac
Signed-off-by: Sahina Bose <sabose(a)redhat.com>
---
M vdsm.spec.in
1 file changed, 5 insertions(+), 1 deletion(-)
Approvals:
Nir Soffer: Verified
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/79128
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I838d64527ff27f9403355e6aae51832a1db971ac
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: spec: Conditionally use gluster version
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/79128
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I838d64527ff27f9403355e6aae51832a1db971ac
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has uploaded a new change for review.
Change subject: [WIP] iscsi: netIfaceName: expect network name
......................................................................
[WIP] iscsi: netIfaceName: expect network name
This is pseudo code for letting Engine pass the network it would like to
use for iscsi connection, and let Vdsm resolve it to the specific
IP-bearing interface to be used by iscsiadm.
Without this patch, Engine has to know too much about the implementation
of networks on Vdsm.
Change-Id: Ia50582ae0202e4dd058c254f3b34d8817d28fe80
Bug-Url: https://bugzilla.redhat.com/1441245
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com>
---
M lib/vdsm/storage/hsm.py
1 file changed, 17 insertions(+), 10 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/36/79236/1
diff --git a/lib/vdsm/storage/hsm.py b/lib/vdsm/storage/hsm.py
index 22841f7..99c19d1 100644
--- a/lib/vdsm/storage/hsm.py
+++ b/lib/vdsm/storage/hsm.py
@@ -130,16 +130,21 @@
sd.GLUSTERFS_DOMAIN: 'glusterfs'}
-def _updateIfaceNameIfNeeded(iface, netIfaceName):
+def _updateIfaceNameIfNeeded(iface, network_name):
if iface.netIfaceName is None:
- iface.netIfaceName = netIfaceName
+ if network_name is a network name:
+ iface.netIfaceName = northbound iface of network_name
+ else:
+ # Engine < 4.2 may pass the intrface name instead of the network
+ # name.
+ iface.netIfaceName = network_name
iface.update()
return True
return False
-def _resolveIscsiIface(ifaceName, initiatorName, netIfaceName):
+def _resolveIscsiIface(ifaceName, initiatorName, network_name):
if not ifaceName:
return iscsi.IscsiInterface('default')
@@ -148,14 +153,16 @@
if iface.name != ifaceName:
continue
- if netIfaceName is not None:
- if (not _updateIfaceNameIfNeeded(iface, netIfaceName) and
+ if network_name is not None:
+ if (not _updateIfaceNameIfNeeded(iface, network_name) and
netIfaceName != iface.netIfaceName):
- logging.error('iSCSI netIfaceName coming from engine [%s] '
- 'is different from iface.net_ifacename '
- 'present on the system [%s]. Aborting iscsi '
- 'iface [%s] configuration.' %
- (netIfaceName, iface.netIfaceName, iface.name))
+ logging.error(
+ 'network_name coming from engine [%s] was resolved to'
+ 'iSCSI netIfaceName [%s] which is different from '
+ 'iface.net_ifacename present on the system [%s]. '
+ 'Aborting iscsi iface [%s] configuration.' %
+ (network_name, netIfaceName, iface.netIfaceName,
+ iface.name))
raise se.iSCSIifaceError()
--
To view, visit https://gerrit.ovirt.org/79236
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia50582ae0202e4dd058c254f3b34d8817d28fe80
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: Report lldp through new getLldp command
......................................................................
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/79093/5/lib/vdsm/network/api.py
File lib/vdsm/network/api.py:
Line 284: def remove_ovs_port(bridge, port):
Line 285: netswitch.configurator.ovs_remove_port(bridge, port)
Line 286:
Line 287:
Line 288: def lldp_info(device):
> Is such a complex filtering used in other placed in VDSM already?
getVMList has a "vmList" argument specifying which vmid are interesting to the caller. (I hope I understood your question)
Line 289: """"
Line 290: Get LLDP information of a device.
Line 291:
Line 292: Returns LLDP Information
--
To view, visit https://gerrit.ovirt.org/79093
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1e5e81cfbfe9c714d8173ecd6ee20f8b59bd14fe
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dominik Holler <dholler(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dominik Holler <dholler(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: ssl: wrong protocol used by the client
......................................................................
Patch Set 7: Code-Review+2
I prefer that. more clear to me
--
To view, visit https://gerrit.ovirt.org/79194
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I82ec945a8e6520fdda8848861ef0b7a5922bf6d4
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Nelly Credi <ncredi(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: ssl: wrong protocol used by the client
......................................................................
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/79194/6/lib/yajsonrpc/stompreactor.py
File lib/yajsonrpc/stompreactor.py:
Line 594: from vdsm.sslutils import CLIENT_PROTOCOL, SSLContext
Line 595: sslctx = SSLContext(key_file=constants.KEY_FILE,
Line 596: cert_file=constants.CERT_FILE,
Line 597: ca_certs=constants.CA_FILE,
Line 598: protocol=CLIENT_PROTOCOL)
> just write it directly the value instead of this CLIENT_PROTCOL constant, i
ssl.PROTOCOL_SSLv23
Line 599: return StandAloneRpcClient(host, port, "jms.topic.vdsm_requests",
Line 600: str(uuid4()), sslctx, lazy_start=False)
Line 601:
Line 602:
--
To view, visit https://gerrit.ovirt.org/79194
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I82ec945a8e6520fdda8848861ef0b7a5922bf6d4
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Nelly Credi <ncredi(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: ssl: wrong protocol used by the client
......................................................................
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/79194/6/lib/yajsonrpc/stompreactor.py
File lib/yajsonrpc/stompreactor.py:
Line 594: from vdsm.sslutils import CLIENT_PROTOCOL, SSLContext
Line 595: sslctx = SSLContext(key_file=constants.KEY_FILE,
Line 596: cert_file=constants.CERT_FILE,
Line 597: ca_certs=constants.CA_FILE,
Line 598: protocol=CLIENT_PROTOCOL)
just write it directly the value instead of this CLIENT_PROTCOL constant, if its always the same value
Line 599: return StandAloneRpcClient(host, port, "jms.topic.vdsm_requests",
Line 600: str(uuid4()), sslctx, lazy_start=False)
Line 601:
Line 602:
--
To view, visit https://gerrit.ovirt.org/79194
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I82ec945a8e6520fdda8848861ef0b7a5922bf6d4
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Nelly Credi <ncredi(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: ssl: wrong protocol used by the client
......................................................................
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/79194/5//COMMIT_MSG
Commit Message:
Line 7: ssl: wrong protocol used by the client
Line 8:
Line 9:
Line 10: No matter which ssl implementation we are using we need to pass
Line 11: CLIENT_PROTOCOL from sslutils and ignore protocol config settings.
protocol config settings? you mean the value that we can configure in vdsm.conf?
Line 12:
Line 13: This change is related to ovirt-4.1 branch since on master we are using
Line 14: only one ssl implementation - native ssl.
Line 15:
--
To view, visit https://gerrit.ovirt.org/79194
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I82ec945a8e6520fdda8848861ef0b7a5922bf6d4
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Nelly Credi <ncredi(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: ssl: wrong protocol used by the client
......................................................................
Patch Set 5:
(2 comments)
https://gerrit.ovirt.org/#/c/79194/5/lib/yajsonrpc/stompreactor.py
File lib/yajsonrpc/stompreactor.py:
Line 24
Line 25
Line 26
Line 27
Line 28
this gives the config value
Line 590: there is a need to customize please use StandAloneRpcClient().
Line 591: """
Line 592: sslctx = None
Line 593: if ssl:
Line 594: from vdsm.sslutils import CLIENT_PROTOCOL, SSLContext
this gives hard-coded value?
Line 595: sslctx = SSLContext(key_file=constants.KEY_FILE,
Line 596: cert_file=constants.CERT_FILE,
Line 597: ca_certs=constants.CA_FILE,
Line 598: protocol=CLIENT_PROTOCOL)
--
To view, visit https://gerrit.ovirt.org/79194
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I82ec945a8e6520fdda8848861ef0b7a5922bf6d4
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Nelly Credi <ncredi(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: ssl: wrong protocol used by the client
......................................................................
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/79194/4/lib/yajsonrpc/stompreactor.py
File lib/yajsonrpc/stompreactor.py:
Line 590: there is a need to customize please use StandAloneRpcClient().
Line 591: """
Line 592: sslctx = None
Line 593: if ssl:
Line 594: from vdsm.sslutils import CLIENT_PROTOCOL, SSLContext
> No it is not, sslcompat give you value depending on config.py but here we w
and both called CLIENT_PROTOCOL? this looks like a magic fix. I import the variable from different location and I get different behavior - have different name if each point to different meaning
Line 595: sslctx = SSLContext(key_file=constants.KEY_FILE,
Line 596: cert_file=constants.CERT_FILE,
Line 597: ca_certs=constants.CA_FILE,
Line 598: protocol=CLIENT_PROTOCOL)
--
To view, visit https://gerrit.ovirt.org/79194
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I82ec945a8e6520fdda8848861ef0b7a5922bf6d4
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Nelly Credi <ncredi(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: ssl: wrong protocol used by the client
......................................................................
Patch Set 4:
(3 comments)
sorry, im not sure I understand the fix. added comments
https://gerrit.ovirt.org/#/c/79194/4//COMMIT_MSG
Commit Message:
Line 6:
Line 7: ssl: wrong protocol used by the client
Line 8:
Line 9: When vdsm uses m2crypto we pass CLIENT_PROTOCOL to vdsm client defined
Line 10: by this implementation. The client uses always ssl so we need to make
this sentence is not clear to me - I guess you meant we pass XX to Y which defines its ssl implementation?
Line 11: sure to pass protocol for this implementation.
Line 12:
Line 13: This change is related to ovirt-4.1 branch since on master we are using
Line 14: only one ssl implementation - native ssl.
Line 9: When vdsm uses m2crypto we pass CLIENT_PROTOCOL to vdsm client defined
Line 10: by this implementation. The client uses always ssl so we need to make
Line 11: sure to pass protocol for this implementation.
Line 12:
Line 13: This change is related to ovirt-4.1 branch since on master we are using
LABEL: OVIRT-4.1 ONLY
Line 14: only one ssl implementation - native ssl.
Line 15:
Line 16:
Line 17: Bug-Url: https://bugzilla.redhat.com/1468991https://gerrit.ovirt.org/#/c/79194/4/lib/yajsonrpc/stompreactor.py
File lib/yajsonrpc/stompreactor.py:
Line 590: there is a need to customize please use StandAloneRpcClient().
Line 591: """
Line 592: sslctx = None
Line 593: if ssl:
Line 594: from vdsm.sslutils import CLIENT_PROTOCOL, SSLContext
do you have CLIENT_PROTOCOL on both sslutils and sslcompact and they are different ? this is odd
Line 595: sslctx = SSLContext(key_file=constants.KEY_FILE,
Line 596: cert_file=constants.CERT_FILE,
Line 597: ca_certs=constants.CA_FILE,
Line 598: protocol=CLIENT_PROTOCOL)
--
To view, visit https://gerrit.ovirt.org/79194
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I82ec945a8e6520fdda8848861ef0b7a5922bf6d4
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Nelly Credi <ncredi(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/78862 )
Change subject: network: make sure to pass bytes to io.BytesIO
......................................................................
network: make sure to pass bytes to io.BytesIO
Change-Id: I756f87a1ec34f88c1ebeeb09462127aebbfad98a
Signed-off-by: Petr Horacek <phoracek(a)redhat.com>
---
M tests/network/netinfo_test.py
1 file changed, 9 insertions(+), 9 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Petr Horáček: Verified
Dan Kenigsberg: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/78862
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I756f87a1ec34f88c1ebeeb09462127aebbfad98a
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horacek <phoracek(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: network: make sure to pass bytes to io.BytesIO
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/78862
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I756f87a1ec34f88c1ebeeb09462127aebbfad98a
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horacek <phoracek(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/78780 )
Change subject: net: Generate dump bonding options on boot and upgrade
......................................................................
net: Generate dump bonding options on boot and upgrade
Compatible bonding options aren't guaranteed across different
kernel version, so a scenario where the kernel is upgraded and incompatible
default options are lingering will cause problems.
Instead of shipping with default options, dump bonding defaults on
boot via network service and installation/upgrade via a new
dedicated configurator.
Change-Id: I98f7c691a2a86d152ebcb81e1d96f9b0d83fa698
Bug-Id: https://bugzilla.redhat.com/1468240
Signed-off-by: Leon Goldberg <lgoldber(a)redhat.com>
---
M init/systemd/vdsm-network.service.in
M lib/vdsm/tool/configurators/Makefile.am
A lib/vdsm/tool/configurators/bond_defaults.py
M tests/Makefile.am
R tests/bonding-defaults.json
M tests/netinfoTests.py
M tests/netmodelsTests.py
M vdsm.spec.in
M vdsm/Makefile.am
9 files changed, 60 insertions(+), 15 deletions(-)
Approvals:
Michael Burman: Verified
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
Edward Haas: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/78780
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I98f7c691a2a86d152ebcb81e1d96f9b0d83fa698
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Meni Yakove <myakove(a)redhat.com>
Gerrit-Reviewer: Michael Burman <mburman(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: Generate dump bonding options on boot and upgrade
......................................................................
Patch Set 11: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/78780
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I98f7c691a2a86d152ebcb81e1d96f9b0d83fa698
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Meni Yakove <myakove(a)redhat.com>
Gerrit-Reviewer: Michael Burman <mburman(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has uploaded a new change for review.
Change subject: ifcfg: ad_actor_system can not be reset to its default value
......................................................................
ifcfg: ad_actor_system can not be reset to its default value
_restore_default_bond_options tried to reset this option to
00:00:00:00:00:00, which (on Fedora 23) causes "IOError: [Errno 22]
Invalid argument", during testSetupNetworksActiveSlave.
Linux documentation (bonding.txt) says that "The value can not
be either NULL or Multicast".
Let's add ad_actor_system to EXCLUDED_BONDING_ENTRIES for now
and assume that if a user set ad_actor_system explicitly, she
knows the way to reset it, and that is by setting it to the bond's
own MAC address:
In an AD system, this specifies the mac-address for the actor in
protocol packet exchanges (LACPDUs). The value cannot be NULL or
multicast. It is preferred to have the local-admin bit set for this
mac but driver does not enforce it. If the value is not given then
system defaults to using the masters' mac address as actors' system
address.
Change-Id: I3f307b64546c3efa73ca202e97ced49eeb9670e9
Signed-off-by: Ondřej Svoboda <osvoboda(a)redhat.com>
Reviewed-on: https://gerrit.ovirt.org/57490
Reviewed-by: Dan Kenigsberg <danken(a)redhat.com>
Continuous-Integration: Dan Kenigsberg <danken(a)redhat.com>
---
M lib/vdsm/netinfo.py
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/98/78898/1
diff --git a/lib/vdsm/netinfo.py b/lib/vdsm/netinfo.py
index bfd7546..d93a3c9 100644
--- a/lib/vdsm/netinfo.py
+++ b/lib/vdsm/netinfo.py
@@ -72,7 +72,8 @@
_BONDING_LOADBALANCE_MODES = frozenset(('0', '2', '4', '5', '6'))
_EXCLUDED_BONDING_ENTRIES = frozenset((
'slaves', 'active_slave', 'mii_status', 'queue_id', 'ad_aggregator',
- 'ad_num_ports', 'ad_actor_key', 'ad_partner_key', 'ad_partner_mac'
+ 'ad_num_ports', 'ad_actor_key', 'ad_partner_key', 'ad_partner_mac',
+ 'ad_actor_system'
))
_IFCFG_ZERO_SUFFIXED = frozenset(
('IPADDR0', 'GATEWAY0', 'PREFIX0', 'NETMASK0'))
--
To view, visit https://gerrit.ovirt.org/78898
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3f307b64546c3efa73ca202e97ced49eeb9670e9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has removed a vote on this change.
Change subject: net: Generate dump bonding options on boot and upgrade
......................................................................
Removed Verified-1 by gerrit-hooks <automation(a)ovirt.org>
--
To view, visit https://gerrit.ovirt.org/78780
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I98f7c691a2a86d152ebcb81e1d96f9b0d83fa698
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Meni Yakove <myakove(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has submitted this change and it was merged. ( https://gerrit.ovirt.org/79162 )
Change subject: net: On MTU change to the default value update the ifcfg file
......................................................................
net: On MTU change to the default value update the ifcfg file
When changing only the MTU on a bridged network to the default value
(1500), the new value has not been updated in the ifcfg file.
The problem has been detected on RHEL 7.4, where the MTU of the bridge
is automatically updated to the default when it has no ports connected.
Change-Id: Ib55712725c19e7d20fa8491c8ee78f6f9298ff9a
Bug-Url: https://bugzilla.redhat.com/1460687
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
---
M lib/vdsm/network/legacy_switch.py
1 file changed, 7 insertions(+), 0 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
Edward Haas: Verified
--
To view, visit https://gerrit.ovirt.org/79162
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib55712725c19e7d20fa8491c8ee78f6f9298ff9a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has submitted this change and it was merged. ( https://gerrit.ovirt.org/79161 )
Change subject: net: Relocate DEFAULT_MTU costant to link.iface module
......................................................................
net: Relocate DEFAULT_MTU costant to link.iface module
Users of the DEFAULT_MTU do not directly need netinfo, they just require
the default mtu value.
This patch is partially cleanin up netinfo package and avoids uneeded
dependency on netinfo.
Change-Id: Ie7ec8d809ff6c93398f3d28a158b3dc31fbbda35
Bug-Url: https://bugzilla.redhat.com/1460687
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
---
M lib/vdsm/network/canonicalize.py
M lib/vdsm/network/configurators/ifcfg.py
M lib/vdsm/network/link/iface.py
M lib/vdsm/network/netinfo/mtus.py
M tests/functional/networkTests.py
M tests/network/config_network_test.py
6 files changed, 9 insertions(+), 8 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
Edward Haas: Verified
--
To view, visit https://gerrit.ovirt.org/79161
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie7ec8d809ff6c93398f3d28a158b3dc31fbbda35
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has uploaded a new change for review.
Change subject: Move fencing code to host/fencing.py
......................................................................
Move fencing code to host/fencing.py
The intention is to split the fence code to be in generic location.
Later patches will pack this code in separate package and will be used
in separate micro service in ovirt cluster.
Change-Id: I73763a7a784b17bd2b8bd04a22c0f5a5ec4ab1b6
Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com>
---
A lib/vdsm/host/fencing.py
M vdsm/API.py
2 files changed, 203 insertions(+), 151 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/27/78927/1
diff --git a/lib/vdsm/host/fencing.py b/lib/vdsm/host/fencing.py
new file mode 100644
index 0000000..2283af5
--- /dev/null
+++ b/lib/vdsm/host/fencing.py
@@ -0,0 +1,200 @@
+#
+# Copyright 2017 Red Hat, Inc.
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 2 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
+#
+# Refer to the README and COPYING files for full details of the license
+#
+from __future__ import absolute_import
+
+"""
+The module is taking care of fencing command to a remote host.
+agent is one of (rsa, ilo, drac5, ipmilan, etc)
+action can be one of (status, on, off, reboot).
+"""
+
+# using general logging
+import logging
+import os
+
+from vdsm import commands
+from vdsm import constants
+from vdsm import supervdsm
+from vdsm.common import conv
+from vdsm.common.define import doneCode
+from vdsm.common.define import errCode
+from vdsm.storage import clusterlock
+
+try:
+ import vdsm.gluster.fence as glusterFence
+except ImportError:
+ pass
+
+
+_log = logging.getLogger("fencing")
+
+# This global var will hold HSM instance or another provider that can retrieve Host Lease Status
+# Therefore set_storage_monitor should be called before and set there a class that implements getHostLeaseStatus
+# function.
+_storageMonitor = None
+
+
+def set_storage_monitor(monitor):
+ global _storageMonitor
+ _storageMonitor = monitor
+
+
+def _fence(script, inp):
+ rc, out, err = commands.execCmd([script], data=inp)
+ _log.debug('rc %s inp %s out %s err %s', rc,
+ _hidePasswd(inp), out, err)
+ return rc, out, err
+
+
+def _hidePasswd(text):
+ cleantext = ''
+ for line in text.splitlines(True):
+ if line.startswith('passwd='):
+ line = 'passwd=XXXX\n'
+ cleantext += line
+ return cleantext
+
+
+def _should_fence(policy):
+ # Skip fencing if any of the condition mentioned in the fencing
+ # policy is met
+ if policy is None:
+ _log.debug('No policy specified')
+ return True
+ result = _check_virt_fencing_policies(policy)
+ if result:
+ result = _check_gluster_fencing_policies(policy)
+ return result
+
+
+def _check_virt_fencing_policies(policy):
+ # skip fence execution if map of storage domains with host id is
+ # entered and at least one storage domain connection from host is
+ # alive. Also enforce the following gluster related fencing
+ # policies.
+ hostIdMap = policy.get('storageDomainHostIdMap')
+ if not hostIdMap:
+ _log.warning('No storageDomainHostIdMap provided')
+ return True
+
+ result = _storageMonitor.getHostLeaseStatus(hostIdMap)
+ if result['status']['code'] != 0:
+ _log.error(
+ "Error getting host lease status, error code '%s'",
+ result['status']['code'])
+ return True
+
+ # HOST_STATUS_LIVE means that host renewed its lease in last 80
+ # seconds. If so, we consider the host Up and we won't execute
+ # fencing, even when it's unreachable from engine
+ for sd, status in result['domains'].iteritems():
+ if status == clusterlock.HOST_STATUS_LIVE:
+ _log.debug("Host has live lease on '%s'", sd)
+ return False
+
+ _log.debug("Host doesn't have any live lease")
+ return True
+
+
+def _check_gluster_fencing_policies(policy):
+ # If skipFencingIfGlusterBricksUp is set to true the fencing should
+ # should be skipped if there is any brick up running in the host
+ # being fenced.
+ skipFencingIfGlusterBricksUp = \
+ policy.get('skipFencingIfGlusterBricksUp')
+ # If skipFencingIfGlusterQuorumNotMet is set to true then fencing
+ # should be skipped if the gluster bricks are UP and fencing
+ # this host will bring down those bricks and quourm will be
+ # lost for any replicated volume in the gluster.
+ skipFencingIfGlusterQuorumNotMet = \
+ policy.get('skipFencingIfGlusterQuorumNotMet')
+ hostUuid = policy.get('glusterServerUuid')
+ if skipFencingIfGlusterBricksUp \
+ or skipFencingIfGlusterQuorumNotMet:
+ if not glusterFence:
+ _log.error("Required vdsm-gluster package is "
+ "missing on this host. Note that "
+ "gluster related fencing will not be"
+ "enforced!. Please install the missing "
+ "package in order to enforce gluster "
+ "related fencing polices")
+ return True
+ result, msg = glusterFence. \
+ can_fence_host(supervdsm.getProxy(), hostUuid,
+ skipFencingIfGlusterBricksUp,
+ skipFencingIfGlusterQuorumNotMet)
+
+ _log.debug(msg)
+ return result
+
+ return True
+
+
+def fence_node(addr, port, agent, username, password, action, secure=False, options='', policy=None):
+ _log.debug('fenceNode(addr=%s,port=%s,agent=%s,user=%s,passwd=%s,'
+ 'action=%s,secure=%s,options=%s,policy=%s)',
+ addr, port, agent, username, password, action, secure,
+ options, policy)
+
+ if action not in ('status', 'on', 'off', 'reboot'):
+ raise ValueError('illegal action ' + action)
+
+ if action != 'status' and not _should_fence(policy):
+ _log.debug("Skipping execution of action '%s'", action)
+ return {'status': doneCode, 'operationStatus': 'skipped'}
+
+ script = constants.EXT_FENCE_PREFIX + agent
+
+ inp = ('agent=fence_%s\nipaddr=%s\nlogin=%s\naction=%s\n'
+ 'passwd=%s\n') % (agent, addr, username, action, password.value)
+ if port != '':
+ inp += 'port=%s\n' % (port,)
+ if conv.tobool(secure):
+ inp += 'secure=yes\n'
+ inp += options
+
+ try:
+ rc, out, err = _fence(script, inp)
+ except OSError as e:
+ if e.errno == os.errno.ENOENT:
+ return errCode['fenceAgent']
+ raise
+ _log.debug('rc %s in %s out %s err %s', rc,
+ _hidePasswd(inp), out, err)
+ if not 0 <= rc <= 2:
+ return {'status': {'code': 1,
+ 'message': out + err}}
+ message = doneCode['message']
+ ret = 0
+ if action == 'status':
+ if rc == 0:
+ power = 'on'
+ elif rc == 2:
+ power = 'off'
+ else:
+ power = 'unknown'
+ message = out + err
+ ret = rc
+ return {'status': {'code': ret, 'message': message},
+ 'power': power}
+ if rc != 0:
+ message = out + err
+ return {'status': {'code': rc, 'message': message},
+ 'power': 'unknown', 'operationStatus': 'initiated'}
\ No newline at end of file
diff --git a/vdsm/API.py b/vdsm/API.py
index cf7c04e..e301f51 100644
--- a/vdsm/API.py
+++ b/vdsm/API.py
@@ -20,11 +20,8 @@
#
# pylint: disable=R0904
-import os
-
from vdsm.network.errors import ConfigNetworkError
-from vdsm import commands
from vdsm import utils
from clientIF import clientIF
from vdsm import constants
@@ -40,9 +37,9 @@
from vdsm.common import logutils
from vdsm.common import response
from vdsm.common import validate
-from vdsm.common import conv
from vdsm.host import api as hostapi
from vdsm.host import caps
+from vdsm.host import fencing
# TODO fix name conflict and use from vdsm.storage import sd
import vdsm.storage.sd
from vdsm.storage import clusterlock
@@ -64,11 +61,6 @@
haClient = None # Define here to work around pyflakes issue #13
try:
import ovirt_hosted_engine_ha.client.client as haClient
-except ImportError:
- pass
-
-try:
- import vdsm.gluster.fence as glusterFence
except ImportError:
pass
@@ -1092,148 +1084,8 @@
# General Host functions
def fenceNode(self, addr, port, agent, username, password, action,
secure=False, options='', policy=None):
- """Send a fencing command to a remote node.
-
- agent is one of (rsa, ilo, drac5, ipmilan, etc)
- action can be one of (status, on, off, reboot)."""
-
- def fence(script, inp):
- rc, out, err = commands.execCmd([script], data=inp)
- self.log.debug('rc %s inp %s out %s err %s', rc,
- hidePasswd(inp), out, err)
- return rc, out, err
-
- def hidePasswd(text):
- cleantext = ''
- for line in text.splitlines(True):
- if line.startswith('passwd='):
- line = 'passwd=XXXX\n'
- cleantext += line
- return cleantext
-
- def should_fence(policy):
- # Skip fencing if any of the condition mentioned in the fencing
- # policy is met
- result = False
- if policy is None:
- self.log.debug('No policy specified')
- return True
- result = check_virt_fencing_policies(policy)
- if result:
- result = check_gluster_fencing_policies(policy)
- return result
-
- def check_virt_fencing_policies(policy):
- # skip fence execution if map of storage domains with host id is
- # entered and at least one storage domain connection from host is
- # alive. Also enforce the following gluster related fencing
- # policies.
- hostIdMap = policy.get('storageDomainHostIdMap')
- if not hostIdMap:
- self.log.warning('No storageDomainHostIdMap provided')
- return True
-
- result = self._irs.getHostLeaseStatus(hostIdMap)
- if result['status']['code'] != 0:
- self.log.error(
- "Error getting host lease status, error code '%s'",
- result['status']['code'])
- return True
-
- # HOST_STATUS_LIVE means that host renewed its lease in last 80
- # seconds. If so, we consider the host Up and we won't execute
- # fencing, even when it's unreachable from engine
- for sd, status in result['domains'].iteritems():
- if status == clusterlock.HOST_STATUS_LIVE:
- self.log.debug("Host has live lease on '%s'", sd)
- return False
-
- self.log.debug("Host doesn't have any live lease")
- return True
-
- def check_gluster_fencing_policies(policy):
- # If skipFencingIfGlusterBricksUp is set to true the fencing should
- # should be skipped if there is any brick up running in the host
- # being fenced.
- skipFencingIfGlusterBricksUp = \
- policy.get('skipFencingIfGlusterBricksUp')
- # If skipFencingIfGlusterQuorumNotMet is set to true then fencing
- # should be skipped if the gluster bricks are UP and fencing
- # this host will bring down those bricks and quourm will be
- # lost for any replicated volume in the gluster.
- skipFencingIfGlusterQuorumNotMet = \
- policy.get('skipFencingIfGlusterQuorumNotMet')
- hostUuid = policy.get('glusterServerUuid')
- if skipFencingIfGlusterBricksUp \
- or skipFencingIfGlusterQuorumNotMet:
- if not glusterFence:
- self.log.error("Required vdsm-gluster package is "
- "missing on this host. Note that "
- "gluster related fencing will not be"
- "enforced!. Please install the missing "
- "package in order to enforce gluster "
- "related fencing polices")
- return True
- result, msg = glusterFence. \
- can_fence_host(supervdsm.getProxy(), hostUuid,
- skipFencingIfGlusterBricksUp,
- skipFencingIfGlusterQuorumNotMet)
-
- self.log.debug(msg)
- return result
-
- return True
-
- self.log.debug('fenceNode(addr=%s,port=%s,agent=%s,user=%s,passwd=%s,'
- 'action=%s,secure=%s,options=%s,policy=%s)',
- addr, port, agent, username, password, action, secure,
- options, policy)
-
- if action not in ('status', 'on', 'off', 'reboot'):
- raise ValueError('illegal action ' + action)
-
- if action != 'status' and not should_fence(policy):
- self.log.debug("Skipping execution of action '%s'", action)
- return {'status': doneCode, 'operationStatus': 'skipped'}
-
- script = constants.EXT_FENCE_PREFIX + agent
-
- inp = ('agent=fence_%s\nipaddr=%s\nlogin=%s\naction=%s\n'
- 'passwd=%s\n') % (agent, addr, username, action, password.value)
- if port != '':
- inp += 'port=%s\n' % (port,)
- if conv.tobool(secure):
- inp += 'secure=yes\n'
- inp += options
-
- try:
- rc, out, err = fence(script, inp)
- except OSError as e:
- if e.errno == os.errno.ENOENT:
- return errCode['fenceAgent']
- raise
- self.log.debug('rc %s in %s out %s err %s', rc,
- hidePasswd(inp), out, err)
- if not 0 <= rc <= 2:
- return {'status': {'code': 1,
- 'message': out + err}}
- message = doneCode['message']
- ret = 0
- if action == 'status':
- if rc == 0:
- power = 'on'
- elif rc == 2:
- power = 'off'
- else:
- power = 'unknown'
- message = out + err
- ret = rc
- return {'status': {'code': ret, 'message': message},
- 'power': power}
- if rc != 0:
- message = out + err
- return {'status': {'code': rc, 'message': message},
- 'power': 'unknown', 'operationStatus': 'initiated'}
+ fencing.set_storage_monitor(self._irs)
+ return fencing.fence_node(addr, port, agent, username, password, action, secure, options, policy)
def ping(self):
"Ping the server. Useful for tests"
--
To view, visit https://gerrit.ovirt.org/78927
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I73763a7a784b17bd2b8bd04a22c0f5a5ec4ab1b6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: On MTU change to the default value update the ifcfg file
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/79162
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib55712725c19e7d20fa8491c8ee78f6f9298ff9a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has removed a vote on this change.
Change subject: net: On MTU change to the default value update the ifcfg file
......................................................................
Removed Verified-1 by gerrit-hooks <automation(a)ovirt.org>
--
To view, visit https://gerrit.ovirt.org/79162
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ib55712725c19e7d20fa8491c8ee78f6f9298ff9a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has removed gerrit-hooks from this change. ( https://gerrit.ovirt.org/79161 )
Change subject: net: Relocate DEFAULT_MTU costant to link.iface module
......................................................................
Removed reviewer gerrit-hooks with the following votes:
* Verified-1 by gerrit-hooks <automation(a)ovirt.org>
--
To view, visit https://gerrit.ovirt.org/79161
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: Ie7ec8d809ff6c93398f3d28a158b3dc31fbbda35
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: Relocate DEFAULT_MTU costant to link.iface module
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/79161
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7ec8d809ff6c93398f3d28a158b3dc31fbbda35
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has uploaded a new change for review.
Change subject: packaging: eliminate /usr/lib/systemd/systemd-vdsmd
......................................................................
packaging: eliminate /usr/lib/systemd/systemd-vdsmd
This script was introduced many years ago (commit c01a733c) as a helper
to the makeshift systemd service. Mistakenly, it was not removed by
commit ad15e459 that introduced a proper systemd service. This patch
drops the long-dead code.
Change-Id: I04bd7e8acfbbfb5a0ec2cfc0239a243624083bf1
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com>
---
M .gitignore
M init/systemd/Makefile.am
D init/systemd/systemd-vdsmd.in
M vdsm.spec.in
4 files changed, 0 insertions(+), 36 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/53/79153/1
diff --git a/.gitignore b/.gitignore
index 0f8849c..9937872 100644
--- a/.gitignore
+++ b/.gitignore
@@ -24,7 +24,6 @@
configure
cscope.out
doc/build
-init/systemd/systemd-vdsmd
init/systemd/vdsm-tmpfiles.d.conf
init/vdsmd_init_common.sh
lib/vdsm/api/vdsm-api.html
diff --git a/init/systemd/Makefile.am b/init/systemd/Makefile.am
index 2ff6be8..8f1e12b 100644
--- a/init/systemd/Makefile.am
+++ b/init/systemd/Makefile.am
@@ -21,7 +21,6 @@
include $(top_srcdir)/build-aux/Makefile.subs
nodist_noinst_DATA = \
- systemd-vdsmd \
vdsm-tmpfiles.d.conf \
$(NULL)
@@ -32,7 +31,6 @@
EXTRA_DIST = \
85-vdsmd.preset \
- systemd-vdsmd.in \
vdsm-tmpfiles.d.conf.in \
unlimited-core.conf \
$(NULL)
diff --git a/init/systemd/systemd-vdsmd.in b/init/systemd/systemd-vdsmd.in
deleted file mode 100644
index a502b62..0000000
--- a/init/systemd/systemd-vdsmd.in
+++ /dev/null
@@ -1,31 +0,0 @@
-#!/bin/sh
-# Copyright 2013 IBM, Inc.
-#
-# This program is free software; you can redistribute it and/or modify
-# it under the terms of the GNU General Public License as published by
-# the Free Software Foundation; either version 2 of the License, or
-# (at your option) any later version.
-#
-# This program is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
-# GNU General Public License for more details.
-#
-# You should have received a copy of the GNU General Public License
-# along with this program; if not, write to the Free Software
-# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
-#
-# Refer to the README and COPYING files for full details of the license
-#
-
-usage_exit(){
- echo 'Usage: systemd-vdsmd reconfigure [force]' >&2
- exit 1
-}
-
-[ "$1" != "reconfigure" ] && usage_exit
-[ -n "$2" -a "$2" != "force" ] && usage_exit
-
-if [ "$2" = "force" ] || ! "@BINDIR@/vdsm-tool" is-configured; then
- "@BINDIR@/vdsm-tool" configure --force
-fi
diff --git a/vdsm.spec.in b/vdsm.spec.in
index 4dc79f7..fb899fd 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -735,7 +735,6 @@
install -Dm 0644 lib/vdsm/storage/vdsm-lvm.rules \
%{buildroot}%{_udevrulesdir}/12-vdsm-lvm.rules
-install -Dm 0755 init/systemd/systemd-vdsmd %{buildroot}%{_libdir}/systemd/systemd-vdsmd
install -Dm 0644 init/systemd/85-vdsmd.preset %{buildroot}%{_presetdir}/85-vdsmd.preset
install -Dm 0644 init/systemd/vdsm-tmpfiles.d.conf \
@@ -858,7 +857,6 @@
%doc lib/vdsm/vdsm.conf.sample
%doc README.logging
%license COPYING
-%{_libdir}/systemd/systemd-vdsmd
%{_presetdir}/85-vdsmd.preset
%{_unitdir}/dev-hugepages1G.mount
%{_unitdir}/vdsmd.service
--
To view, visit https://gerrit.ovirt.org/79153
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I04bd7e8acfbbfb5a0ec2cfc0239a243624083bf1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: network: todo py3 nettestlib Tap
......................................................................
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/78863/3/tests/network/nettestlib.py
File tests/network/nettestlib.py:
Line 186:
Line 187: _deviceListener = None
Line 188:
Line 189: def addDevice(self):
Line 190: self._cloneDevice = open('/dev/net/tun', 'r+b', buffering=0)
use io.open to have better control on file encoding
Line 191: ifr = struct.pack('16sH', conv.to_binary(self.devName), self._IFF_TAP |
Line 192: self._IFF_NO_PI)
Line 193: fcntl.ioctl(self._cloneDevice, self._TUNSETIFF, ifr)
Line 194: self.up()
--
To view, visit https://gerrit.ovirt.org/78863
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9d899d6e8bfe332174b722362136cc79de982c28
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horacek <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: Generate dump bonding options on boot and upgrade
......................................................................
Patch Set 8: Code-Review-1
-1 for visibility
--
To view, visit https://gerrit.ovirt.org/78780
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I98f7c691a2a86d152ebcb81e1d96f9b0d83fa698
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Meni Yakove <myakove(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79110 )
Change subject: net: On MTU change to the default value update the ifcfg file
......................................................................
net: On MTU change to the default value update the ifcfg file
When changing only the MTU on a bridged network to the default value
(1500), the new value has not been updated in the ifcfg file.
The problem has been detected on RHEL 7.4, where the MTU of the bridge
is automatically updated to the default when it has no ports connected.
Change-Id: Ib55712725c19e7d20fa8491c8ee78f6f9298ff9a
Bug-Url: https://bugzilla.redhat.com/1460687
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
---
M lib/vdsm/network/legacy_switch.py
1 file changed, 7 insertions(+), 0 deletions(-)
Approvals:
Meni Yakove: Verified
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
Edward Haas: Verified
--
To view, visit https://gerrit.ovirt.org/79110
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib55712725c19e7d20fa8491c8ee78f6f9298ff9a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Meni Yakove <myakove(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79109 )
Change subject: net: Relocate DEFAULT_MTU costant to link.iface module
......................................................................
net: Relocate DEFAULT_MTU costant to link.iface module
Users of the DEFAULT_MTU do not directly need netinfo, they just require
the default mtu value.
This patch is partially cleanin up netinfo package and avoids uneeded
dependency on netinfo.
Change-Id: Ie7ec8d809ff6c93398f3d28a158b3dc31fbbda35
Bug-Url: https://bugzilla.redhat.com/1460687
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
---
M lib/vdsm/network/canonicalize.py
M lib/vdsm/network/configurators/ifcfg.py
M lib/vdsm/network/link/iface.py
M lib/vdsm/network/netinfo/mtus.py
M tests/functional/networkTests.py
M tests/network/config_network_test.py
6 files changed, 9 insertions(+), 8 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
Edward Haas: Verified
--
To view, visit https://gerrit.ovirt.org/79109
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie7ec8d809ff6c93398f3d28a158b3dc31fbbda35
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: On MTU change to the default value update the ifcfg file
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/79110
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib55712725c19e7d20fa8491c8ee78f6f9298ff9a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Meni Yakove <myakove(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: Relocate DEFAULT_MTU costant to link.iface module
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/79109
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7ec8d809ff6c93398f3d28a158b3dc31fbbda35
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: Relocate DEFAULT_MTU costant to link.iface module
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/79109
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7ec8d809ff6c93398f3d28a158b3dc31fbbda35
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: Increase netlink socket buffer size to 512KB
......................................................................
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/78928/2//COMMIT_MSG
Commit Message:
PS2, Line 7: 512KB
where does this big number come from?
--
To view, visit https://gerrit.ovirt.org/78928
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic8c9c03ff86a843021655945c1ece38abe0c738d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: virt: move the libvirt migration hook under lib/
......................................................................
Patch Set 5: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/78569
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I066748a070d1779552c02361e617b1d418fcb668
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: network: make sure to pass bytes to io.BytesIO
......................................................................
Patch Set 4: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/78862/4/tests/network/netinfo_test.py
File tests/network/netinfo_test.py:
Line 105: @mock.patch.object(nics.io, 'open')
Line 106: def test_valid_nic_speed(self, mock_io_open, mock_operstate):
Line 107: values = ((b'0', nics.OPERSTATE_UP, 0),
Line 108: (b'-10', nics.OPERSTATE_UP, 0),
Line 109: (six.b(str(2 ** 16 - 1)), nics.OPERSTATE_UP, 0),
> What a mess...
but the kernel reports these numbers in ascii-coded decimals, not hexadecimals. the test should mimic that.
Line 110: (six.b(str(2 ** 32 - 1)), nics.OPERSTATE_UP, 0),
Line 111: (b'123', nics.OPERSTATE_UP, 123),
Line 112: (b'', nics.OPERSTATE_UP, 0),
Line 113: (b'', 'unknown', 0),
--
To view, visit https://gerrit.ovirt.org/78862
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I756f87a1ec34f88c1ebeeb09462127aebbfad98a
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horacek <phoracek(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has uploaded a new change for review.
Change subject: mimicking and error, please ingnore
......................................................................
mimicking and error, please ingnore
Change-Id: I25597b866e25f3d74f1fa96f549b6f86a4bde831
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com>
---
M vdsm/vdsmd.py
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/21/79021/1
diff --git a/vdsm/vdsmd.py b/vdsm/vdsmd.py
index ddfea54..b3c7566 100755
--- a/vdsm/vdsmd.py
+++ b/vdsm/vdsmd.py
@@ -6,6 +6,8 @@
# (at your option) any later version. See the files README and
# LICENSE_GPL_v2 which accompany this distribution.
#
+GGGG
+
from __future__ import absolute_import
from __future__ import print_function
import sys
--
To view, visit https://gerrit.ovirt.org/79021
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I25597b866e25f3d74f1fa96f549b6f86a4bde831
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/78861 )
Change subject: network: use bytes explicitly in netinfo.IPv4toMapped
......................................................................
network: use bytes explicitly in netinfo.IPv4toMapped
Change-Id: I64518a0247baa91969b80c2204ee73e594ef5a72
Signed-off-by: Petr Horacek <phoracek(a)redhat.com>
---
M lib/vdsm/network/netinfo/addresses.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jenkins CI: Passed CI tests
Petr Horáček: Verified
Edward Haas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/78861
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I64518a0247baa91969b80c2204ee73e594ef5a72
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horacek <phoracek(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/77946 )
Change subject: network: replace Popen calls with exec_sync
......................................................................
network: replace Popen calls with exec_sync
In order to do required decoding of command output with Python 3,
use network.cmd.exec_sync to run commands that used to be executed
explicitly via Popen.
Change-Id: Ia28b23f41348a61331622cb362d7a3de5843f0e7
Signed-off-by: Petr Horacek <phoracek(a)redhat.com>
---
M lib/vdsm/network/ip/dhclient.py
M tests/network/tc_test.py
2 files changed, 6 insertions(+), 10 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Petr Horáček: Verified
Edward Haas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/77946
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia28b23f41348a61331622cb362d7a3de5843f0e7
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horacek <phoracek(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/77940 )
Change subject: network: make ipwrapper.drv_name Python 3 compatible
......................................................................
network: make ipwrapper.drv_name Python 3 compatible
In Python 3 array.array does not support 'c' (Python char) type anymore.
We need to ask for C chars (Python ints) instead and then decode
returned data if needed.
Change-Id: I2dee4fd4a1ac5470e739594704da5781589af1d3
Signed-off-by: Petr Horacek <phoracek(a)redhat.com>
---
M lib/vdsm/network/ipwrapper.py
M tests/network/ipwrapper_test.py
2 files changed, 14 insertions(+), 8 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Petr Horáček: Verified
Dan Kenigsberg: Looks good to me, but someone else must approve
Edward Haas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/77940
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2dee4fd4a1ac5470e739594704da5781589af1d3
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horacek <phoracek(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/78389 )
Change subject: network: to_str and to_binary
......................................................................
network: to_str and to_binary
Move to_str and to_binary functions under network py2to3.py module
as they were needed and duplicated in multiple places.
Change-Id: I0f4853e48086c577a7b1ff3232eb567a62674e60
Signed-off-by: Petr Horacek <phoracek(a)redhat.com>
---
M lib/vdsm/network/Makefile.am
M lib/vdsm/network/cmd.py
M lib/vdsm/network/netlink/libnl.py
A lib/vdsm/network/py2to3.py
M vdsm.spec.in
5 files changed, 60 insertions(+), 53 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Petr Horáček: Verified
Francesco Romani: Looks good to me, but someone else must approve
Edward Haas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/78389
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0f4853e48086c577a7b1ff3232eb567a62674e60
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Petr Horacek <phoracek(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79006 )
Change subject: Revert stomp client reconect patches
......................................................................
Revert stomp client reconect patches
This reverts all client reconnect commits
Change-Id: Id8cdea5f1c17da931e44b5bcf436db5d2ac5c018
Signed-off-by: eyal edri <eedri(a)redhat.com>
---
M lib/vdsm/client.py
M lib/yajsonrpc/betterAsyncore.py
M lib/yajsonrpc/stomp.py
M lib/yajsonrpc/stompreactor.py
M tests/integration/jsonRpcTests.py
M tests/stompasyncclient_test.py
6 files changed, 20 insertions(+), 119 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Irit Goihman: Verified; Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/79006
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id8cdea5f1c17da931e44b5bcf436db5d2ac5c018
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: network: make ipwrapper.drv_name Python 3 compatible
......................................................................
Patch Set 17: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/77940
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2dee4fd4a1ac5470e739594704da5781589af1d3
Gerrit-PatchSet: 17
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horacek <phoracek(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/78925 )
Change subject: stomp: set default heartbeat values and add grace period
......................................................................
stomp: set default heartbeat values and add grace period
default incoming heartbeat used to be 5 seconds but was never checked.
In an actual system the heartbeat should be greater, since CPU and network
spikes affect the server communication and don't indicate there is a
real communication problem.
Also, in order to make sure incoming heartbeats are received and we won't
close the socket before getting them, we add grace period for incoming
heartbeats and reduce the outgoing heartbeats interval in order to make
sure the outgoing heartbeats are received in server side.
By default, number of retries after timeout is 1 to ensure fast recovery.
Change-Id: I0e8c4f2fef9083521dcf2da12cf1f9db84b75492
Signed-off-by: Irit Goihman <igoihman(a)redhat.com>
Bug-Url: https://bugzilla.redhat.com/1376843
---
M lib/vdsm/client.py
M lib/yajsonrpc/stomp.py
M lib/yajsonrpc/stompreactor.py
M tests/stompasyncclient_test.py
4 files changed, 39 insertions(+), 14 deletions(-)
Approvals:
Piotr Kliczewski: Looks good to me, approved
Yaniv Bronhaim: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Irit Goihman: Verified
--
To view, visit https://gerrit.ovirt.org/78925
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0e8c4f2fef9083521dcf2da12cf1f9db84b75492
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: Unneeded newline is added when updating only the mtu
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/78900
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I98659616218d65dc4126f3bb1df92bc0b9b06a8d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/78890 )
Change subject: net: Unneeded newline is added when updating only the mtu
......................................................................
net: Unneeded newline is added when updating only the mtu
When the MTU is updated on a bridged network, a special handling is
conducted and a nasty newline may be added where not needed.
This patch also makes sure a newline is always added at the end.
Change-Id: I98659616218d65dc4126f3bb1df92bc0b9b06a8d
Bug-Url: https://bugzilla.redhat.com/1460619
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
---
M lib/vdsm/network/configurators/ifcfg.py
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
Edward Haas: Verified
--
To view, visit https://gerrit.ovirt.org/78890
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I98659616218d65dc4126f3bb1df92bc0b9b06a8d
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michael Burman <mburman(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: Unneeded newline is added when updating only the mtu
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/78890
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I98659616218d65dc4126f3bb1df92bc0b9b06a8d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michael Burman <mburman(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: move vm.py to lib/vdsm/virt
......................................................................
Patch Set 4:
ci please build
--
To view, visit https://gerrit.ovirt.org/78797
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I158a7739ef171d6c88d7516d92abea632fb03df5
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: Unneeded newline is added when updating only the mtu
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/78890
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I98659616218d65dc4126f3bb1df92bc0b9b06a8d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michael Burman <mburman(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No