Change in vdsm[master]: net: Increase netlink socket buffer size to 512KB
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: Increase netlink socket buffer size to 512KB
......................................................................
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/78928/2//COMMIT_MSG
Commit Message:
PS2, Line 7: 512KB
where does this big number come from?
--
To view, visit https://gerrit.ovirt.org/78928
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic8c9c03ff86a843021655945c1ece38abe0c738d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
6 years, 9 months
Change in vdsm[master]: virt: move the libvirt migration hook under lib/
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: virt: move the libvirt migration hook under lib/
......................................................................
Patch Set 5: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/78569
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I066748a070d1779552c02361e617b1d418fcb668
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
6 years, 9 months
Change in vdsm[master]: network: make sure to pass bytes to io.BytesIO
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: network: make sure to pass bytes to io.BytesIO
......................................................................
Patch Set 4: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/78862/4/tests/network/netinfo_test.py
File tests/network/netinfo_test.py:
Line 105: @mock.patch.object(nics.io, 'open')
Line 106: def test_valid_nic_speed(self, mock_io_open, mock_operstate):
Line 107: values = ((b'0', nics.OPERSTATE_UP, 0),
Line 108: (b'-10', nics.OPERSTATE_UP, 0),
Line 109: (six.b(str(2 ** 16 - 1)), nics.OPERSTATE_UP, 0),
> What a mess...
but the kernel reports these numbers in ascii-coded decimals, not hexadecimals. the test should mimic that.
Line 110: (six.b(str(2 ** 32 - 1)), nics.OPERSTATE_UP, 0),
Line 111: (b'123', nics.OPERSTATE_UP, 123),
Line 112: (b'', nics.OPERSTATE_UP, 0),
Line 113: (b'', 'unknown', 0),
--
To view, visit https://gerrit.ovirt.org/78862
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I756f87a1ec34f88c1ebeeb09462127aebbfad98a
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horacek <phoracek(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
6 years, 9 months
Change in vdsm[master]: mimicking and error, please ingnore
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has uploaded a new change for review.
Change subject: mimicking and error, please ingnore
......................................................................
mimicking and error, please ingnore
Change-Id: I25597b866e25f3d74f1fa96f549b6f86a4bde831
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com>
---
M vdsm/vdsmd.py
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/21/79021/1
diff --git a/vdsm/vdsmd.py b/vdsm/vdsmd.py
index ddfea54..b3c7566 100755
--- a/vdsm/vdsmd.py
+++ b/vdsm/vdsmd.py
@@ -6,6 +6,8 @@
# (at your option) any later version. See the files README and
# LICENSE_GPL_v2 which accompany this distribution.
#
+GGGG
+
from __future__ import absolute_import
from __future__ import print_function
import sys
--
To view, visit https://gerrit.ovirt.org/79021
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I25597b866e25f3d74f1fa96f549b6f86a4bde831
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
6 years, 9 months
Change in vdsm[master]: network: replace Popen calls with exec_sync
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/77946 )
Change subject: network: replace Popen calls with exec_sync
......................................................................
network: replace Popen calls with exec_sync
In order to do required decoding of command output with Python 3,
use network.cmd.exec_sync to run commands that used to be executed
explicitly via Popen.
Change-Id: Ia28b23f41348a61331622cb362d7a3de5843f0e7
Signed-off-by: Petr Horacek <phoracek(a)redhat.com>
---
M lib/vdsm/network/ip/dhclient.py
M tests/network/tc_test.py
2 files changed, 6 insertions(+), 10 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Petr Horáček: Verified
Edward Haas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/77946
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia28b23f41348a61331622cb362d7a3de5843f0e7
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horacek <phoracek(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 9 months
Change in vdsm[master]: network: use bytes explicitly in netinfo.IPv4toMapped
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/78861 )
Change subject: network: use bytes explicitly in netinfo.IPv4toMapped
......................................................................
network: use bytes explicitly in netinfo.IPv4toMapped
Change-Id: I64518a0247baa91969b80c2204ee73e594ef5a72
Signed-off-by: Petr Horacek <phoracek(a)redhat.com>
---
M lib/vdsm/network/netinfo/addresses.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jenkins CI: Passed CI tests
Petr Horáček: Verified
Edward Haas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/78861
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I64518a0247baa91969b80c2204ee73e594ef5a72
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horacek <phoracek(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 9 months
Change in vdsm[master]: network: make ipwrapper.drv_name Python 3 compatible
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/77940 )
Change subject: network: make ipwrapper.drv_name Python 3 compatible
......................................................................
network: make ipwrapper.drv_name Python 3 compatible
In Python 3 array.array does not support 'c' (Python char) type anymore.
We need to ask for C chars (Python ints) instead and then decode
returned data if needed.
Change-Id: I2dee4fd4a1ac5470e739594704da5781589af1d3
Signed-off-by: Petr Horacek <phoracek(a)redhat.com>
---
M lib/vdsm/network/ipwrapper.py
M tests/network/ipwrapper_test.py
2 files changed, 14 insertions(+), 8 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Petr Horáček: Verified
Dan Kenigsberg: Looks good to me, but someone else must approve
Edward Haas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/77940
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2dee4fd4a1ac5470e739594704da5781589af1d3
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horacek <phoracek(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 9 months
Change in vdsm[master]: network: to_str and to_binary
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/78389 )
Change subject: network: to_str and to_binary
......................................................................
network: to_str and to_binary
Move to_str and to_binary functions under network py2to3.py module
as they were needed and duplicated in multiple places.
Change-Id: I0f4853e48086c577a7b1ff3232eb567a62674e60
Signed-off-by: Petr Horacek <phoracek(a)redhat.com>
---
M lib/vdsm/network/Makefile.am
M lib/vdsm/network/cmd.py
M lib/vdsm/network/netlink/libnl.py
A lib/vdsm/network/py2to3.py
M vdsm.spec.in
5 files changed, 60 insertions(+), 53 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Petr Horáček: Verified
Francesco Romani: Looks good to me, but someone else must approve
Edward Haas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/78389
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0f4853e48086c577a7b1ff3232eb567a62674e60
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Petr Horacek <phoracek(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 9 months
Change in vdsm[master]: Revert stomp client reconect patches
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79006 )
Change subject: Revert stomp client reconect patches
......................................................................
Revert stomp client reconect patches
This reverts all client reconnect commits
Change-Id: Id8cdea5f1c17da931e44b5bcf436db5d2ac5c018
Signed-off-by: eyal edri <eedri(a)redhat.com>
---
M lib/vdsm/client.py
M lib/yajsonrpc/betterAsyncore.py
M lib/yajsonrpc/stomp.py
M lib/yajsonrpc/stompreactor.py
M tests/integration/jsonRpcTests.py
M tests/stompasyncclient_test.py
6 files changed, 20 insertions(+), 119 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Irit Goihman: Verified; Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/79006
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id8cdea5f1c17da931e44b5bcf436db5d2ac5c018
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 9 months
Change in vdsm[master]: Revert stomp client reconect patches
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: Revert stomp client reconect patches
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/79006
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id8cdea5f1c17da931e44b5bcf436db5d2ac5c018
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
6 years, 9 months