Change in vdsm[master]: net: tests: Migrate testFailWithInvalidParams to the new fun...
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: tests: Migrate testFailWithInvalidParams to the new func tests
......................................................................
Patch Set 2: Code-Review-1
requires manual rebase
--
To view, visit https://gerrit.ovirt.org/79905
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I848f360e3e4f0e8cda17870f53ce27af25252343
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
6 years, 9 months
Change in vdsm[master]: net: tests: Migrate testFailWithInvalidIpConfig to the new f...
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79438 )
Change subject: net: tests: Migrate testFailWithInvalidIpConfig to the new func tests
......................................................................
net: tests: Migrate testFailWithInvalidIpConfig to the new func tests
Change-Id: I4a46e5e5e210fd4d17b70d1f77405ffbadedb44d
Signed-off-by: Leon Goldberg <lgoldber(a)redhat.com>
---
M tests/functional/networkTests.py
A tests/network/func_net_ip_test.py
2 files changed, 75 insertions(+), 16 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Leon Goldberg: Verified
Edward Haas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/79438
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4a46e5e5e210fd4d17b70d1f77405ffbadedb44d
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 9 months
Change in vdsm[master]: net: place bonding defaults under /var/lib
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has uploaded a new change for review.
Change subject: net: place bonding defaults under /var/lib
......................................................................
net: place bonding defaults under /var/lib
vdsm-tool places bonding-defaults.json under /usr/share. However,
the proper place to store application data is under /var/lib
Change-Id: Ib50e3c34d54c949ef22e780731518ff17890226f
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com>
---
M lib/vdsm/network/link/bond/sysfs_options.py
M lib/vdsm/network/link/bond/sysfs_options_mapper.py
M lib/vdsm/tool/configurators/bond_defaults.py
3 files changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/36/79436/1
diff --git a/lib/vdsm/network/link/bond/sysfs_options.py b/lib/vdsm/network/link/bond/sysfs_options.py
index d230736..bf5e93c 100644
--- a/lib/vdsm/network/link/bond/sysfs_options.py
+++ b/lib/vdsm/network/link/bond/sysfs_options.py
@@ -27,7 +27,7 @@
from vdsm import constants
from vdsm.common.cache import memoized
-BONDING_DEFAULTS = constants.P_VDSM + 'bonding-defaults.json'
+BONDING_DEFAULTS = constants.P_VDSM_LIB + 'bonding-defaults.json'
BONDING_OPT = '/sys/class/net/%s/bonding/%s'
ARP_IP_TARGET = 'arp_ip_target'
diff --git a/lib/vdsm/network/link/bond/sysfs_options_mapper.py b/lib/vdsm/network/link/bond/sysfs_options_mapper.py
index 01aaa0c..2219ab3 100644
--- a/lib/vdsm/network/link/bond/sysfs_options_mapper.py
+++ b/lib/vdsm/network/link/bond/sysfs_options_mapper.py
@@ -35,7 +35,7 @@
from vdsm.network.link.bond.sysfs_driver import BONDING_MASTERS
from vdsm.network.link.iface import random_iface_name
-BONDING_NAME2NUMERIC_PATH = constants.P_VDSM + 'bonding-name2numeric.json'
+BONDING_NAME2NUMERIC_PATH = constants.P_VDSM_LIB + 'bonding-name2numeric.json'
_MAX_BONDING_MODES = 6
diff --git a/lib/vdsm/tool/configurators/bond_defaults.py b/lib/vdsm/tool/configurators/bond_defaults.py
index 6487506..adad925 100644
--- a/lib/vdsm/tool/configurators/bond_defaults.py
+++ b/lib/vdsm/tool/configurators/bond_defaults.py
@@ -28,7 +28,7 @@
from . import YES, NO
-BONDING_DEFAULTS = constants.P_VDSM + 'bonding-defaults.json'
+BONDING_DEFAULTS = constants.P_VDSM_LIB + 'bonding-defaults.json'
def isconfigured():
--
To view, visit https://gerrit.ovirt.org/79436
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib50e3c34d54c949ef22e780731518ff17890226f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
6 years, 9 months
Change in vdsm[master]: net test: use static bonding defaults if dump fails
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has uploaded a new change for review.
Change subject: net test: use static bonding defaults if dump fails
......................................................................
net test: use static bonding defaults if dump fails
sysfs_options_mapper.dump_bonding_options may fail during the test if
its target directory is missing. In such a case, take the shipped
defaults.
Change-Id: I33a6ecc14f6d1a2f7cc9da9bfaff4fad13fa8055
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com>
---
M tests/network/nettestlib.py
1 file changed, 7 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/89/79889/1
diff --git a/tests/network/nettestlib.py b/tests/network/nettestlib.py
index 7395755..79f55f4 100644
--- a/tests/network/nettestlib.py
+++ b/tests/network/nettestlib.py
@@ -532,13 +532,18 @@
bonding_name2num_fpath = ALTERNATIVE_BONDING_NAME2NUMERIC_PATH
if _has_sysfs_bond_permission():
- sysfs_options_mapper.dump_bonding_options()
+ try:
+ sysfs_options_mapper.dump_bonding_options()
+ except SystemError as e:
+ if e.errno != errno.ENOENT:
+ raise
if os.path.exists(BONDING_DEFAULTS):
bonding_defaults_fpath = BONDING_DEFAULTS
if os.path.exists(sysfs_options_mapper.BONDING_NAME2NUMERIC_PATH):
- bonding_name2num_fpath = sysfs_options_mapper.BONDING_NAME2NUMERIC_PATH
+ bonding_name2num_fpath = \
+ sysfs_options_mapper.BONDING_NAME2NUMERIC_PATH
return bonding_defaults_fpath, bonding_name2num_fpath
--
To view, visit https://gerrit.ovirt.org/79889
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I33a6ecc14f6d1a2f7cc9da9bfaff4fad13fa8055
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
6 years, 9 months
Change in vdsm[master]: testrunner: mock vdsm.common.constants.P_VDSM
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has uploaded a new change for review.
Change subject: testrunner: mock vdsm.common.constants.P_VDSM
......................................................................
testrunner: mock vdsm.common.constants.P_VDSM
As long as we keep vdsm.constants as proxy to vdsm.common.constants, we
need to keep them align also when mocked.
Change-Id: I39231c2e9d4b883de0294d90f42860d72edc67f4
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com>
---
M tests/testrunner.py
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/11/79911/1
diff --git a/tests/testrunner.py b/tests/testrunner.py
index e4dab3b..7586158 100644
--- a/tests/testrunner.py
+++ b/tests/testrunner.py
@@ -49,6 +49,7 @@
"instead of installed ones.\n")
if findRemove(sys.argv, "--local-modules"):
from vdsm import constants
- constants.P_VDSM = "../vdsm/"
+ from vdsm.common import common_constants
+ common_constants.P_VDSM = constants.P_VDSM = "../vdsm/"
testlib.run()
--
To view, visit https://gerrit.ovirt.org/79911
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I39231c2e9d4b883de0294d90f42860d72edc67f4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
6 years, 9 months
Change in vdsm[ovirt-4.1]: storage: Add LibgfApi support as additional feature
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: storage: Add LibgfApi support as additional feature
......................................................................
Patch Set 6: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/79605
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0aac04c144ae647aad1c0714379246060f4e991f
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Raz Tamir <ratamir(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
6 years, 9 months
Change in vdsm[master]: introduce network.constants
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has uploaded a new change for review.
Change subject: introduce network.constants
......................................................................
introduce network.constants
This patch places a copy of autoconf-generated P_VDSM_RUN and P_VDSM_LIB
inside the network subpackage. This removes the dependency of the
network package on the global vdsm.constants module.
Change-Id: I8571a806f09195007622d15eff59e72b55042559
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com>
---
M .gitignore
M lib/vdsm/network/Makefile.am
M lib/vdsm/network/configurators/ifcfg.py
M lib/vdsm/network/connectivity.py
M lib/vdsm/network/dhclient_monitor.py
M lib/vdsm/network/ifacetracking.py
M lib/vdsm/network/link/bond/sysfs_options.py
M lib/vdsm/network/link/bond/sysfs_options_mapper.py
M lib/vdsm/network/netconfpersistence.py
M lib/vdsm/network/netrestore.py
M lib/vdsm/network/sourceroute.py
M vdsm.spec.in
12 files changed, 19 insertions(+), 9 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/37/79437/1
diff --git a/.gitignore b/.gitignore
index 9937872..9300c20 100644
--- a/.gitignore
+++ b/.gitignore
@@ -30,6 +30,7 @@
lib/vdsm/config.py
lib/vdsm/constants.py
lib/vdsm/dsaversion.py
+lib/vdsm/network/constants.py
lib/sos/vdsm.py
lib/vdsm/storage/lvm.env
lib/vdsm/storage/protect/spmprotect.sh
diff --git a/lib/vdsm/network/Makefile.am b/lib/vdsm/network/Makefile.am
index abf1db6..290af4e 100644
--- a/lib/vdsm/network/Makefile.am
+++ b/lib/vdsm/network/Makefile.am
@@ -46,3 +46,11 @@
sourceroute.py \
sysctl.py \
$(NULL)
+
+nodist_vdsmnetwork_PYTHON = \
+ constants.py \
+ $(NULL)
+
+EXTRA_DIST = \
+ constants.py.in \
+ $(NULL)
diff --git a/lib/vdsm/network/configurators/ifcfg.py b/lib/vdsm/network/configurators/ifcfg.py
index 78fcb26..5b0ef02 100644
--- a/lib/vdsm/network/configurators/ifcfg.py
+++ b/lib/vdsm/network/configurators/ifcfg.py
@@ -33,7 +33,6 @@
import six
from vdsm.config import config
-from vdsm import constants
from vdsm import dsaversion
from vdsm import hooks
from vdsm.common import concurrent
@@ -41,6 +40,7 @@
from vdsm.common.conv import tobool
from vdsm.network import cmd
+from vdsm.network import constants
from vdsm.network import ifacetracking
from vdsm.network import ipwrapper
from vdsm.network import sysctl
diff --git a/lib/vdsm/network/connectivity.py b/lib/vdsm/network/connectivity.py
index 11e5601..ccd8234 100644
--- a/lib/vdsm/network/connectivity.py
+++ b/lib/vdsm/network/connectivity.py
@@ -23,9 +23,9 @@
import time
import logging
-from vdsm import constants
from vdsm.common.conv import tobool
+from . import constants
from . import errors as ne
from .errors import ConfigNetworkError
diff --git a/lib/vdsm/network/dhclient_monitor.py b/lib/vdsm/network/dhclient_monitor.py
index fb6471d..aca0d8f 100644
--- a/lib/vdsm/network/dhclient_monitor.py
+++ b/lib/vdsm/network/dhclient_monitor.py
@@ -26,8 +26,8 @@
import pyinotify
-from vdsm.constants import P_VDSM_RUN
from vdsm.common import logutils
+from vdsm.network.constants import P_VDSM_RUN
from vdsm.network import ifacetracking
from vdsm.network.kernelconfig import networks_northbound_ifaces
diff --git a/lib/vdsm/network/ifacetracking.py b/lib/vdsm/network/ifacetracking.py
index 5b328f4..baf1f2a 100644
--- a/lib/vdsm/network/ifacetracking.py
+++ b/lib/vdsm/network/ifacetracking.py
@@ -23,7 +23,7 @@
from vdsm.common.fileutils import rm_file
from vdsm.common.fileutils import touch_file
-from vdsm.constants import P_VDSM_RUN
+from vdsm.network.constants import P_VDSM_RUN
TRACKED_INTERFACES_FOLDER = os.path.join(P_VDSM_RUN, 'trackedInterfaces')
diff --git a/lib/vdsm/network/link/bond/sysfs_options.py b/lib/vdsm/network/link/bond/sysfs_options.py
index bf5e93c..eadfbc2 100644
--- a/lib/vdsm/network/link/bond/sysfs_options.py
+++ b/lib/vdsm/network/link/bond/sysfs_options.py
@@ -24,7 +24,7 @@
import six
-from vdsm import constants
+from vdsm.network import constants
from vdsm.common.cache import memoized
BONDING_DEFAULTS = constants.P_VDSM_LIB + 'bonding-defaults.json'
diff --git a/lib/vdsm/network/link/bond/sysfs_options_mapper.py b/lib/vdsm/network/link/bond/sysfs_options_mapper.py
index 2219ab3..cc2b469 100644
--- a/lib/vdsm/network/link/bond/sysfs_options_mapper.py
+++ b/lib/vdsm/network/link/bond/sysfs_options_mapper.py
@@ -28,9 +28,9 @@
import six
-from vdsm import constants
from vdsm.common.cache import memoized
+from vdsm.network import constants
from vdsm.network.link.bond import sysfs_options
from vdsm.network.link.bond.sysfs_driver import BONDING_MASTERS
from vdsm.network.link.iface import random_iface_name
diff --git a/lib/vdsm/network/netconfpersistence.py b/lib/vdsm/network/netconfpersistence.py
index 79095d8..864126d 100644
--- a/lib/vdsm/network/netconfpersistence.py
+++ b/lib/vdsm/network/netconfpersistence.py
@@ -28,9 +28,9 @@
import six
-from vdsm import constants
from vdsm.common import fileutils
+from vdsm.network import constants
from vdsm.network.link.iface import random_iface_name
from . import errors as ne
diff --git a/lib/vdsm/network/netrestore.py b/lib/vdsm/network/netrestore.py
index d2739cf..715401f 100644
--- a/lib/vdsm/network/netrestore.py
+++ b/lib/vdsm/network/netrestore.py
@@ -25,7 +25,7 @@
import six
from vdsm.config import config
-from vdsm.constants import P_VDSM_RUN
+from vdsm.network.constants import P_VDSM_RUN
from vdsm.network import netswitch
from vdsm.network.link import setup
from vdsm.network.link.bond import Bond
diff --git a/lib/vdsm/network/sourceroute.py b/lib/vdsm/network/sourceroute.py
index 0d5e47a..a3e4e2d 100644
--- a/lib/vdsm/network/sourceroute.py
+++ b/lib/vdsm/network/sourceroute.py
@@ -22,7 +22,7 @@
import netaddr
from vdsm.common.contextlib import suppress
-from vdsm.constants import P_VDSM_RUN
+from vdsm.network.constants import P_VDSM_RUN
from vdsm.network.ip import route as ip_route
from vdsm.network.ip import rule as ip_rule
from vdsm.network.ip.route import IPRouteData
diff --git a/vdsm.spec.in b/vdsm.spec.in
index 8ba16d8..f4fa0e9 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -1084,6 +1084,7 @@
%{python_sitelib}/%{vdsm_name}/network/canonicalize.py*
%{python_sitelib}/%{vdsm_name}/network/cmd.py*
%{python_sitelib}/%{vdsm_name}/network/connectivity.py*
+%{python_sitelib}/%{vdsm_name}/network/constants.py*
%{python_sitelib}/%{vdsm_name}/network/dhclient_monitor.py*
%{python_sitelib}/%{vdsm_name}/network/driverloader.py*
%{python_sitelib}/%{vdsm_name}/network/ip/*.py*
--
To view, visit https://gerrit.ovirt.org/79437
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8571a806f09195007622d15eff59e72b55042559
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
6 years, 9 months
Change in vdsm[ovirt-4.1]: m2c: uses different protocol constant names
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: m2c: uses different protocol constant names
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
https://gerrit.ovirt.org/#/c/79664/3/lib/vdsm/m2cutils.py
File lib/vdsm/m2cutils.py:
Line 331: excludes = 0
Line 332:
Line 333: for no_protocol in config.get('vars', 'ssl_excludes').split(','):
Line 334: if no_protocol != '':
Line 335: protocol = 'SSL_' + no_protocol.strip()
> SSL_OP_NO_TLSv1_1 is not supported. Only two values are supported as specif
didn't we say that we'll just support both ..? you agreed. just add the SSL_ prefix if it was not provided.
But I don't mind to restrict it.
Line 336: if protocol == 'SSL_OP_NO_TLSv1_1':
Line 337: # not all m2crypto provide this constant
Line 338: excludes |= 268435456
Line 339: else:
--
To view, visit https://gerrit.ovirt.org/79664
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6c05bddfba94d85e2c48122b6fd56d8f336d01f5
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
6 years, 9 months
Change in vdsm[ovirt-4.1]: Revert "Revert "storage: Made diskType a real property.""
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: Revert "Revert "storage: Made diskType a real property.""
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/79800
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id98229bd3705fc056d54d9eb536d74c7b7729f47
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-HasComments: No
6 years, 9 months
Change in vdsm[ovirt-4.1]: Revert "Revert "storage: Added disk type change logging""
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: Revert "Revert "storage: Added disk type change logging""
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/79801
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia2e875c82b672384d04b23907292a8b7dfd5dcc3
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-HasComments: No
6 years, 9 months