Yaniv Bronhaim has posted comments on this change.
Change subject: forceVMstart: Initial commit
......................................................................
Patch Set 8:
(4 comments)
guess this tool is relevant when vdsm is not functional to gather information about the
running vms iiuc.
not sure how required is it, but if so, and it should be used by admin user, vdsm-tool is
good location for that.
please move it there and I'll review it more deeply.
adding alonbl to say what he thinks about the need of those commands.
http://gerrit.ovirt.org/#/c/9473/8//COMMIT_MSG
Commit Message:
Line 3: AuthorDate: 2013-01-31 00:33:45 +0100
Line 4: Commit: Pablo <Pablo.Iranzo(a)gmail.com>
Line 5: CommitDate: 2013-01-31 00:33:45 +0100
Line 6:
Line 7: forceVMstart: Initial commit
please change "Initial commit" to what is the meaning of this tool
Line 8:
Line 9: forceVMstart is a tool for gathering information for a VM using locally
Line 10: available xml files on SPM in order to manually start it in the event of
Line 11: RHEV-M not being available
Line 6:
Line 7: forceVMstart: Initial commit
Line 8:
Line 9: forceVMstart is a tool for gathering information for a VM using locally
Line 10: available xml files on SPM in order to manually start it in the event of
"manually start it in the event of RHEV-M.." what does it mean? please elaborate
..
Line 11: RHEV-M not being available
Line 12:
Line 13: Signed-off-by: Pablo <Pablo.Iranzo(a)gmail.com>
http://gerrit.ovirt.org/#/c/9473/8/contrib/forceVMstart.py
File contrib/forceVMstart.py:
Line 1: #!/usr/bin/env python
Line 2: #
Line 3: # Copyright 2010-2012 Red Hat, Inc.
go for 2014
Line 4: #
Line 5: # Licensed to you under the GNU General Public License as published by
Line 6: # the Free Software Foundation; either version 2 of the License, or
Line 7: # (at your option) any later version.
Line 17:
Line 18:
Line 19: ###############################################################################
Line 20: ############## WARNING ##############
Line 21: ############## The use of this script is inherently raceful ##############
explain the race
Line 22: ############## use it only on emergency cases when it's no
##############
Line 23: ############## possible to wait until manager is up again ##############
Line 24: ###############################################################################
Line 25:
--
To view, visit
http://gerrit.ovirt.org/9473
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9a70b31ce0730194880406701316f219c9f92ceb
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Pablo Iranzo Gómez <Pablo.Iranzo(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Amador Pahim <apahim(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Pablo Iranzo Gómez <Pablo.Iranzo(a)redhat.com>
Gerrit-Reviewer: Shu Ming <shuming(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes