Change in vdsm[master]: vdsm/storage/misc.py: Convert uuid input to string before va...

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: vdsm/storage/misc.py: Convert uuid input to string before validating
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

....................................................
Commit Message
Line 45: Which explains to me my error quite well.
However, if the function now receives utf-8-encoded buffer for uuid, it would now explode
instead of returning false.

I prefer that you validate that uuid is an instance of BaseString instead of casting (even
though Python purist would reject even that, together with all validate.* functions)

--
To view, visit http://gerrit.ovirt.org/3687
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If16466e88a50d3af03ae7830d4d8148ebf69d0d9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ryan Harper <ryanh(a)us.ibm.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;