Piotr Kliczewski has posted comments on this change.
Change subject: ssl: runtime config to choose implementation
......................................................................
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/44689/6/lib/vdsm/sslcompat.py
File lib/vdsm/sslcompat.py:
Line 26: else:
Line 27: from . import sslutils
Line 28: from .sslutils import SSLHandshakeDispatcher
Line 29: from ssl import SSLSocket
Line 30: except ImportError:
Could you try and do it more nicely?
We may have contradicting settings during the build and in runtime. I am open for suggestions but I think that there is no nicer way to do it.
Line 31: from . import sslutils
Line 32: from .sslutils import SSLHandshakeDispatcher
Line 33: from ssl import SSLSocket
Line 34:
--
To view, visit
https://gerrit.ovirt.org/44689
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9881d11e30ced9c34bfe602bba3d968f57e0fe15
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski
piotr.kliczewski@gmail.com
Gerrit-Reviewer: Dan Kenigsberg
danken@redhat.com
Gerrit-Reviewer: Francesco Romani
fromani@redhat.com
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer
nsoffer@redhat.com
Gerrit-Reviewer: Piotr Kliczewski
piotr.kliczewski@gmail.com
Gerrit-Reviewer: Sandro Bonazzola
sbonazzo@redhat.com
Gerrit-Reviewer: Simone Tiraboschi
stirabos@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim
ybronhei@redhat.com
Gerrit-Reviewer: Yeela Kaplan
ykaplan@redhat.com
Gerrit-Reviewer: automation@ovirt.org
Gerrit-HasComments: Yes