Saggi Mizrahi has posted comments on this change.
Change subject: sp: asynchronous convertDomain in activateSD ......................................................................
Patch Set 1: Code-Review-1
(2 comments)
.................................................... File vdsm/storage/hsm.py Line 3395: @public Line 3396: def upgradeStoragePool(self, spUUID, targetDomVersion): Line 3397: targetDomVersion = int(targetDomVersion) Line 3398: pool = self.getPool(spUUID) Line 3399: # TODO: this request should become asynchronous using a task No it shouldn't. Pool upgrade progress is not reported by design. Line 3400: pool._upgradeMasterDomain(targetDomVersion) Line 3401: pool._upgradeRegularDomains() Line 3402: return {"upgradeStatus": "started"} Line 3403:
Line 3397: targetDomVersion = int(targetDomVersion) Line 3398: pool = self.getPool(spUUID) Line 3399: # TODO: this request should become asynchronous using a task Line 3400: pool._upgradeMasterDomain(targetDomVersion) Line 3401: pool._upgradeRegularDomains() This is what _upgradePool() did both things. I don't see why exposing the change outward is needed. Leaving it _upgradePool() and having it call these two methods would have done the trick. Line 3402: return {"upgradeStatus": "started"} Line 3403: Line 3404: @public Line 3405: def repoStats(self, options=None):