Mark Wu has posted comments on this change.
Change subject: Add qemu's memory usage to VM statistics. ......................................................................
Patch Set 8: I would prefer that you didn't submit this
(1 inline comment)
.................................................... File vdsm_api/vdsmapi-schema.json Line 4964: # Line 4965: # @majflt: The number of major page faults since the last collection Line 4966: # Line 4967: # @vm_rss: Resident set size for the vm process (in KiB) Line 4968: # @since: 4.10.3 no @ before since, otherwise it will be treated as a field.
And I think GuestMemoryStats is not a suitable place to store the new added memory information. As described above, it's the "Memory statistics as reported by the guest agent." The new memory stats is for qemu process. Even though most memory of qemu process is used by guest, I suppose you could add a new structure for it. Line 4969: # Line 4970: # @vm_size: Current virtual memory usage for the vm process (in KiB) Line 4971: # @since: 4.10.3 Line 4972: #
-- To view, visit http://gerrit.ovirt.org/9006 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ibeb35759454c4a9b41e1303956267e93ca3545a0 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Gal Hammer ghammer@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Gal Hammer ghammer@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Michal Skrivanek michal.skrivanek@redhat.com Gerrit-Reviewer: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Vinzenz Feenstra vfeenstr@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server