Federico Simoncelli has posted comments on this change.
Change subject: Add the hostId parameter to reconstructMaster ......................................................................
Patch Set 12: (1 inline comment)
.................................................... File vdsm/storage/hsm.py Line 1448: ioOpTimeoutSec=None, leaseRetries=None, hostId=None, Yes the "options" arg was never used. Now when we have a 3.0 engine managing newer vdsm versions both hostId and options will be None (old behavior). On the other hand if the engine is 3.1 and the vdsm version is old, options will contain the hostId but it will be discarded.
-- To view, visit http://gerrit.ovirt.org/5068 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: If665af4ed8be9b5b53dffc7e1fc258b818bf7f98 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Allon Mureinik amureini@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Maor Lipchuk mlipchuk@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com