ShaoHe Feng has posted comments on this change.
Change subject: Add qemu's memory usage to VM statistics. ......................................................................
Patch Set 6: I would prefer that you didn't submit this
(1 inline comment)
.................................................... File vdsm_api/vdsmapi-schema.json Line 4853: # @pageflt: The number of page faults since the last collection Line 4854: # Line 4855: # @majflt: The number of major page faults since the last collection Line 4856: # Line 4857: # Since: 4.10.0 I'm not sure, should the old version "Since tag" be remained.
You generate the html file when make.
You can see there is only one "Since tag", it is the lastes one, not the biggest one. Line 4858: # Line 4859: # @vm_rss: Resident set size for the vm process (in KiB) Line 4860: # Line 4861: # @vm_size: Current virtual memory usage for the vm process (in KiB)
-- To view, visit http://gerrit.ovirt.org/9006 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ibeb35759454c4a9b41e1303956267e93ca3545a0 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Gal Hammer ghammer@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Gal Hammer ghammer@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Michal Skrivanek michal.skrivanek@redhat.com Gerrit-Reviewer: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: ShaoHe Feng shaohef@linux.vnet.ibm.com Gerrit-Reviewer: Vinzenz Feenstra vfeenstr@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server