Milan Zamazal has posted comments on this change.
Change subject: vmstats: take in account missing bulk stats fields ......................................................................
Patch Set 3: Code-Review-1
(2 comments)
Fine, just typos in the comment.
https://gerrit.ovirt.org/#/c/47760/3/vdsm/virt/vmstats.py File vdsm/virt/vmstats.py:
Line 361: for idx in six.moves.xrange(stats.get('%s.count' % group, 0)): Line 362: try: Line 363: name = stats['%s.%d.name' % (group, idx)] Line 364: except KeyError: Line 365: # bulk stats accumulate what they can get, raising errors Bulk ... Line 366: # only in the critical cases. This includes fundamntal Line 367: # attributes like names, so count has to be considered Line 368: # an upper bound more like a precise indicator. Line 369: pass
Line 362: try: Line 363: name = stats['%s.%d.name' % (group, idx)] Line 364: except KeyError: Line 365: # bulk stats accumulate what they can get, raising errors Line 366: # only in the critical cases. This includes fundamntal ... fundamental Line 367: # attributes like names, so count has to be considered Line 368: # an upper bound more like a precise indicator. Line 369: pass Line 370: else: