Mark Wu has posted comments on this change.
Change subject: Split xmlrpc server into its own rpm ......................................................................
Patch Set 1: (1 inline comment)
.................................................... File vdsm/clientIF.py Line 118: It could be better if we implement it as the following way: 1. add a configuration value to tell vdsm which bindings to be enables, like: ('bindings', 'XMLRPC, REST', 'bindings to be enabled') 2. move the parameters into their individual module if they can't be shared. 3. parse the configured value of 'bindings', and import the module "'Binding' + item" . it requires the binding module is stored in the same path.
It's the same as what you did in MOM. It could make code more clean. Does it make sense?
-- To view, visit http://gerrit.ovirt.org/3892 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ifdf84af0b903406c148877e26ec27e6ed913bd51 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com