From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: storage: validateDirAccess: move to sdperm
......................................................................
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/73115/2/lib/vdsm/storage/sdperm.py
File lib/vdsm/storage/sdperm.py:
Line 28: from . import exception as se
Line 29: from . import outOfProcess
Line 30:
Line 31:
Line 32: def validate_dir_access(path):
If this is code is related to file storage domain, it should remain
in file
When we manage to move fileSD to lib/vdsm/stroge, we can merge sdperm back
into it.
This is arguably not pretty, but neither is keeping storageServer under /usr/share/vdsm.
Line 33: """verify that path's permissions match those of a file
storage domain"""
Line 34: try:
Line 35: outOfProcess.getGlobalProcPool().fileUtils.validateAccess(path)
Line 36: supervdsm.getProxy().validateAccess(
--
To view, visit
https://gerrit.ovirt.org/73115
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I21ead1cb635f8224cb09f7319ffcb55eebe2a9e3
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes