Antoni Segura Puimedon has posted comments on this change.
Change subject: sourcerouting: fix _getRoute not to include local routes
......................................................................
Patch Set 2:
Why does a show on a specific table show routes that were not inserted
by us? I have a vague recollection of an iproute bug where shows on tables with a large
table_id show a large set of routes, and not just the routes belonging to that table. If
you define a low IP on the network I suspect the bug wouldn't manifest. You could work
around this using the routes table file instead (With low table IDs).
Okay, I did bisect the hell out of ip route show table X
The highest number that doesn't expose the bug is: 2147483647
So for any value < 2147483648 the behavior is correct without this patch.
--
To view, visit
http://gerrit.ovirt.org/27262
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5b3d43c8a2077e40b8b4314f02ea17bc3968c42b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No