Federico Simoncelli has posted comments on this change.
Change subject: hsm: move domainStateCallback to HSM ......................................................................
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/27478/2/vdsm/storage/hsm.py File vdsm/storage/hsm.py:
Line 418: self.domainStateChangeCallbacks.add(callbackFunc) Line 419: Line 420: def _onDomainStateChange(self, sdUUID, isValid): Line 421: for pool in self.pools.values(): Line 422: pool.domainStateChangeEvent(sdUUID, isValid)
This happens from an event thread - I'm sure that this is not thread safe a
It seems not (getPools, etc.). Anyway values() is going to create another list. Line 423: Line 424: def _hsmSchedule(self, name, func, *args): Line 425: self.taskMng.scheduleJob("hsm", self.tasksDir, vars.task, Line 426: name, func, *args)