Igor Lvovsky has posted comments on this change.
Change subject: Implement VMs live snapshots ......................................................................
Patch Set 6: I would prefer that you didn't submit this
(4 inline comments)
.................................................... File vdsm/libvirtvm.py Line 1351: errStatus = errCode['changeDisk']['status'] Do you think it's good enough to use 'changeDisk' error here? We use it for change CD flow. Maybe we need new dedicated error for shapshots? I don't know ...
Line 1357: for drive in self._drives: The is no such thing _drives anymore. Use self._vm._devices[vm.DISK_DEVICES] instead
Line 1361: drive.volumeID = snapParam[vmDev]["volumeID"] you should update same fields in self.conf["devices"] too. In additional you need self.saveState() at the end
Line 1364: Do we need to update self._preparedDrives ? I know that we want to drop it at some moment, but it still here
-- To view, visit http://gerrit.ovirt.org/469 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Id48a905938037eca2b1de966f4f83d801fdb9970 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com