Zhou Zheng Sheng has posted comments on this change.
Change subject: dump the core of a domain
......................................................................
Patch Set 4: (1 inline comment)
....................................................
File vdsm/vm.py
Line 303:
Line 304: def _finishSuccessfully(self):
Line 305: self.status = {'status': {'code': 0, 'message':
Line 306: 'Dump finished sucessfully'},
Line 307: 'progress': "done"}
But _coreDumpOngoingEvt itself can be read by main thread and written by worker thread..
I tried to write a small script to simulate the race here. Seems race very rare and even
it occurs, it does no harm. So lock is not need here.
Line 308:
Line 309: def run(self):
Line 310:
Line 311: def reportError(key='coreDumpErr', msg=None):
--
To view, visit
http://gerrit.ovirt.org/7329
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If4aac9e747dc7aa64a6ff5ef256a7a4375aa2bb5
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Ryan Harper <ryanh(a)us.ibm.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server