Nir Soffer has posted comments on this change.
Change subject: persistentDict: if no metadata do not calculate the checksum ......................................................................
Patch Set 2:
(1 comment)
Looks good, but log message can be refined.
http://gerrit.ovirt.org/#/c/27528/2/vdsm/storage/persistentDict.py File vdsm/storage/persistentDict.py:
Line 249: newMD[key] = value Line 250: Line 251: if not newMD: Line 252: self.log.debug("Empty metadata - " Line 253: "No need to compute the checksum") There is no need to talk about the checksum in this case. Just "Empty metadata" Line 254: self._isValid = True Line 255: self._metadata = newMD Line 256: return Line 257: