Dan Kenigsberg has posted comments on this change.
Change subject: vm: make new timekeeping revertable ......................................................................
Patch Set 2: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/24443/2/lib/vdsm/config.py.in File lib/vdsm/config.py.in:
Line 193: ('transient_disks_repository', '@VDSMLIBDIR@/transient', Line 194: 'Local path to the transient disks repository.'), Line 195: Line 196: ('kvm_specific_timekeeping', 'true', Line 197: 'Enable the best KVM time keeping settings;' sorry for worrying about the name, but if we were 100% sure that what we use is the "best", we would not need this configurable. Also, "pit" is not kvm-specific. Plain qemu has it, I suppose.
maybe have
legacy_timekeeping_ovirt_3.0 = false
? Line 198: ' disable to revert to legacy QEMU settings'), Line 199: ]), Line 200: Line 201: # Section: [ksm]