Change in vdsm[master]: vdsm-logrotate.conf: Add copytruncate

Zhou Zheng Sheng has posted comments on this change.

Change subject: vdsm-logrotate.conf: Add copytruncate
......................................................................

Patch Set 1: (1 inline comment)

....................................................
File vdsm/vdsm-logrotate.conf.in
Line 1: /var/log/vdsm/*.log {
Line 2:     rotate 100
Line 3:     copytruncate
> From the bugzilla link I can see, the size of /var/log/vdsm/vdsm.log.1 is normal, but the size of /var/log/vdsm/libvirt.log.1 is huge.

/var/log/vdsm/libvirt.log is not written by vdsm, it's written by libvirt, so vdsm/logger.conf.in does not apply to this file, no WatchedFileHandler available for this file. This file needs copytruncate. Maybe other log files need this as well, as long as they are not configured by vdsm/logger.conf.in .

However with copytruncate, there is a small time window between copying the file and truncating it, some log message may be lost.
Line 4:     missingok
Line 5:     size 15M
Line 6:     compress
Line 7:     compresscmd /usr/bin/xz

--
To view, visit http://gerrit.ovirt.org/13499
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie018b2039eac565cfdb5874c664b177d6fad64fa
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Mark Wu 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server