Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: dhcp reporting based on dhclient daemon state
......................................................................
net: dhcp reporting based on dhclient daemon state
dhcp state has passed several changes in the reporting logic.
Started by checking leased entries, followed by checking the ip source
(static or dynamic).
Both solutions have linked the dhcp state to the IP address assigned.
This aproach has required some faking to be introduced, in order to
handle cases where the dhcp has been activated but the address took some
time to be assigned.
This patch introduces a new approach, decoupling dhcp from the ip
address.
The dhcp state is now checked against the dhclient daemon existence.
This patch also resolves dhcp6 false report.
An IPv6 address may be assigned dynamically through autoconf, previously
we have reported it as dhcp6 enabled.
Change-Id: I346b8d2d52a457a3cffd543a8da800edd53ce186
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
Reviewed-on:
https://gerrit.ovirt.org/61458
Continuous-Integration: Jenkins CI
Reviewed-by: Petr Horáček <phoracek(a)redhat.com>
Reviewed-by: Dan Kenigsberg <danken(a)redhat.com>
---
M lib/vdsm/network/ip/dhclient.py
M lib/vdsm/network/netinfo/cache.py
M lib/vdsm/network/netinfo/dhcp.py
M lib/vdsm/network/ovs/info.py
M tests/functional/networkTests.py
M vdsm_hooks/ovs/ovs_after_get_caps.py
6 files changed, 18 insertions(+), 39 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Petr Horáček: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, approved
Edward Haas: Verified
--
To view, visit
https://gerrit.ovirt.org/61458
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I346b8d2d52a457a3cffd543a8da800edd53ce186
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>