Dan Kenigsberg has posted comments on this change.
Change subject: Add hooksTests. ......................................................................
Patch Set 2: I would prefer that you didn't submit this
(3 inline comments)
really minor stuff left.
note that there are several other things in hooks.py that should be tested: _getHookInfo, _getScriptInfo and even the ability to execute hooks.py as a script. (can wait for another patch).
.................................................... File tests/hooksTests.py Line 40: echo -n %s "$1" >> "$_hook_domxml" why you need "$1" is a mystery to me.
.................................................... File vdsm/hooks.py Line 33: # dir path starts with '/' for test purposes trailing redspace is evil
Line 34: # otherwise starts with P_VDSM_HOOKS starts with -> "path is relative to"
-- To view, visit http://gerrit.ovirt.org/3589 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ic4e9c5acc4ae8a1fa352c7cec4724a930c837257 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykaplan@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Yeela Kaplan ykaplan@redhat.com