Shahar Havivi has posted comments on this change.
Change subject: setVmTicket: add before and after hooks ......................................................................
Patch Set 7: (4 inline comments)
.................................................... File vdsm/hooks.py Line 37: def _runHooksDir(domxml, dir, vmconf={}, raiseError=True, params = {}): Done
Line 51: scriptenv.update(params) yes its string
Line 135: def before_vm_set_ticket(domxml, params, vmconf={}): Done
.................................................... File vdsm/vdsmd.8.in Line 65: .B vmId. what do you mean? please define the string you want me to add/change
-- To view, visit http://gerrit.ovirt.org/3565 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I48cbc934e48055630b734a2d3c79c72b6c36f28f Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi shavivi@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Shahar Havivi shavivi@redhat.com