From Dan Kenigsberg danken@redhat.com:
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: report correct exit value in vdsm-logrotate
......................................................................
Patch Set 2: Code-Review+2
(2 comments)
https://gerrit.ovirt.org/#/c/65603/2/vdsm/vdsm-logrotate
File vdsm/vdsm-logrotate:
PS2, Line 7:
We do not need this space. Please remove.
but it's not strictly related to this patch, so it should not block it.
PS2, Line 17: ((errors+1)
I don't think so. This type of arithmetic expansion is defined in POSIX.
You are correct. http://pubs.opengroup.org/onlinepubs/9699919799/utilities/V3_chap02.html#tag...
--
To view, visit
https://gerrit.ovirt.org/65603
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I29df6cac36c64be2bf20337ab096ec471d864ca5
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Golembiovsky
tgolembi@redhat.com
Gerrit-Reviewer: Dan Kenigsberg
danken@redhat.com
Gerrit-Reviewer: Fabian Deutsch
fabiand@redhat.com
Gerrit-Reviewer: Francesco Romani
fromani@redhat.com
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer
nsoffer@redhat.com
Gerrit-Reviewer: Piotr Kliczewski
piotr.kliczewski@gmail.com
Gerrit-Reviewer: Tomas Golembiovsky
tgolembi@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim
ybronhei@redhat.com
Gerrit-Reviewer: gerrit-hooks
automation@ovirt.org
Gerrit-HasComments: Yes