Dan Kenigsberg has posted comments on this change.
Change subject: Remove (almost all) class Volume virtual (!) methods. ......................................................................
Patch Set 2:
I've never understood your vendetta against pure virtual functions in Python. The functions that you are removing should have raised "UnimplentedError" instead of returning None, but other than that, they have merit for documenting the abstract class.
-- To view, visit http://gerrit.ovirt.org/3461 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ib14c4d398aa68edbd9a413506b2cc4d8615c686b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com